Re: RFR: JDK-8199608 Clean up LDFLAGS for libfontmanager

2018-04-05 Thread Erik Joelsson
Looks good. /Erik On 2018-04-05 02:31, Magnus Ihse Bursie wrote: On 2018-03-14 22:17, Magnus Ihse Bursie wrote: On 2018-03-14 22:05, Phil Race wrote: >I see we used to link with libawt_headless for solaris, but removed it in >JDK-8194870. Phil remarked in that bug: "We linked against

Re: RFR: JDK-8199608 Clean up LDFLAGS for libfontmanager

2018-04-05 Thread Magnus Ihse Bursie
On 2018-03-14 22:17, Magnus Ihse Bursie wrote: On 2018-03-14 22:05, Phil Race wrote: >I see we used to link with libawt_headless for solaris, but removed it in >JDK-8194870. Phil remarked in that bug: "We linked against headless before then >but allowed undefined symbols JDK 9 switched

Re: RFR: JDK-8199608 Clean up LDFLAGS for libfontmanager

2018-03-14 Thread Magnus Ihse Bursie
On 2018-03-14 22:05, Phil Race wrote: >I see we used to link with libawt_headless for solaris, but removed it in >JDK-8194870. Phil remarked in that bug: "We linked against headless before then >but allowed undefined symbols JDK 9 switched this to libawt_headless when >headless apps

Re: RFR: JDK-8199608 Clean up LDFLAGS for libfontmanager

2018-03-14 Thread Phil Race
>I see we used to link with libawt_headless for solaris, but removed it in >JDK-8194870. Phil remarked in that bug: "We linked against headless before then >but allowed undefined symbols JDK 9 switched this to libawt_headless when >headless apps failed." but I'm not sure I understand what

Re: RFR: JDK-8199608 Clean up LDFLAGS for libfontmanager

2018-03-14 Thread Magnus Ihse Bursie
On 2018-03-14 21:44, Erik Joelsson wrote: On 2018-03-14 13:22, Magnus Ihse Bursie wrote: On 2018-03-14 15:59, Erik Joelsson wrote: This change is unfortunately not correct for Linux and Solaris. We cannot link libfontmanager explicitly against either libawt_xawt or libawt_headless. See

Re: RFR: JDK-8199608 Clean up LDFLAGS for libfontmanager

2018-03-14 Thread Erik Joelsson
On 2018-03-14 13:22, Magnus Ihse Bursie wrote: On 2018-03-14 15:59, Erik Joelsson wrote: This change is unfortunately not correct for Linux and Solaris. We cannot link libfontmanager explicitly against either libawt_xawt or libawt_headless. See https://bugs.openjdk.java.net/browse/JDK-8196516

Re: RFR: JDK-8199608 Clean up LDFLAGS for libfontmanager

2018-03-14 Thread Magnus Ihse Bursie
On 2018-03-14 15:59, Erik Joelsson wrote: This change is unfortunately not correct for Linux and Solaris. We cannot link libfontmanager explicitly against either libawt_xawt or libawt_headless. See https://bugs.openjdk.java.net/browse/JDK-8196516 for my suggestion on a better fix than we

Re: RFR: JDK-8199608 Clean up LDFLAGS for libfontmanager

2018-03-14 Thread Erik Joelsson
This change is unfortunately not correct for Linux and Solaris. We cannot link libfontmanager explicitly against either libawt_xawt or libawt_headless. See https://bugs.openjdk.java.net/browse/JDK-8196516 for my suggestion on a better fix than we currently have. I was hoping for Severin to

RFR: JDK-8199608 Clean up LDFLAGS for libfontmanager

2018-03-14 Thread Magnus Ihse Bursie
This is the final LDFLAGS cleanup, which required some more work to resolve. Libfontmanager had previously explicitely disabled -z defs, with the result that linking did not complain about missing libraries. To fix this, I had to provide the proper libraries to link with. For linux and