Withdrawn: 8345813: Replace $LDCXX with proper libraries to $LD instead

2025-05-27 Thread duke
On Mon, 9 Dec 2024 16:24:51 GMT, Magnus Ihse Bursie wrote: > As suggested by @djelinski in > https://github.com/openjdk/jdk/pull/17986#issuecomment-1965991536, we can > (and should) remove the special `$LDCXX` linker, and instead just pass the > C++ standard libraries to gcc. This pull reques

Re: RFR: 8357920: Add .rej and .orig to .gitignore

2025-05-27 Thread SendaoYan
On Tue, 27 May 2025 21:59:05 GMT, Magnus Ihse Bursie wrote: > The file types .rej and .orig are often created by diff tools. Adding them to > .gitignore will help people from mistakenly committing these files. > > See https://github.com/openjdk/jdk/pull/25306#discussion_r2102407122 for an > ex

RFR: 8355725: SPEC_FILTER stopped working

2025-05-27 Thread Magnus Ihse Bursie
>From the bug description: The SPEC_FILTER make variable is meant to be used to create small documentation bundles that just contain some selected files. Example usage: `make docs-specs-zip SPEC_FILTER="%-jls.md copyright.html %logo.gif resources"` The fix for [JDK-8349143](https://bugs.openjdk

RFR: 8357510: [REDO] RunTest variables should always be assigned

2025-05-27 Thread Magnus Ihse Bursie
This is a redo of [JDK-8357048](https://bugs.openjdk.org/browse/JDK-8357048), which had to backed out since it caused testing errors in higher tiers. The problem was that `JTREG_PROBLEM_LIST_PREFIX` was not defined before it was used, and when `JTREG_BASIC_OPTIONS` were no longer implicitly decl

Integrated: 8349665: Make clean removes module-deps.gmk

2025-05-27 Thread Magnus Ihse Bursie
On Thu, 3 Apr 2025 09:18:07 GMT, Magnus Ihse Bursie wrote: > After [JDK-8292944](https://bugs.openjdk.org/browse/JDK-8292944), we only > generate module-deps.gmk once at the start of Init.gmk. This causes `make > clean ` to first generate and then remove module-deps.gmk > after which the rest

Re: RFR: 8357869: Remove PreviewNote taglet in its current form

2025-05-27 Thread Magnus Ihse Bursie
On Tue, 27 May 2025 14:38:53 GMT, Hannes Wallnöfer wrote: > Please review a change to remove the `PreviewNote` build taglet as it did not > pass CSR. This is a partial (build changes) undo of > [JDK-8346109](https://bugs.openjdk.org/browse/JDK-8346109). > > The taglet is planned to be reintr

RFR: 8357920: Add .rej and .orig to .gitignore

2025-05-27 Thread Magnus Ihse Bursie
The file types .rej and .orig are often created by diff tools. Adding them to .gitignore will help people from mistakenly committing these files. See https://github.com/openjdk/jdk/pull/25306#discussion_r2102407122 for an example of where this happened. - Commit messages: - 835792

Re: RFR: 8355003: Implement JEP 515: Ahead-of-Time Method Profiling [v25]

2025-05-27 Thread Igor Veresov
> Improve warm-up time by making profile data from a previous run of an > application instantly available, when the HotSpot Java Virtual Machine > starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) > to store method execution profiles from training runs, reducing profili

Re: RFR: 8349665: Make clean removes module-deps.gmk [v2]

2025-05-27 Thread Erik Joelsson
On Tue, 27 May 2025 20:48:13 GMT, Magnus Ihse Bursie wrote: >> After [JDK-8292944](https://bugs.openjdk.org/browse/JDK-8292944), we only >> generate module-deps.gmk once at the start of Init.gmk. This causes `make >> clean ` to first generate and then remove module-deps.gmk >> after which the

Re: RFR: 8349665: Make clean removes module-deps.gmk [v3]

2025-05-27 Thread Magnus Ihse Bursie
> After [JDK-8292944](https://bugs.openjdk.org/browse/JDK-8292944), we only > generate module-deps.gmk once at the start of Init.gmk. This causes `make > clean ` to first generate and then remove module-deps.gmk > after which the rest of the build proceeds without a module-deps.gmk, causing > p

Re: RFR: 8349665: Make clean removes module-deps.gmk [v3]

2025-05-27 Thread Erik Joelsson
On Tue, 27 May 2025 21:15:35 GMT, Magnus Ihse Bursie wrote: >> After [JDK-8292944](https://bugs.openjdk.org/browse/JDK-8292944), we only >> generate module-deps.gmk once at the start of Init.gmk. This causes `make >> clean ` to first generate and then remove module-deps.gmk >> after which the

Re: RFR: 8349665: Make clean removes module-deps.gmk [v2]

2025-05-27 Thread Magnus Ihse Bursie
On Tue, 27 May 2025 20:48:13 GMT, Magnus Ihse Bursie wrote: >> After [JDK-8292944](https://bugs.openjdk.org/browse/JDK-8292944), we only >> generate module-deps.gmk once at the start of Init.gmk. This causes `make >> clean ` to first generate and then remove module-deps.gmk >> after which the

Re: RFR: 8349665: Make clean removes module-deps.gmk [v2]

2025-05-27 Thread Magnus Ihse Bursie
> After [JDK-8292944](https://bugs.openjdk.org/browse/JDK-8292944), we only > generate module-deps.gmk once at the start of Init.gmk. This causes `make > clean ` to first generate and then remove module-deps.gmk > after which the rest of the build proceeds without a module-deps.gmk, causing > p

Re: RFR: 8349665: Make clean removes module-deps.gmk

2025-05-27 Thread Magnus Ihse Bursie
On Thu, 3 Apr 2025 09:18:07 GMT, Magnus Ihse Bursie wrote: > After [JDK-8292944](https://bugs.openjdk.org/browse/JDK-8292944), we only > generate module-deps.gmk once at the start of Init.gmk. This causes `make > clean ` to first generate and then remove module-deps.gmk > after which the rest

Re: RFR: 8357869: Remove PreviewNote taglet in its current form

2025-05-27 Thread Erik Joelsson
On Tue, 27 May 2025 14:38:53 GMT, Hannes Wallnöfer wrote: > Please review a change to remove the `PreviewNote` build taglet as it did not > pass CSR. This is a partial (build changes) undo of > [JDK-8346109](https://bugs.openjdk.org/browse/JDK-8346109). > > The taglet is planned to be reintr

Integrated: 8357842: PandocFilter misses copyright header

2025-05-27 Thread Magnus Ihse Bursie
On Tue, 27 May 2025 11:19:12 GMT, Magnus Ihse Bursie wrote: > `make/jdk/src/classes/build/tools/pandocfilter/PandocFilter.java` misses a > copyright header. This pull request has now been integrated. Changeset: 72a3022d Author:Magnus Ihse Bursie URL: https://git.openjdk.org/jdk/com

Re: RFR: 8357141: Update to use jtreg 7.5.2 [v2]

2025-05-27 Thread Christian Stein
On Mon, 26 May 2025 05:54:10 GMT, Christian Stein wrote: >> Please review the change to update to using jtreg 7.5.2. >> >> The primary change is to the `jib-profiles.js` file, which specifies the >> version of jtreg to use, for those systems that rely on this file. In >> addition, the `require

Re: RFR: 8357842: PandocFilter misses copyright header

2025-05-27 Thread Erik Joelsson
On Tue, 27 May 2025 11:19:12 GMT, Magnus Ihse Bursie wrote: > `make/jdk/src/classes/build/tools/pandocfilter/PandocFilter.java` misses a > copyright header. Marked as reviewed by erikj (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/25463#pullrequestreview-2870888969

RFR: 8357869: Remove PreviewNote taglet in its current form

2025-05-27 Thread Hannes Wallnöfer
Please review a change to remove the `PreviewNote` build taglet as it did not pass CSR. This is a partial (build changes) undo of [JDK-8346109](https://bugs.openjdk.org/browse/JDK-8346109). The taglet is planned to be reintroduced at a later date in a redesigned form. - Commit me

Re: RFR: 8357842: PandocFilter misses copyright header

2025-05-27 Thread SendaoYan
On Tue, 27 May 2025 11:19:12 GMT, Magnus Ihse Bursie wrote: > `make/jdk/src/classes/build/tools/pandocfilter/PandocFilter.java` misses a > copyright header. Marked as reviewed by syan (Committer). - PR Review: https://git.openjdk.org/jdk/pull/25463#pullrequestreview-2870765088

RFR: 8357842: PandocFilter misses copyright header

2025-05-27 Thread Magnus Ihse Bursie
`make/jdk/src/classes/build/tools/pandocfilter/PandocFilter.java` misses a copyright header. - Commit messages: - 8357842: PandocFilter misses copyright header Changes: https://git.openjdk.org/jdk/pull/25463/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25463&range=00