Withdrawn: 8349638: Build libjdwp with SIZE optimization

2025-09-12 Thread duke
On Tue, 11 Feb 2025 15:56:39 GMT, Matthias Baesken wrote: > The libjdwp is currently built with LOW optimization level, it could be built > with SIZE optimization to lower the lib size by ~ 10 % on UNIX. > On Windows LOW and SIZE currently translate to the same O1 optimization flag > so no diff

Re: RFR: 8366195: Remove unnecessary quotes around -Ta ml64 assembler argument

2025-09-03 Thread duke
On Sat, 30 Aug 2025 15:34:00 GMT, Saint Wesonga wrote: > This PR cleans up the handling of the -Ta argument by removing the quotes > that were unintentionally added around the argument and moving the > declaration of the argument to match -Fo as suggested in > https://github.com/openjdk/jdk/pu

Re: RFR: 8365053: Refresh hotspot precompiled.hpp with headers based on current frequency [v20]

2025-08-28 Thread duke
On Wed, 27 Aug 2025 18:06:30 GMT, Francesco Andreuzzi wrote: >> In this PR I propose to refresh the included headers in hotspot >> `precompiled.hpp`. The current set of precompiled headers was refreshed in >> 2018, 7 years ago. I repeated the same operations and measurements after >> refreshin

Re: RFR: 8365053: Refresh hotspot precompiled.hpp with headers based on current frequency [v18]

2025-08-27 Thread duke
On Tue, 26 Aug 2025 22:34:39 GMT, Francesco Andreuzzi wrote: >> In this PR I propose to refresh the included headers in hotspot >> `precompiled.hpp`. The current set of precompiled headers was refreshed in >> 2018, 7 years ago. I repeated the same operations and measurements after >> refreshin

Withdrawn: 8357979: [JVMCI] jdk.internal.vm.ci should have earlier class file version

2025-08-26 Thread duke
On Wed, 28 May 2025 14:24:47 GMT, Doug Simon wrote: > There are plans to have libgraal be built for JDK master using a version of > Native Image running on a JDK one version behind the current JDK. This Native > Image execution needs to be able to load the JVMCI classes. As such, the > JVMCI c

Re: RFR: 8365579: ml64.exe is not the right assembler for Windows aarch64 [v4]

2025-08-25 Thread duke
On Fri, 22 Aug 2025 23:52:10 GMT, Saint Wesonga wrote: >> [ml64](https://learn.microsoft.com/en-us/cpp/assembler/masm/ml-and-ml64-command-line-reference?view=msvc-170) >> is set as the assembler for the Windows platform but is specific to the x64 >> platform. The >> [armasm64](https://learn.mi

Re: RFR: 8365579: ml64.exe is not the right assembler for Windows aarch64 [v2]

2025-08-15 Thread duke
On Fri, 15 Aug 2025 15:46:58 GMT, Saint Wesonga wrote: >> [ml64](https://learn.microsoft.com/en-us/cpp/assembler/masm/ml-and-ml64-command-line-reference?view=msvc-170) >> is set as the assembler for the Windows platform but is specific to the x64 >> platform. The >> [armasm64](https://learn.mi

Re: RFR: 8365048: idea.sh script does not correctly detect/handle git worktrees [v2]

2025-08-14 Thread duke
On Thu, 14 Aug 2025 15:21:29 GMT, David Beaumont wrote: >> Allows files or directories called .git to indicate likely use of Git for >> VCS in IntelliJ. >> Tested locally in a worktree and normal repository. It produces: >> >> >> >> >> >> >> in both cases, as expected. > > David

Re: RFR: 8365098: make/RunTests.gmk generates a wrong path to test artifacts on Alpine

2025-08-14 Thread duke
On Tue, 12 Aug 2025 10:51:06 GMT, Roman Marchenko wrote: > This change fixes the test artifact path on Alpine as `'[_*1000]'` is not > recognized as a correct pattern, at least on Alpine 3.11. > > Without this fix, on Alpine the command `make test-prebuilt` generated paths > like the followin

Re: RFR: 8365238: 'jfr' feature requires 'services' with 'custom' build variant

2025-08-11 Thread duke
On Mon, 11 Aug 2025 10:55:44 GMT, Francesco Andreuzzi wrote: > In this PR I add an `autoconfigure` check to make sure that `jfr` is not > built without the feature `services`, which would lead to the following error: > > /jdk/src/hotspot/share/jfr/periodic/jfrPeriodic.cpp: In member function >

Withdrawn: 8339355: Test build/AbsPathsInImage.java fails configure with --enable-ccache

2025-08-11 Thread duke
On Sat, 14 Jun 2025 03:51:28 GMT, SendaoYan wrote: > Hi all, > > The debuginfo file will not ship to customers generally, so I think it's not > necessary to check the debuginfo files contains absolutive path or not. And I > can't find why the debuginfo file always contains workspace path info

Re: RFR: 8364177: JDK fails to build due to undefined symbol in libpng on LoongArch64

2025-08-01 Thread duke
On Mon, 28 Jul 2025 09:25:34 GMT, Ao Qi wrote: > After [JDK-8329004](https://bugs.openjdk.org/browse/JDK-8329004), the > following code was added. > > > #ifndef PNG_LOONGARCH_LSX_OPT > # if defined(__loongarch_sx) > # define PNG_LOONGARCH_LSX_OPT 1 > # else > # define PNG_LOONGARCH_LSX_OPT 0 >

Re: RFR: 8359760: Remove the jdk.jsobject module [v2]

2025-07-23 Thread duke
On Tue, 22 Jul 2025 19:53:39 GMT, Kevin Rushforth wrote: >> This PR removes the terminally-deprecated `jdk.jsobject` module from the >> JDK. This module is now shipped with JavaFX, and has been since JavaFX 24. >> >> The following files still reference `jdk.jsobject` (or the >> `netscape.javas

Withdrawn: 8352044: Add --with-import-jvms to configure

2025-07-11 Thread duke
On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote: > We should allow pre-built JVMs to be included in a build, so they are just > copied into place, and the jvm.cfg file properly updated. This pull request has been closed without being integrated. - PR: https://git.openjd

Re: RFR: 8357079: Fix Windows AArch64 DevKit Creation [v2]

2025-06-26 Thread duke
On Mon, 23 Jun 2025 18:54:10 GMT, Luigi Montoya wrote: >> Fix path for Visual Studio arm64 binaries in createWindowsDevkit.sh >> >> The DevKit currently created on a Windows AArch64 machine uses the x64 >> compiler binaries (e.g. cl.exe). This can be inspected by running "dumpbin >> /headers /

Withdrawn: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-06-18 Thread duke
On Wed, 26 Mar 2025 07:54:48 GMT, Jan Lahoda wrote: > The `java.io.Console` has several backends: a simple on in `java.base`, a > more convenient one in `jdk.internal.le` (with line-reading based on JLine) > and one for JShell. > > The backend based on JLine is proving to be a somewhat problem

Withdrawn: 8345813: Replace $LDCXX with proper libraries to $LD instead

2025-05-27 Thread duke
On Mon, 9 Dec 2024 16:24:51 GMT, Magnus Ihse Bursie wrote: > As suggested by @djelinski in > https://github.com/openjdk/jdk/pull/17986#issuecomment-1965991536, we can > (and should) remove the special `$LDCXX` linker, and instead just pass the > C++ standard libraries to gcc. This pull reques

Withdrawn: 8351842: Windows specific issues in combination of JEP 493 and --with-external-symbols-in-bundles=public

2025-05-16 Thread duke
On Fri, 14 Mar 2025 12:29:22 GMT, Christoph Langer wrote: > Alternative approach to #24012 > > This keeps the current handling of *.pdb vs *.stripped.pdb which allows > debugging at the cost of a little hack in jlink. Maybe the code in jlink can > be improved, e.g. make it more conditional. >

Re: RFR: 8354257: xctracenorm profiler not working with JDK JMH benchmarks

2025-05-06 Thread duke
On Thu, 10 Apr 2025 12:02:45 GMT, Galder Zamarreño wrote: > Avoid filtering out xml files at the root of the JMH folder, in order to get > the `default.instruments.template.xml` file bundled in the JMH core jar to > support xtrace profiler. @galderz Your change (at version a2b73be2533635ee169

Re: RFR: 8355249: Remove the use of WMIC from the entire source code [v2]

2025-05-06 Thread duke
On Tue, 22 Apr 2025 07:41:43 GMT, Daishi Tabata wrote: >> After searching the entire JDK source code, I found that WMIC is only used >> in four files. These WMIC calls can be replaced with PowerShell for WMI. >> >> The primary challenge in this replacement is to make it work the same as >> bef

Withdrawn: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava

2025-05-05 Thread duke
On Wed, 24 Jul 2024 19:11:42 GMT, Brian Burkhalter wrote: > This proposed change would move the native objects required for NIO file > interaction from the libnio native library to the libjava native library on > Linux, macOS, and Windows. This pull request has been closed without being integr

Re: RFR: 8356032: createAutoconfBundle.sh downloads to local directory

2025-05-02 Thread duke
On Thu, 1 May 2025 13:12:46 GMT, Ivan Bereziuk wrote: > Fixed a small issue in createAutoconfBundle.sh where we CD to > `build/autoconf` folder before it's created. > As result, we end up with `m4` and `autoconf` downloadable and unpacked > folders in CWD. > > By a chance, I did few other impr

Re: RFR: 8355697: Create windows devkit on wsl and msys2 [v3]

2025-04-29 Thread duke
On Tue, 29 Apr 2025 03:38:33 GMT, kuaiwei wrote: >> The patch fix error when creating devkit on wsl/msys2 . >> * Msys2 can be supported like cygwin >> * In wsl, it can not test path name in windows format, like `if [ -d >> "d:/VisualStuio"]` . The path must be converted as linux style before >>

Re: RFR: 8355400: Better git detection in update_copyright_year.sh

2025-04-24 Thread duke
On Wed, 23 Apr 2025 13:19:19 GMT, Manuel Hässig wrote: > The script `make/scripts/update_copyright.sh` relies on the path to the > script for git detection, which is fragile or does not work at all or git > worktrees. This PR uses git itself to detect whether the script is running in > a git r

Withdrawn: 8346987: [lto] gtest build fails

2025-04-22 Thread duke
On Fri, 17 Jan 2025 11:41:06 GMT, Matthias Baesken wrote: > When building with link time optimization (lto) , configure flag is > --enable-jvm-feature-link-time-opt , we run in the gtest build into a lot of > errors. > One workaround is just to configure without gtest ; this one changes the mak

Re: RFR: 8353009: Improve documentation for Windows AArch64 builds [v6]

2025-04-16 Thread duke
On Wed, 16 Apr 2025 14:50:57 GMT, Saint Wesonga wrote: >> The target selection configuration flag for Windows AArch64 should be added >> to the build documentation for improved discoverability and completeness. > > Saint Wesonga has updated the pull request incrementally with two additional > c

Re: RFR: 8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot C++ source files [v4]

2025-04-05 Thread duke
On Mon, 31 Mar 2025 14:31:56 GMT, Patrick Zhang wrote: >> Building jdk with `--with-extra-cflags='-Wno-incompatible-pointer-types'` >> triggers 1000+ warning messages like `cc1plus: warning: command-line option >> ‘-Wno-incompatible-pointer-types’ is valid for C/ObjC but not for C++`. >> >> T

Re: RFR: 8353573: System giflib not found by configure if it's not in system directories

2025-04-04 Thread duke
On Thu, 3 Apr 2025 08:04:50 GMT, snake66 wrote: > The configure script is not able to pick up the giflib installed via system > packages if it's not located in the system include and lib directories. Since > giflib does not provide a pkgconfig, arguments to specify the location of the > includ

Re: RFR: 8353580: libjpeg is not found if not installed in system directories

2025-04-04 Thread duke
On Thu, 3 Apr 2025 07:59:26 GMT, snake66 wrote: > The autoconf scrips fail to find libjpeg on systems where it's not installed > in the default system include and library directories. It should check for > the pkgconfig in these cases. > > This work is sponsored by The FreeBSD Foundation @sna

Re: RFR: 8353009: Document target selection flag for Windows AArch64 builds

2025-03-27 Thread duke
On Wed, 26 Mar 2025 22:38:40 GMT, Saint Wesonga wrote: > The target selection configuration flag for Windows AArch64 should be added > to the build documentation for improved discoverability and completeness. @swesonga Your change (at version c15306a8213b48e369c2b40648a4fd1af2fe2dea) is now re

Re: RFR: 8350801: Add a code signing hook to the JDK build system [v5]

2025-03-27 Thread duke
On Wed, 26 Mar 2025 09:28:49 GMT, Frederic Thevenet wrote: >> OpenJDK vendors who provide binary distributions for the Windows and macOS >> platforms generally need to ensure that every native executable file and >> dynamic library that are part of the binary builds are digitally signed >> us

Re: RFR: 8351323: Parameterize compiler and linker flags for iconv [v3]

2025-03-13 Thread duke
On Thu, 13 Mar 2025 11:39:14 GMT, snake66 wrote: >> Allows for future support for platforms that require different flags for >> libiconv support. >> >> Sponsored-by: The FreeBSD Foundation > > snake66 has updated the pull request incrementally with one additional commit > since the last revisi

Re: RFR: 8345940: Migrate security-related resources from Java classes to properties files [v9]

2025-03-11 Thread duke
On Mon, 10 Mar 2025 17:57:42 GMT, Artur Barashev wrote: >> These resources files are in Java classes. If converted to properties files, >> the localized versions can use UTF-8 encoding directly. >> >> ./src/java.base/share/classes/sun/security/tools/keytool/Resources.java >> ./src/java.base/sha

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-11 Thread duke
On Sat, 8 Mar 2025 13:39:44 GMT, snake66 wrote: >> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that >> it's possible to parameterize this for platforms that use different flags >> for enabling posix threads. >> >> This work is a continuation of the work done by Greg Lew

Withdrawn: 8342869: Errors related to unused code on Windows after 8339120 in awt

2025-02-17 Thread duke
On Wed, 23 Oct 2024 05:07:37 GMT, Julian Waters wrote: > After 8339120, gcc began catching many different instances of unused code in > the Windows specific codebase. Some of these seem to be bugs. I've taken the > effort to mark out all the relevant globals and locals that trigger the > unuse

Re: RFR: 8349934: Wrong file regex for copyright header format check in .jcheck/conf

2025-02-12 Thread duke
On Wed, 12 Feb 2025 19:49:42 GMT, Zhao Song wrote: > The copyright header format check was introduced in > [JDK-8346046](https://bugs.openjdk.org/browse/JDK-8346046). However, a user > recently reported that the check doesn't catch incorrect copyright headers in > this pr(https://github.com/op

Withdrawn: 8344191: Build code should not have classpath exception

2025-01-15 Thread duke
On Thu, 14 Nov 2024 12:22:36 GMT, Magnus Ihse Bursie wrote: > In several (most? all?) of the build system files, the copyright header > includes the classpath exception. This makes no sense, and should be removed. > > I have removed the classpath exception from makefiles, autoconf, shell > sc

Withdrawn: 8340574: Drop stackMapTable.cpp to -O1 for MacOS on XCode 16 to work around JDK-8340341

2025-01-08 Thread duke
On Sun, 22 Sep 2024 09:46:43 GMT, Thomas Stuefe wrote: > Trivial change to drop the optimization level (for both fastdebug and > release) of stackMapTable.cpp to O1 on MacOS with Xcode 16. > > This is a workaround for https://bugs.openjdk.org/browse/JDK-8340341, which > prevents building on Ma

Re: RFR: 8346773: Fix unmatched brackets in some misc files [v3]

2025-01-02 Thread duke
On Wed, 25 Dec 2024 02:34:16 GMT, Qizheng Xing wrote: >> This patch fixes unmatched brackets in some files, mostly in comments, docs >> and man pages. > > Qizheng Xing has updated the pull request incrementally with one additional > commit since the last revision: > > Revert fix in the CTW M

Withdrawn: 8342974: Inconsistent building of static JDK libraries

2024-12-19 Thread duke
On Thu, 24 Oct 2024 16:47:52 GMT, Aleksandar Pejovic wrote: > This PR addresses an inconsistency in the building of static JDK libraries on > Linux when using Clang. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/21689

Re: RFR: 8346046: Enable copyright header format check [v2]

2024-12-16 Thread duke
On Fri, 13 Dec 2024 17:18:10 GMT, Zhao Song wrote: >> As requested in [SKARA-1357](https://bugs.openjdk.org/browse/SKARA-1357), >> now skara bot is able to check the copyright header format. >> Now I am going to update the jcheck configuration to configure copyright >> check as an error. > > Zh

Re: RFR: 8311530: Deprecate jdk.jsobject module for removal [v4]

2024-10-17 Thread duke
On Thu, 17 Oct 2024 18:13:45 GMT, Kevin Rushforth wrote: >> Deprecate the `jdk.jsobject` module for removal from the JDK, and ship it >> with JavaFX instead. >> >> See [JDK-8337280](https://bugs.openjdk.org/browse/JDK-8337280) / PR >> openjdk/jfx#1529 for the JavaFX PR that will include the mo

Re: RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names [v2]

2024-09-25 Thread duke
On Mon, 23 Sep 2024 15:28:48 GMT, Florian Weimer wrote: >> 8340552: Harden TzdbZoneRulesCompiler against missing zone names > > Florian Weimer has updated the pull request incrementally with one additional > commit since the last revision: > > Update copyright year @fweimer-rh Your change (

Re: RFR: 8340815: Add SECURITY.md file [v3]

2024-09-25 Thread duke
On Wed, 25 Sep 2024 06:28:18 GMT, George Adams wrote: >> Currently the [security tab](https://github.com/openjdk/jdk/security) on the >> GitHub repos is empty with no clear information or links on where to report >> security vulnerabilities. >> >> > src="https://github.com/user-attachments/ass

Re: RFR: 8340804: doc/building.md update Xcode instructions to note that full install is required [v3]

2024-09-24 Thread duke
On Tue, 24 Sep 2024 17:18:57 GMT, George Adams wrote: >> Since JDK17 there has been a dependency on metal in the macOS builds which >> is only available as part of the full Xcode IDE (rather than command-line >> tools). We currently recommend only installing the command-line tools in the >> bu

Withdrawn: 8333282: Better warning if newly build JDK fails to run

2024-09-19 Thread duke
On Thu, 30 May 2024 15:02:38 GMT, Magnus Ihse Bursie wrote: > If the newly built JDK fails to run ("DOA"), we will get a strange error > message about jdk.compiler-gendata errors from make. The reason is not at all > obvious. > > Instead, we should make a simple check that we can actually use

Re: RFR: 8339714: Delete tedious bool type define

2024-09-10 Thread duke
On Mon, 9 Sep 2024 09:50:59 GMT, SendaoYan wrote: > Hi all, > This PR delete tedious bool type define in > `src/java.base/unix/native/libjsig/jsig.c` and > `src/utils/hsdis/binutils/hsdis-binutils.c`. After JEP > 347([JDK-8246032](https://bugs.openjdk.org/browse/JDK-8246032)), I think we >

Re: RFR: 8282944: GHA: Add Alpine Linux x86_64 pre-integration check [v12]

2024-08-20 Thread duke
On Mon, 19 Aug 2024 15:33:07 GMT, George Adams wrote: >> Adds Alpine build CI job to the GitHub actions matrix. Currently this only >> builds hotspot. I can add tests too if people think that would be useful but >> for now I've left it as just build. > > George Adams has updated the pull reques

Withdrawn: 8330988: Implementation of 8288293: Windows/gcc Port for hsdis

2024-08-19 Thread duke
On Tue, 23 Apr 2024 13:56:32 GMT, Julian Waters wrote: > WIP > > This changeset contains hsdis for Windows/gcc Port. It supports both the > binutils and capstone backends, though the LLVM backend is left out due to > compatibility issues encountered during the build. Currently, which gcc > di

Withdrawn: 8314488: Compile the JDK as C++17

2024-08-14 Thread duke
On Mon, 24 Jul 2023 01:41:16 GMT, Julian Waters wrote: > Compile the JDK as C++17, enabling the use of all C++17 language features This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/14988

Re: RFR: 8338402: GHA: some of bundles may not get removed

2024-08-14 Thread duke
On Wed, 14 Aug 2024 14:30:28 GMT, Zdenek Zambersky wrote: > Some of bundles may not get removed. This is follows > [JDK-8336928](https://bugs.openjdk.org/browse/JDK-8336928). Problem does not > always show up, so I have not seen it in my test runs, but since then I have > seen some GHA runs af

Re: RFR: 8336928: GHA: Bundle artifacts removal broken [v2]

2024-08-05 Thread duke
On Mon, 22 Jul 2024 20:41:52 GMT, Zdenek Zambersky wrote: >> GHA code, which tries to remove bundle artifacts no longer works. It >> probably broke after >> [JDK-8324723](https://bugs.openjdk.org/browse/JDK-8324723) (GHA: Upgrade >> some actions to avoid deprecated Node 16). >> >> **Details:*

Withdrawn: 8315113: Print request Chromaticity.MONOCHROME attribute does not work on macOS

2024-08-01 Thread duke
On Mon, 11 Mar 2024 13:54:02 GMT, Alexander Scherbatiy wrote: > The fix provides ability to print Black & White pages on macOS. > > Cocoa API has > [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode) > function but it is marked

Re: RFR: 8334166: Enable binary check

2024-08-01 Thread duke
On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song wrote: > @kevinrushforth said in > [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our > repositories contain source code and not binary files. There are exceptions > to this for images and other similar resources, but otherwis

Withdrawn: 8323672: Suppress unwanted autoconf added flags in CC and CXX

2024-07-22 Thread duke
On Fri, 12 Jan 2024 14:49:11 GMT, Julian Waters wrote: > [JDK-8323008](https://bugs.openjdk.org/browse/JDK-8323008) reports unwanted > autoconf flags being added to the command line, and solves the issue by > filtering out the added flags by force. This is not optimal however, as doing > so le

Re: RFR: 8336040: Missing closing anchor element in Docs.gmk

2024-07-17 Thread duke
On Tue, 16 Jul 2024 14:12:54 GMT, Nizar Benalla wrote: > Can I please have a review for this bug fix to make file used to generate the > OpenJDK documentation. It adds the missing `` tag after `OTHER > SPECIFICATIONS`, this should help remove some HTML warnings in out generated > docs. > > Th

Re: RFR: 8336091: Fix HTML warnings in the generated HTML files

2024-07-17 Thread duke
On Tue, 16 Jul 2024 14:29:25 GMT, Nizar Benalla wrote: > Can I please have a review for this bug fix? This regex to avoid duplicate > "style" tags in our generated HTML, It can now match it even if the text > contains a newline character. > > Thanks in advance! @nizarbenalla Your change (at

Withdrawn: 8331020: Assign LANG to C++ for Windows code that uses C++

2024-07-04 Thread duke
On Wed, 24 Apr 2024 01:02:36 GMT, Julian Waters wrote: > Currently, on Windows LANG is not assigned to C++ for some code that does use > C++. This just works because link.exe does not bother about what kind of code > it is currently linking. gcc however, does. It doesn't hurt to assign LANG to

Withdrawn: 8325316: Enable -pedantic -Wpedantic for gcc

2024-07-03 Thread duke
On Tue, 6 Feb 2024 09:45:07 GMT, Julian Waters wrote: > Similarly to [JDK-8325163](https://bugs.openjdk.org/browse/JDK-8325163), this > enables pedantic mode for gcc, ensuring stricter Standard conformance and > allowing for buggy and broken code previously undetectable by gcc to be caught Thi

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v6]

2024-06-27 Thread duke
On Thu, 27 Jun 2024 01:34:36 GMT, Jan Kratochvil wrote: >> fastdebug: >> >> >> # A fatal error has been detected by the Java Runtime Environment: >> # >> # Internal Error >> (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), >> pid=878152, tid=878158 >> # assert

Re: RFR: 8334031: Generated JfrNativeSettings seems off

2024-06-27 Thread duke
On Tue, 25 Jun 2024 18:55:14 GMT, Robert Toyonaga wrote: > This PR changes GenerateJfrFiles.java so that the generated > `JfrNativeSettings` union does not include JFR structs.`JfrNativeSettings` is > meant to hold the settings for JFR events, but previously also included JFR > structs such as

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v4]

2024-06-27 Thread duke
On Mon, 24 Jun 2024 14:11:35 GMT, Jan Kratochvil wrote: >> fastdebug: >> >> >> # A fatal error has been detected by the Java Runtime Environment: >> # >> # Internal Error >> (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), >> pid=878152, tid=878158 >> # assert

Re: RFR: 8334895: OpenJDK fails to configure on linux aarch64 when CDS is disabled after JDK-8331942 [v3]

2024-06-27 Thread duke
On Tue, 25 Jun 2024 19:30:26 GMT, Vladimir Petko wrote: >> This PR sets COMPATIBLE_CDS_ALIGNMENT_DEFAULT to auto for aarch64. >> This allows to avoid configure error on arm64: >> >> $ sh configure --disable-jvm-feature-cds >> ... >> checking if CDS archive is available... no (CDS is disabled) >

Withdrawn: 8311846: Resolve duplicate 'Thread' related symbols with JDK static linking

2024-05-08 Thread duke
On Wed, 17 Jan 2024 00:14:58 GMT, Jiangli Zhou wrote: > Please review this PR with a simple solution for resolving duplicate `Thread` > symbol issue. In https://github.com/openjdk/jdk/pull/14808 comments, there > was an alternative suggestion to redefine the symbol at build time, such as > us

Withdrawn: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF

2024-02-05 Thread duke
On Wed, 18 Oct 2023 06:12:29 GMT, Xiaohong Gong wrote: > Currently the vector floating-point math APIs like > `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform, > which causes large performance gap on AArch64. Note that those APIs are > optimized by C2 compiler on X86 p

Withdrawn: JDK-8313790: [arm32] Specify -marm when building without an ABI profile

2024-02-01 Thread duke
On Fri, 4 Aug 2023 16:17:04 GMT, Thomas Stuefe wrote: > See [JDK-8288719](https://bugs.openjdk.org/browse/JDK-8288719) and subsequent > [discussion](https://mail.openjdk.org/pipermail/build-dev/2022-May/034635.html) > back in 2022. > > On Arm, we can generate either arm- or thumb-code (`-marm`

Withdrawn: 8319761: Simplify fields of Array VarHandles

2024-01-05 Thread duke
On Sun, 24 Sep 2023 13:17:05 GMT, Chen Liang wrote: > 1. Primitive array VHs are now singletons and no longer need to record their > array base and offset in their object themselves. > 2. Moved Unsafe offset calculation to a utility method, like `index` in > VarHandleByteArrayView. This pull r

Withdrawn: JDK-8303166: Disable RTTI for Hotspot when building with MSVC

2023-10-05 Thread duke
On Fri, 24 Feb 2023 15:36:16 GMT, Justin King wrote: > Disable RTTI `-GR-` for Hotspot when building with MSVC. This drops the size > of `jvm.dll` by roughly 1 MB. Hotspot does not rely on RTTI and it is > disabled for both GCC/Clang and Open XL C/C++ already. This change disables > it for MSV

Withdrawn: 8308961: Automatically find configuration matching name of checked of branch

2023-07-27 Thread duke
On Mon, 29 May 2023 13:21:27 GMT, Erik Duveblad wrote: > Hi all, > > please review this smaller patch to the build system. This patch changes what > the build system will do when there are multiple configurations available and > none has been selected (neither via `CONF` nor via `SPEC`). Inste

Withdrawn: 8308071: [REDO] update for deprecated sprintf for src/utils

2023-07-25 Thread duke
On Mon, 15 May 2023 18:46:00 GMT, Xue-Lei Andrew Fan wrote: > Hi, > > This is a redo of JDK-8307855, where issues were found after integration. > > The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because > of security concerns. The issue was addressed in > [JDK-8296812](h

Withdrawn: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-07-06 Thread duke
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote: > This PR converts Unicode sequences to UTF-8 native in .properties file. > (Excluding the Unicode space and tab sequence). The conversion was done using > native2ascii. > > In addition, the build logic is adjusted to support reading in the >

Withdrawn: 8295146: Clean up native code with newer C/C++ language features

2023-06-12 Thread duke
On Thu, 10 Nov 2022 06:20:41 GMT, Julian Waters wrote: > After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and > [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++ > code across the JDK can be replaced and simplified with cleaner language > features that

Withdrawn: 8295795: hsdis does not build with binutils 2.39+

2023-06-06 Thread duke
On Fri, 21 Oct 2022 15:26:59 GMT, Aleksey Shipilev wrote: > Fails like this: > > > $ sh ./configure --with-boot-jdk=jdk19u-ea --with-hsdis=binutils > --with-binutils-src=binutils-2.39 > $ make clean build-hsdis > > === Output from failing command(s) repeated here === > * For target support_hs

Withdrawn: JDK-8305090: Some NMT tests broken when running under ASan

2023-05-31 Thread duke
On Tue, 28 Mar 2023 15:05:41 GMT, Justin King wrote: > This change fixes or skips some NMT tests when running under ASan, as well as > fixing a leak. > > - `allocator_may_return_null=1` is added as the default is `0`, meaning ASan > will never return `nullptr` and will instead crash. NMT tests

Withdrawn: JDK-8300531: Update MSVC optimization flags to match GCC/Clang

2023-05-14 Thread duke
On Wed, 18 Jan 2023 14:32:20 GMT, Justin King wrote: > Update MSVC CFlags to be more consistent with other compilers. Also disables > RTTI in a simliar manner to GCC/Clang for the JVM. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pu

Withdrawn: 8301869: Regression ~14% in J2dBench-bimg_misc-* in 21-b5 only on linux-aarch64

2023-05-01 Thread duke
On Mon, 27 Feb 2023 11:49:27 GMT, Jayathirth D V wrote: > Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of > gcc optimizations from -O1 level for libawt build. This improved our J2DBench > performance numbers in some options considerably. > > Recent changes done under

Withdrawn: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic

2023-04-14 Thread duke
On Tue, 11 Oct 2022 16:02:41 GMT, Andrew Haley wrote: > A bug in GCC causes shared libraries linked with -ffast-math to disable > denormal arithmetic. This breaks Java's floating-point semantics. > > The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522 > > One solution is to save and

Withdrawn: 8294549: configure script should detect unsupported path

2023-03-26 Thread duke
On Thu, 29 Sep 2022 00:09:37 GMT, Mike Duigou wrote: > The OpenJDK build system does not support building when the source code > resides on a path that contains a space. This requirement is documented in > the build instructions but not enforced by the configure script. > > This change adds an