On Tue, 29 Apr 2025 03:38:33 GMT, kuaiwei <d...@openjdk.org> wrote:

>> The patch fix error when creating devkit on wsl/msys2 .
>> * Msys2 can be supported like cygwin
>> * In wsl, it can not test path name in windows format, like `if [ -d 
>> "d:/VisualStuio"]` . The path must be converted as linux style before 
>> testing.
>> * In msys2, `cmd.exe /c` doesn't work because "/c" is converted as "c:", it 
>> can be work around with `cmd.exe //c`. see 
>> https://superuser.com/questions/526736/how-to-run-internal-cmd-command-from-the-msys-shell
>> 
>> I tested it with win10 + wsl/msys2 + VisualStudio 2022(17.13.6)
>
> kuaiwei has updated the pull request incrementally with one additional commit 
> since the last revision:
> 
>   Support more msys2 environments and use MSYS2_ARG_CONV_EXCL for cmd.exe

@kuaiwei 
Your change (at version a81a294e7d6a6630604c03e72f7adfe7565ff9b9) is now ready 
to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24916#issuecomment-2837862847

Reply via email to