On Tue, 21 Jan 2025 09:26:55 GMT, Stefan Karlsson wrote:
>> HotSpot uses precompiled headers to speed up non-incremental builds. The
>> current mechanism requires all .cpp files to include precompiled.hpp as the
>> first non-comment line. This requires HotSpot devs to think about
>> precompile
On Tue, 21 Jan 2025 09:26:55 GMT, Stefan Karlsson wrote:
>> HotSpot uses precompiled headers to speed up non-incremental builds. The
>> current mechanism requires all .cpp files to include precompiled.hpp as the
>> first non-comment line. This requires HotSpot devs to think about
>> precompile
> HotSpot uses precompiled headers to speed up non-incremental builds. The
> current mechanism requires all .cpp files to include precompiled.hpp as the
> first non-comment line. This requires HotSpot devs to think about precompiled
> headers when they create new files and when they need to upda
> HotSpot uses precompiled headers to speed up non-incremental builds. The
> current mechanism requires all .cpp files to include precompiled.hpp as the
> first non-comment line. This requires HotSpot devs to think about precompiled
> headers when they create new files and when they need to upda
On Mon, 20 Jan 2025 10:06:16 GMT, Stefan Karlsson wrote:
>> HotSpot uses precompiled headers to speed up non-incremental builds. The
>> current mechanism requires all .cpp files to include precompiled.hpp as the
>> first non-comment line. This requires HotSpot devs to think about
>> precompile
On Mon, 20 Jan 2025 10:06:16 GMT, Stefan Karlsson wrote:
>> HotSpot uses precompiled headers to speed up non-incremental builds. The
>> current mechanism requires all .cpp files to include precompiled.hpp as the
>> first non-comment line. This requires HotSpot devs to think about
>> precompile
> HotSpot uses precompiled headers to speed up non-incremental builds. The
> current mechanism requires all .cpp files to include precompiled.hpp as the
> first non-comment line. This requires HotSpot devs to think about precompiled
> headers when they create new files and when they need to upda
On Fri, 17 Jan 2025 06:05:54 GMT, David Holmes wrote:
> Do the gtest changes not require something in
> make/hotspot/lib/CompileGtest.gmk?
I don't see anything obvious that needs to be changed.
I've verified that turning precompiled headers on adds the correct flags for
gtests and that gtestM
On Thu, 16 Jan 2025 18:49:51 GMT, Stefan Karlsson wrote:
>> HotSpot uses precompiled headers to speed up non-incremental builds. The
>> current mechanism requires all .cpp files to include precompiled.hpp as the
>> first non-comment line. This requires HotSpot devs to think about
>> precompile
On Thu, 16 Jan 2025 18:49:51 GMT, Stefan Karlsson wrote:
>> HotSpot uses precompiled headers to speed up non-incremental builds. The
>> current mechanism requires all .cpp files to include precompiled.hpp as the
>> first non-comment line. This requires HotSpot devs to think about
>> precompile
> HotSpot uses precompiled headers to speed up non-incremental builds. The
> current mechanism requires all .cpp files to include precompiled.hpp as the
> first non-comment line. This requires HotSpot devs to think about precompiled
> headers when they create new files and when they need to upda
On Thu, 16 Jan 2025 15:49:39 GMT, Stefan Karlsson wrote:
>> HotSpot uses precompiled headers to speed up non-incremental builds. The
>> current mechanism requires all .cpp files to include precompiled.hpp as the
>> first non-comment line. This requires HotSpot devs to think about
>> precompile
On Thu, 16 Jan 2025 14:31:25 GMT, Erik Joelsson wrote:
> > I believe I had cases where I explicitly needed to avoid using the
> > precompiled mechanism for a file. That is still possible, right?
>
> That should still be possible using the exclude parameter to
> SetupNativeCompilation.
JvmOver
On Thu, 16 Jan 2025 14:26:53 GMT, Erik Joelsson wrote:
> Looks good to me, but would suggest breaking up some of those lines.
Thanks for reviewing. I committed your suggestions.
-
PR Comment: https://git.openjdk.org/jdk/pull/23146#issuecomment-2596071557
> HotSpot uses precompiled headers to speed up non-incremental builds. The
> current mechanism requires all .cpp files to include precompiled.hpp as the
> first non-comment line. This requires HotSpot devs to think about precompiled
> headers when they create new files and when they need to upda
On Thu, 16 Jan 2025 13:10:30 GMT, Thomas Stuefe wrote:
> I believe I had cases where I explicitly needed to avoid using the
> precompiled mechanism for a file. That is still possible, right?
That should still be possible using the exclude parameter to
SetupNativeCompilation.
-
PR
On Thu, 16 Jan 2025 11:28:55 GMT, Stefan Karlsson wrote:
> HotSpot uses precompiled headers to speed up non-incremental builds. The
> current mechanism requires all .cpp files to include precompiled.hpp as the
> first non-comment line. This requires HotSpot devs to think about precompiled
> he
On Thu, 16 Jan 2025 11:28:55 GMT, Stefan Karlsson wrote:
> HotSpot uses precompiled headers to speed up non-incremental builds. The
> current mechanism requires all .cpp files to include precompiled.hpp as the
> first non-comment line. This requires HotSpot devs to think about precompiled
> he
HotSpot uses precompiled headers to speed up non-incremental builds. The
current mechanism requires all .cpp files to include precompiled.hpp as the
first non-comment line. This requires HotSpot devs to think about precompiled
headers when they create new files and when they need to update/manag
19 matches
Mail list logo
