Re: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension [v3]

2025-08-15 Thread Manuel Hässig
On Fri, 15 Aug 2025 06:36:46 GMT, Manuel Hässig wrote: >> This PR adds a basic configuration for the [Oracle Java VSCode >> extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) >> to the `vscode-project-*` targets. > > Manuel Hässig has updated the pull request inc

Re: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension [v3]

2025-08-15 Thread Magnus Ihse Bursie
On Fri, 15 Aug 2025 06:36:46 GMT, Manuel Hässig wrote: >> This PR adds a basic configuration for the [Oracle Java VSCode >> extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) >> to the `vscode-project-*` targets. > > Manuel Hässig has updated the pull request inc

Re: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension [v3]

2025-08-15 Thread Jan Lahoda
On Fri, 15 Aug 2025 06:36:46 GMT, Manuel Hässig wrote: >> This PR adds a basic configuration for the [Oracle Java VSCode >> extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) >> to the `vscode-project-*` targets. > > Manuel Hässig has updated the pull request inc

Re: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension [v2]

2025-08-14 Thread Manuel Hässig
On Wed, 13 Aug 2025 14:23:37 GMT, Manuel Hässig wrote: >> This PR adds a basic configuration for the [Oracle Java VSCode >> extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) >> to the `vscode-project-*` targets. > > Manuel Hässig has updated the pull request inc

Re: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension [v3]

2025-08-14 Thread Manuel Hässig
> This PR adds a basic configuration for the [Oracle Java VSCode > extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) > to the `vscode-project-*` targets. Manuel Hässig has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension

2025-08-14 Thread Jan Lahoda
On Wed, 13 Aug 2025 14:24:28 GMT, Manuel Hässig wrote: > > I would suggest to drop: `"jdk.advanced.disable.nbjavac": true,` > > Can you elaborate on the surprising results? When developing the JDK we will > most probably use features not supported by the `nbjavac`. In general, it can be anythi

Re: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension [v2]

2025-08-14 Thread Magnus Ihse Bursie
On Wed, 13 Aug 2025 14:23:37 GMT, Manuel Hässig wrote: >> This PR adds a basic configuration for the [Oracle Java VSCode >> extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) >> to the `vscode-project-*` targets. > > Manuel Hässig has updated the pull request inc

Re: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension

2025-08-13 Thread Manuel Hässig
On Wed, 13 Aug 2025 14:08:56 GMT, Jan Lahoda wrote: > I would suggest to drop: `"jdk.advanced.disable.nbjavac": true,` Can you elaborate on the surprising results? When developing the JDK we will most probably use features not supported by the `nbjavac`. > Also, including:`"jdk.java.onSave.org

Re: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension [v2]

2025-08-13 Thread Manuel Hässig
> This PR adds a basic configuration for the [Oracle Java VSCode > extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) > to the `vscode-project-*` targets. Manuel Hässig has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension

2025-08-13 Thread Jan Lahoda
On Wed, 13 Aug 2025 13:22:21 GMT, Manuel Hässig wrote: > This PR adds a basic configuration for the [Oracle Java VSCode > extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) > to the `vscode-project-*` targets. Looks like a reasonable direction to me. I would sug

RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension

2025-08-13 Thread Manuel Hässig
This PR adds a basic configuration for the [Oracle Java VSCode extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) to the `vscode-project-*` targets. - Commit messages: - make/ide/vscode: add basic configuration for Oracle Java extension Changes: htt