On Thu, 16 Feb 2023 06:33:08 GMT, Ioi Lam wrote:
> As a general comment, the bug title should be to the point. "Look suspicious"
> contains no information. It looks like you are changing the optimization
> level, so the bug title should reflect that.
I agree. But let me expand the point a bit:
On Wed, 15 Feb 2023 21:21:47 GMT, Justin King wrote:
>> Update MSVC CFlags to be more consistent with other compilers. Also disables
>> RTTI in a simliar manner to GCC/Clang for the JVM.
>
> Justin King has updated the pull request incrementally with one additional
> commit since the last revis
On Wed, 15 Feb 2023 21:21:47 GMT, Justin King wrote:
>> Update MSVC CFlags to be more consistent with other compilers. Also disables
>> RTTI in a simliar manner to GCC/Clang for the JVM.
>
> Justin King has updated the pull request incrementally with one additional
> commit since the last revis
On Wed, 15 Feb 2023 21:21:47 GMT, Justin King wrote:
>> Update MSVC CFlags to be more consistent with other compilers. Also disables
>> RTTI in a simliar manner to GCC/Clang for the JVM.
>
> Justin King has updated the pull request incrementally with one additional
> commit since the last revis
On Thu, 16 Feb 2023 02:03:35 GMT, David Holmes wrote:
> > Looks like serviceability might rely on RTTI on Windows.
>
> Can you point to the code please? We should not be using RTTI.
Removing /GR- makes the tests pass. I think somewhere we are indirectly relying
on RTTI for Windows. Maybe relat
On Wed, 15 Feb 2023 21:17:45 GMT, Justin King wrote:
> Looks like serviceability might rely on RTTI on Windows.
Can you point to the code please? We should not be using RTTI.
-
PR: https://git.openjdk.org/jdk/pull/12073
On Tue, 14 Feb 2023 18:42:07 GMT, Justin King wrote:
>> Update MSVC CFlags to be more consistent with other compilers. Also disables
>> RTTI in a simliar manner to GCC/Clang for the JVM.
>
> Justin King has updated the pull request incrementally with one additional
> commit since the last revis
> Update MSVC CFlags to be more consistent with other compilers. Also disables
> RTTI in a simliar manner to GCC/Clang for the JVM.
Justin King has updated the pull request incrementally with one additional
commit since the last revision:
Revert usage of /GR-
Signed-off-by: Justin King
On Tue, 14 Feb 2023 18:42:07 GMT, Justin King wrote:
>> Update MSVC CFlags to be more consistent with other compilers. Also disables
>> RTTI in a simliar manner to GCC/Clang for the JVM.
>
> Justin King has updated the pull request incrementally with one additional
> commit since the last revis
> Update MSVC CFlags to be more consistent with other compilers. Also disables
> RTTI in a simliar manner to GCC/Clang for the JVM.
Justin King has updated the pull request incrementally with one additional
commit since the last revision:
Reposition -Oy-
Signed-off-by: Justin King
> Update MSVC CFlags to be more consistent with other compilers. Also disables
> RTTI in a simliar manner to GCC/Clang for the JVM.
Justin King has updated the pull request incrementally with one additional
commit since the last revision:
Reposition -Oy-
Signed-off-by: Justin King
> Update MSVC CFlags to be more consistent with other compilers. Also disables
> RTTI in a simliar manner to GCC/Clang for the JVM.
Justin King has updated the pull request incrementally with one additional
commit since the last revision:
Add -Oy-
Signed-off-by: Justin King
---
On Tue, 14 Feb 2023 17:21:51 GMT, Justin King wrote:
>> Update MSVC CFlags to be more consistent with other compilers. Also disables
>> RTTI in a simliar manner to GCC/Clang for the JVM.
>
> Justin King has updated the pull request with a new target base due to a
> merge or a rebase. The pull r
> Update MSVC CFlags to be more consistent with other compilers. Also disables
> RTTI in a simliar manner to GCC/Clang for the JVM.
Justin King has updated the pull request incrementally with one additional
commit since the last revision:
Remove -Ob3
Signed-off-by: Justin King
> Update MSVC CFlags to be more consistent with other compilers. Also disables
> RTTI in a simliar manner to GCC/Clang for the JVM.
Justin King has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains one commit:
Update MSVC CFlags
Sig
> Update MSVC CFlags to be more consistent with other compilers. Also disables
> RTTI in a simliar manner to GCC/Clang for the JVM.
Justin King has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the
On Thu, 19 Jan 2023 19:23:30 GMT, Erik Joelsson wrote:
> Changing the global optimization flags is a pretty big and potentially
> intrusive change. It's quite possible that the current flags need a
> re-evaluation, since they were chosen a long time ago, for a much older
> version of Visual St
On Thu, 19 Jan 2023 19:23:30 GMT, Erik Joelsson wrote:
> I don't think making the number after the O in the flags match what we use
> for other compilers is motivation enough to warrant a change like this.
> Different compilers are sure to have their optimization levels mean different
> things
On Thu, 19 Jan 2023 17:27:57 GMT, Justin King wrote:
>> Update MSVC CFlags to be more consistent with other compilers. Also disables
>> RTTI in a simliar manner to GCC/Clang for the JVM.
>
> Justin King has updated the pull request with a new target base due to a
> merge or a rebase. The increm
> Update MSVC CFlags to be more consistent with other compilers. Also disables
> RTTI in a simliar manner to GCC/Clang for the JVM.
Justin King has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the
On Wed, 18 Jan 2023 14:32:20 GMT, Justin King wrote:
> Update MSVC CFlags to be more consistent with other compilers. Also disables
> RTTI in a simliar manner to GCC/Clang for the JVM.
Not sure why `-Oy-` was used. GCC/Clang omit frame pointers by default these
days, IIRC. So forcing MSVC to p
Update MSVC CFlags to be more consistent with other compilers. Also disables
RTTI in a simliar manner to GCC/Clang for the JVM.
-
Commit messages:
- Update MSVC CFlags
Changes: https://git.openjdk.org/jdk/pull/12073/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12073&rang
22 matches
Mail list logo
