Re: RFR: 8348327: Incorrect march flag when building libsleef/vector_math_neon.c

2025-01-23 Thread Aleksey Shipilev
On Thu, 23 Jan 2025 00:04:47 GMT, Mikael Vidstedt wrote: > [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) started building > the libsleef library with `$(SVE_CFLAGS)` on aarch64. That variable expands > to `-march=armv8-a+sve` if the compiler supports it. > > The flag should only b

RFR: 8348392: Make claims "other matches are possible" even when that is not true

2025-01-23 Thread Magnus Ihse Bursie
When matching configurations using CONF, normally this is treated as a pattern. However, if an exact match is found, this is exclusively used. This is to allow matching for e.g. linux-x64 and not matching linux-x64-debug, which is otherwise impossible. To inform the user that this has happened,

RFR: 8348391: Keep case if possible for TOPDIR

2025-01-23 Thread Magnus Ihse Bursie
To figure out the root of the JDK build, we set the TOPDIR variable in configure. Furthermore, we clean it up using UTIL_FIXUP_PATH as we do with all paths. On Windows, this can result in the path becoming all lowercase. Since Windows paths are case insensitive, this is normally not a problem. H

Re: RFR: 8348286: [AIX] clang 17 introduces new warning Wtentative-Definitions which produces Build errors

2025-01-23 Thread Joachim Kern
On Thu, 23 Jan 2025 00:22:08 GMT, Magnus Ihse Bursie wrote: > Try this instead: > > ``` > diff --git a/make/autoconf/flags-cflags.m4 b/make/autoconf/flags-cflags.m4 > index 729e508cc26..04831c07d97 100644 > --- a/make/autoconf/flags-cflags.m4 > +++ b/make/autoconf/flags-cflags.m4 > @@ -263,7 +26

RFR: 8348387: Add fixpath if needed for user-supplied tools

2025-01-23 Thread Magnus Ihse Bursie
When discovering tools, configure checks if it is a program that can handle unix-style paths or not. If it isn't, a fixpath prefix is automatically added. But when the user supplies a tool like `configure FOO=foo.exe`, this does not happen. If that tool does not understand unix-style paths, then

Re: RFR: 8348286: [AIX] clang 17 introduces new warning Wtentative-Definitions which produces Build errors

2025-01-23 Thread Joachim Kern
On Thu, 23 Jan 2025 09:58:07 GMT, Magnus Ihse Bursie wrote: > If you run `make jdk -k`, you will get a complete list of all places where > the compiler is complaining. Unless it is too large, please post it here. Only two headers are questionable for clang 17 src/java.desktop/share/native/liba

Re: RFR: 8348286: [AIX] clang 17 introduces new warning Wtentative-Definitions which produces Build errors

2025-01-23 Thread Joachim Kern
On Wed, 22 Jan 2025 15:34:36 GMT, Joachim Kern wrote: > We (SAP) try to introduce the ‘IBM Open XL C/C++ for AIX 17.1.2’ (based on > clang 17) as a feasible compiler for jdk25, because in combination with the > 17.1.3 runtime this would enable the support for ubsan. > Unfortunately, the new com

Re: RFR: 8348286: [AIX] clang 17 introduces new warning Wtentative-Definitions which produces Build errors [v2]

2025-01-23 Thread Joachim Kern
> We (SAP) try to introduce the ‘IBM Open XL C/C++ for AIX 17.1.2’ (based on > clang 17) as a feasible compiler for jdk25, because in combination with the > 17.1.3 runtime this would enable the support for ubsan. > Unfortunately, the new compiler comes along with a new set of compiler > warnings

Re: RFR: 8348286: [AIX] clang 17 introduces new warning Wtentative-Definitions which produces Build errors

2025-01-23 Thread Magnus Ihse Bursie
On Thu, 23 Jan 2025 11:47:08 GMT, Joachim Kern wrote: > I reverted the changes in flags-cflags.m4 I still see them..? I think the changes you propose seem much better. Of course, in the end, the client team needs to agree to them to. The fp_pipewire.h looks trivially okay -- there seem to be

RFR: 8348207: Linux PPC64 PCH build broken after JDK-8347909

2025-01-23 Thread Matthias Baesken
The Linux PPC64 PCH build was broken after JDK-8347909. - Commit messages: - JDK-8348207 Changes: https://git.openjdk.org/jdk/pull/23268/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23268&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8348207 Stats: 10 lines in

Re: RFR: 8348327: Incorrect march flag when building libsleef/vector_math_neon.c

2025-01-23 Thread Vladimir Ivanov
On Thu, 23 Jan 2025 00:04:47 GMT, Mikael Vidstedt wrote: > [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) started building > the libsleef library with `$(SVE_CFLAGS)` on aarch64. That variable expands > to `-march=armv8-a+sve` if the compiler supports it. > > The flag should only b

Integrated: 8348392: Make claims "other matches are possible" even when that is not true

2025-01-23 Thread Magnus Ihse Bursie
On Thu, 23 Jan 2025 10:58:19 GMT, Magnus Ihse Bursie wrote: > When matching configurations using CONF, normally this is treated as a > pattern. However, if an exact match is found, this is exclusively used. This > is to allow matching for e.g. linux-x64 and not matching linux-x64-debug, > whic

Integrated: 8348387: Add fixpath if needed for user-supplied tools

2025-01-23 Thread Magnus Ihse Bursie
On Thu, 23 Jan 2025 10:02:32 GMT, Magnus Ihse Bursie wrote: > When discovering tools, configure checks if it is a program that can handle > unix-style paths or not. If it isn't, a fixpath prefix is automatically added. > > But when the user supplies a tool like `configure FOO=foo.exe`, this doe

Re: RFR: 8348391: Keep case if possible for TOPDIR

2025-01-23 Thread Magnus Ihse Bursie
On Thu, 23 Jan 2025 10:14:24 GMT, Magnus Ihse Bursie wrote: > To figure out the root of the JDK build, we set the TOPDIR variable in > configure. Furthermore, we clean it up using UTIL_FIXUP_PATH as we do with > all paths. On Windows, this can result in the path becoming all lowercase. > Since

Integrated: 8348391: Keep case if possible for TOPDIR

2025-01-23 Thread Magnus Ihse Bursie
On Thu, 23 Jan 2025 10:14:24 GMT, Magnus Ihse Bursie wrote: > To figure out the root of the JDK build, we set the TOPDIR variable in > configure. Furthermore, we clean it up using UTIL_FIXUP_PATH as we do with > all paths. On Windows, this can result in the path becoming all lowercase. > Since

Re: RFR: 8348286: [AIX] clang 17 introduces new warning Wtentative-Definitions which produces Build errors [v3]

2025-01-23 Thread Magnus Ihse Bursie
On Thu, 23 Jan 2025 13:48:06 GMT, Joachim Kern wrote: >> We (SAP) try to introduce the ‘IBM Open XL C/C++ for AIX 17.1.2’ (based on >> clang 17) as a feasible compiler for jdk25, because in combination with the >> 17.1.3 runtime this would enable the support for ubsan. >> Unfortunately, the new

Re: RFR: 8348327: Incorrect march flag when building libsleef/vector_math_neon.c

2025-01-23 Thread Mikael Vidstedt
On Thu, 23 Jan 2025 00:04:47 GMT, Mikael Vidstedt wrote: > [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) started building > the libsleef library with `$(SVE_CFLAGS)` on aarch64. That variable expands > to `-march=armv8-a+sve` if the compiler supports it. > > The flag should only b

Integrated: 8348327: Incorrect march flag when building libsleef/vector_math_neon.c

2025-01-23 Thread Mikael Vidstedt
On Thu, 23 Jan 2025 00:04:47 GMT, Mikael Vidstedt wrote: > [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) started building > the libsleef library with `$(SVE_CFLAGS)` on aarch64. That variable expands > to `-march=armv8-a+sve` if the compiler supports it. > > The flag should only b

Re: RFR: 8348387: Add fixpath if needed for user-supplied tools

2025-01-23 Thread Erik Joelsson
On Thu, 23 Jan 2025 10:02:32 GMT, Magnus Ihse Bursie wrote: > When discovering tools, configure checks if it is a program that can handle > unix-style paths or not. If it isn't, a fixpath prefix is automatically added. > > But when the user supplies a tool like `configure FOO=foo.exe`, this doe

Re: RFR: 8348391: Keep case if possible for TOPDIR

2025-01-23 Thread Erik Joelsson
On Thu, 23 Jan 2025 10:14:24 GMT, Magnus Ihse Bursie wrote: > To figure out the root of the JDK build, we set the TOPDIR variable in > configure. Furthermore, we clean it up using UTIL_FIXUP_PATH as we do with > all paths. On Windows, this can result in the path becoming all lowercase. > Since

Re: RFR: 8348286: [AIX] clang 17 introduces new warning Wtentative-Definitions which produces Build errors [v3]

2025-01-23 Thread Joachim Kern
> We (SAP) try to introduce the ‘IBM Open XL C/C++ for AIX 17.1.2’ (based on > clang 17) as a feasible compiler for jdk25, because in combination with the > 17.1.3 runtime this would enable the support for ubsan. > Unfortunately, the new compiler comes along with a new set of compiler > warnings

Re: RFR: 8348392: Make claims "other matches are possible" even when that is not true

2025-01-23 Thread Erik Joelsson
On Thu, 23 Jan 2025 10:58:19 GMT, Magnus Ihse Bursie wrote: > When matching configurations using CONF, normally this is treated as a > pattern. However, if an exact match is found, this is exclusively used. This > is to allow matching for e.g. linux-x64 and not matching linux-x64-debug, > whic

Re: RFR: 8348207: Linux PPC64 PCH build broken after JDK-8347909

2025-01-23 Thread Erik Joelsson
On Thu, 23 Jan 2025 12:59:19 GMT, Matthias Baesken wrote: > The Linux PPC64 PCH build was broken after JDK-8347909. > Build error > > * For target hotspot_variant-server_libjvm_objs_sharedRuntimeTrans.o: > cc1plus: error: > /jdk25_opt/hotspot/variant-server/libjvm/objs/precompiled/precompiled.h

Re: RFR: 8348286: [AIX] clang 17 introduces new warning Wtentative-Definitions which produces Build errors [v3]

2025-01-23 Thread Alexander Zvegintsev
On Thu, 23 Jan 2025 13:48:06 GMT, Joachim Kern wrote: >> We (SAP) try to introduce the ‘IBM Open XL C/C++ for AIX 17.1.2’ (based on >> clang 17) as a feasible compiler for jdk25, because in combination with the >> 17.1.3 runtime this would enable the support for ubsan. >> Unfortunately, the new

Re: RFR: 8348207: Linux PPC64 PCH build broken after JDK-8347909

2025-01-23 Thread Martin Doerr
On Thu, 23 Jan 2025 12:59:19 GMT, Matthias Baesken wrote: > The Linux PPC64 PCH build was broken after JDK-8347909. > Build error > > * For target hotspot_variant-server_libjvm_objs_sharedRuntimeTrans.o: > cc1plus: error: > /jdk25_opt/hotspot/variant-server/libjvm/objs/precompiled/precompiled.h

RFR: 8318098: Update jfr tests to replace keyword jfr with vm.flagless

2025-01-23 Thread Leonid Mesnik
A lot of jfr tests are very specific. Currently all of them are marked with jfr keyword and excluded when VM flags are set. It makes sense to mark them with @requires to be complaint with all other openjdk tests. The next step is to review tests and remove vm.flagless from tests that should b

RFR: 8348429: Update cross-compilation devkits to Fedora 41/gcc 13.2

2025-01-23 Thread Magnus Ihse Bursie
The devkit makefile is a public description on how Oracle builds the JDK in its CI system. This patch will update the devkit makefile to make Fedora 41 default for all platforms, and update the jib configuration to use devkits based on Fedora 41 and gcc 13.2. Also some additional fixes are need

Re: RFR: 8348286: [AIX] clang 17 introduces new warning Wtentative-Definitions which produces Build errors [v3]

2025-01-23 Thread Magnus Ihse Bursie
On Thu, 23 Jan 2025 20:31:03 GMT, Phil Race wrote: > The compiler must have been confused. Definitely, but I don't blame it. Look at this construct: #define IMGEXTERN #include "imageInitIDs.h" There is really no way for the poor compiler to understand that in this case, it was really intentio

Re: [jdk24] RFR: 8348327: Incorrect march flag when building libsleef/vector_math_neon.c

2025-01-23 Thread Erik Joelsson
On Thu, 23 Jan 2025 18:47:35 GMT, Mikael Vidstedt wrote: > This pull request contains a backport of commit > [3ebf8899](https://github.com/openjdk/jdk/commit/3ebf88996f35f397f4396e3d139b9251048de751) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backpor

Re: RFR: 8348207: Linux PPC64 PCH build broken after JDK-8347909

2025-01-23 Thread David Holmes
On Thu, 23 Jan 2025 23:53:01 GMT, Magnus Ihse Bursie wrote: >> The Linux PPC64 PCH build was broken after JDK-8347909. >> Build error >> >> * For target hotspot_variant-server_libjvm_objs_sharedRuntimeTrans.o: >> cc1plus: error: >> /jdk25_opt/hotspot/variant-server/libjvm/objs/precompiled/preco

Re: RFR: 8348207: Linux PPC64 PCH build broken after JDK-8347909

2025-01-23 Thread Magnus Ihse Bursie
On Thu, 23 Jan 2025 12:59:19 GMT, Matthias Baesken wrote: > The Linux PPC64 PCH build was broken after JDK-8347909. > Build error > > * For target hotspot_variant-server_libjvm_objs_sharedRuntimeTrans.o: > cc1plus: error: > /jdk25_opt/hotspot/variant-server/libjvm/objs/precompiled/precompiled.h

Re: RFR: 8348429: Update cross-compilation devkits to Fedora 41/gcc 13.2

2025-01-23 Thread Erik Joelsson
On Thu, 23 Jan 2025 22:51:46 GMT, Magnus Ihse Bursie wrote: > The devkit makefile is a public description on how Oracle builds the JDK in > its CI system. This patch will update the devkit makefile to make Fedora 41 > default for all platforms, and update the jib configuration to use devkits >

Re: RFR: 8348429: Update cross-compilation devkits to Fedora 41/gcc 13.2

2025-01-23 Thread Magnus Ihse Bursie
On Thu, 23 Jan 2025 23:19:44 GMT, Erik Joelsson wrote: >> The devkit makefile is a public description on how Oracle builds the JDK in >> its CI system. This patch will update the devkit makefile to make Fedora 41 >> default for all platforms, and update the jib configuration to use devkits >>

[jdk24] RFR: 8348327: Incorrect march flag when building libsleef/vector_math_neon.c

2025-01-23 Thread Mikael Vidstedt
This pull request contains a backport of commit [3ebf8899](https://github.com/openjdk/jdk/commit/3ebf88996f35f397f4396e3d139b9251048de751) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Mikael Vidstedt on 23 Jan 2025 and was reviewed

Re: RFR: 8348286: [AIX] clang 17 introduces new warning Wtentative-Definitions which produces Build errors [v3]

2025-01-23 Thread Phil Race
On Thu, 23 Jan 2025 13:48:06 GMT, Joachim Kern wrote: >> We (SAP) try to introduce the ‘IBM Open XL C/C++ for AIX 17.1.2’ (based on >> clang 17) as a feasible compiler for jdk25, because in combination with the >> 17.1.3 runtime this would enable the support for ubsan. >> Unfortunately, the new

Re: RFR: 8348207: Linux PPC64 PCH build broken after JDK-8347909

2025-01-23 Thread Magnus Ihse Bursie
On Thu, 23 Jan 2025 12:59:19 GMT, Matthias Baesken wrote: > The Linux PPC64 PCH build was broken after JDK-8347909. > Build error > > * For target hotspot_variant-server_libjvm_objs_sharedRuntimeTrans.o: > cc1plus: error: > /jdk25_opt/hotspot/variant-server/libjvm/objs/precompiled/precompiled.h