> Allow the user to set "--with-jcov-modules=java.desktop", instead of
> "--with-jcov-filters=--include-modules java.desktop", since this is one of
> the common use cases for the filtering.
Magnus Ihse Bursie has updated the pull request incrementally with one
additional commit since the last r
On Wed, 7 May 2025 09:18:29 GMT, Magnus Ihse Bursie wrote:
>> Allow the user to set "--with-jcov-modules=java.desktop", instead of
>> "--with-jcov-filters=--include-modules java.desktop", since this is one of
>> the common use cases for the filtering.
>
> Magnus Ihse Bursie has updated the pull
On Wed, 7 May 2025 09:18:29 GMT, Magnus Ihse Bursie wrote:
>> Allow the user to set "--with-jcov-modules=java.desktop", instead of
>> "--with-jcov-filters=--include-modules java.desktop", since this is one of
>> the common use cases for the filtering.
>
> Magnus Ihse Bursie has updated the pull
Windows can create short names for directories that contain spaces in the name.
However, where short name creation was previously enabled by default, it no
longer seems to be in recent version of Windows (the default setting is instead
'per volume', and the default for each volume is 'off').
We
On Mon, 7 Apr 2025 08:45:13 GMT, Magnus Ihse Bursie wrote:
> Allow the user to set "--with-jcov-modules=java.desktop", instead of
> "--with-jcov-filters=--include-modules java.desktop", since this is one of
> the common use cases for the filtering.
This pull request has now been integrated.
C
On Wed, 7 May 2025 07:51:16 GMT, Magnus Ihse Bursie wrote:
> After [JEP 503](https://openjdk.org/jeps/503), we cannot build linux-x86 so
> it should not be included in the jib profiles.
>
> I also took the opportunity to remove the superfluous `--with-target-bits=64`
> option, clean up some `
On Wed, 7 May 2025 09:09:53 GMT, Magnus Ihse Bursie wrote:
>> After [JEP 503](https://openjdk.org/jeps/503), we cannot build linux-x86 so
>> it should not be included in the jib profiles.
>>
>> I also took the opportunity to remove the superfluous
>> `--with-target-bits=64` option, clean up s
On Wed, 7 May 2025 09:18:29 GMT, Magnus Ihse Bursie wrote:
>> Allow the user to set "--with-jcov-modules=java.desktop", instead of
>> "--with-jcov-filters=--include-modules java.desktop", since this is one of
>> the common use cases for the filtering.
>
> Magnus Ihse Bursie has updated the pull
On Wed, 7 May 2025 10:57:27 GMT, Magnus Ihse Bursie wrote:
> When we setup a command to run, e.g. $FOO we typically set this to just a
> path to a binary, e.g. /usr/bin/foo. However, this is not necessarily true.
> On Windows, this can be prefixed by the $FIXPATH prefix, and on all platforms
>
On Mon, 7 Apr 2025 09:18:08 GMT, Magnus Ihse Bursie wrote:
> Windows can create short names for directories that contain spaces in the
> name.
>
> However, where short name creation was previously enabled by default, it no
> longer seems to be in recent version of Windows (the default setting
> After [JEP 503](https://openjdk.org/jeps/503), we cannot build linux-x86 so
> it should not be included in the jib profiles.
>
> I also took the opportunity to remove the superfluous `--with-target-bits=64`
> option, clean up some `configure_args` constructs, and to reorder the
> profiles to
On Wed, 7 May 2025 11:22:40 GMT, Magnus Ihse Bursie wrote:
> JAVA_TOOL_OPTIONS and _JAVA_OPTIONS are setup in lines 127...130 in
> RunTests.gmk.
>
> @mrserb Is this expected behavior, or am I doing something wrong?
That is a known issue: https://bugs.openjdk.org/browse/JDK-8219323
---
When we setup a command to run, e.g. $FOO we typically set this to just a path
to a binary, e.g. /usr/bin/foo. However, this is not necessarily true. On
Windows, this can be prefixed by the $FIXPATH prefix, and on all platforms we
are allowed to pass arguments to the executable.
If we want to t
On Tue, 6 May 2025 21:50:34 GMT, Igor Veresov wrote:
>> Improve warm-up time by making profile data from a previous run of an
>> application instantly available, when the HotSpot Java Virtual Machine
>> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483)
>> to store met
On Wed, 7 May 2025 10:57:27 GMT, Magnus Ihse Bursie wrote:
> When we setup a command to run, e.g. $FOO we typically set this to just a
> path to a binary, e.g. /usr/bin/foo. However, this is not necessarily true.
> On Windows, this can be prefixed by the $FIXPATH prefix, and on all platforms
>
On Wed, 7 May 2025 15:08:53 GMT, Magnus Ihse Bursie wrote:
> If you check out your source code in Cygwin, somewhere under /home/... (as
> opposed to /cygpath/...), IncludeCustomExtension does not work.
>
> The problem is that TOPDIR gets a different lexical value from the spec.gmk
> file when
`echo -n` is not part of the required POSIX standard, and built in shell
versions of echo might not support it. Restore the previous use of `printf`
instead.
-
Commit messages:
- 8354278: Revert use of non-POSIX echo -n introduced in JDK-8301197
Changes: https://git.openjdk.org/jd
On Wed, 7 May 2025 21:25:39 GMT, Magnus Ihse Bursie wrote:
> `echo -n` is not part of the required POSIX standard, and built in shell
> versions of echo might not support it. Restore the previous use of `printf`
> instead.
Verified 15 uses of `$(ECHO) -n` introduced by
[8301197](https://bugs.
On Mon, 7 Apr 2025 09:18:08 GMT, Magnus Ihse Bursie wrote:
> Windows can create short names for directories that contain spaces in the
> name.
>
> However, where short name creation was previously enabled by default, it no
> longer seems to be in recent version of Windows (the default setting
On Fri, 4 Apr 2025 14:44:07 GMT, Magnus Ihse Bursie wrote:
> We should always exclude `doc-files` and `snippet-files` when compiling java
> code. To generalize this, exclude all `*-files` directories.
>
> (The usage of EXCLUDES and EXCLUDE_FILES is a bit weird. In essence,
> EXCLUDE_FILES prep
On Wed, 7 May 2025 21:21:14 GMT, Erik Joelsson wrote:
> Is it the `cd $$(TOPDIR)` when calling make from `DefineMakeTargets` that is
> causing the mismatch that you are correcting by including SPEC here?
No, it is the `-f $$(TOPDIR)/make/GenerateFindTests.gmk` argument to make. This
is added v
On Wed, 7 May 2025 15:08:53 GMT, Magnus Ihse Bursie wrote:
> If you check out your source code in Cygwin, somewhere under /home/... (as
> opposed to /cygpath/...), IncludeCustomExtension does not work.
>
> The problem is that TOPDIR gets a different lexical value from the spec.gmk
> file when
On Wed, 7 May 2025 21:17:47 GMT, Erik Joelsson wrote:
>> If you check out your source code in Cygwin, somewhere under /home/... (as
>> opposed to /cygpath/...), IncludeCustomExtension does not work.
>>
>> The problem is that TOPDIR gets a different lexical value from the spec.gmk
>> file when
On Wed, 7 May 2025 22:50:52 GMT, Magnus Ihse Bursie wrote:
>> If you check out your source code in Cygwin, somewhere under /home/... (as
>> opposed to /cygpath/...), IncludeCustomExtension does not work.
>>
>> The problem is that TOPDIR gets a different lexical value from the spec.gmk
>> file
> Windows can create short names for directories that contain spaces in the
> name.
>
> However, where short name creation was previously enabled by default, it no
> longer seems to be in recent version of Windows (the default setting is
> instead 'per volume', and the default for each volume i
On Wed, 7 May 2025 20:26:13 GMT, Magnus Ihse Bursie wrote:
>> Windows can create short names for directories that contain spaces in the
>> name.
>>
>> However, where short name creation was previously enabled by default, it no
>> longer seems to be in recent version of Windows (the default set
We should always exclude `doc-files` and `snippet-files` when compiling java
code. To generalize this, exclude all `*-files` directories.
(The usage of EXCLUDES and EXCLUDE_FILES is a bit weird. In essence,
EXCLUDE_FILES prepends a `%` wildchar match to the filenames given, which we
use here, w
> Windows can create short names for directories that contain spaces in the
> name.
>
> However, where short name creation was previously enabled by default, it no
> longer seems to be in recent version of Windows (the default setting is
> instead 'per volume', and the default for each volume i
If you check out your source code in Cygwin, somewhere under /home/... (as
opposed to /cygpath/...), IncludeCustomExtension does not work.
The problem is that TOPDIR gets a different lexical value from the spec.gmk
file when setup in Makefile, even if this was the same directory. Since
THIS_INC
> If you check out your source code in Cygwin, somewhere under /home/... (as
> opposed to /cygpath/...), IncludeCustomExtension does not work.
>
> The problem is that TOPDIR gets a different lexical value from the spec.gmk
> file when setup in Makefile, even if this was the same directory. Since
On Wed, 7 May 2025 21:12:54 GMT, Erik Joelsson wrote:
>> We should always exclude `doc-files` and `snippet-files` when compiling java
>> code. To generalize this, exclude all `*-files` directories.
>>
>> (The usage of EXCLUDES and EXCLUDE_FILES is a bit weird. In essence,
>> EXCLUDE_FILES prep
> We should always exclude `doc-files` and `snippet-files` when compiling java
> code. To generalize this, exclude all `*-files` directories.
>
> (The usage of EXCLUDES and EXCLUDE_FILES is a bit weird. In essence,
> EXCLUDE_FILES prepends a `%` wildchar match to the filenames given, which we
>
On Wed, 16 Apr 2025 10:35:02 GMT, Matthias Baesken wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Also document UTF-8 requirements (solves JDK-8338973)
>> - Let configure only accept utf-8 locales
>> -
After [JEP 503](https://openjdk.org/jeps/503), we cannot build linux-x86 so it
should not be included in the jib profiles.
I also took the opportunity to remove the superfluous `--with-target-bits=64`
option, clean up some `configure_args` constructs, and to reorder the profiles
to group all l
On Tue, 6 May 2025 15:39:04 GMT, Magnus Ihse Bursie wrote:
>> Most of the JDK code base has been transitioned to UTF-8, but not all. This
>> has recently become an acute problem, since our mixing of iso-8859-1 and
>> utf-8 in properties files confused the version of `sed` that is shipped with
On Tue, 6 May 2025 15:39:04 GMT, Magnus Ihse Bursie wrote:
>> Most of the JDK code base has been transitioned to UTF-8, but not all. This
>> has recently become an acute problem, since our mixing of iso-8859-1 and
>> utf-8 in properties files confused the version of `sed` that is shipped with
> Allow the user to set "--with-jcov-modules=java.desktop", instead of
> "--with-jcov-filters=--include-modules java.desktop", since this is one of
> the common use cases for the filtering.
Magnus Ihse Bursie has updated the pull request with a new target base due to a
merge or a rebase. The pu
37 matches
Mail list logo
