On 28/02/2018 19:54, Lance Andersen wrote:
:
Is there any XA text from the original JTA spec that should be added
to the module description as part of this? Another way to ask this is
whether the JTA 1.3 drops any text dealing with the XA part.
Still waiting to see what changes are made to th
On 2018-03-02 00:46, Erik Joelsson wrote:
Hello Magnus,
Nice to finally see this posted! Overall very nice improvement.
Thank you.
I would advocate a simple bash replace to remove the dots, like this:
MACOSX_VERSION_MIN_NODOTS=${MACOSX_VERSION_MIN//\./}
Ok, I updated this. I see no need to
On 2018-03-02 00:02, Erik Joelsson wrote:
Hello,
In xlibtypes.txt comment, should it be sizes-64.txt?
Yes, good catch.
Generating both 32 and 64 seems a bit outdated at this point. Surely
this is a remnant of bundling 64 and 32 bit together on Solaris in the
past? Perhaps someone in 2d ca
On 2018-03-02 03:01, David Holmes wrote:
Hi Magnus,
On 1/03/2018 10:48 AM, Magnus Ihse Bursie wrote:
We're doing a lot of weird compilation stuff for dtrace. With this
patch, most of the weirdness is removed. The remaining calls to $(CC)
-E has been changed to $(CPP) to clarify that we do not
On 2018-03-01 23:17, Erik Joelsson wrote:
Hello Magnus,
This is a nice fix!
I would prefer if the shell expression wasn't executed on every
re-make. In this case it can easily be fixed by changing := to =.
There is only one use of DTRACE_ELFEDIT_COMMANDS so it will only be
evaluated once, an
On 2018-03-02 12:10, Magnus Ihse Bursie wrote:
On 2018-03-02 03:01, David Holmes wrote:
Hi Magnus,
On 1/03/2018 10:48 AM, Magnus Ihse Bursie wrote:
We're doing a lot of weird compilation stuff for dtrace. With this
patch, most of the weirdness is removed. The remaining calls to
$(CC) -E has b
In make/doc/testing.md, the descriptions of the TEST option for jtreg
tests has not been updated to account for the repository layout change.
For example, "hotspot/test:hotspot_gc" should be
"test/hotspot/jtreg:hotspot_gc".
Bug: https://bugs.openjdk.java.net/browse/JDK-8198323
WebRev:
http:/
On 2018-03-02 01:54, Magnus Ihse Bursie wrote:
I actually don't know of any cases where CFLAGS ordering is relevant.
(LIBS is another issue) It's good to be aware of such issues, so
please enlighten me. :-)
If you have a flag that enables a feature and the corresponding
disabling flag of the
Adding 2d-dev in the hopes of getting some input from component team.
Seems like they should be aware of us removing the support for multiple
data models.
Looks like you left a debug message at line 40 in GensrcX11Wrappers.gmk.
/Erik
On 2018-03-02 03:00, Magnus Ihse Bursie wrote:
On 2018-03-
On 03/02/2018 01:48 PM, Magnus Ihse Bursie wrote:
In make/doc/testing.md, the descriptions of the TEST option for jtreg
tests has not been updated to account for the repository layout change.
For example, "hotspot/test:hotspot_gc" should be
"test/hotspot/jtreg:hotspot_gc".
Bug: https://bugs.o
This looks good to me.
/Erik
On 2018-03-02 04:45, Magnus Ihse Bursie wrote:
On 2018-03-02 12:10, Magnus Ihse Bursie wrote:
On 2018-03-02 03:01, David Holmes wrote:
Hi Magnus,
On 1/03/2018 10:48 AM, Magnus Ihse Bursie wrote:
We're doing a lot of weird compilation stuff for dtrace. With this
Looks good to me as well.
Tim
On 03/02/18 07:29, Erik Joelsson wrote:
This looks good to me.
/Erik
On 2018-03-02 04:45, Magnus Ihse Bursie wrote:
On 2018-03-02 12:10, Magnus Ihse Bursie wrote:
On 2018-03-02 03:01, David Holmes wrote:
Hi Magnus,
On 1/03/2018 10:48 AM, Magnus Ihse Bursie w
Hello,
Nice fixes, some grammar notes:
building.md: 872: provide -> provides
testing.md: 57: JTReg test -> JTReg tests
68: tests roots -> test roots
77: "Here too can just `hotspot` be used as an alias for
`hotspot/jtreg`" reads weird (and is missing punctuation), how about:
"`hotspot` can
On Mar 1, 2018, at 11:52 PM, Alan Bateman wrote:
> I assume the copyright range should be 2003, 2018 (to match Launcher.java) as
> this is not a new file in 2018.
Will update before pushing.
> So I think you good to go and it's great to have the .so files removed from
> the repos.
+1
Thanks
Hello,
Here is a new version of this patch, reworked in several ways. It now
supports gcc, clang and solstudio. It uses nm instead of objdump, which
is more readily available in all our current build environments. The
check now uses mangled symbol names for all toolchain types which makes
thi
> On Mar 2, 2018, at 4:18 PM, Erik Joelsson wrote:
>
> Hello,
>
> Here is a new version of this patch, reworked in several ways. It now
> supports gcc, clang and solstudio. It uses nm instead of objdump, which is
> more readily available in all our current build environments. The check now
>
On Thu, Mar 1, 2018 at 11:50 AM, Erik Joelsson
wrote:
>
> On 2018-02-26 12:57, joe darcy wrote:
>
>> Hi Magnus,
>>
>> Looks okay for now, but longer term should the version be queried from
>> the environment some way?
>>
>> The problem as I understand it is that the URL is dead until the docs
> t
17 matches
Mail list logo