On 05/15/2018 08:58 PM, Igor Ignatyev wrote:
Hi Erik,
please see my answers inline.
can I consider this RFR as reviewed by you?
Yep!
Thanks,
-- Igor
On May 14, 2018, at 4:23 AM, Erik Helin wrote:
On 05/08/2018 12:35 AM, Igor Ignatyev wrote:
Hi all,
Hi Igor,
On 05/08/2018 12:35 AM, I
Thank you for review.
Leonid
> On May 16, 2018, at 8:48 PM, serguei.spit...@oracle.com wrote:
>
> Hi Leonid,
>
> Looks good to me too.
>
> Thanks,
> Serguei
>
>
> On 5/14/18 14:04, Leonid Mesnik wrote:
>> Misha
>>
>> Thank you for review. I still need one more review from 'R'eviewer.
>>
>>
Hi,
I'd like to get a review for this 8u/hotspot build change for
Windows, to loosen the restriction on what compilers we can use.
JBS:
8203349: 8u hotspot should recognise later Windows compilers
https://bugs.openjdk.java.net/browse/JDK-8203349
Webrev: http://cr.openjdk.java.net/~kevinw/820334
Hello Kevin,
In JDK 11, vm_version.cpp we have _MSC_VER == 1900 translating to VS2015
and 1912 to VS2017. Is it really 1900 in nmake?
Otherwise I think this looks ok.
/Erik
On 2018-05-17 15:21, Kevin Walls wrote:
Hi,
I'd like to get a review for this 8u/hotspot build change for
Windows, t
http://cr.openjdk.java.net/~prr/8191522.1 uploaded.
Adding .. the removal of .. a couple of uses of lucida
- sanity check of lucida in font config files is no longer needed.
- J2DBench demo opts change from lucida to dialog. Not sure why it had
lucida anyway ..
-phil.
On 5/16/18, 4:08 PM, Erik
Looks fine.
On 17/05/2018 16:58, Philip Race wrote:
http://cr.openjdk.java.net/~prr/8191522.1 uploaded.
Adding .. the removal of .. a couple of uses of lucida
- sanity check of lucida in font config files is no longer needed.
- J2DBench demo opts change from lucida to dialog. Not sure why it had
