Re: compiling openJdk 11 on windows 7 32bits fail

2019-02-12 Thread Magnus Ihse Bursie
On 2019-02-12 14:38, Alexey Ivanov wrote: On 12/02/2019 04:25, David Holmes wrote: On 12/02/2019 1:45 pm, Franco Gastón Pellegrini wrote: I just downloaded again (to be sure about my errors) JDK 12 and use this command: bash ./configure --enable-debug --disable-warnings-as-errors

Re: RFR: JDK-8218807: Compilation database (compile_commands.json) may contain obsolete items

2019-02-12 Thread Erik Joelsson
Looks good. /Erik On 2019-02-12 00:01, Robin Westberg wrote: Hi all, When generating a compilation database by either "make compile-commands" or "make compile-commands-hotspot", every object file that should be built results in a temporary json fragment describing the compiler invocation.

Re: RFR: JDK-8218807: Compilation database (compile_commands.json) may contain obsolete items

2019-02-12 Thread Magnus Ihse Bursie
On 2019-02-12 09:01, Robin Westberg wrote: Hi all, When generating a compilation database by either "make compile-commands" or "make compile-commands-hotspot", every object file that should be built results in a temporary json fragment describing the compiler invocation. However, when the

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-12 Thread Erik Joelsson
On 2019-02-12 01:35, Severin Gehwolf wrote: Hi Erik, On Mon, 2019-02-11 at 11:12 -0800, Erik Joelsson wrote: Hello Severin, I think you also need a $(wildcard ) around it, but I may be wrong. Did you try this version? Yes, this version works for me without $(wildcard). Why is it needed?

Re: compiling openJdk 11 on windows 7 32bits fail

2019-02-12 Thread Alexey Ivanov
On 12/02/2019 04:25, David Holmes wrote: On 12/02/2019 1:45 pm, Franco Gastón Pellegrini wrote: I just downloaded again (to be sure about my errors) JDK 12 and use this command: bash ./configure --enable-debug --disable-warnings-as-errors --with-target-bits=32 --with-toolchain-version=2017

Re: compiling openJdk 11 on windows 7 32bits fail

2019-02-12 Thread Alexey Ivanov
On 12/02/2019 14:37, Magnus Ihse Bursie wrote: There has been some fallout due to the mapfile/linking changes made in JDK 12 that affected JNICALL. However, that should not be affecting JDK 11. Wasn't it done in JDK 11? If my memory serves me right, it was done in JDK 11. -- Alexey

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-12 Thread Severin Gehwolf
Hi Erik, On Tue, 2019-02-12 at 08:44 -0800, Erik Joelsson wrote: > On 2019-02-12 01:35, Severin Gehwolf wrote: > > Hi Erik, > > > > On Mon, 2019-02-11 at 11:12 -0800, Erik Joelsson wrote: > > > Hello Severin, > > > > > > I think you also need a $(wildcard ) around it, but I may be wrong. Did >

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-12 Thread Erik Joelsson
Hello, On 2019-02-12 09:05, Severin Gehwolf wrote: Hi Erik, On Tue, 2019-02-12 at 08:44 -0800, Erik Joelsson wrote: On 2019-02-12 01:35, Severin Gehwolf wrote: Hi Erik, On Mon, 2019-02-11 at 11:12 -0800, Erik Joelsson wrote: Hello Severin, I think you also need a $(wildcard ) around it,

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-12 Thread Severin Gehwolf
Hi Mandy, Alan, Please find the proposal for CLI option of --strip-native-debug-symbols below. On Fri, 2019-02-08 at 10:53 -0800, Mandy Chung wrote: > > On 2/8/19 2:08 AM, Alan Bateman wrote: > > I agree with Mandy that the CLI options need examination. The proposed > >

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-12 Thread Severin Gehwolf
Hi Mandy, Thanks for the review! On Thu, 2019-02-07 at 12:43 -0800, Mandy Chung wrote: > Hi Severin, > > Using the plugin specific ResourceBundle is good. Thanks for making > the change. > > I see that Alan's comment [1] on the plugin options and I assume > you will investigate the plugin

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-12 Thread Mandy Chung
On 2/12/19 12:05 PM, Severin Gehwolf wrote: Hi Mandy, Thanks for the review! OK. Here is the summary: http://mail.openjdk.java.net/pipermail/jigsaw-dev/2019-February/014132.html Personally, I find --strip-native-debug-info or --strip-native-debug- symbols clearer than just

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-12 Thread Mandy Chung
On 2/12/19 11:52 AM, Severin Gehwolf wrote: Hi Mandy, Alan, Please find the proposal for CLI option of --strip-native-debug-symbols below. The current implementation here has the following options: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8214796/05/webrev/ [i]

RFR: JDK-8218807: Compilation database (compile_commands.json) may contain obsolete items

2019-02-12 Thread Robin Westberg
Hi all, When generating a compilation database by either "make compile-commands" or "make compile-commands-hotspot", every object file that should be built results in a temporary json fragment describing the compiler invocation. However, when the final compile_commands.json file is assembled,

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-12 Thread Severin Gehwolf
Hi Erik, On Mon, 2019-02-11 at 11:12 -0800, Erik Joelsson wrote: > Hello Severin, > > I think you also need a $(wildcard ) around it, but I may be wrong. Did > you try this version? Yes, this version works for me without $(wildcard). Why is it needed? > Also, please do not indent so much. We