In that case, the review looks good.
Thanks-
Tim
On 04/13/18 13:15, Kevin Walls wrote:
Hi Erik - thanks for clarifying.
On 13/04/2018 20:58, Erik Joelsson wrote:
ccache shouldn't be commented out. That must have been a local edit
mistake in the original webrev.
/Erik
On 2018-04-13 12:51,
Hi Erik - thanks for clarifying.
On 13/04/2018 20:58, Erik Joelsson wrote:
ccache shouldn't be commented out. That must have been a local edit
mistake in the original webrev.
/Erik
On 2018-04-13 12:51, Kevin Walls wrote:
Thanks Tim -
There's a later webrev in the review thread:
http://cr
ccache shouldn't be commented out. That must have been a local edit
mistake in the original webrev.
/Erik
On 2018-04-13 12:51, Kevin Walls wrote:
Thanks Tim -
There's a later webrev in the review thread:
http://cr.openjdk.java.net/~erikj/8038340/webrev.root.03/ in which I
see the common/au
Thanks Tim -
There's a later webrev in the review thread:
http://cr.openjdk.java.net/~erikj/8038340/webrev.root.03/ in which I see
the common/autoconf/configure.ac change... It's in the commit in 9
also. I think we need it. 8-)
But that webrev.03 also has the commenting out of "Building cca
Kevin - looks good in general with a few remarks (see below):
I'd like to request review of this backport from 9 to 8u:
8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris
JBS: https://bugs.openjdk.java.net/browse/JDK-8038340
9 changesets:
base repo: http://hg.openjdk.jav
Looks good.
/Erik
On 2018-04-13 09:22, Kevin Walls wrote:
Hi,
I'd like to request review of this backport from 9 to 8u:
8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris
JBS: https://bugs.openjdk.java.net/browse/JDK-8038340
9 changesets:
base repo: http://hg.openjdk.
