Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

Thanks Kim, Tim, David and Magnus for reviews! /Erik On 2018-03-05 12:06, Erik Joelsson wrote: New webrev: http://cr.openjdk.java.net/~erikj/8198243/webrev.04 /Erik On 2018-03-05 12:03, Erik Joelsson wrote: On 2018-03-05 11:46, Kim Barrett wrote: Old code in toolkit.m4 did the OBJDUMP

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

On 2018-03-05 21:06, Erik Joelsson wrote: New webrev: http://cr.openjdk.java.net/~erikj/8198243/webrev.04 Looks good to me. /Magnus /Erik On 2018-03-05 12:03, Erik Joelsson wrote: On 2018-03-05 11:46, Kim Barrett wrote: Old code in toolkit.m4 did the OBJDUMP stuff unconditionally. New

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

On 6/03/2018 6:06 AM, Erik Joelsson wrote: New webrev: http://cr.openjdk.java.net/~erikj/8198243/webrev.04 Looks good. Thanks, David /Erik On 2018-03-05 12:03, Erik Joelsson wrote: On 2018-03-05 11:46, Kim Barrett wrote: Old code in toolkit.m4 did the OBJDUMP stuff unconditionally. New

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

> On Mar 5, 2018, at 3:06 PM, Erik Joelsson wrote: > > New webrev: http://cr.openjdk.java.net/~erikj/8198243/webrev.04 Looks good. > > /Erik > > > On 2018-03-05 12:03, Erik Joelsson wrote: >> >> On 2018-03-05 11:46, Kim Barrett wrote: >>> Old code in toolkit.m4

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

Erik: Looks good. /Tim New webrev: http://cr.openjdk.java.net/~erikj/8198243/webrev.04 /Erik On 2018-03-05 12:03, Erik Joelsson wrote: On 2018-03-05 11:46, Kim Barrett wrote: Old code in toolkit.m4 did the OBJDUMP stuff unconditionally. New code makes it conditional on TOOLCHAIN_TYPE.

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

New webrev: http://cr.openjdk.java.net/~erikj/8198243/webrev.04 /Erik On 2018-03-05 12:03, Erik Joelsson wrote: On 2018-03-05 11:46, Kim Barrett wrote: Old code in toolkit.m4 did the OBJDUMP stuff unconditionally. New code makes it conditional on TOOLCHAIN_TYPE. That doesn’t seem right. 

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

On 2018-03-05 11:46, Kim Barrett wrote: Old code in toolkit.m4 did the OBJDUMP stuff unconditionally. New code makes it conditional on TOOLCHAIN_TYPE. That doesn’t seem right. compare.sh seems to want OBJDUMP for aix too, and that’s not in the toolchain list here. That is a good point. I

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

> On Mar 5, 2018, at 11:41 AM, Erik Joelsson wrote: > > Hello, > > On 2018-03-04 15:22, David Holmes wrote: >> Hi Erik, >> >> On 3/03/2018 7:18 AM, Erik Joelsson wrote: >>> Hello, >>> >>> Here is a new version of this patch, reworked in several ways. It now >>>

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

Erik: make/devkit/Tools.gmk Lines 565, 566 - I see you removed dtrace from this list as that is dealt with up in lines 556 ... 558. Makes sense to me. Looks good. Tim On 2018-03-04 15:22, David Holmes wrote: Hi Erik, On 3/03/2018 7:18 AM, Erik Joelsson wrote: Hello, Here is a new

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

Hello, On 2018-03-04 15:22, David Holmes wrote: Hi Erik, On 3/03/2018 7:18 AM, Erik Joelsson wrote: Hello, Here is a new version of this patch, reworked in several ways. It now supports gcc, clang and solstudio. It uses nm instead of objdump, which is more readily available in all our

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

Hi Erik, On 3/03/2018 7:18 AM, Erik Joelsson wrote: Hello, Here is a new version of this patch, reworked in several ways. It now supports gcc, clang and solstudio. It uses nm instead of objdump, which is more readily available in all our current build environments. The check now uses

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

> On Mar 2, 2018, at 4:18 PM, Erik Joelsson wrote: > > Hello, > > Here is a new version of this patch, reworked in several ways. It now > supports gcc, clang and solstudio. It uses nm instead of objdump, which is > more readily available in all our current build

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

Hello, Here is a new version of this patch, reworked in several ways. It now supports gcc, clang and solstudio. It uses nm instead of objdump, which is more readily available in all our current build environments. The check now uses mangled symbol names for all toolchain types which makes

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

On 2018-02-22 20:41, Erik Joelsson wrote: On 2018-02-21 21:06, David Holmes wrote: On 22/02/2018 4:07 AM, Erik Joelsson wrote: Hello, On 2018-02-20 21:33, David Holmes wrote: a) how much time it adds to the build? I have not done extensive testing, but on my Linux workstation with 32

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

On Feb 22, 2018, at 11:41 AM, Erik Joelsson wrote: > > We could grep for the mangled strings for the operators instead, which is > super fast. Problem is just figuring out all the possible combinations. Idea: Do a config-style move where you compile a test file of

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

On 2018-02-21 21:06, David Holmes wrote: On 22/02/2018 4:07 AM, Erik Joelsson wrote: Hello, On 2018-02-20 21:33, David Holmes wrote: a) how much time it adds to the build? I have not done extensive testing, but on my Linux workstation with 32 hw threads, building just hotspot release

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

On 22/02/2018 4:07 AM, Erik Joelsson wrote: Hello, On 2018-02-20 21:33, David Holmes wrote: a) how much time it adds to the build? I have not done extensive testing, but on my Linux workstation with 32 hw threads, building just hotspot release build from a clean workspace increased maybe

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

Hello, On 2018-02-20 21:33, David Holmes wrote: a) how much time it adds to the build? I have not done extensive testing, but on my Linux workstation with 32 hw threads, building just hotspot release build from a clean workspace increased maybe 1 or 2 seconds (at around 90s total), but the

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

> 20 feb. 2018 kl. 22:35 skrev Erik Joelsson : > > >> On 2018-02-20 12:51, Magnus Ihse Bursie wrote: >> >>> On 2018-02-20 19:05, Erik Joelsson wrote: >>> Hello, >>> >>> This patch adds a build time check for uses of global operators new and >>> delete in hotspot C++

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

Hi Erik, This seems okay. Just wondering: a) how much time it adds to the build? b) why this doesn't work for Solaris Studio? Thanks, David On 21/02/2018 4:05 AM, Erik Joelsson wrote: Hello, This patch adds a build time check for uses of global operators new and delete in hotspot C++

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

On 2018-02-20 12:51, Magnus Ihse Bursie wrote: On 2018-02-20 19:05, Erik Joelsson wrote: Hello, This patch adds a build time check for uses of global operators new and delete in hotspot C++ code. The check is only run with toolchains GCC and Clang (Linux and Macos builds). I have also

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

On 2018-02-20 19:05, Erik Joelsson wrote: Hello, This patch adds a build time check for uses of global operators new and delete in hotspot C++ code. The check is only run with toolchains GCC and Clang (Linux and Macos builds). I have also modified the Oracle devkit on Linux to add the

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

Erik: This patch adds a build time check for uses of global operators new and delete in hotspot C++ code. The check is only run with toolchains GCC and Clang (Linux and Macos builds). I have also modified the Oracle devkit on Linux to add the necessary symlink so that objdump will get picked up