Re: RFR: JDK-8248548 Use DISABLED_WARNINGS for globally disabled warnings on Visual Studio in Hotspot

2020-06-30 Thread Kim Barrett
> On Jun 30, 2020, at 6:08 AM, Magnus Ihse Bursie > wrote: > > Currently hotspot/share/utilities/globalDefinitions_visCPP.hpp contains a lot > of #pragma warning( disable : ...). > > All these globally disabled warnings should move to the make files instead. > > I also cleaned out some

Re: RFR: JDK-8248548 Use DISABLED_WARNINGS for globally disabled warnings on Visual Studio in Hotspot

2020-06-30 Thread Erik Joelsson
Looks good. /Erik On 2020-06-30 03:08, Magnus Ihse Bursie wrote: Currently hotspot/share/utilities/globalDefinitions_visCPP.hpp contains a lot of #pragma warning( disable : ...). All these globally disabled warnings should move to the make files instead. I also cleaned out some versions

Re: RFR: JDK-8248548 Use DISABLED_WARNINGS for globally disabled warnings on Visual Studio in Hotspot

2020-06-30 Thread Kim Barrett
> On Jun 30, 2020, at 6:48 AM, Magnus Ihse Bursie > wrote: > > On 2020-06-30 12:32, Kim Barrett wrote: >>> On Jun 30, 2020, at 6:08 AM, Magnus Ihse Bursie >>> wrote: >>> >>> Currently hotspot/share/utilities/globalDefinitions_visCPP.hpp contains a >>> lot of #pragma warning( disable : ...).

Re: RFR: JDK-8248548 Use DISABLED_WARNINGS for globally disabled warnings on Visual Studio in Hotspot

2020-06-30 Thread Magnus Ihse Bursie
On 2020-06-30 12:32, Kim Barrett wrote: On Jun 30, 2020, at 6:08 AM, Magnus Ihse Bursie wrote: Currently hotspot/share/utilities/globalDefinitions_visCPP.hpp contains a lot of #pragma warning( disable : ...). All these globally disabled warnings should move to the make files instead. I