subject:"Re\: RfR JDK\-8167213 Move include\/bridge\/AccessBridgeCalls.c to the source directory"



On 10/27/16 6:31 PM, Pete Brunet wrote:
> On 10/27/16 1:30 PM, Mandy Chung wrote:
>>> On Oct 27, 2016, at 10:44 AM, Phil Race  wrote:
>>>
>>> No, we are definitely shipping those.
>>> Unless of course you think we should stop shipping JNI headers too …
>>>
>> No.  I tried to understand what is external interface.  I took it that these 
>> header files are external interfaces.
>>
>> I reviewed:
>>   http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.05/index.html
>>
>> Please move AccessBridgeCalls.c to  
>> src/jdk.accessibility/windows/native/bridge directory.
> I moved the source to
> src/jdk.accessibility/windows/native/bridge/src
> and the includes to
> src/jdk.accessibility/windows/native/bridge/include
>
> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.06/
I forgot to update the link in readme.html, i.e. include/bridge is now
bridge/include.  See
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.07/
>> Right now, the header files to be packaged in the JMOD file and linked into 
>> the image is white-listed in the makefile.
>>
>> Ultimately, we want the entire directory to contain only header files for 
>> external interfaces and then the build can simply take all files under 
>> src/${MODULE}/share,${OS}/native/include and get rid of the hardcoded list 
>> in the makefile.  We are not there yet - one open issue is related to the 
>> duplicated header files in VM and JDK and some are private and some are 
>> external.  But we should prepare for that.
>>
>> Mandy
>>
>>

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory


On 10/27/16 1:30 PM, Mandy Chung wrote:
>> On Oct 27, 2016, at 10:44 AM, Phil Race  wrote:
>>
>> No, we are definitely shipping those.
>> Unless of course you think we should stop shipping JNI headers too …
>>
> No.  I tried to understand what is external interface.  I took it that these 
> header files are external interfaces.
>
> I reviewed:
>   http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.05/index.html
>
> Please move AccessBridgeCalls.c to  
> src/jdk.accessibility/windows/native/bridge directory.
I moved the source to
src/jdk.accessibility/windows/native/bridge/src
and the includes to
src/jdk.accessibility/windows/native/bridge/include

http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.06/
>
> Right now, the header files to be packaged in the JMOD file and linked into 
> the image is white-listed in the makefile.
>
> Ultimately, we want the entire directory to contain only header files for 
> external interfaces and then the build can simply take all files under 
> src/${MODULE}/share,${OS}/native/include and get rid of the hardcoded list in 
> the makefile.  We are not there yet - one open issue is related to the 
> duplicated header files in VM and JDK and some are private and some are 
> external.  But we should prepare for that.
>
> Mandy
>
>

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory


On 10/27/2016 11:52 AM, Pete Brunet wrote:


On 10/27/16 1:47 PM, Pete Brunet wrote:

On 10/27/16 1:34 PM, Phil Race wrote:

In which case be careful it is not built by the JDK build ..

Build team, Is there anything I need to handle here to make sure it isn't?

Actually, let me give it a try.  I should be able to resolve any
issues.  If not I'll ask again.


The makefiles have lists of files to be excluded from the build.
Look at make/lib/Awt2dLibraries.gmk for lines like
LIBFOO_EXCLUDE_FILES += ...

In theory this should work the same way for AccessBridge.

-phil.

unless that is actually required .. which I didn't think it was.

-phil.

On 10/27/2016 11:30 AM, Mandy Chung wrote:

Please move AccessBridgeCalls.c to
src/jdk.accessibility/windows/native/bridge directory.

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory



On 10/27/16 1:47 PM, Pete Brunet wrote:
>
> On 10/27/16 1:34 PM, Phil Race wrote:
>> In which case be careful it is not built by the JDK build ..
> Build team, Is there anything I need to handle here to make sure it isn't?
Actually, let me give it a try.  I should be able to resolve any
issues.  If not I'll ask again.
>> unless that is actually required .. which I didn't think it was.
>>
>> -phil.
>>
>> On 10/27/2016 11:30 AM, Mandy Chung wrote:
>>> Please move AccessBridgeCalls.c to 
>>> src/jdk.accessibility/windows/native/bridge directory.

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory



On 10/27/16 1:34 PM, Phil Race wrote:
> In which case be careful it is not built by the JDK build ..
Build team, Is there anything I need to handle here to make sure it isn't?
> unless that is actually required .. which I didn't think it was.
>
> -phil.
>
> On 10/27/2016 11:30 AM, Mandy Chung wrote:
>> Please move AccessBridgeCalls.c to 
>> src/jdk.accessibility/windows/native/bridge directory.
>

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory



On 10/27/16 1:34 PM, Phil Race wrote:
> In which case be careful it is not built by the JDK build ..
> unless that is actually required .. which I didn't think it was.
It isn't.
>
> -phil.
>
> On 10/27/2016 11:30 AM, Mandy Chung wrote:
>> Please move AccessBridgeCalls.c to 
>> src/jdk.accessibility/windows/native/bridge directory.
>

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory


In which case be careful it is not built by the JDK build ..
unless that is actually required .. which I didn't think it was.

-phil.

On 10/27/2016 11:30 AM, Mandy Chung wrote:

Please move AccessBridgeCalls.c to  src/jdk.accessibility/windows/native/bridge 
directory.

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-27 Thread Mandy Chung

> On Oct 27, 2016, at 10:44 AM, Phil Race  wrote:
> 
> No, we are definitely shipping those.
> Unless of course you think we should stop shipping JNI headers too …
> 

No.  I tried to understand what is external interface.  I took it that these 
header files are external interfaces.

I reviewed:
  http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.05/index.html

Please move AccessBridgeCalls.c to  src/jdk.accessibility/windows/native/bridge 
directory.

Right now, the header files to be packaged in the JMOD file and linked into the 
image is white-listed in the makefile.

Ultimately, we want the entire directory to contain only header files for 
external interfaces and then the build can simply take all files under 
src/${MODULE}/share,${OS}/native/include and get rid of the hardcoded list in 
the makefile.  We are not there yet - one open issue is related to the 
duplicated header files in VM and JDK and some are private and some are 
external.  But we should prepare for that.

Mandy

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory


No, we are definitely shipping those.
Unless of course you think we should stop shipping JNI headers too ...

-phil

On 10/27/2016 10:37 AM, Mandy Chung wrote:

Should they be kept just in the source and not to be included in the 
image/include directory?

It’s not clear to me if anyone needs these header files from the JDK image as 
AccessBridgeCalls.c is obtained from the source.

Mandy


On Oct 27, 2016, at 6:48 AM, Pete Brunet  wrote:

The .h files are unlicensed in the bundle/install so no need?

On 10/26/16 11:52 PM, Mandy Chung wrote:

Should the same change be applied to the .h files as well?

Mandy


On Oct 26, 2016, at 7:24 PM, Pete Brunet  wrote:

Please review the latest update at
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.03/

The change is to AccessBridgeCalls.c.  The license has been changed from
GPL2 to BSD.  This is because the file was originally unlicensed prior
to being bundled into the JDK and the compiled .obj is linked to by
vendors creating proprietary code.  Vendors will be instructed to
download AccessBridgeCalls.c from the OpenJDK repository.  Also the
include/use of AccessBridgeDebug.h/cpp has been removed.

Please also review readme.html which has been added to
.../jdk/include/win32/bridge.

Pete

On 10/25/16 6:48 AM, Alexandr Scherbatiy wrote:

The fix looks good to me.

Thanks,
Alexandr.

On 10/24/2016 1:18 PM, Erik Joelsson wrote:

The last change looks good and simple to me.

/Erik


On 2016-10-21 06:55, Pete Brunet wrote:

Please see the latest update
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.02/

The fix now is to simply remove the copy of the AccessBridgeCalls.c
file
into the JDK.

AccessBridgeCalls.c is the implementation of the documented Java Access
Bridge API and is a set of wrapper functions that hides the
complications related to interfacing to JAB's WindowsAccessBridge*.dll.
In the past users of the API would compile and link to
AccessBridgeCalls.c/obj.

Since the interface implementation of AccessBridgeCalls.c will no
longer
be provided the JAB API documentation will be updated to instruct a
user
how to create an equivalent of AccessBridgeCalls.c.  The documentation
will also contain a reference to the JAB 2.0.2 download
http://www.oracle.com/technetwork/java/javase/downloads/jab-2-0-2-download-354311.html

which does contain AccessBridgeCalls.c and which is compatible with the
current API and related calls into WindowsAccessBridge*.dll.

Pete

On 10/18/16 12:28 PM, Pete Brunet wrote:

I've updated the webrev.  Please see
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.01/

Rather than removing the files needed by Assistive Technology
developers
we have to provide them in JDK.  However since there is a .c file
in the
group of files the files were moved from the include directory to a
new
javaaccessbridge directory.

On 10/17/16 2:43 AM, Magnus Ihse Bursie wrote:

On 2016-10-14 17:51, Pete Brunet wrote:

Please review the following.

The .h files and .c file provided to allow Assistive Technology to
interface to the Java Access Bridge API are being removed from
the built
JRE/JDK images.  They are not used much and they can be obtained
online
via the OpenJDK web site.  The pubs will be updated to mention the
location of the files.

Since there is a .c file in this group of files the directory
structure
has been changed slightly to remove the include directory.

There was one file missing from the group of files needed by
developers
and that was moved from the common to the bridge directory.

The make was updated in response to the above.

Bug: https://bugs.openjdk.java.net/browse/JDK-8167213

Webrev: http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.00/

Build changes looks good to me.

/Magnus

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-27 Thread Mandy Chung

Should they be kept just in the source and not to be included in the 
image/include directory?

It’s not clear to me if anyone needs these header files from the JDK image as 
AccessBridgeCalls.c is obtained from the source.

Mandy

> On Oct 27, 2016, at 6:48 AM, Pete Brunet  wrote:
> 
> The .h files are unlicensed in the bundle/install so no need?
> 
> On 10/26/16 11:52 PM, Mandy Chung wrote:
>> Should the same change be applied to the .h files as well?
>> 
>> Mandy
>> 
>>> On Oct 26, 2016, at 7:24 PM, Pete Brunet  wrote:
>>> 
>>> Please review the latest update at
>>> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.03/
>>> 
>>> The change is to AccessBridgeCalls.c.  The license has been changed from
>>> GPL2 to BSD.  This is because the file was originally unlicensed prior
>>> to being bundled into the JDK and the compiled .obj is linked to by
>>> vendors creating proprietary code.  Vendors will be instructed to
>>> download AccessBridgeCalls.c from the OpenJDK repository.  Also the
>>> include/use of AccessBridgeDebug.h/cpp has been removed.
>>> 
>>> Please also review readme.html which has been added to
>>> .../jdk/include/win32/bridge.
>>> 
>>> Pete
>>> 
>>> On 10/25/16 6:48 AM, Alexandr Scherbatiy wrote:
 The fix looks good to me.
 
 Thanks,
 Alexandr.
 
 On 10/24/2016 1:18 PM, Erik Joelsson wrote:
> The last change looks good and simple to me.
> 
> /Erik
> 
> 
> On 2016-10-21 06:55, Pete Brunet wrote:
>> Please see the latest update
>> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.02/
>> 
>> The fix now is to simply remove the copy of the AccessBridgeCalls.c
>> file
>> into the JDK.
>> 
>> AccessBridgeCalls.c is the implementation of the documented Java Access
>> Bridge API and is a set of wrapper functions that hides the
>> complications related to interfacing to JAB's WindowsAccessBridge*.dll.
>> In the past users of the API would compile and link to
>> AccessBridgeCalls.c/obj.
>> 
>> Since the interface implementation of AccessBridgeCalls.c will no
>> longer
>> be provided the JAB API documentation will be updated to instruct a
>> user
>> how to create an equivalent of AccessBridgeCalls.c.  The documentation
>> will also contain a reference to the JAB 2.0.2 download
>> http://www.oracle.com/technetwork/java/javase/downloads/jab-2-0-2-download-354311.html
>> 
>> which does contain AccessBridgeCalls.c and which is compatible with the
>> current API and related calls into WindowsAccessBridge*.dll.
>> 
>> Pete
>> 
>> On 10/18/16 12:28 PM, Pete Brunet wrote:
>>> I've updated the webrev.  Please see
>>> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.01/
>>> 
>>> Rather than removing the files needed by Assistive Technology
>>> developers
>>> we have to provide them in JDK.  However since there is a .c file
>>> in the
>>> group of files the files were moved from the include directory to a
>>> new
>>> javaaccessbridge directory.
>>> 
>>> On 10/17/16 2:43 AM, Magnus Ihse Bursie wrote:
 On 2016-10-14 17:51, Pete Brunet wrote:
> Please review the following.
> 
> The .h files and .c file provided to allow Assistive Technology to
> interface to the Java Access Bridge API are being removed from
> the built
> JRE/JDK images.  They are not used much and they can be obtained
> online
> via the OpenJDK web site.  The pubs will be updated to mention the
> location of the files.
> 
> Since there is a .c file in this group of files the directory
> structure
> has been changed slightly to remove the include directory.
> 
> There was one file missing from the group of files needed by
> developers
> and that was moved from the common to the bridge directory.
> 
> The make was updated in response to the above.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8167213
> 
> Webrev: http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.00/
 Build changes looks good to me.
 
 /Magnus
>

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

This all seems fine.

Do other accessbridge files still have the remnants of SCCS ? :-
That was purged from all the other JDK files when we moved to mercurial.

33 /*
34 * @(#)AccessBridgeCalls.c 1.25 05/08/22
35 */

If "yes", then I suggest to file a clean-up bug to clean up all of these
separately.

if "no", then I suggest to fix this one file here and now ..

-phil.

On 10/27/2016 07:41 AM, Pete Brunet wrote:

Thanks for noticing that Phil. Updated at
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.05/

On 10/27/16 9:20 AM, Philip Race wrote:

But it still needs to say "jdk9/jdk9" not jdk9/client or jdk9/dev.

-phil.

On 10/26/16, 9:27 PM, Anirvan Sarkar wrote:

Hi,

If you replace the hex number with 'tip' then it will always point
to the latest version.

Something like
http://hg.openjdk.java.net/jdk9/client/jdk/file/tip/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c

Regards,
Anirvan Sarkar

On Thursday 27 October 2016, Pete Brunet > wrote:

On 10/26/16 10:44 PM, Philip Race wrote:

>
15 http://hg.openjdk.java.net/jdk9/client/jdk/file/544828ab2a9b/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c;

>
That URL is definitely not authoritative.

I think you need to give a pointer to something more like

http://hg.openjdk.java.net/jdk9/jdk9/jdk/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c

Looks like that hex number in there is the Mercurial long
revision number of the tip so that's going to keep changing.
I'm not aware of a "latest" link. Maybe some other reader will

know.

But I am not sure about that either .. it may need to be split between the
main URL and the location in the repo.

-phil
On 10/26/16, 7:24 PM, Pete Brunet wrote:

Please review the latest update at
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.03/

The change is to AccessBridgeCalls.c. The license has been changed from
GPL2 to BSD. This is because the file was originally unlicensed prior
to being bundled into the JDK and the compiled .obj is linked to by
vendors creating proprietary code. Vendors will be instructed to
download AccessBridgeCalls.c from the OpenJDK repository. Also the
include/use of AccessBridgeDebug.h/cpp has been removed.

Please also review readme.html which has been added to
.../jdk/include/win32/bridge.

Pete

On 10/25/16 6:48 AM, Alexandr Scherbatiy wrote:

The fix looks good to me.

Thanks,
Alexandr.

On 10/24/2016 1:18 PM, Erik Joelsson wrote:

The last change looks good and simple to me.

/Erik

On 2016-10-21 06:55, Pete Brunet wrote:

Please see the latest update
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.02/

The fix now is to simply remove the copy of the AccessBridgeCalls.c
file
into the JDK.

AccessBridgeCalls.c is the implementation of the documented Java Access
Bridge API and is a set of wrapper functions that hides the
complications related to interfacing to JAB's WindowsAccessBridge*.dll.
In the past users of the API would compile and link to
AccessBridgeCalls.c/obj.

Since the interface implementation of AccessBridgeCalls.c will no
longer
be provided the JAB API documentation will be updated to instruct a
user
how to create an equivalent of AccessBridgeCalls.c. The documentation
will also contain a reference to the JAB 2.0.2 download

http://www.oracle.com/technetwork/java/javase/downloads/jab-2-0-2-download-354311.html

which does contain AccessBridgeCalls.c and which is compatible with the
current API and related calls into WindowsAccessBridge*.dll.

Pete

On 10/18/16 12:28 PM, Pete Brunet wrote:

I've updated the webrev. Please see
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.01/

Rather than removing the files needed by Assistive Technology
developers
we have to provide them in JDK. However since there is a .c file
in the
group of files the files were moved from the include directory to a
new
javaaccessbridge directory.

On 10/17/16

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

Thanks for noticing that Phil.  Updated at
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.05/


On 10/27/16 9:20 AM, Philip Race wrote:
> But it still needs to say "jdk9/jdk9" not jdk9/client or jdk9/dev.
>
> -phil.
>
> On 10/26/16, 9:27 PM, Anirvan Sarkar wrote:
>> Hi,
>>
>> If you replace the hex number with 'tip' then it will always point to
>> the latest version. 
>>
>> Something
>> like 
>> http://hg.openjdk.java.net/jdk9/client/jdk/file/tip/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c
>> 
>>
>> Regards,
>> Anirvan Sarkar
>>
>> On Thursday 27 October 2016, Pete Brunet > > wrote:
>>
>>
>>
>> On 10/26/16 10:44 PM, Philip Race wrote:
>>> >
>>>   15 >> href="http://hg.openjdk.java.net/jdk9/client/jdk/file/544828ab2a9b/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c;
>>> 
>>> >
>>> That URL is definitely not authoritative.
>>>
>>> I think you need to give a pointer to something more like
>>> 
>>> http://hg.openjdk.java.net/jdk9/jdk9/jdk/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c
>>> 
>>> 
>> Looks like that hex number in there is the Mercurial long
>> revision number of the tip so that's going to keep changing.  I'm
>> not aware of a "latest" link.  Maybe some other reader will know.
>>> But I am not sure about that either .. it may need to be split between 
>>> the main URL and the location in the repo.
>>>
>>> -phil 
>>> On 10/26/16, 7:24 PM, Pete Brunet wrote:
 Please review the latest update at
 http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.03/
 

 The change is to AccessBridgeCalls.c.  The license has been changed 
 from
 GPL2 to BSD.  This is because the file was originally unlicensed prior
 to being bundled into the JDK and the compiled .obj is linked to by
 vendors creating proprietary code.  Vendors will be instructed to
 download AccessBridgeCalls.c from the OpenJDK repository.  Also the
 include/use of AccessBridgeDebug.h/cpp has been removed.

 Please also review readme.html which has been added to
 .../jdk/include/win32/bridge.

 Pete

 On 10/25/16 6:48 AM, Alexandr Scherbatiy wrote:
> The fix looks good to me.
>
> Thanks,
> Alexandr.
>
> On 10/24/2016 1:18 PM, Erik Joelsson wrote:
>> The last change looks good and simple to me.
>>
>> /Erik
>>
>>
>> On 2016-10-21 06:55, Pete Brunet wrote:
>>> Please see the latest update
>>> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.02/
>>> 
>>>
>>> The fix now is to simply remove the copy of the AccessBridgeCalls.c
>>> file
>>> into the JDK.
>>>
>>> AccessBridgeCalls.c is the implementation of the documented Java 
>>> Access
>>> Bridge API and is a set of wrapper functions that hides the
>>> complications related to interfacing to JAB's 
>>> WindowsAccessBridge*.dll.
>>> In the past users of the API would compile and link to
>>> AccessBridgeCalls.c/obj.
>>>
>>> Since the interface implementation of AccessBridgeCalls.c will no
>>> longer
>>> be provided the JAB API documentation will be updated to instruct a
>>> user
>>> how to create an equivalent of AccessBridgeCalls.c.  The 
>>> documentation
>>> will also contain a reference to the JAB 2.0.2 download
>>> 
>>> http://www.oracle.com/technetwork/java/javase/downloads/jab-2-0-2-download-354311.html
>>> 
>>> 
>>>
>>> which does contain AccessBridgeCalls.c and which is compatible with 
>>> the
>>> current API and related calls into WindowsAccessBridge*.dll.
>>>
>>> Pete
>>>
>>> On 10/18/16 12:28 PM, Pete Brunet wrote:
 I've updated the webrev.  Please see
 http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.01/
 

 Rather than removing the files needed by Assistive Technology
 developers
 we have to provide them

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-27 Thread Philip Race

But it still needs to say "jdk9/jdk9" not jdk9/client or jdk9/dev.

-phil.

On 10/26/16, 9:27 PM, Anirvan Sarkar wrote:

Hi,

If you replace the hex number with 'tip' then it will always point to
the latest version.

Something like
http://hg.openjdk.java.net/jdk9/client/jdk/file/tip/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c

Regards,
Anirvan Sarkar

On Thursday 27 October 2016, Pete Brunet > wrote:

On 10/26/16 10:44 PM, Philip Race wrote:

>
15http://hg.openjdk.java.net/jdk9/client/jdk/file/544828ab2a9b/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c;

>
That URL is definitely not authoritative.

I think you need to give a pointer to something more like

http://hg.openjdk.java.net/jdk9/jdk9/jdk/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c

Looks like that hex number in there is the Mercurial long revision
number of the tip so that's going to keep changing. I'm not aware
of a "latest" link. Maybe some other reader will know.

But I am not sure about that either .. it may need to be split between the
main URL and the location in the repo.

-phil

On 10/26/16, 7:24 PM, Pete Brunet wrote:

Please review the latest update at
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.03/

Please also review readme.html which has been added to
.../jdk/include/win32/bridge.

Pete

On 10/25/16 6:48 AM, Alexandr Scherbatiy wrote:

The fix looks good to me.

Thanks,
Alexandr.

On 10/24/2016 1:18 PM, Erik Joelsson wrote:

The last change looks good and simple to me.

/Erik

On 2016-10-21 06:55, Pete Brunet wrote:

Please see the latest update
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.02/

The fix now is to simply remove the copy of the AccessBridgeCalls.c
file
into the JDK.

http://www.oracle.com/technetwork/java/javase/downloads/jab-2-0-2-download-354311.html

which does contain AccessBridgeCalls.c and which is compatible with the
current API and related calls into WindowsAccessBridge*.dll.

Pete

On 10/18/16 12:28 PM, Pete Brunet wrote:

I've updated the webrev. Please see
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.01/

On 10/17/16 2:43 AM, Magnus Ihse Bursie wrote:

On 2016-10-14 17:51, Pete Brunet wrote:

Please review the following.

The .h files and .c file provided to allow Assistive Technology to
interface to the Java Access Bridge API are being removed from
the built
JRE/JDK images. They are not used much and they can be obtained
online
via the OpenJDK web site. The pubs will be updated to mention the
location of the files.

Since there is a .c file in this group of files the directory
structure
has been changed slightly to remove the include directory.

There was

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

The .h files are unlicensed in the bundle/install so no need?

On 10/26/16 11:52 PM, Mandy Chung wrote:
> Should the same change be applied to the .h files as well?
>
> Mandy
>
>> On Oct 26, 2016, at 7:24 PM, Pete Brunet  wrote:
>>
>> Please review the latest update at
>> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.03/
>>
>> The change is to AccessBridgeCalls.c.  The license has been changed from
>> GPL2 to BSD.  This is because the file was originally unlicensed prior
>> to being bundled into the JDK and the compiled .obj is linked to by
>> vendors creating proprietary code.  Vendors will be instructed to
>> download AccessBridgeCalls.c from the OpenJDK repository.  Also the
>> include/use of AccessBridgeDebug.h/cpp has been removed.
>>
>> Please also review readme.html which has been added to
>> .../jdk/include/win32/bridge.
>>
>> Pete
>>
>> On 10/25/16 6:48 AM, Alexandr Scherbatiy wrote:
>>> The fix looks good to me.
>>>
>>> Thanks,
>>> Alexandr.
>>>
>>> On 10/24/2016 1:18 PM, Erik Joelsson wrote:
 The last change looks good and simple to me.

 /Erik


 On 2016-10-21 06:55, Pete Brunet wrote:
> Please see the latest update
> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.02/
>
> The fix now is to simply remove the copy of the AccessBridgeCalls.c
> file
> into the JDK.
>
> AccessBridgeCalls.c is the implementation of the documented Java Access
> Bridge API and is a set of wrapper functions that hides the
> complications related to interfacing to JAB's WindowsAccessBridge*.dll.
> In the past users of the API would compile and link to
> AccessBridgeCalls.c/obj.
>
> Since the interface implementation of AccessBridgeCalls.c will no
> longer
> be provided the JAB API documentation will be updated to instruct a
> user
> how to create an equivalent of AccessBridgeCalls.c.  The documentation
> will also contain a reference to the JAB 2.0.2 download
> http://www.oracle.com/technetwork/java/javase/downloads/jab-2-0-2-download-354311.html
>
> which does contain AccessBridgeCalls.c and which is compatible with the
> current API and related calls into WindowsAccessBridge*.dll.
>
> Pete
>
> On 10/18/16 12:28 PM, Pete Brunet wrote:
>> I've updated the webrev.  Please see
>> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.01/
>>
>> Rather than removing the files needed by Assistive Technology
>> developers
>> we have to provide them in JDK.  However since there is a .c file
>> in the
>> group of files the files were moved from the include directory to a
>> new
>> javaaccessbridge directory.
>>
>> On 10/17/16 2:43 AM, Magnus Ihse Bursie wrote:
>>> On 2016-10-14 17:51, Pete Brunet wrote:
 Please review the following.

 The .h files and .c file provided to allow Assistive Technology to
 interface to the Java Access Bridge API are being removed from
 the built
 JRE/JDK images.  They are not used much and they can be obtained
 online
 via the OpenJDK web site.  The pubs will be updated to mention the
 location of the files.

 Since there is a .c file in this group of files the directory
 structure
 has been changed slightly to remove the include directory.

 There was one file missing from the group of files needed by
 developers
 and that was moved from the common to the bridge directory.

 The make was updated in response to the above.

 Bug: https://bugs.openjdk.java.net/browse/JDK-8167213

 Webrev: http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.00/
>>> Build changes looks good to me.
>>>
>>> /Magnus

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-27 Thread Erik Joelsson


Build change looks good.

/Erik


On 2016-10-27 04:24, Pete Brunet wrote:

Please review the latest update at
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.03/

The change is to AccessBridgeCalls.c.  The license has been changed from
GPL2 to BSD.  This is because the file was originally unlicensed prior
to being bundled into the JDK and the compiled .obj is linked to by
vendors creating proprietary code.  Vendors will be instructed to
download AccessBridgeCalls.c from the OpenJDK repository.  Also the
include/use of AccessBridgeDebug.h/cpp has been removed.

Please also review readme.html which has been added to
.../jdk/include/win32/bridge.

Pete

On 10/25/16 6:48 AM, Alexandr Scherbatiy wrote:

The fix looks good to me.

Thanks,
Alexandr.

On 10/24/2016 1:18 PM, Erik Joelsson wrote:

The last change looks good and simple to me.

/Erik


On 2016-10-21 06:55, Pete Brunet wrote:

Please see the latest update
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.02/

The fix now is to simply remove the copy of the AccessBridgeCalls.c
file
into the JDK.

AccessBridgeCalls.c is the implementation of the documented Java Access
Bridge API and is a set of wrapper functions that hides the
complications related to interfacing to JAB's WindowsAccessBridge*.dll.
In the past users of the API would compile and link to
AccessBridgeCalls.c/obj.

Since the interface implementation of AccessBridgeCalls.c will no
longer
be provided the JAB API documentation will be updated to instruct a
user
how to create an equivalent of AccessBridgeCalls.c.  The documentation
will also contain a reference to the JAB 2.0.2 download
http://www.oracle.com/technetwork/java/javase/downloads/jab-2-0-2-download-354311.html

which does contain AccessBridgeCalls.c and which is compatible with the
current API and related calls into WindowsAccessBridge*.dll.

Pete

On 10/18/16 12:28 PM, Pete Brunet wrote:

I've updated the webrev.  Please see
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.01/

Rather than removing the files needed by Assistive Technology
developers
we have to provide them in JDK.  However since there is a .c file
in the
group of files the files were moved from the include directory to a
new
javaaccessbridge directory.

On 10/17/16 2:43 AM, Magnus Ihse Bursie wrote:

On 2016-10-14 17:51, Pete Brunet wrote:

Please review the following.

The .h files and .c file provided to allow Assistive Technology to
interface to the Java Access Bridge API are being removed from
the built
JRE/JDK images.  They are not used much and they can be obtained
online
via the OpenJDK web site.  The pubs will be updated to mention the
location of the files.

Since there is a .c file in this group of files the directory
structure
has been changed slightly to remove the include directory.

There was one file missing from the group of files needed by
developers
and that was moved from the common to the bridge directory.

The make was updated in response to the above.

Bug: https://bugs.openjdk.java.net/browse/JDK-8167213

Webrev: http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.00/

Build changes looks good to me.

/Magnus

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-26 Thread Mandy Chung

Should the same change be applied to the .h files as well?

Mandy

> On Oct 26, 2016, at 7:24 PM, Pete Brunet  wrote:
> 
> Please review the latest update at
> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.03/
> 
> The change is to AccessBridgeCalls.c.  The license has been changed from
> GPL2 to BSD.  This is because the file was originally unlicensed prior
> to being bundled into the JDK and the compiled .obj is linked to by
> vendors creating proprietary code.  Vendors will be instructed to
> download AccessBridgeCalls.c from the OpenJDK repository.  Also the
> include/use of AccessBridgeDebug.h/cpp has been removed.
> 
> Please also review readme.html which has been added to
> .../jdk/include/win32/bridge.
> 
> Pete
> 
> On 10/25/16 6:48 AM, Alexandr Scherbatiy wrote:
>> 
>> The fix looks good to me.
>> 
>> Thanks,
>> Alexandr.
>> 
>> On 10/24/2016 1:18 PM, Erik Joelsson wrote:
>>> The last change looks good and simple to me.
>>> 
>>> /Erik
>>> 
>>> 
>>> On 2016-10-21 06:55, Pete Brunet wrote:
 Please see the latest update
 http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.02/
 
 The fix now is to simply remove the copy of the AccessBridgeCalls.c
 file
 into the JDK.
 
 AccessBridgeCalls.c is the implementation of the documented Java Access
 Bridge API and is a set of wrapper functions that hides the
 complications related to interfacing to JAB's WindowsAccessBridge*.dll.
 In the past users of the API would compile and link to
 AccessBridgeCalls.c/obj.
 
 Since the interface implementation of AccessBridgeCalls.c will no
 longer
 be provided the JAB API documentation will be updated to instruct a
 user
 how to create an equivalent of AccessBridgeCalls.c.  The documentation
 will also contain a reference to the JAB 2.0.2 download
 http://www.oracle.com/technetwork/java/javase/downloads/jab-2-0-2-download-354311.html
 
 which does contain AccessBridgeCalls.c and which is compatible with the
 current API and related calls into WindowsAccessBridge*.dll.
 
 Pete
 
 On 10/18/16 12:28 PM, Pete Brunet wrote:
> I've updated the webrev.  Please see
> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.01/
> 
> Rather than removing the files needed by Assistive Technology
> developers
> we have to provide them in JDK.  However since there is a .c file
> in the
> group of files the files were moved from the include directory to a
> new
> javaaccessbridge directory.
> 
> On 10/17/16 2:43 AM, Magnus Ihse Bursie wrote:
>> On 2016-10-14 17:51, Pete Brunet wrote:
>>> Please review the following.
>>> 
>>> The .h files and .c file provided to allow Assistive Technology to
>>> interface to the Java Access Bridge API are being removed from
>>> the built
>>> JRE/JDK images.  They are not used much and they can be obtained
>>> online
>>> via the OpenJDK web site.  The pubs will be updated to mention the
>>> location of the files.
>>> 
>>> Since there is a .c file in this group of files the directory
>>> structure
>>> has been changed slightly to remove the include directory.
>>> 
>>> There was one file missing from the group of files needed by
>>> developers
>>> and that was moved from the common to the bridge directory.
>>> 
>>> The make was updated in response to the above.
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8167213
>>> 
>>> Webrev: http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.00/
>> Build changes looks good to me.
>> 
>> /Magnus
>>> 
>> 
>

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

Thanks Anirvan.  Appreciate you taking the time to participate in this
thread.

On 10/26/16 11:27 PM, Anirvan Sarkar wrote:
> Hi,
>
> If you replace the hex number with 'tip' then it will always point to
> the latest version. 
>
> Something
> like 
> http://hg.openjdk.java.net/jdk9/client/jdk/file/tip/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c
> 
>
> Regards,
> Anirvan Sarkar
>
> On Thursday 27 October 2016, Pete Brunet  > wrote:
>
>
>
> On 10/26/16 10:44 PM, Philip Race wrote:
>> >
>>   15 > href="http://hg.openjdk.java.net/jdk9/client/jdk/file/544828ab2a9b/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c;
>> 
>> >
>> That URL is definitely not authoritative.
>>
>> I think you need to give a pointer to something more like
>> 
>> http://hg.openjdk.java.net/jdk9/jdk9/jdk/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c
>> 
>> 
> Looks like that hex number in there is the Mercurial long revision
> number of the tip so that's going to keep changing.  I'm not aware
> of a "latest" link.  Maybe some other reader will know.
>> But I am not sure about that either .. it may need to be split between 
>> the main URL and the location in the repo.
>>
>> -phil 
>> On 10/26/16, 7:24 PM, Pete Brunet wrote:
>>> Please review the latest update at
>>> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.03/
>>> 
>>>
>>> The change is to AccessBridgeCalls.c.  The license has been changed from
>>> GPL2 to BSD.  This is because the file was originally unlicensed prior
>>> to being bundled into the JDK and the compiled .obj is linked to by
>>> vendors creating proprietary code.  Vendors will be instructed to
>>> download AccessBridgeCalls.c from the OpenJDK repository.  Also the
>>> include/use of AccessBridgeDebug.h/cpp has been removed.
>>>
>>> Please also review readme.html which has been added to
>>> .../jdk/include/win32/bridge.
>>>
>>> Pete
>>>
>>> On 10/25/16 6:48 AM, Alexandr Scherbatiy wrote:
 The fix looks good to me.

 Thanks,
 Alexandr.

 On 10/24/2016 1:18 PM, Erik Joelsson wrote:
> The last change looks good and simple to me.
>
> /Erik
>
>
> On 2016-10-21 06:55, Pete Brunet wrote:
>> Please see the latest update
>> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.02/
>> 
>>
>> The fix now is to simply remove the copy of the AccessBridgeCalls.c
>> file
>> into the JDK.
>>
>> AccessBridgeCalls.c is the implementation of the documented Java 
>> Access
>> Bridge API and is a set of wrapper functions that hides the
>> complications related to interfacing to JAB's 
>> WindowsAccessBridge*.dll.
>> In the past users of the API would compile and link to
>> AccessBridgeCalls.c/obj.
>>
>> Since the interface implementation of AccessBridgeCalls.c will no
>> longer
>> be provided the JAB API documentation will be updated to instruct a
>> user
>> how to create an equivalent of AccessBridgeCalls.c.  The 
>> documentation
>> will also contain a reference to the JAB 2.0.2 download
>> 
>> http://www.oracle.com/technetwork/java/javase/downloads/jab-2-0-2-download-354311.html
>> 
>> 
>>
>> which does contain AccessBridgeCalls.c and which is compatible with 
>> the
>> current API and related calls into WindowsAccessBridge*.dll.
>>
>> Pete
>>
>> On 10/18/16 12:28 PM, Pete Brunet wrote:
>>> I've updated the webrev.  Please see
>>> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.01/
>>> 
>>>
>>> Rather than removing the files needed by Assistive Technology
>>> developers
>>> we have to provide them in JDK.  However since there is a .c file
>>> in the
>>> group of files the files were moved from the include directory to a
>>> new
>>> javaaccessbridge directory.
>>>
>>> On 10/17/16 2:43 AM, Magnus Ihse Bursie wrote:

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

I found a comment from Mandy in the bug.  That hex number can be
replaced with "tip".

I uploaded http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.04/

Pete


On 10/26/16 11:05 PM, Pete Brunet wrote:
>
>
> On 10/26/16 10:44 PM, Philip Race wrote:
>> >
>>   15 > href="http://hg.openjdk.java.net/jdk9/client/jdk/file/544828ab2a9b/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c;>
>> That URL is definitely not authoritative.
>>
>> I think you need to give a pointer to something more like
>> http://hg.openjdk.java.net/jdk9/jdk9/jdk/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c
> Looks like that hex number in there is the Mercurial long revision
> number of the tip so that's going to keep changing.  I'm not aware of
> a "latest" link.  Maybe some other reader will know.
>> But I am not sure about that either .. it may need to be split between the 
>> main URL and the location in the repo.
>>
>> -phil 
>>
>>
>> On 10/26/16, 7:24 PM, Pete Brunet wrote:
>>> Please review the latest update at
>>> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.03/
>>>
>>> The change is to AccessBridgeCalls.c.  The license has been changed from
>>> GPL2 to BSD.  This is because the file was originally unlicensed prior
>>> to being bundled into the JDK and the compiled .obj is linked to by
>>> vendors creating proprietary code.  Vendors will be instructed to
>>> download AccessBridgeCalls.c from the OpenJDK repository.  Also the
>>> include/use of AccessBridgeDebug.h/cpp has been removed.
>>>
>>> Please also review readme.html which has been added to
>>> .../jdk/include/win32/bridge.
>>>
>>> Pete
>>>
>>> On 10/25/16 6:48 AM, Alexandr Scherbatiy wrote:
 The fix looks good to me.

 Thanks,
 Alexandr.

 On 10/24/2016 1:18 PM, Erik Joelsson wrote:
> The last change looks good and simple to me.
>
> /Erik
>
>
> On 2016-10-21 06:55, Pete Brunet wrote:
>> Please see the latest update
>> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.02/
>>
>> The fix now is to simply remove the copy of the AccessBridgeCalls.c
>> file
>> into the JDK.
>>
>> AccessBridgeCalls.c is the implementation of the documented Java Access
>> Bridge API and is a set of wrapper functions that hides the
>> complications related to interfacing to JAB's WindowsAccessBridge*.dll.
>> In the past users of the API would compile and link to
>> AccessBridgeCalls.c/obj.
>>
>> Since the interface implementation of AccessBridgeCalls.c will no
>> longer
>> be provided the JAB API documentation will be updated to instruct a
>> user
>> how to create an equivalent of AccessBridgeCalls.c.  The documentation
>> will also contain a reference to the JAB 2.0.2 download
>> http://www.oracle.com/technetwork/java/javase/downloads/jab-2-0-2-download-354311.html
>>
>> which does contain AccessBridgeCalls.c and which is compatible with the
>> current API and related calls into WindowsAccessBridge*.dll.
>>
>> Pete
>>
>> On 10/18/16 12:28 PM, Pete Brunet wrote:
>>> I've updated the webrev.  Please see
>>> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.01/
>>>
>>> Rather than removing the files needed by Assistive Technology
>>> developers
>>> we have to provide them in JDK.  However since there is a .c file
>>> in the
>>> group of files the files were moved from the include directory to a
>>> new
>>> javaaccessbridge directory.
>>>
>>> On 10/17/16 2:43 AM, Magnus Ihse Bursie wrote:
 On 2016-10-14 17:51, Pete Brunet wrote:
> Please review the following.
>
> The .h files and .c file provided to allow Assistive Technology to
> interface to the Java Access Bridge API are being removed from
> the built
> JRE/JDK images.  They are not used much and they can be obtained
> online
> via the OpenJDK web site.  The pubs will be updated to mention the
> location of the files.
>
> Since there is a .c file in this group of files the directory
> structure
> has been changed slightly to remove the include directory.
>
> There was one file missing from the group of files needed by
> developers
> and that was moved from the common to the bridge directory.
>
> The make was updated in response to the above.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8167213
>
> Webrev: http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.00/
 Build changes looks good to me.

 /Magnus
>

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory



On 10/26/16 10:44 PM, Philip Race wrote:
> >
>   15  href="http://hg.openjdk.java.net/jdk9/client/jdk/file/544828ab2a9b/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c;>
> That URL is definitely not authoritative.
>
> I think you need to give a pointer to something more like
> http://hg.openjdk.java.net/jdk9/jdk9/jdk/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c
Looks like that hex number in there is the Mercurial long revision
number of the tip so that's going to keep changing.  I'm not aware of a
"latest" link.  Maybe some other reader will know.
>
> But I am not sure about that either .. it may need to be split between the 
> main URL and the location in the repo.
>
> -phil 
>
>
> On 10/26/16, 7:24 PM, Pete Brunet wrote:
>> Please review the latest update at
>> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.03/
>>
>> The change is to AccessBridgeCalls.c.  The license has been changed from
>> GPL2 to BSD.  This is because the file was originally unlicensed prior
>> to being bundled into the JDK and the compiled .obj is linked to by
>> vendors creating proprietary code.  Vendors will be instructed to
>> download AccessBridgeCalls.c from the OpenJDK repository.  Also the
>> include/use of AccessBridgeDebug.h/cpp has been removed.
>>
>> Please also review readme.html which has been added to
>> .../jdk/include/win32/bridge.
>>
>> Pete
>>
>> On 10/25/16 6:48 AM, Alexandr Scherbatiy wrote:
>>> The fix looks good to me.
>>>
>>> Thanks,
>>> Alexandr.
>>>
>>> On 10/24/2016 1:18 PM, Erik Joelsson wrote:
 The last change looks good and simple to me.

 /Erik


 On 2016-10-21 06:55, Pete Brunet wrote:
> Please see the latest update
> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.02/
>
> The fix now is to simply remove the copy of the AccessBridgeCalls.c
> file
> into the JDK.
>
> AccessBridgeCalls.c is the implementation of the documented Java Access
> Bridge API and is a set of wrapper functions that hides the
> complications related to interfacing to JAB's WindowsAccessBridge*.dll.
> In the past users of the API would compile and link to
> AccessBridgeCalls.c/obj.
>
> Since the interface implementation of AccessBridgeCalls.c will no
> longer
> be provided the JAB API documentation will be updated to instruct a
> user
> how to create an equivalent of AccessBridgeCalls.c.  The documentation
> will also contain a reference to the JAB 2.0.2 download
> http://www.oracle.com/technetwork/java/javase/downloads/jab-2-0-2-download-354311.html
>
> which does contain AccessBridgeCalls.c and which is compatible with the
> current API and related calls into WindowsAccessBridge*.dll.
>
> Pete
>
> On 10/18/16 12:28 PM, Pete Brunet wrote:
>> I've updated the webrev.  Please see
>> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.01/
>>
>> Rather than removing the files needed by Assistive Technology
>> developers
>> we have to provide them in JDK.  However since there is a .c file
>> in the
>> group of files the files were moved from the include directory to a
>> new
>> javaaccessbridge directory.
>>
>> On 10/17/16 2:43 AM, Magnus Ihse Bursie wrote:
>>> On 2016-10-14 17:51, Pete Brunet wrote:
 Please review the following.

 The .h files and .c file provided to allow Assistive Technology to
 interface to the Java Access Bridge API are being removed from
 the built
 JRE/JDK images.  They are not used much and they can be obtained
 online
 via the OpenJDK web site.  The pubs will be updated to mention the
 location of the files.

 Since there is a .c file in this group of files the directory
 structure
 has been changed slightly to remove the include directory.

 There was one file missing from the group of files needed by
 developers
 and that was moved from the common to the bridge directory.

 The make was updated in response to the above.

 Bug: https://bugs.openjdk.java.net/browse/JDK-8167213

 Webrev: http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.00/
>>> Build changes looks good to me.
>>>
>>> /Magnus

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-26 Thread Philip Race

15http://hg.openjdk.java.net/jdk9/client/jdk/file/544828ab2a9b/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c;>
That URL is definitely not authoritative.

I think you need to give a pointer to something more like
http://hg.openjdk.java.net/jdk9/jdk9/jdk/src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.c

But I am not sure about that either .. it may need to be split between the main
URL and the location in the repo.

-phil

On 10/26/16, 7:24 PM, Pete Brunet wrote:

Please review the latest update at
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.03/

Please also review readme.html which has been added to
.../jdk/include/win32/bridge.

Pete

On 10/25/16 6:48 AM, Alexandr Scherbatiy wrote:

The fix looks good to me.

Thanks,
Alexandr.

On 10/24/2016 1:18 PM, Erik Joelsson wrote:

The last change looks good and simple to me.

/Erik

On 2016-10-21 06:55, Pete Brunet wrote:

Please see the latest update
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.02/

The fix now is to simply remove the copy of the AccessBridgeCalls.c
file
into the JDK.

which does contain AccessBridgeCalls.c and which is compatible with the
current API and related calls into WindowsAccessBridge*.dll.

Pete

On 10/18/16 12:28 PM, Pete Brunet wrote:

I've updated the webrev. Please see
http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.01/

On 10/17/16 2:43 AM, Magnus Ihse Bursie wrote:

On 2016-10-14 17:51, Pete Brunet wrote:

Please review the following.

Since there is a .c file in this group of files the directory
structure
has been changed slightly to remove the include directory.

There was one file missing from the group of files needed by
developers
and that was moved from the common to the bridge directory.

The make was updated in response to the above.

Bug: https://bugs.openjdk.java.net/browse/JDK-8167213

Webrev: http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.00/

Build changes looks good to me.

/Magnus

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory