Re: [PATCH] ubi_tools: enhance -s option to allow size multiplier to match mtd-utils

2013-06-02 Thread Mike Frysinger
On Friday 31 May 2013 22:28:03 Paul B. Henson wrote: On 5/31/2013 4:34 PM, Mike Frysinger wrote: +static int get_bytes(const char *str) [...] the style is wrong, but ignoring that, this seems like it'd be prime for adding to common libbb code if there isn't a func in there already I

[PATCH] man: find posix man pages

2013-06-02 Thread John Spencer
the posix manpages ( http://www.kernel.org/pub/linux/docs/man-pages/man-pages-posix/man-pages-posix-2003-a.tar.xz ) are placed in man0p man1p and man3p. Signed-off-by: John Spencer maillist-busy...@barfooze.de --- busybox-1.20.2.org/miscutils/man.c 2013-06-02 10:12:54.25103 + +++

[PATCH] man: use less as default pager and parse DEFINE lines defining pager

2013-06-02 Thread John Spencer
man.config can define lines such as DEFINE pager less -s this patch parses them, additionally it always sets pager to less instead of more. Signed-off-by: John Spencer maillist-busy...@barfooze.de --- busybox-1.20.2.org/miscutils/man.c 2013-06-02 10:12:54.25103 + +++

Re: [PATCH] man: use less as default pager and parse DEFINE lines defining pager

2013-06-02 Thread Tito
On Sunday 02 June 2013 12:51:21 John Spencer wrote: man.config can define lines such as DEFINE pager less -s this patch parses them, additionally it always sets pager to less instead of more. Signed-off-by: John Spencer maillist-busy...@barfooze.de + /*

Re: [PATCH] man: use less as default pager and parse DEFINE lines defining pager

2013-06-02 Thread John Spencer
On 06/02/2013 01:48 PM, Tito wrote: On Sunday 02 June 2013 12:51:21 John Spencer wrote: man.config can define lines such as DEFINE pager less -s this patch parses them, additionally it always sets pager to less instead of more. Signed-off-by: John Spencermaillist-busy...@barfooze.de

Re: [PATCH] man: use less as default pager and parse DEFINE lines defining pager

2013-06-02 Thread John Spencer
On 06/02/2013 12:51 PM, John Spencer wrote: man.config can define lines such as DEFINE pager less -s this patch parses them, additionally it always sets pager to less instead of more. Signed-off-by: John Spencer maillist-busy...@barfooze.de ++const char* env_pager = getenv(MANPAGER); ++

Re: [PATCH] man: use less as default pager and parse DEFINE lines defining pager

2013-06-02 Thread Tito
On Sunday 02 June 2013 14:01:01 John Spencer wrote: On 06/02/2013 01:48 PM, Tito wrote: On Sunday 02 June 2013 12:51:21 John Spencer wrote: man.config can define lines such as DEFINE pager less -s this patch parses them, additionally it always sets pager to less instead of

Re: [PATCH] man: use less as default pager and parse DEFINE lines defining pager

2013-06-02 Thread Rich Felker
On Sun, Jun 02, 2013 at 02:06:03PM +0200, John Spencer wrote: On 06/02/2013 12:51 PM, John Spencer wrote: man.config can define lines such as DEFINE pager less -s this patch parses them, additionally it always sets pager to less instead of more. Signed-off-by: John Spencer

Re: [PATCH] ubimkvol: add -m option to create volume of maximum size

2013-06-02 Thread Paul B. Henson
On Fri, May 31, 2013 at 11:05:56PM -0400, Mike Frysinger wrote: uses sscanf like this on lines 239 and 245. I'm certainly open to updating my patch to use xstrtou if that's preferable, it won't match the existing code but I suppose another commit at some point could change that. yes,

Re: [PATCH] man: use less as default pager and parse DEFINE lines defining pager

2013-06-02 Thread walter harms
Am 02.06.2013 18:03, schrieb Tito: On Sunday 02 June 2013 14:01:01 John Spencer wrote: On 06/02/2013 01:48 PM, Tito wrote: On Sunday 02 June 2013 12:51:21 John Spencer wrote: man.config can define lines such as DEFINE pager less -s this patch parses them, additionally it always

[PATCH] Convert sscanf to preferred xstrtou conversion.

2013-06-02 Thread Paul B. Henson
Signed-off-by: Paul B. Henson hen...@acm.org --- miscutils/ubi_tools.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/miscutils/ubi_tools.c b/miscutils/ubi_tools.c index dd99a44..9e3db1e 100644 --- a/miscutils/ubi_tools.c +++ b/miscutils/ubi_tools.c @@

Re: less with disabled options show help for them

2013-06-02 Thread David Balažic
This is still printed in the latest version even if search (FEATURE_LESS_REGEXP) is not configured: -I Ignore case in all searches Regards, David On 2 June 2013 05:19, Mike Frysinger vap...@gentoo.org wrote: On Saturday 01 June 2013 09:08:25 David Balažic wrote: Can anyone confirm, that in

[PATCH] Convert sscanf to preferred xstrtou conversion.

2013-06-02 Thread Paul B. Henson
Signed-off-by: Paul B. Henson hen...@acm.org --- miscutils/ubi_tools.c | 20 ++-- 1 files changed, 14 insertions(+), 6 deletions(-) diff --git a/miscutils/ubi_tools.c b/miscutils/ubi_tools.c index dd99a44..f6dfcae 100644 --- a/miscutils/ubi_tools.c +++ b/miscutils/ubi_tools.c

Re: [PATCH] Convert sscanf to preferred xstrtou conversion.

2013-06-02 Thread Paul B. Henson
On Sun, Jun 02, 2013 at 12:49:49PM -0700, Paul B. Henson wrote: + leb_size = xstrtou(buf, 10); Meh, there's a trailing newline at the end of buf in this version that causes xstrtou to barf :(. I fixed it and submitted an updated patch, please disregard the first one.

[PATCH] ubimkvol: add -m option to create volume of maximum size

2013-06-02 Thread Paul B. Henson
Signed-off-by: Paul B. Henson hen...@acm.org --- miscutils/ubi_tools.c | 51 +++- 1 files changed, 45 insertions(+), 6 deletions(-) diff --git a/miscutils/ubi_tools.c b/miscutils/ubi_tools.c index f6dfcae..f09be8c 100644 --- a/miscutils/ubi_tools.c

Re: [PATCH] ubimkvol: add -m option to create volume of maximum size

2013-06-02 Thread Paul B. Henson
On Fri, May 31, 2013 at 07:31:22PM -0400, Mike Frysinger wrote: all of these sscanf would be better off using the existing xstrtou() [...] you sprintf the same string at the start of buf every time. this would probably be smaller code: Ok, I resubmitted this patch with your requested

[PATCH] ubi_tools: enhance -s option to allow size multiplier to match mtd-utils

2013-06-02 Thread Paul B. Henson
Signed-off-by: Paul B. Henson hen...@acm.org --- miscutils/ubi_tools.c | 33 - 1 files changed, 24 insertions(+), 9 deletions(-) diff --git a/miscutils/ubi_tools.c b/miscutils/ubi_tools.c index f09be8c..6b5d384 100644 --- a/miscutils/ubi_tools.c +++

Re: [PATCH] ubi_tools: enhance -s option to allow size multiplier to match mtd-utils

2013-06-02 Thread Paul B. Henson
On Sun, Jun 02, 2013 at 03:23:18AM -0400, Mike Frysinger wrote: i think libbb has grown to the point where it needs to start providing its own API reference :/. it's been a while since i hacked seriously on busybox, so i've lost touch with much of its deeper layers. [...] inputs. it's

Re: [PATCH] ubimkvol: add -m option to create volume of maximum size

2013-06-02 Thread Tito
On Monday 03 June 2013 02:48:05 Paul B. Henson wrote: Signed-off-by: Paul B. Henson hen...@acm.org --- miscutils/ubi_tools.c | 51 +++- 1 files changed, 45 insertions(+), 6 deletions(-) diff --git a/miscutils/ubi_tools.c b/miscutils/ubi_tools.c

Re: [PATCH] ubi_tools: enhance -s option to allow size multiplier to match mtd-utils

2013-06-02 Thread Tito
On Monday 03 June 2013 03:11:10 Paul B. Henson wrote: Signed-off-by: Paul B. Henson hen...@acm.org --- miscutils/ubi_tools.c | 33 - 1 files changed, 24 insertions(+), 9 deletions(-) diff --git a/miscutils/ubi_tools.c b/miscutils/ubi_tools.c index