Re: [PATCH] devmem: add 128-bit width

Hi, On Fri, Aug 26, 2022 at 05:25:22PM +0200, Denys Vlasenko wrote: > Is there a need to make these 128 reads actually this wide as one atomic load? > (On x86, SSE insn do that). There are arm64 hardware where such register access is needed, and GCC handles that correctly. A.

[PATCH] devmem: add 128-bit width

From: Aaro Koskinen Add 128-bit width if the compiler provides the needed type. function old new delta devmem_main 412 517+105 usage_messages 247 313

Re: Bash compatibility TODO

Hi, On Mon, Jun 27, 2022 at 11:24:15PM +0200, Bernd Petrovitsch wrote: > On 27/06/2022 23:10, David Laight wrote: > > From: Aaro Koskinen > > > Sent: 27 June 2022 21:43 > [...] > > > Looks like it's not possible to build mainline Linux anymore with the > > &g

Bash compatibility TODO

Hi all, Looks like it's not possible to build mainline Linux anymore with the busybox as "bash". :-( $ make CC scripts/mod/empty.o ./scripts/check-local-export: line 17: shopt: not found make[1]: *** [scripts/Makefile.build:249: scripts/mod/empty.o] Error 127 make[1]: *** Deleting file

Re: [PATCH] Improve support for long options to grep

Hi, On Mon, Jan 24, 2022 at 01:12:25PM -0300, Walter Lozano wrote: > In my specific use case, I try to run some Debian scripts, that make use of > some of those long options, of course not all of them. Since I was already > there I thought it would be nice to add them, since these kind of

[PATCH] find: implement -samefile

Implement -samefile. Signed-off-by: Aaro Koskinen --- findutils/find.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/findutils/find.c b/findutils/find.c index fdc5c152d..87fd5b9bc 100644 --- a/findutils/find.c +++ b/findutils/find.c @@ -155,6 +155,13

Regression: busybox xargs broken

Hi, I noticed the following: $ echo foo bar | ./busybox xargs -n1 foo b a r This makes busybox build fail under busybox (scripts/trylink uses xargs). Bisected to: commit 1ff7002b1d229c678fdffebec602fb4c54439a31 (HEAD -> master) Author: Ron Yorston Date: Fri Jan 24 13:16:45 2020

Regression: busybox gzip broken

Hi, This time gzip is broken, caused by: c763392458304d68951d0b22e89e2422b9c2f8ef is the first bad commit commit c763392458304d68951d0b22e89e2422b9c2f8ef Author: Denys Vlasenko Date: Sat Oct 19 18:33:49 2019 +0200 gzip: code shrink Decompressing large gzip archive segfaults: $ busybox

Re: Regression: busybox tar broken

Hi, On Thu, Oct 24, 2019 at 02:30:18AM +0300, Aaro Koskinen wrote: > $ busybox tar > tar: NO OPT �! > $ busybox tar xf foo.tar > tar: NO OPT �! Seems to happen only when CONFIG_FEATURE_SEAMLESS_LZMA is not set. A. ___ busybox mailing

Regression: busybox tar broken

Hi, I get this with the current git master: $ busybox tar tar: NO OPT �! $ busybox tar xf foo.tar tar: NO OPT �! Bisected to: 16474cf246cb10b982f7365b201f32a930e8af95 is the first bad commit commit 16474cf246cb10b982f7365b201f32a930e8af95 Author: Denys Vlasenko Date: Fri Aug 2 15:19:56

Re: [PATCH] find: implement -empty

Hi, On Wed, Sep 11, 2019 at 03:22:33PM +0200, David Demelier wrote: > You can save an indent level here by removing this else block. Since there > is a return before, no need for this else. The block is used to limit variable scope, so I don't have to declare variables that are only used when

Re: [PATCH] find: implement -empty

Hi, On Wed, Sep 11, 2019 at 09:46:45AM +0200, walter harms wrote: > is seems possible to simply that a bit (untested version): > > if ( ! S_ISDIR(statbuf->st_mode)) >return S_ISREG(statbuf->st_mode) && !statbuf->st_size; > > DIR *dir; Not sure if this is allowed by current busybox

[PATCH] find: implement -empty

Implement -empty. Signed-off-by: Aaro Koskinen --- findutils/find.c | 45 + 1 file changed, 45 insertions(+) diff --git a/findutils/find.c b/findutils/find.c index d6679bd08..3e4ae3266 100644 --- a/findutils/find.c +++ b/findutils/find.c @@ -203,6

Re: find options -empty and -delete

Hi, On Tue, Sep 10, 2019 at 06:29:02PM +0200, Tim Tassonis wrote: > I just found out about a terribly convenient way to recursively delete empty > directories with find, using the options -empty and -delete > > It seems current busybox does not support these, are there any plans to add > them?

Re: Patches to make GNU gzip and BusyBox gzip produce identical compression results

Hi, On Tue, Sep 03, 2019 at 10:31:20AM +0800, Kang-Che Sung wrote: > gzip -9 is quite fast in modern processors, and if someone builds busybox > without CONFIG_FEATURE_GZIP_LEVELS, I think they are moke likely to stick > with -9 as default instead of -6. No, -9 is really slow with little gain:

[PATCH v2] sysctl: fix compatibility with procps sysctl

From: Aaro Koskinen Busybox sysctl is incompatible with procps when '.' appears in directory name, mostly happens with VLANs. busybox syntax (since 2008): net.ipv4.conf.eth0.100.mc_forwarding procps syntax (since 2002): net.ipv4.conf.eth0/100.mc_forwarding

[PATCH] sysctl: fix compatibility with procps sysctl

From: Aaro Koskinen Busybox sysctl is incompatible with procps when '.' appears in directory name, mostly happens with VLANs. busybox syntax (since 2008): net.ipv4.conf.eth0.100.mc_forwarding procps syntax (since 2002): net.ipv4.conf.eth0/100.mc_forwarding

Re: [RFC PATCH v2] Allow applets to be implemented as scripts

On Tue, Nov 06, 2018 at 08:36:11PM +, Ron Yorston wrote: > For the rest I suppose there are a couple of ways to look at it. The > dependencies could be specified explicitly: > >depends on ASH_EMBEDDED_SCRIPTS && (ECHO || ASH_ECHO) && CAT && SLEEP > > Though this means that scripted

[REGRESSION] busybox less output messed up

Hi, Busybox less output gets messed up if the input is delayed. E.g. on busybox source tree: (sleep 10; ls) | ./busybox less produces the following on my Xterm: [...] ~ LICENSE ~ Makefile ~

[PATCH] less: implement -F

Implement -F option: Exit if entire file fits on first screen. Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- miscutils/less.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/miscutils/less.c b/miscutils/less.c index 51ef2a59d..3bce93247

[REGRESSION] busybox "make install" failure

Hi, make install fails with a minimal busybox config (see further below). Note that it shouldn'd be even trying to install the symlinks (CONFIG_INSTALL_APPLET_DONT=y)... [...] CC libbb/appletlib.o AR shell/lib.a CC libbb/lineedit.o CC libbb/vfork_daemon_rexec.o AR

Re: bc

Hi, On Tue, Mar 13, 2018 at 02:13:24AM +0200, Aaro Koskinen wrote: > On Mon, Mar 12, 2018 at 05:22:05PM -0600, Gavin Howard wrote: > > Over the past month or so, I have written a standalone bc. I have > > written it so it could be integrated into busybox/toybox, etc on an > >

Re: bc

Hi, On Mon, Mar 12, 2018 at 05:22:05PM -0600, Gavin Howard wrote: > Over the past month or so, I have written a standalone bc. I have > written it so it could be integrated into busybox/toybox, etc on an > automated basis (ie, I submit a new release soon before a busybox > release). Would you be

[PATCH] cp: implement -T

Implement "cp -T". Some Linux kernel Makefiles started using this recently, so allow also building on systems using busybox cp. Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- coreutils/cp.c | 10 -- include/libbb.h | 7 --- 2 files changed, 12 insertions

[PATCH 1/2] patch: fix debug log failure

If we reach the end of plist it means the input has still data while we are expecting EOF. Fix the log to avoid a crash. Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- editors/patch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/editors/patch.c b/editors/p

[PATCH 2/2] patch: fix matching failure

Fix matching failure when plist is advanced while checking for buffered lines - the lines in the hunk that are about to be added should be skipped when checking for matching context. Also add a valid test case that fails with current busybox and is fixed by the change. Signed-off-by: Aaro

Re: [PATCH 2/2] cpio: add missing initialization for cpio__owner

Hi, On Fri, Nov 04, 2016 at 10:34:46PM +0100, Denys Vlasenko wrote: > This seems to be fixed already? > > commit 85100a7067a51c5e6720c0a738317cc2144ab219 > Author: Denys Vlasenko > Date: Wed Oct 12 20:56:46 2016 +0200 Yeah, sorry, I had forgotten to refresh the

[PATCH 1/2] cpio: add ownership (-R) test cases

Add ownership (-R) test cases. Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- testsuite/cpio.tests | 24 1 file changed, 24 insertions(+) diff --git a/testsuite/cpio.tests b/testsuite/cpio.tests index 4cd441a..d44c95b 100755 --- a/testsuite/cpio.tests

[PATCH 2/2] cpio: add missing initialization for cpio__owner

From: Marc Smith <marc.sm...@mcc.edu> Add missing initialization for cpio__owner. Otherwise all files are owned by root. The patch fixes the failing test cases added in the previous patch. Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- archival/cpio.c | 2 ++ 1 fil

Re: Busybox ash regression

Hi, On Sun, Oct 02, 2016 at 01:27:41AM +0200, Denys Vlasenko wrote: > On Sat, Oct 1, 2016 at 11:18 PM, Aaro Koskinen <aaro.koski...@iki.fi> wrote: > > > > Fails like this (globbing error?): > > > > fgrep: /home/aaro/los/work/pkg/foo/*/stamp.os: No such file

Busybox ash regression

Hi, Current git HEAD (3ed7e2749a3f9fd315d8f46a3b0a25ff10caf726) seems to break GLIBC build when /bin/sh is busybox ash. Steps to reproduce: tar xf glibc-2.24.tar.xz mkdir foo cd foo ../glibc-2.24/configure --prefix=/usr make -j12 Fails like this

Busybox git build broken

Hi, The following commit: commit 607f2b404e992174d7c5956d11e8f35f78d2701f Author: Denys Vlasenko Date: Tue Aug 23 16:13:33 2016 +0200 fdisk: print much less cryptic partition table broke the fdisk build with CONFIG_FEATURE_SUN_LABEL=y: CC

Re: [PATCH 1/2] Allow BusyBox to be built without a list of applet names

Hi, On Sat, Apr 30, 2016 at 08:58:46AM -0400, Jody Lee Bruchon wrote: > On April 30, 2016 8:39:24 AM EDT, Andreas Oberritter > wrote: > >Even worse, consider a busybox binary that someone expects to contain a > >real command like cat or hexdump, which it doesn't. The

Re: [PATCH 1/2] Allow BusyBox to be built without a list of applet names

Hi, On Fri, Apr 29, 2016 at 12:05:24PM -0700, ..mg.. wrote: > The lookup hash isn't collision-free: more than one input string > points to the same applet. Normally invalid applet names might > cause an unexpected one to run Highly insecure, no? A.

[BISECTED] busybox modprobe regression

Hi, modprobes are failing for me (with some kernel modules reporting -2) with current busybox, and I bisected this to: commit 3a5cc989025eefe03fda0552b253a4a8f015a761 Author: Mike Frysinger Date: Fri Feb 12 23:26:51 2016 -0500 modprobe: only parse files that end in

[PATCH v3] nandwrite: implement -n (read/write without ecc)

Implement -n (read/write without ecc). Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- v3: Use xioctl() instead of open coding it. v2: http://marc.info/?t=14476328081=1=2 The first version was bogus, opt bits were messed up. v1: http://mar

Re: [PATCH] blkdiscard: new applet

Hi, On Fri, Nov 27, 2015 at 10:09:47PM +0200, Ari Sundholm wrote: > + if (!S_ISBLK(st.st_mode)) > + bb_error_msg_and_die("%s is not a block device!", argv[optind]); $ git grep -A1 '!S_ISBLK' | grep bb_error_msg util-linux/fdformat.c- bb_error_msg_and_die("%s: not a block

[PATCH] nandwrite: implement -n (read/write without ecc)

Implement -n (read/write without ecc). Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- miscutils/nandwrite.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/miscutils/nandwrite.c b/miscutils/nandwrite.c index 247fc72..ec0b5b0 100644 --- a/mis

[PATCH v2] nandwrite: implement -n (read/write without ecc)

Implement -n (read/write without ecc). Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- v2: The first version was bogus, opt bits were messed up. miscutils/nandwrite.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/mis

Busybox tar/gunzip regression

Hi, The below commit broke untarring .gz archives: $ tar xf memtester-4.3.0.tar.gz tar: short read commit 1de25a6e87e0e627aa34298105a3d17c60a1f44e Author: Denys Vlasenko Date: Mon Oct 26 19:33:05 2015 +0100 unzip: test for bad archive SEGVing A.

[PATCH 1/2] gunzip: add support for long options

Add support for long options. Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- archival/bbunzip.c | 20 1 file changed, 20 insertions(+) diff --git a/archival/bbunzip.c b/archival/bbunzip.c index 548882f..e10372e 100644 --- a/archival/bbunzip.c +++ b/ar

[PATCH 2/2] gzip: add support for --no-name long option

Add support for --no-name long option. Just silently ignore it like the short -n option. This allows to use busybox gzip with Lynx browser. Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- archival/bbunzip.c | 1 + archival/gzip.c| 1 + 2 files changed, 2 insertions(+) diff

[BISECTED] Busybox sort regression

Hi, Current busybox git breaks glibc builds because of "sort" regression. Bisected to: commit 8aa7cf305ba5133721aa9852b398cbf1867fc857 Author: Denys Vlasenko Date: Sat Sep 19 22:06:40 2015 +0200 sort: fix -kN,M handling (was including last separator into the

[PATCH] xargs: make -I imply -r

Make -I imply -r (GNU findutils seems to do the same). Fixes the following bug: $ echo -n | xargs -I% echo % Segmentation fault Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- findutils/xargs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/findutils/xar

[PATCH] cpio: implement -R/--owner

910 943 +33 cpio_o 814 844 +30 -- (add/remove: 0/0 grow/shrink: 4/0 up/down: 154/0) Total: 154 bytes Signed-off-by: Aaro

[BISECTED] busybox ash regression

Hi, The following commit: commit 549deab5abd59c1ab752754170f69aa2248e72c9 Author: Ron Yorston r...@pobox.com Date: Mon May 18 09:57:51 2015 +0200 ash: move parse-time quote flag detection to run-time introduced the following change of behaviour:

[PATCH 2/2] diff.tests: add testcases for -B and single line changes

Add testcases for -B and single line changes. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- testsuite/diff.tests | 12 1 file changed, 12 insertions(+) diff --git a/testsuite/diff.tests b/testsuite/diff.tests index 84d8538..0ced0f2 100755 --- a/testsuite/diff.tests +++ b

[PATCH 1/2] diff: fix -B with single line changes

Fix -B with single line changes. They were always ignored regardless if they were blank or not. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- editors/diff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/editors/diff.c b/editors/diff.c index cf14b1d..e0adcee

diff -B is broken?

Hi, diff -B option does not seem to work as expected. See the below for an example: $ cat foo 1 $ cat bar 2 $ diff foo bar --- foo +++ bar @@ -1 +1 @@ -1 +2 $ diff -B foo bar $ A. ___ busybox mailing list busybox@busybox.net

[PATCH] gzip: add support for compression levels 4-9

4: 0m12.484s (0m11.167s) 156.4M If the compression level support is enabled, we make 6 the default as with gzip 1.6. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- archival/gzip.c | 56 +++- 1 file changed, 55

[PATCH] update copyright years

Copyright years seem to be out of date, e.g. coreutils/truncate.c has Copyright (C) 2015. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- libbb/appletlib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libbb/appletlib.c b/libbb/appletlib.c index 8fd8fd5..e0b843d

Re: [PATCH] install: support -t option

Hi, On Wed, Sep 24, 2014 at 02:53:35AM +0200, Denys Vlasenko wrote: On Tuesday 23 September 2014 21:12, Aaro Koskinen wrote: Some packages want to install themselves using -t to specify the directory (as supported by GNU coreutils). Add support for the option for compatibility reasons

Re: Busybox less sometimes ignores newlines in input?

On Sun, Sep 21, 2014 at 10:10:37PM +0200, Denys Vlasenko wrote: On Saturday 20 September 2014 13:30, Aaro Koskinen wrote: Hi, Sometimes when running git log, busybox less won't display a newline between commits. This happens when git is slow and less needs to wait for new input

Busybox less sometimes ignores newlines in input?

Hi, Sometimes when running git log, busybox less won't display a newline between commits. This happens when git is slow and less needs to wait for new input to appear. A simple reproducer: (perl -e 'print \nfoo\n;'; sleep 1; perl -e 'print \nbar\n;') | less A.

Re: [PATCH v2 2/2] tftp: ignore trailing garbage in the request

Hi, On Wed, Sep 03, 2014 at 06:36:36PM +0200, Denys Vlasenko wrote: On Mon, Sep 1, 2014 at 10:24 PM, Aaro Koskinen aaro.koski...@iki.fi wrote: The firmware in some HP PA-RISC boxes is always sending fixed 512-byte requests, and sometimes there is some garbage at the end which makes busybox

[PATCH v2 2/2] tftp: ignore trailing garbage in the request

The firmware in some HP PA-RISC boxes is always sending fixed 512-byte requests, and sometimes there is some garbage at the end which makes busybox to reject the request. Ignore any characters after the last NUL. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- networking/tftp.c | 5

[PATCH v2 1/2] tftp: fix off by one error

RFC 2347 allows requests to be up to 512 bytes, so a request equal to sizeof(G.block_buf) should be fine. The remaining result sizeof(G.block_buf) check would be redudant, since the recv function should take care of not overrunning the buffer, so delete that too. Signed-off-by: Aaro Koskinen

Re: [PATCH RESEND v2] less: respect -E (quit at EOF)

Hi, On Sat, Nov 16, 2013 at 08:48:13PM +0200, Aaro Koskinen wrote: less displays -E in help text, but it's not doing anything. Make it quit less when the last lines of the file have been printed. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- Any comments about this patch? Or should

Re: [PATCH] taskset: support more than 64 cores

Hi, On Mon, Aug 11, 2014 at 02:25:04PM +0100, Laszlo Papp wrote: I wonder about the use case for this feature? I mean busybox is meant for small systems in general, and =64 cores are not that small embedded systems, at least not yet, yeah? How you define small? Earlier you said using libc

Re: [PATCH] taskset: support more than 64 cores

Hi, On Mon, Aug 11, 2014 at 10:27:12PM +0100, Laszlo Papp wrote: Show me one typical embedded system that is high-volume and has more than 64 cores. Even the full-fledged iphone tablets are not there and even if they were, they would use complete utils rather than chopped most probably

Re: [PATCH] taskset: support more than 64 cores

Hi, On Mon, Aug 11, 2014 at 10:35:46PM +0100, Laszlo Papp wrote: Not quite sure what you are trying to achieve, but you wrote embedded systems _word-by-word_, and I asked for one typical example with more than 64 cores where busybox is so much needed. I'm not trying the limit busybox usage,

Re: [PATCH] taskset: support more than 64 cores

Hi, On Mon, Aug 11, 2014 at 11:19:34PM +0100, Laszlo Papp wrote: Right, so you cannot bring up any valid and real use case for this, or do not want despite the explicit clarification request, I take it. I do not think theoretical changes should be added just because it is a good technical

Re: [PATCH] taskset: support more than 64 cores

Hi, BTW, if you care about bloat, please consider stopping sending HTML mails to the list. A. ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: [PATCH] nproc: new applet

Hi, On Mon, Aug 04, 2014 at 09:51:50PM +0100, Laszlo Papp wrote: Glibc is out of the question, naturally. What would matter is eglibc if one can verify it. What you mean? According to EGLIBC home page: EGLIBC is no longer developed and such goals are now being addressed directly in GLIBC. A.

Re: [PATCH] nproc: new applet

Hi, On Mon, Aug 04, 2014 at 11:22:13PM +0100, Laszlo Papp wrote: I am not sure what is unclear. eglibc is eglibc. Yes, they merged lately, yet, Yocto, et all uses eglibc out there. That would be the most important to verify. In fact, you will not have a full blown glibc on the target

Re: [PATCH] nproc: new applet

Hi, On Mon, Aug 04, 2014 at 11:06:58PM +0100, Steven Honeyman wrote: Right, seeing as musl libc (and most other non-glibcs) do not provide a get_nprocs() that actually works... I have mixed both solutions and used sysconf() instead. It works just as well. If the underlying libc supports

[PATCH 2/2] tftp: ignore trailing garbage in the request

The firmware in some HP PA-RISC boxes sending fixed 512-byte requests, and sometimes there is some garbage at the end which makes busybox to reject the request. Ignore any characters after the last NUL. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- networking/tftp.c | 5 +++-- 1 file

[PATCH 1/2] tftp: fix off by one error

RFC 2347 allows requests to be up to 512 bytes. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- networking/tftp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/networking/tftp.c b/networking/tftp.c index 630fdaf..b91ef5b 100644 --- a/networking/tftp.c +++ b/networking

Re: Ntpd config file support

On Tue, Mar 18, 2014 at 01:43:43PM +0100, Harald Becker wrote: The Busybox ntpd applet get all information it needs via command line, so it doesn't need to read any config file. I agree, it would be overlapping functionality and not needed. A. ___

[PATCH] man: default to ascii

Default to ascii instead of latin1. Otherwise man pages will be displayed incorrectly on UTF-8 terminals. E.g. bullets show as B7. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- miscutils/man.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/miscutils/man.c b/miscutils

Re: Interworking of cron and sendmail applets

Hi, On Wed, Jan 22, 2014 at 11:29:14PM +0100, Harald Becker wrote: I do not know, why this option has made mandatory, but as far as i know does BB sendmail always need some extra options to know where to send the mail (mail relay), and will not work without this information. So it is of no

Re: busybox sendmail and recipients list

Hi, On Sun, Dec 29, 2013 at 11:02:21PM +0100, Piotr Rotter wrote: I observed some problem with busybox sendmail applet in case when present many recipient in headers in one line like below: To: us...@domain.tld,us...@domain.tld Earlier this year some fixes were made to sendmail to address

[PATCH RESEND v2] less: respect -E (quit at EOF)

less displays -E in help text, but it's not doing anything. Make it quit less when the last lines of the file have been printed. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- Patch history: v2: Also check that EOF was reached (eof_error = 0). v1: http://marc.info/?t

[PATCH v2] less: respect -E (quit at EOF)

less displays -E in help text, but it's not doing anything. Make it quit less when the last lines of the file have been printed. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- Patch history: v2: Also check that EOF was reached (eof_error = 0). v1: http://marc.info/?t

Re: [PATCH] less: respect -E (quit at EOF)

Hi, On Sat, Sep 14, 2013 at 12:13:52AM +0300, Aaro Koskinen wrote: less displays -E in help text, but it's not doing anything. Make it quit less when the last lines of the file have been printed. Any comments? A. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- miscutils/less.c | 3

Re: [PATCH] Fix incorrect OS reporting in uname -o

Hi, On Tue, Sep 17, 2013 at 11:47:55PM -0400, Patrick 'P. J.' McDermott wrote: On 2013-09-17 18:56, Rich Felker wrote: - strcpy(uname_info.os, GNU/Linux); + strcpy(uname_info.os, +#ifdef __GLIBC__ + GNU/ +#endif + Linux); I'd agree that most BusyBox-based

[PATCH] less: respect -E (quit at EOF)

less displays -E in help text, but it's not doing anything. Make it quit less when the last lines of the file have been printed. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- miscutils/less.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/miscutils/less.c b/miscutils/less.c index

Re: ash: source nonexistent file makes ash exit?

Hi, On Sat, Mar 16, 2013 at 12:04:12AM +0100, Harald Becker wrote: Hi Matthew ! I've heard rumors that backticks are discouraged in favor of $( )... Can we do the same for . in favor of source? You can't exactly grep for '.' It was just a hint for novices that both syntax forms behave

Re: ash: source nonexistent file makes ash exit?

Hi, On Sat, Mar 16, 2013 at 12:38:28AM +0100, Harald Becker wrote: source is bashism, and . should be preferred for portability. Definitely not! Even very old Unix shells (and alike) back in the 80th accepted both syntax forms (but shells are different and not all are standards conform). I

[PATCH 2/7] sendmail: don't mangle e-mail headers

Leave the original To: and Cc: headers untouched, when we try to extract addresses from them. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- mailutils/sendmail.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mailutils/sendmail.c b/mailutils/sendmail.c index

[PATCH 0/7] sendmail: improve recipient address handling

review comments sent with busybox sendmail. :-) Aaro Koskinen (7): sendmail: avoid sending mail to wrong addresses sendmail: don't mangle e-mail headers sendmail: support addresses inside angle brackets sendmail: support address lists sendmail: support long header fields for recipients

[PATCH 6/7] sendmail: don't add To: header if it already exists

If the message we are sending already has To: header, don't add a new one. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- mailutils/sendmail.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/mailutils/sendmail.c b/mailutils/sendmail.c index 9c1c589..323ad0a

[PATCH 7/7] sendmail: don't add multiple To: headers

When adding To: header, add only a single header. If there are multiple addresses, make it multiline. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- mailutils/sendmail.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/mailutils/sendmail.c b

[PATCH 2/2] fdisk_sun: fix partition alignment

When the display unit is sectors, the partition alignment will convert the partition start to a wrong unit (it should always be in sectors). Fix this. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- util-linux/fdisk_sun.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions

[PATCH 1/2] fdisk_sun: fix corrupted partition data with blank disk

After creating Sun disk label for the first time for a blank disk, the partition table appears corrupted because current_label_type will never get set to a proper type. Fix this by calling check_sun_label() after BusyBox has created the label. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi