Re: fix large PID overflow their column in top command

2024-04-01 Thread Matthew Chae
___ From: Bernhard Reutner-Fischer Sent: Thursday, February 15, 2024 9:46 PM To: Matthew Chae Cc: rep.dot@gmail.com ; David Laight ; 'Denys Vlasenko' ; busybox@busybox.net ; Christopher Wong Subject: Re: fix large PID overflow their column in top command On Wed, 14 Feb 2024 14:05:1

Re: fix large PID overflow their column in top command

2024-03-01 Thread Matthew Chae
enko' ; busybox@busybox.net ; Christopher Wong Subject: Re: fix large PID overflow their column in top command On Wed, 14 Feb 2024 14:05:15 + Matthew Chae wrote: Hi Bernhard, I'm sending new patch and the result of bloatcheck. Many thanks for the updated patch! function 

Re: fix large PID overflow their column in top command

2024-03-01 Thread Matthew Chae
r-Fischer Sent: Tuesday, February 13, 2024 7:16 PM To: Matthew Chae Cc: rep.dot@gmail.com ; David Laight ; 'Denys Vlasenko' ; busybox@busybox.net ; Christopher Wong Subject: Re: fix large PID overflow their column in top command On Mon, 5 Feb 2024 09:56:20 + Matthew Chae wrote:

Re: fix large PID overflow their column in top command

2024-03-01 Thread Matthew Chae
asenko' ; busybox@busybox.net ; Christopher Wong Subject: Re: fix large PID overflow their column in top command On Wed, 14 Feb 2024 14:05:15 + Matthew Chae wrote: Hi Bernhard, I'm sending new patch and the result of bloatcheck. Many thanks for the updated patch! function

Re: fix large PID overflow their column in top command

2024-02-21 Thread Bernhard Reutner-Fischer
arches. Many thanks in advance and cheers, Bernhard > > Br-Matthew > > > From: Bernhard Reutner-Fischer > Sent: Thursday, February 15, 2024 9:46 PM > To: Matthew Chae > Cc: rep.dot@gmail.com ; David Laight > ; 'Denys Vlasenko' ; > busybox@

Re: fix large PID overflow their column in top command

2024-02-19 Thread Matthew Chae
day, February 13, 2024 7:16 PM > To: Matthew Chae > Cc: rep.dot@gmail.com ; David Laight > ; 'Denys Vlasenko' ; > busybox@busybox.net ; Christopher Wong > > Subject: Re: fix large PID overflow their column in top command > > On Mon, 5 Feb 2024 09:56:20 + >

Re: fix large PID overflow their column in top command

2024-02-15 Thread Bernhard Reutner-Fischer
13, 2024 7:16 PM > To: Matthew Chae > Cc: rep.dot@gmail.com ; David Laight > ; 'Denys Vlasenko' ; > busybox@busybox.net ; Christopher Wong > > Subject: Re: fix large PID overflow their column in top command > > On Mon, 5 Feb 2024 09:56:20 + > Matthew Chae wrot

Re: fix large PID overflow their column in top command

2024-02-14 Thread Matthew Chae
PM To: Matthew Chae Cc: rep.dot@gmail.com ; David Laight ; 'Denys Vlasenko' ; busybox@busybox.net ; Christopher Wong Subject: Re: fix large PID overflow their column in top command On Mon, 5 Feb 2024 09:56:20 + Matthew Chae wrote: > Hi David, > > I'm sending an improved pa

Re: fix large PID overflow their column in top command

2024-02-13 Thread Bernhard Reutner-Fischer
___ > From: David Laight > Sent: Thursday, November 23, 2023 6:10 PM > To: 'Denys Vlasenko' ; Matthew Chae > > Cc: busybox@busybox.net ; Christopher Wong > > Subject: RE: fix large PID overflow their column in top command > > ... > > + fp = xfopen_f

Re: fix large PID overflow their column in top command

2024-02-05 Thread Matthew Chae
, November 23, 2023 6:10 PM To: 'Denys Vlasenko' ; Matthew Chae Cc: busybox@busybox.net ; Christopher Wong Subject: RE: fix large PID overflow their column in top command ... > + fp = xfopen_for_read("/proc/sys/kernel/pid_max"); > + if (!fgets(pid_buf, PID_DI

RE: fix large PID overflow their column in top command

2023-11-23 Thread David Laight
... > + fp = xfopen_for_read("/proc/sys/kernel/pid_max"); > + if (!fgets(pid_buf, PID_DIGITS_MAX + 1, fp)) { > ... > + if (strncmp(pid_buf, "32768", 5) == 0) > + pid_digits_num = 5; > + else > + pid_digits_num = PID_DIGITS_MAX; > > The logic

Re: fix large PID overflow their column in top command

2023-11-23 Thread Denys Vlasenko
On Fri, Nov 10, 2023 at 4:22 PM Matthew Chae wrote: > Hi Denys, > > I'm sending the patch what I've mentioned. Can you take a look at this? > If I don't understand correctly what you said before, let me know. > > The max PID value can have 7 digits as the 4194304. > > Busybox v1.36 released a

Re: fix large PID overflow their column in top command

2023-11-20 Thread Matthew Chae
Chae Sent: Wednesday, November 8, 2023 5:33 PM To: Denys Vlasenko Cc: busybox@busybox.net ; Christopher Wong Subject: Re: fix large PID overflow their column in top command Hi Denys, Ok. Good to hear. If I understand correctly, will you first review my patch and then give me Morris's account

Re: fix large PID overflow their column in top command

2023-11-10 Thread Matthew Chae
:33 PM To: Denys Vlasenko Cc: busybox@busybox.net ; Christopher Wong Subject: Re: fix large PID overflow their column in top command Hi Denys, Ok. Good to hear. If I understand correctly, will you first review my patch and then give me Morris's account to commit the change? Then, let me send

Re: fix large PID overflow their column in top command

2023-11-08 Thread Matthew Chae
Chae Cc: busybox@busybox.net ; Christopher Wong Subject: Re: fix large PID overflow their column in top command On Wed, Nov 1, 2023 at 10:18 AM Matthew Chae wrote: > > Hi maintainer, > > I'd like to hear your opinion regarding large PID can overflow its column in > top command.

Re: fix large PID overflow their column in top command

2023-11-08 Thread Denys Vlasenko
On Wed, Nov 1, 2023 at 10:18 AM Matthew Chae wrote: > > Hi maintainer, > > I'd like to hear your opinion regarding large PID can overflow its column in > top command. > > The max PID value can have 7 digits as the 4194304. > Busybox v1.36 released a new patch to handle large PID value in top

fix large PID overflow their column in top command

2023-11-01 Thread Matthew Chae
Hi maintainer, I'd like to hear your opinion regarding large PID can overflow its column in top command. The max PID value can have 7 digits as the 4194304. Busybox v1.36 released a new patch to handle large PID value in top command. However, it still causes misalignment between the title and