On Tue, Mar 3, 2015 at 2:13 PM, Laszlo Papp wrote:
> Denys, any feedback about this bugfix?
It is whitespace damaged.
>> +char *cp, *line;
>> +if (!name && member) {
>> +struct group* g;
>> +if ((g = getgrent())) {
Read the file using getgtent?
The rest o
On Thu, Mar 5, 2015 at 2:16 PM, Laszlo Papp wrote:
> This is not at all what I am referring to. I am not talking about how
> it ought to work. I am talking about it should be _documented_ how it
> works.
You proposed to add the following to --help:
+//usage: "\nIf no peer is defined,
On Fri, Mar 13, 2015 at 3:47 PM, Alexis Guilloteau wrote:
> Hi,
>
> When trying to use the ftpd command as this :
>
> ftpd -w ~root/ (or any other directory)
Are you running this from command line?
What's the output?
> I am always send back to the help for this command. ftpd is enabled in
> inet
Applied, thanks!
On Mon, Mar 16, 2015 at 3:14 PM, Ron Yorston wrote:
> A tilde expansion generates a valid pathname. Splitting it using IFS
> either leaves it unchanged or changes it to something unintended.
>
> Example:
>IFS=m HOME=/tmp; printf "%s\n" ~
>
> Based on this commit authored by J
On Wed, Mar 11, 2015 at 2:38 PM, Highland, Glenn
wrote:
> Specifically, we’re acquiring the host name from /etc/hostname and passing
> it to udhcpc with the –H option.
You should be seeing this warning then:
if (opt & (OPT_h|OPT_H)) {
//msg added 2011-11
b
On Thu, Mar 19, 2015 at 8:34 PM, Chen, Simon (N-DCR SYSTEM HOUSE)
wrote:
> Hi,
>
>
>
> I am working on an embedded OS called YOCTO, which apparently includes
> BusyBox into its build. YOCTO is currently running on a target board, and I
> am trying to integrate an AMD Radeon E8860 GPU into it. This
Applied in a slightly different form.
Please try current git. Thanks.
On Thu, Mar 19, 2015 at 4:24 PM, Phil Sutter wrote:
> This is basically a combination of the default (dump mode) and -f
> (follow mode). Specifying -F makes logread first dump the log buffer and
> then immediately start followi
Applied, thanks!
On Thu, Mar 19, 2015 at 2:30 PM, Ari Sundholm wrote:
> Denys, is this patch acceptable? It has 7 iterations of review behind it
> and I find it generally useful. It won't bloat busybox much and is of
> course optional even if mainlined.
>
> On Fri, 2015-03-06 at 18:43 +0200, Ari
gt; Please refer patch against current git attached.
>
> Best Regards, Vladislav Grishenko
>
>> -Original Message-
>> From: busybox-boun...@busybox.net [mailto:busybox-
>> boun...@busybox.net] On Behalf Of Denys Vlasenko
>> Sent: Sunday, July 20, 2014 6:03 PM
>
Fixed, thanks
On Thu, Mar 26, 2015 at 2:03 AM, Martin dørum nygaard
wrote:
> Hey. I just noticed a typo in e2fsck.c, where ext2fs_adjust_ea_refcount has
> been typo'd to ext2fs_adjust_ea_refocunt in an error message:
>
> http://sources.debian.net/src/busybox/1:1.22.0-9/e2fsprogs/old_e2fsprogs/e2f
On Mon, Mar 30, 2015 at 7:31 AM, Rich Felker wrote:
> For details on CVE-2015-1817, see:
> http://www.openwall.com/lists/musl/2015/03/30/1
>
> With musl-linked Busybox installed setuid and ping enabled, exploiting
> this issue is trivial.
>
> While CVE-2015-1817 is certainly musl's fault, there ar
On Wed, Apr 1, 2015 at 4:39 AM, santosh wrote:
> Hello!
>
> I have a link to directory.
>
> /var/test --> /hdd1/test.
>
> /$pwd
> /
> $cd /var/test
> /hdd/test$
>
> The prompt's PS1 w should displays real directory name.
> I like it to display like
>
> /var/test$
>
> Is there anything I can config
On Wed, Apr 1, 2015 at 3:42 PM, santosh wrote:
> On Wed, Apr 1, 2015 at 5:48 PM, Denys Vlasenko
> wrote:
>> On Wed, Apr 1, 2015 at 4:39 AM, santosh wrote:
>>> Hello!
>>>
>>> I have a link to directory.
>>>
>>> /var/test --> /hd
Fixed (hopefully). Can you try current git?
On Tue, Apr 14, 2015 at 9:47 AM, Greg Whiteley wrote:
> Hi All,
>
> I've run into trouble setting CONFIG_EXTRA_LDFLAGS in my config. It is not
> honoured in some of the sub-make files (first failure is in applets). In my
> specific case I'm selecting
Applied, thanks!
On Tue, Apr 14, 2015 at 9:34 AM, Alfonso Ranieri wrote:
> Little bug in get_devname.c that makes swapon by label not working.
>
> --- ./util-linux/volume_id/get_devname.c.orig 2015-04-14
> 09:30:05.0 +0200
> +++ ./util-linux/volume_id/get_devname.c2015-04-14
> 0
Applied, thanks!
On Thu, Apr 9, 2015 at 10:20 AM, Felix Fietkau wrote:
> Regression added in commit 14158b4127dba30466c50147b868a6a89702960b
> "find: add optional support for '-exec ... {} +'"
>
> This commit causes find to exit on the first path argument that was not
> found, which breaks existi
.2/util-linux/ndev.c
--- busybox.1/util-linux/ndev.c1970-01-01 01:00:00.00000 +0100
+++ busybox.2/util-linux/ndev.c2015-04-15 18:27:58.607840699 +0200
@@ -0,0 +1,118 @@
+/*
+ * Copyright 2014 Denys Vlasenko
+ *
+ * Licensed under GPLv2, see file LICENSE in this source tree.
+ */
+
+//conf
On Thu, Mar 26, 2015 at 11:57 AM, Bernhard Reutner-Fischer
wrote:
> UTMP is SVID legacy, UTMPX is mandated by POSIX.
>
> Glibc and uClibc have identical layout of UTMP and UTMPX, both of these
> libc treat _PATH_UTMPX as _PATH_UTMP so from a user-perspective nothing
> changes except the names of t
It fails a case where we have more than one file:
testing "sed -i finishes ranges correctly" \
"cat - >input2; sed /^4/,+2{d} -i input input2; echo \$?; cat
input input2; rm input2" \
"0\n""1\n2\n3\n7\n8\n""1\n2\n7\n8\n" \
"1\n2\n3\n4\n5\n6\n7\n8\n" \
"1\n2\n4\n5\n6
Pushed the fix to git.
Please try.
On Thu, Apr 16, 2015 at 6:07 PM, Denys Vlasenko
wrote:
> It fails a case where we have more than one file:
>
> testing "sed -i finishes ranges correctly" \
> "cat - >input2; sed /^4/,+2{d} -i input input2; echo \$?;
Fixed in git.
On Fri, Apr 17, 2015 at 12:53 PM, Cristian Ionescu-Idbohrn
wrote:
> On Thu, 16 Apr 2015, Eugene Rudoy wrote:
>>
>> @Denys: your commit-message states "bash does that". bash indeed does
>> so for the test-case from your commit, but doesn't do so for Bastians
>> example (tested with b
On Fri, Apr 17, 2015 at 1:58 AM, Felix Fietkau wrote:
> commit 109ee5d33694a03cda3424b4846584250832ba8e
> "ash: make "locak VAR" unset VAR (bash does that)"
>
> This commit introduced a regression where calling local on an already
> local variable unsets it. This does not match bash behavior.
>
>
On Sat, Apr 18, 2015 at 5:05 PM, Floris Bos wrote:
> Hi,
>
> I was wondering if it is possible to configure mdev NOT to add and remove
> device nodes, and let devtmpfs handle that part instead?
examples/mdev.conf says:
# Syntax:
# [-]devicename_regex user:group mode [=path]|[>path]|[!] [@|$|*cmd
On Sun, Apr 19, 2015 at 6:07 PM, Rich Felker wrote:
> On Sun, Apr 19, 2015 at 10:50:25AM +0100, Ron Yorston wrote:
>> The loop_on_EINTR argument to nonblock_immune_read is always set to 1.
>>
>> function old new delta
>> xmalloc_reads
Applied, thanks!
On Sun, Apr 19, 2015 at 11:50 AM, Ron Yorston wrote:
> The loop_on_EINTR argument to nonblock_immune_read is always set to 1.
>
> function old new delta
> xmalloc_reads200 195 -5
>
Works for me now. Thanks!
On Mon, Apr 20, 2015 at 3:24 PM, Bernhard Reutner-Fischer
wrote:
> commit:
> http://git.busybox.net/busybox/commit/?id=7d86384b246434e7252f7f409a7aa9efeacb
> branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master
>
> Fixes compilation against uClibc-0.9
Works for me. Thanks!
On Mon, Apr 20, 2015 at 3:49 PM, Bernhard Reutner-Fischer
wrote:
> On 16 April 2015 at 22:37, Bernhard Reutner-Fischer
> wrote:
>> On April 16, 2015 1:08:06 PM GMT+02:00, Denys Vlasenko
>> wrote:
>>>On Thu, Mar 26, 2015 at 11:57 AM, Bernhar
On Mon, Apr 20, 2015 at 2:35 PM, walter harms wrote:
> just for my curiosity:
> if only ash uses this function should why it is in libbb ?
It was used by hush too.
I envision other cases where I'd want to use it.
___
busybox mailing list
busybox@busybox
Let me know how I can test this on a x86 machine.
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
Applied, thanks!
On Sat, Apr 25, 2015 at 9:29 PM, Matt Whitlock
wrote:
> ---
> include/platform.h | 7 +++
> libbb/platform.c | 17 +
> 2 files changed, 24 insertions(+)
>
> diff --git a/include/platform.h b/include/platform.h
> index 8914d4a..8896a6b 100644
> --- a/includ
Applied, thanks
On Sat, Apr 25, 2015 at 12:48 AM, Matt Whitlock
wrote:
> ---
> libbb/missing_syscalls.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/libbb/missing_syscalls.c b/libbb/missing_syscalls.c
> index c768f11..1e2507d 100644
> --- a/libbb/missing_syscalls.c
> +++ b/libbb
Applied, thanks!
On Fri, Apr 24, 2015 at 7:41 PM, Aaro Koskinen wrote:
> Add support for compression levels 4-9.
>
> function old new delta
> gzip_main191 306+115
> usage_messages
Applied, thanks!
On Sat, May 2, 2015 at 9:36 PM, Andrew Fuller wrote:
> Currently basic undo functionality with the 'u' key depends on
> FEATURE_VI_YANKMARK. These two features are separate, so we can remove this
> dependency.
>
> Signed-off-by: Andrew Fuller
> ---
> editors/vi.c | 10 +
Applied patch #2 (the part that pertains to open_transformer.c), thanks.
Patch #1 does not apply.
On Thu, Apr 23, 2015 at 9:03 PM, Thiago Jung Bauermann
wrote:
> Hello,
>
>
>
> I set out to fix the following bug:
>
>
>
> $ ./busybox zcat /tmp/a.Z
>
> zcat: no gzip/bzip2/xz magic
>
>
>
> In the p
On Tue, Apr 28, 2015 at 8:36 AM, wrote:
> Whose policy is that which caters to a certain compiler option's inept
> warnings? "What are the goals of Busybox?"
> (http://www.busybox.net/FAQ.html#goals) says: "We also want to have the
> simplest and cleanest implementation we can manage..." - I w
On Sat, Apr 25, 2015 at 11:33 PM, Matt Whitlock
wrote:
> On Saturday, 25 April 2015, at 7:17 pm, Denys Vlasenko wrote:
>> Let me know how I can test this on a x86 machine.
>
> Bionic doesn't really support vanilla Linux.
Do you really build your busybox on your phone?
I gu
Applied, thanks!
On Wed, Apr 29, 2015 at 4:45 AM, Matt Whitlock
wrote:
> (The attached patch subsumes the previous "Bionic lacks mempcpy; enable
> existing workaround".)
>
> Bionic has been growing new features over the years, so platform.h should
> test the __ANDROID_API__ macro to determine
The process is exiting after this, and all files automatically close at exit.
On Fri, May 8, 2015 at 5:49 AM, Maninder Singh wrote:
>
> EP-E9D7571734A347E2ADA07C4134AB97EA
>
> Hi,
>
> Package: busybox
> Version: v1.24.0.git
> Severity: wishlist
>
> This patch fixes a samll resource leak- Missing
On Tue, May 5, 2015 at 2:55 PM, Joakim Tjernlund
wrote:
> Ping ? I am the only one seeing this?
./usr/lib/locale/locale-archive
is stored as a sparse file (tar header type 'S')
https://www.gnu.org/software/tar/manual/html_section/tar_92.html
37a90600 2e 2f 75 73 72 2f 6c 69 62 2f 6c 6f 63 6
Applied, thanks!
On Tue, Apr 21, 2015 at 2:29 PM, Bartosz Golaszewski
wrote:
> Trying to access /dev/i2c/* on every error after opening /dev/i2c-* can
> mislead users who e.g. don't have root access. Instead of bailing-out
> with "permission denied" we currently print "no such file or directory".
This code is used by build system. realloc failure would result in
make failure, which is a correct behavior on ENOMEM.
On Tue, May 12, 2015 at 12:27 PM, Maninder Singh
wrote:
> EP-E9D7571734A347E2ADA07C4134AB97EA
>
> Package: busybox
> Version: v1.24.0.git
> Severity: wishlist
>
> Subject: [PATC
Applied, thanks!
On Tue, May 12, 2015 at 8:56 AM, Daniel Thompson
wrote:
> Linux recently gained a new config option, CONFIG_MULTIUSER, that makes
> support for non-root users optional. This results in a number of syscalls
> being disabled: setuid, setregid, setgid, setreuid, setresuid, getresuid
Is this behavior compatible with standard coreutils?
On Mon, May 11, 2015 at 4:00 PM, Matt Weber
wrote:
> Fixes the case of using mkdir in inittab where a system might boot
> with selinux disable during testing and still needs the folders created
> by this command for ram mounts, etc before a mou
Applied, thanks!
On Sun, Apr 26, 2015 at 11:32 PM, Eugene Rudoy wrote:
> fixes segfault introduced in 0a0acb55db8d7c4dec445573f1b0528d126b9e1f with
> functions using "local -".
> test-case: f() { local -; local x; }; f
>
> note: with this change applied multiple 'local -'s still cause multiple
I don't think this optimization is worth spending extra code on.
On Sun, Apr 26, 2015 at 11:32 PM, Eugene Rudoy wrote:
> follow-up of 0a0acb55db8d7c4dec445573f1b0528d126b9e1f
>
> not sure if the code is worth adding it to the repository, multiple 'local
> -'s are very very unlikely
>
> Signed-of
On Fri, May 15, 2015 at 12:30 PM, Ron Yorston wrote:
> The following patch series is an attempt to fix a report that this
> doesn't work in BusyBox ash:
>
>test='/dir/file.ext'
>echo "${test##*[/|\\]}"
>test='\dir\file.ext'
>echo "${test##*[/|\\]}"
>
> In both cases the result shou
I need to know what your [up] and [down] keys generate.
Please do this:
$ hexdump -vC
and post the result. For example, when I do it, I see this in my xterm:
$ hexdump -vC
^[[A 1b 5b 41 |.[A|
0003
$
Do the same for down arrow key too.
Thanks, applied.
On Sun, May 24, 2015 at 1:17 PM, bifferos wrote:
>
>
> bash-4.2$ ./dc p
> 2.122e-313
> (on my x86 machine)
>
>
> Attempting to print the last value off a non-existent stack should probably
> error, just like a pop().
>
>
>
> My trivial fix is here:
> https://github.com/bifferos/
Your config works for me with current busybox git.
On Tue, May 19, 2015 at 11:01 PM, Matt Minga wrote:
> I checked out the 1_22_stable repository and used a configuration file
> linked to me in hopes of recreating the busybox configuration shipped with a
> version of the SDK I am using.
>
> I am
Applied all. Thanks.
On Thu, May 21, 2015 at 5:58 AM, Maninder Singh wrote:
> EP-E9D7571734A347E2ADA07C4134AB97EA
> Hi,
>
> Subject: [PATCH 11/11] typo fix
>
> implemenation --> implementation
>
> Signed-off-by: Maninder Singh
> Reviewed-by: Akhilesh Kumar
> ---
> e2fsprogs/old_e2fsprogs/blkid
On Mon, May 25, 2015 at 11:22 AM, Raghavan K wrote:
> Hi Denys/Jimux,
>
> I am using "Tera Term"
>
> The UP arrow key result:
> # hexdump -vC
> ¶A 1b b6 41 |..A|
> 0003
This does not correspond to any type of "standard"
ESC sequences I can fin
On Mon, May 18, 2015 at 4:39 PM, Ari Sundholm wrote:
> From: Ari Sundholm
>
> Additionally, open(2) failures do not make the program die immediately.
> This makes the behavior of the program match coreutils more closely.
>
> bloat-o-meter:
> function ol
Applied, thanks!
On Thu, Jun 4, 2015 at 6:03 AM, Junling Zheng wrote:
> Commit 16ca379b fixed the help text of chown incompletely.
> This patch fixes the rest.
>
> Signed-off-by: Junling Zheng
> ---
> coreutils/chown.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cor
Applied all five patches, thanks!
On Fri, Jun 5, 2015 at 10:47 AM, Bartosz Golaszewski
wrote:
> Since there are no more statements in the if block after the while loop
> in list_i2c_busses_and_exit(), there's no need for a goto.
>
> Signed-off-by: Bartosz Golaszewski
> ---
> NOTES: fixed two typ
Applied, thanks!
On Mon, Jun 1, 2015 at 12:38 PM, Maninder Singh wrote:
> No need of explicit NULL check before free.
>
> Signed-off-by: Maninder Singh
> Signed-off-by: Akhilesh Kumar
> ---
> e2fsprogs/old_e2fsprogs/blkid/dev.c |3 +--
> e2fsprogs/old_e2fsprogs/fsck.c | 12 -
Applied, thanks!
On Mon, Jun 1, 2015 at 12:40 PM, Maninder Singh wrote:
> Subject: [PATCH 1/1] fix whitespaces
>
> reported by script :- scripts/fix_ws.sh
>
> Signed-off-by: Maninder Singh
> ---
> coreutils/shuf.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/co
Applied, thanks.
On Tue, Jun 23, 2015 at 6:19 PM, Michael Tokarev wrote:
> 23.06.2015 18:44, Bernhard Reutner-Fischer wrote:
>> On June 23, 2015 3:27:54 PM GMT+02:00, Michael Tokarev
>> wrote:
>>> Ping?
>>>
>>> 20.05.2015 16:27, Michael Tokarev wrote:
Signed-off-by: Michael Tokarev
-
Rob Landley has an opposite view: preprocessor #if's are evil.
I agree with him that they do tend to obfuscate.
On Sun, Jun 28, 2015 at 9:44 AM, Michael Tokarev wrote:
> [Rehashing a thread from 3 years ago]
>
> 28.01.2013 11:48, Denys Vlasenko wrote:
>> On Monday 2
Applied, thanks!
On Sun, Jun 28, 2015 at 10:55 PM, Thomas Petazzoni
wrote:
> Hello,
>
> There has been no feedback to the below patch. We would like to support
> this feature in Buildroot, but we don't like carrying significant
> feature patches without knowing upstream's decision.
>
> Would the
Applied, thanks!
On Wed, Jun 10, 2015 at 5:47 AM, Maninder Singh wrote:
> From: Maninder Singh
>
> This patch removes stray empty line from busybox code
> reported by script find_stray_empty_lines
>
> Signed-off-by: Maninder Singh
> Signed-off-by: Akhilesh Kumar
> ---
> archival/cpio.c
On Thu, Jul 2, 2015 at 10:01 AM, Ron Yorston wrote:
> Rich Felker wrote:
>>In general alloca is unsafe. It's not obvious to me what the code here
>>is doing, so I can't tell for sure if it's safe or not, but I think
>>this needs a strong justification of safety before being acceptable.
>
> It's a
Applied, thanks.
On Wed, Jul 1, 2015 at 5:46 PM, Ron Yorston wrote:
> Now that the only thing protected by setjmp/longjmp is the saved string,
> we can allocate it on the stack to get rid of the jump.
>
> Based on commit bd35d8e from git://git.kernel.org/pub/scm/utils/dash/dash.git
> by Herbert X
Applied, thanks!
On Sun, Jul 19, 2015 at 12:12 PM, Ron Yorston wrote:
> The -S flag, to cause long lines to be truncated, was enabled by
> FEATURE_LESS_DASHCMD. This is non-obvious and -S is useful even
> if the '-' command isn't enabled.
>
> function
Applied, thanks!
On Sat, Jul 18, 2015 at 5:20 PM, Ron Yorston wrote:
> Line numbers are displayed incorrectly on lines that have a search
> pattern highlighted. The problem can be fixed by moving the call to
> lineno_str in print_found above the while loop that alters the value
> of the line poi
Applied, thanks!
On Sun, Jul 19, 2015 at 10:41 PM, Ron Yorston wrote:
> Lines are rewrapped when the terminal width changes or line numbers
> are enabled/disabled. The current calculation always adds eight to
> the line length for a tab whereas it should only add enough to move
> to the next tab
Applied, thanks!
On Thu, Jul 16, 2015 at 11:51 AM, Ron Yorston wrote:
> Introduce a library routine to package the idiom:
>
>p = xmalloc(b, n);
>memcpy(p, b, n);
>
> and use it where possible. The example in traceroute used xzalloc
> but it didn't need to.
>
> function
I would rather keep it.
What is the "most horrible" thing which can happen here?
On Thu, Jul 16, 2015 at 11:50 AM, Ron Yorston wrote:
> This reverts commit 072fc60f29ee3a4ff38f095a9ef149b2e820c8c0.
> Use of alloca is considered unsafe.
>
> Signed-off-by: Ron Yorston
> ---
> shell/ash.c | 36 ++
It was kept around in case the decision to remove
e2fsck and other would prove to be a mistake.
Evidently, we somehow surviving without it.
I'm deleting it in git.
On Thu, Jul 16, 2015 at 3:02 PM, Ron Yorston wrote:
> Is there any reason to keep the old_e2fsprogs directory around?
>
> Ron
> ___
I reworked it so that these additions are optional,
and applied the result.
Thanks!
On Mon, Jul 20, 2015 at 6:55 PM, Ari Sundholm wrote:
> From: Ari Sundholm
>
> This brings busybox in line with modern coreutils sync.
>
> function old new delta
Applied, thanks!
I added code to only do a reading pass if the file is a regular file:
think about "less /dev/SOMETHING".
On Tue, Jul 21, 2015 at 5:18 PM, Ron Yorston wrote:
> walter harms wrote:
>>> +while ((len=safe_read(fd, buf, 4096)) > 0) {
>>
>>sorry for being late of that ..
Applied, thanks!
On Tue, Jul 28, 2015 at 7:35 AM, Arthur Gautier wrote:
> While RFC1035 recommends a label not to start with a number, there is
> actually no such limitation in dns. One may buy a domain name like
> 0x1.net and use it.
>
> This commit remove this check and allow a user to use such
Applied, thanks!
On Mon, Jul 27, 2015 at 9:59 AM, Linus Walleij wrote:
> In commit b5c7220e7b2b6611fe5beca494c67bfe51fcfafb
> "fbset: respect rgba configuration lines in fb.modes"
> I somehow managed to swap the offset/length markers around.
> The man page for fb.modes says it should be offset/le
Applied, thanks!
On Thu, Jul 30, 2015 at 5:33 AM, Mike Frysinger wrote:
> Currently when you disable fancy echo, escape sequences are hardcoded
> enabled (e.g. as if you used `echo -e` all the time). The opposite
> behavior is more desirable (always disable -e support) because:
> * This seems to
Applied, thanks!
On Tue, Jul 21, 2015 at 9:12 PM, Ron Yorston wrote:
> Signed-off-by: Ron Yorston
> ---
> miscutils/less.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/miscutils/less.c b/miscutils/less.c
> index 90c1038..d6c921d1 100644
> --- a/miscutils/less.c
> ++
Applied all five patches, thanks!
Applied a patch on top of them which uses fstat (stat+open are racy),
uses it only when we actually going to count lines,
and (try to) handle regular files even on stdin ("less wrote:
> When read_lines tests whether a character will fit on the current
> line it c
Applied both patches, thanks!
On Thu, Jul 30, 2015 at 10:13 PM, Aaro Koskinen wrote:
> Add testcases for -B and single line changes.
>
> Signed-off-by: Aaro Koskinen
> ---
> testsuite/diff.tests | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/testsuite/diff.tests b/testsu
Applied, thanks!
On Fri, Jul 31, 2015 at 6:33 PM, Ron Yorston wrote:
> Test explicitly for REOPEN flags: update_num_lines is called
> unconditionally so (num_lines != NOT_REGULAR_FILE) is also true when
> num_lines contains a valid number of lines.
>
> The call to fstat doesn't need to be in #if
On Mon, Jul 20, 2015 at 6:02 PM, ANTOINE ROUQUETTE
wrote:
> Hi everyone,
>
> My question is has followed :
>
> when I use chpasswd command, the option -e allow me to supply password in
> encrypted form. How do I know which encryption form I should use for this
> command?
You can use any encryptio
On Wed, Jul 15, 2015 at 11:10 PM, Gregory Fong wrote:
> From: Simon Edlund
>
> When mdev -s traverses the /sys directory looking for "dev" files, it
> starts with the block devices under /sys/block, and will find the "dev"
> file through the symlink, and create a block device node. In the next
>
Applied, thanks!
On Sun, Jul 12, 2015 at 5:06 PM, Ron Yorston wrote:
> A mailing list thread in September 2013 discussed changing the string
> returned by the non-POSIX 'uname -o' option. Nothing ever came of this
> because there was no agreement as to what the string should be.
>
> Make the st
On Tue, Jul 21, 2015 at 2:03 PM, dbextern wrote:
> Hello!
>
> For our link local functionality I'm using udhcpc together with zcip out of
> busybox on a Blackfin BF-537 CPU without MMU.
>
> The base functionality is there.
> But when I connect two networks with stable IP addresses, and both netwo
On Tue, Aug 4, 2015 at 12:00 PM, Sebastian Fett wrote:
>> On Tue, Jul 21, 2015 at 2:03 PM, dbextern wrote:
>>> For our link local functionality I'm using udhcpc together with zcip out
>>> of busybox on a Blackfin BF-537 CPU without MMU.
>>>
>>> The base functionality is there.
>>> But when I conn
Applied, thanks!
On Sun, Jul 12, 2015 at 10:19 PM, Ron Yorston wrote:
> Signed-off-by: Ron Yorston
> ---
> networking/ipcalc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/networking/ipcalc.c b/networking/ipcalc.c
> index 3c8b8bf..f4bacd7 100644
> --- a/networking/
Applied, thanks!
On Tue, Aug 4, 2015 at 6:10 PM, Ron Yorston wrote:
> Commit 1ecb996 attempted to make read_lines() use the last column of
> the terminal (as re_wrap() did). There were two problems with this:
>
> - The size of the buffer allocated for lines wasn't increased to allow
> for the
On Tue, Aug 4, 2015 at 12:04 PM, Bartosz Golaszewski
wrote:
> Add -x option which allows to specify the exit status of PROG for which
> inotifyd should exit.
>
> An example use case for this change is writing parallel system startup
> scripts with busybox' runit: inotifyd can be used to wait for a
Applied, thanks
On Fri, Aug 14, 2015 at 8:50 AM, Bartosz Golaszewski
wrote:
> Static build with CONFIG_PAM fails on Debian Jessie due to undefined
> references to libdl and libaudit.
>
> Static build without pam, but with libcrypt required fails as well due
> to undefined references to libpthread
Applied, thanks
On Thu, Aug 13, 2015 at 3:57 PM, Bartosz Golaszewski
wrote:
> In the initial submission struct bbunit_listelem was manipulated by
> custom list functions implemented in bbunit.c. Since the tests are now
> added to the list by llist_add_to_end(), which allocates the llist_t
> objec
Help text needed more fixes than this one.
I included your fix into a more extensive change. Thanks!
On Sun, Aug 23, 2015 at 10:30 PM, Alex wrote:
> Ping...
>
> -- Forwarded message --
> From: Alex Dowad
> Date: Fri, Aug 7, 2015 at 10:31 AM
> Subject: [PATCH v2] traceroute: add
Please check it now, it should be fixed.
On Mon, Aug 24, 2015 at 7:16 PM, Xabier Oneca -- xOneca
wrote:
> Hello Denys,
>
> 2015-08-24 18:57 GMT+02:00 Denys Vlasenko :
>> Help text needed more fixes than this one.
>>
>> I included your fix into a more extensive cha
Applied, thanks!
On Mon, Aug 24, 2015 at 7:01 PM, Alex wrote:
> Sending this one again...
>
> -- Forwarded message --
> From: Alex Dowad
> Date: Fri, Aug 7, 2015 at 11:53 AM
> Subject: [PATCH] ifupdown: 'prio' should have been 'metric' in
> static_up and static_up6
> To: busybox@
Applied, thanks!
On Mon, Aug 24, 2015 at 3:54 PM, Peter Korsgaard wrote:
> Similar to the "big" util-linux version. For !DMESG_PRETTY, the option is
> accepted
> (but ignored) as well, for compatibility reasons.
>
> Signed-off-by: Peter Korsgaard
> ---
> util-linux/dmesg.c | 8 +---
> 1 fi
Applied with small changes, thanks!
On Mon, Aug 24, 2015 at 8:50 PM, Sören Tempel wrote:
> Hi,
>
> I don't know if you are interested at all in this, but I wrote a little
> patch which modifies login(1) to ensure that the message of the day
> isn't printed if a file called '.hushlogin' exists in
On Tue, Aug 25, 2015 at 1:09 PM, Bartosz Golaszewski
wrote:
> While working on an embedded system running several big services, X-org,
> fluxbox, Qt5 etc. where the boot-time was awful, it turned out that the
> readahead implementation from systemd (the one that was nuked in 2014)
> improves the t
On Tue, Aug 25, 2015 at 1:09 PM, Bartosz Golaszewski
wrote:
> Add a wrapper around skip_whitespace() which evaluates to true if given
> string contains only whitespace characters.
>
> Signed-off-by: Bartosz Golaszewski
> ---
> include/libbb.h | 2 ++
> libbb/skip_whitespace.c | 17 +
Applied, thanks!
On Tue, Aug 25, 2015 at 1:09 PM, Bartosz Golaszewski
wrote:
> Test corner cases too like looking for an empty prefix etc.
>
> Signed-off-by: Bartosz Golaszewski
> ---
> libbb/compare_string_array.c | 19 +++
> 1 file changed, 19 insertions(+)
>
> diff --git a/li
Applied, thanks!
On Tue, Aug 25, 2015 at 1:10 PM, Bartosz Golaszewski
wrote:
> Signed-off-by: Bartosz Golaszewski
> ---
> libbb/compare_string_array.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/libbb/compare_string_array.c b/libbb/compare_string_array.c
> index eb754af..901e6
No, it's my fault.
Without optimization, this code
sockopt = offsetof(struct icmp6_hdr, icmp6_cksum);
if (sockopt != 2)
BUG_bad_offsetof_icmp6_cksum();
will not optimize out the comparison. So the generated code
will contain the call, even though it will never exec
Applied. However, it has no users...
On Tue, Aug 25, 2015 at 1:10 PM, Bartosz Golaszewski
wrote:
> This function checks if given key can be found at the end of the string.
>
> Signed-off-by: Bartosz Golaszewski
> ---
> include/libbb.h | 1 +
> libbb/compare_string_array.c | 32 +++
Fixed in git
On Tue, Aug 25, 2015 at 8:16 PM, Bartosz Gołaszewski
wrote:
> 2015-08-25 19:29 GMT+02:00 Xabier Oneca -- xOneca :
>> Hello Bartosz,
>>
>> 2015-08-25 13:10 GMT+02:00 Bartosz Golaszewski :
>>> +/*
>>> + * Return NULL if string is not suffixed with key. Return pointer to the
>>> + * b
On Fri, Aug 28, 2015 at 11:01 PM, Aaro Koskinen wrote:
> The following commit:
>
> commit 549deab5abd59c1ab752754170f69aa2248e72c9
> Author: Ron Yorston
> Date: Mon May 18 09:57:51 2015 +0200
>
> ash: move parse-time quote flag detection to run-time
>
> intro
401 - 500 of 6237 matches
Mail list logo
