Re: mixer applet.

2014-07-05 Thread tito
understand why. Even with the list of mixers it should only be ~500 bytes. If anyone has any suggestions I can try to fix that. regards, Biff. Hi, just for fun some size reduction. Tested it a little bit and it seems to work. Ciao, Tito scripts/bloat-o-meter busybox_old busybox_unstripped

Re: Deluser: deleting the home folder

2014-07-03 Thread tito
remove a normal user from the system example: deluser mike --remove-home remove the users home directory and mail spool userdel --help Usage: userdel [options] LOGIN Options: -r, --remove remove home directory and mail spool Ciao, Tito

Re: Deluser: deleting the home folder

2014-07-03 Thread tito
On Thursday 03 July 2014 14:51:11 you wrote: On Thu, Jul 3, 2014 at 12:59 PM, tito farmat...@tiscali.it wrote: On Thursday 03 July 2014 13:03:46 Laszlo Papp wrote: On Thu, Jul 3, 2014 at 11:10 AM, Laszlo Papp lp...@kde.org wrote: commit 761fd153e340a14abccc0af89f2f6617faf2077f

Re: Deluser: deleting the home folder

2014-07-03 Thread tito
On Thursday 03 July 2014 22:38:23 you wrote: On Thu, Jul 3, 2014 at 8:31 PM, tito farmat...@tiscali.it wrote: On Thursday 03 July 2014 14:51:11 you wrote: On Thu, Jul 3, 2014 at 12:59 PM, tito farmat...@tiscali.it wrote: On Thursday 03 July 2014 13:03:46 Laszlo Papp wrote

Re: [Question] Questions about the BusyBox specification.

2014-06-26 Thread tito
. with telnet or SSH) Telnet yes. SSH only if you install a separate SSH server (e.g. Dropbear) I apologize for questions, that may have already been answered. Thanks for your help. Kind Regards Frank Ihle Hope this helps. Ciao, Tito ___ busybox mailing

Re: [PATCH] Add coreutils/unlink.c

2014-06-22 Thread tito
delete '%s', argv[0]); should be: bb_perror_msg_and_die(can't delete '%s', argv[1]); Eventually instead of getopt32 you can use: if (argc != 2) bb_show_usage(); Hope this helps. Ciao, Tito ___ busybox mailing list busybox@busybox.net http

Re: [PATCH] bug in coreutils/unlink.c

2014-06-22 Thread tito
On Sunday 22 June 2014 20:44:48 Denys Vlasenko wrote: On Sunday 22 June 2014 16:45, Isaac Dunham wrote: Attaching a revised patch, based on Tito's suggestions. On Sun, Jun 22, 2014 at 08:11:25AM +0200, tito wrote: On Saturday 21 June 2014 23:01:10 Isaac Dunham wrote: Here's

Re: [PATCH] bug in coreutils/unlink.c

2014-06-22 Thread tito
On Sunday 22 June 2014 22:43:16 tito wrote: On Sunday 22 June 2014 20:44:48 Denys Vlasenko wrote: On Sunday 22 June 2014 16:45, Isaac Dunham wrote: Attaching a revised patch, based on Tito's suggestions. On Sun, Jun 22, 2014 at 08:11:25AM +0200, tito wrote: On Saturday 21 June

Re: [PATCH] Verbose switch for cp, install, mkdir, mv, rm, and mkdir commands

2014-05-15 Thread Tito
on CONFIG_DESKTOP or another new config option so that it is optimized away by the compiler if the flag is not set, e.g.: if (ENABLE_DESKTOP (flags FILEUTILS_VERBOSE)) { printf(removed directory: `%s'\n, path); } Ciao, Tito

Re: Changing the user name

2014-05-14 Thread Tito
the same time you change a username file corruption could be possible. Ciao, Tito ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: Changing the user name

2014-05-14 Thread Tito
On Wednesday 14 May 2014 12:33:45 you wrote: On Tue, May 13, 2014 at 8:27 PM, Tito farmat...@tiscali.it wrote: On Tuesday 13 May 2014 19:01:41 Laszlo Papp wrote: Hi, is this possible? I am looking for something like usermod -l on desktop. This is actually not supported by busybox

Re: Changing the user name

2014-05-14 Thread Tito
On Wednesday 14 May 2014 15:10:12 you wrote: On Wed, May 14, 2014 at 1:38 PM, Tito farmat...@tiscali.it wrote: On Wednesday 14 May 2014 12:33:45 you wrote: On Tue, May 13, 2014 at 8:27 PM, Tito farmat...@tiscali.it wrote: On Tuesday 13 May 2014 19:01:41 Laszlo Papp wrote: Hi

Re: Changing the user name

2014-05-13 Thread Tito
, I have to look into the get/setpwent syscalls? Yes. You can take a look at libbb/update_passwd.c for inspiration and you need to be root to perform the user name change. Cheers, L. Ciao, Tito ___ busybox mailing list busybox@busybox.net http

Re: [PATCH] which code cleanup

2014-05-03 Thread Tito
On Saturday 03 May 2014 16:38:06 you wrote: On Friday 02 May 2014 21:31, Tito wrote: On Friday 02 May 2014 15:42:40 you wrote: Tito wrote: That's it about PATCH 1. There is still PATCH 2 Your patch searches in PATH for dir/file if dir/file is not executable. The normal

Re: [PATCH 0/2] fix find_execable function and which code cleanup

2014-05-02 Thread Tito
On Friday 02 May 2014 11:19:01 you wrote: Tito wrote: On Thursday 01 May 2014 21:30:25 Ralf Friedl wrote: Tito wrote: while trying to cleanup the debianutils/which command I've spotted a minor glitch in bb's find_execable function as it is not able to handle zero lenght prefixes

Re: [PATCH] which code cleanup

2014-05-02 Thread Tito
On Friday 02 May 2014 15:42:40 you wrote: Tito wrote: That's it about PATCH 1. There is still PATCH 2 Your patch searches in PATH for dir/file if dir/file is not executable. The normal behavior is to not search PATH if the argument contains a '/'. Fixed. Thanks! If you rewrite

[PATCH 0/2] fix find_execable function and which code cleanup

2014-05-01 Thread Tito
; } free(path); } status |= (!found); } while (*(++argv) != NULL); fflush_stdout_and_exit(status); } Hints, critics and improvements are welcome, Ciao, Tito P.S.: the patches could be applied indipendently

Re: [PATCH 0/2] fix find_execable function and which code cleanup

2014-05-01 Thread Tito
On Thursday 01 May 2014 21:30:25 Ralf Friedl wrote: Tito wrote: while trying to cleanup the debianutils/which command I've spotted a minor glitch in bb's find_execable function as it is not able to handle zero lenght prefixes in the PATH variable: http://pubs.opengroup.org/onlinepubs

Re: [PATCH] Add Linux gpio sysfs applets

2014-04-29 Thread Tito
but there could be more. I suspect that the RidgeRun license could a problem for the inclusion of this code in busybox and I wonder if it wouldn't be a cleaner solution to rewrite the app as it is rather simple stuff. Of course the busybox maintainer will decide on this issue. Hope it helps. Ciao, Tito

[PATCH] memset 0 in obscure is optimized away by compiler

2014-04-16 Thread Tito
happens in busybox but I suspect it so more experienced programmers should take a look at it. Ciao, Tito Use nuke_str as memeset is optimized away by compiler. Signed-off-by: Tito Ragusa farmat...@tiscali.it --- libbb/obscure.c.orig 2013-06-02 13:56:34.0 +0200 +++ libbb/obscure.c 2014-04-16

Re: [PATCH] memset 0 in obscure is optimized away by compiler

2014-04-16 Thread Tito
On Wednesday 16 April 2014 19:14:05 you wrote: Hi Tito ! I've tried to find out if memset is really optimized away in this case with some test code that I've compiled with : What is wrong with optimization of code, e.g. replacing call to memset by a quick loop which does same thing even

Re: [PATCH] memset 0 in obscure is optimized away by compiler

2014-04-16 Thread Tito
, secure operations, etc */ } memset(pwd, 0, sizeof(pwd)); if (pwd[0] != '\0') { printf(memory not zeroed); exit(1) } } or would the compiler see that we read just first char and zero only that and force us to check every char of pwd? Ciao, Tito -Original Message

[PATCH] fix exit codes on ignore errors with -a

2014-03-31 Thread Tito
Hi, this patch fixes a minor error on exit codes in swapon/swapoff when the -a switch is set: real swapon/swapoff -a returns 0 on ignored errors. Ciao, Tito --- util-linux/swaponoff.c.orig 2014-03-31 21:59:08.0 +0200 +++ util-linux/swaponoff.c 2014-03-31 21:59:50.490560746 +0200

Re:[PATCH v1] Size reduction, cleanup, fixes, improvements for swapon/swapoff

2014-03-31 Thread Tito
* Tito farmatito at tiscali.it [31.03.2014 09:53]: So now swapoff first cycles through /proc/swaps and then through fstab to swapoff all devices. Does it make sense to swapoff devices which are not known via /proc/swaps? Or is it just if /proc is missing? nevertheless: thanks for submission

[PATCH v1] Size reduction, cleanup, fixes, improvements for swapon/swapoff

2014-03-30 Thread Tito
, Tito Swapon/swapoff fixes, enhacements and size reduction: 1) real swapon/swapoff handles also devices on the commandline with -a; 2) xstat(device) in swap_enable_disable aborts on error when cycling through fstab so some devices are not handled; 3) duplicated code

Re: [PATCH] add discard option -d to swapon

2014-03-24 Thread Tito
On Monday 24 March 2014 01:09:01 you wrote: On Monday, 24 March 2014, at 12:06 am, Tito wrote: On Sunday 23 March 2014 23:09:59 you wrote: This is still going to create a hell when adding the discard flag. Consider what will happen in the enum: if DISCARD is enabled but PRI

Re: [PATCH v2] Ntpd config file support

2014-03-23 Thread Tito
, Tito ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: [PATCH] add discard option -d to swapon

2014-03-23 Thread Tito
will find a alternative patch to your patches #1 and #2 that includes your fixes and improvements and reworks swap_on_off_main to allow you to implement patch #3 without creating a #ifdef hell. I hope that the code is also easier readable than the original unpatched version. Ciao, Tito --- util

Re: [PATCH] add discard option -d to swapon

2014-03-23 Thread Tito
On Sunday 23 March 2014 23:09:59 you wrote: On Sunday, 23 March 2014, at 8:29 pm, Tito wrote: On Sunday 23 March 2014 00:33:04 Matt Whitlock wrote: Attached are a series of three patches affecting swaponoff. Hi, attached you will find a alternative patch to your patches #1 and #2

Re: [PATCH] correct_password: Handle NULL from crypt

2014-02-04 Thread Tito
crypt returned an empty string like that. Though that will throw a warning about assigning a const char to char, something similar would work. - Lauri Hi, still i think it should be better to emit a error msg when crypt fails or you will never notice. Ciao, Tito

Re: [PATCH] correct_password: Handle NULL from crypt

2014-02-03 Thread Tito
(colon_after_user + 1, passwd); } goto end_check_passwd; } Hope this helps. Ciao, Tito ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: [PATCH] sendmail: automatically determine sender if not specified

2014-01-22 Thread Tito
On Wednesday 22 January 2014 17:38:52 Kaarle Ritvanen wrote: opt_from = xasprintf(%s@%s, G.user, xgethostbyname(host)-h_name); Hi, the () in this line look suspicious to me. Ciao, Tito ___ busybox mailing list busybox@busybox.net http

Re: [PATCHv2] adduser addgroup use LAST_ID

2014-01-13 Thread Tito
Hi, Denys maybe this patch slipped through ? Ciao, Tito On Sunday 22 December 2013 15:22:41 Tito wrote: On Sunday 22 December 2013 12:05:04 you wrote: Hi Tito ! Wew could also add a config option as we already have (100) First valid system uid or gid for adduser and addgroup

Re: [PATCH] ping: try SOCK_DGRAM if no root privileges

2014-01-09 Thread Tito
is the difference? the openwall distribution owl, from which the kernel patch originated, has zero suid binaries. Just out of curiosity how do they manage shadow passwords? Ciao, Tito i think if a busybox specialist reshapes the POC code slightly (for example by putting the bind code to get

Re: [PATCH] ping: try SOCK_DGRAM if no root privileges

2014-01-09 Thread Tito
, execs into /bin/busybox `basename $0` $@. Make that separate binary setuid root. Hi, basename is a link to which one of the busybox binaries? Ciao, Tito * the utilities that need to be setuid root are symlinks to that binary, the other ones are direct symlinks to busybox. This solution

[PATCH 4/4] I2C bus fake enumeration applet lsi2cHi,

2014-01-02 Thread Tito
Hi, inline some hints for size reduction (untested). Ciao, Tito From: Alison Chaiken alison_chai...@mentor.com Signed-off-by: Alison Chaiken alison_chai...@mentor.com --- util-linux/lsi2c.c | 84 1 file changed, 84 insertions(+) create

Re: [PATCHv2] adduser addgroup use LAST_ID (Was: adduser remove some code)

2013-12-22 Thread Tito
On Sunday 22 December 2013 12:05:04 you wrote: Hi Tito ! Wew could also add a config option as we already have (100) First valid system uid or gid for adduser and addgroup (999) Last valid system uid or gid for adduser and addgroup + (6) Last valid uid for adduser and addgroup

Re: [PATCH] adduser addgroup use LAST_ID (Was: adduser remove some code)

2013-12-21 Thread Tito
On Saturday 21 December 2013 17:22:36 you wrote: Hi Tito ! So I would simplify the code like: opt_complementary = -1:?2:SD:u+; opts = getopt32(argv, h:g:s:G:DSHu:, pw.pw_dir, pw.pw_gecos, pw.pw_shell, usegroup, pw.pw_uid); IMO you miss one fact. The field pw.pw_uid

Re: [PATCH] do not use gethostbyname() for hostname -s

2013-12-09 Thread Tito
busybox's hostname and real hostname pops up if we change hostname on the fly: su hostname prova debian:/home/tito# hostname prova debian:/home/tito# hostname -s prova debian:/home/tito# ./busybox hostname prova debian:/home/tito# ./busybox hostname -s hostname: prova: Unknown host This in fact

Re: [PATCH] do not use gethostbyname() for hostname -s

2013-12-09 Thread Tito
On Monday 09 December 2013 22:56:34 you wrote: 10.12.2013 01:40, Tito wrote: On Monday 09 December 2013 18:56:43 Michael Tokarev wrote: There's no reason to call gethostbyname() on the value returned by uname() when asked just for a short name of a host. This may also be wrong, when

Re: [PATCH alternative] sulogin: fix FEATURE_SHADOWPASSWDS sematics

2013-11-20 Thread Tito
On Wednesday 20 November 2013 13:25:15 you wrote: On Tue, Nov 19, 2013 at 1:58 PM, Tito farmat...@tiscali.it wrote: Please try attached patch. looks good for consolidation of the other loginutils but for sulogin it makes implementing the locked root account feature more difficult Why

Re: [PATCH alternative] sulogin: fix FEATURE_SHADOWPASSWDS sematics

2013-11-19 Thread Tito
On Tuesday 19 November 2013 13:08:34 Denys Vlasenko wrote: On Mon, Nov 18, 2013 at 3:46 AM, ChenQi qi.c...@windriver.com wrote: I think the above solution proposed by Tito is better, because if we have 'x' or '*' in /etc/passwd, and we don't have /etc/shadow, we're having an invalid user

Re: [PATCH alternative] sulogin: fix FEATURE_SHADOWPASSWDS sematics

2013-11-17 Thread Tito
On Saturday 16 November 2013 22:55:16 Harald Becker wrote: Hi Tito ! On 16-11-2013 22:03 Tito farmat...@tiscali.it wrote: usually passwd sets password field to x in /etc/passwd if password field in /etc/shadow is used so in a correctly managed system there should not be empty password

Re: [PATCH alternative] sulogin: fix FEATURE_SHADOWPASSWDS sematics

2013-11-17 Thread Tito
On Monday 18 November 2013 03:46:49 ChenQi wrote: On 11/17/2013 04:31 PM, Tito wrote: On Saturday 16 November 2013 22:55:16 Harald Becker wrote: Hi Tito ! On 16-11-2013 22:03 Tito farmat...@tiscali.it wrote: usually passwd sets password field to x in /etc/passwd if password field

Re: [PATCH alternative] sulogin: fix FEATURE_SHADOWPASSWDS sematics

2013-11-16 Thread Tito
in busybox: is it worth to be implemented? Ciao, Tito Sulogin: use /etc/shadow only if root's password field in /etc/shadow is set to 'x' or '*'. Signed-off-by: Tito Ragusa farmat...@tiscali.it --- loginutils/sulogin.c.original 2013-06-02 14:00:43.0 +0200 +++ loginutils/sulogin.c 2013-11-16 21

Re: fstrim: patch

2013-11-10 Thread Tito
, range.len); return EXIT_SUCCESS; } return EXIT_FAILURE; Ciao, Tito ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: fstrim: patch

2013-11-10 Thread Tito
On Sunday 10 November 2013 16:52:04 you wrote: Le 10/11/2013 14:56, Tito a écrit : On Sunday 10 November 2013 12:57:41 souf wrote: Hi, Please apply this patch to fstrim applet Thanks. Hi, this patch looks wrong to me: --- busybox/util-linux/fstrim.c.orig2013-11-10 11

Re: running testsuite with PREFER_APPLETS=y and EXEC_PATH=

2013-11-10 Thread Tito
:1.20.0-7) multi-call binary. Ciao, Tito ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: running testsuite with PREFER_APPLETS=y and EXEC_PATH=

2013-11-10 Thread Tito
On Sunday 10 November 2013 22:12:08 you wrote: On 10 November 2013 21:57, Tito farmat...@tiscali.it wrote: On Sunday 10 November 2013 15:46:10 Michael Tokarev wrote: Hello. When running testsuite, we're trying to execute applets by their names, like grep, cp, sh and so on. When

Re: [PATCH] swaponoff: shrink

2013-11-08 Thread Tito
pushed this one now since i did not hear back from you thanks, Hi, I thought you already did. Its OK for me. Ciao, Tito ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: Question about the installation directory of programs

2013-11-08 Thread Tito
as /bin/busybox applet args so as long as there is /bin your system will boot. Ciao, Tito ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: Question about the installation directory of programs

2013-11-07 Thread Tito
Hi, see http://en.wikipedia.org/wiki/Filesystem_Hierarchy_Standard Ciao, Tito On Thursday 07 November 2013 07:56:01 ChenQi wrote: Hi all, Forgive me if this is a dummy question. I see the installation directories of programs are controlled by the applets.src.h file. Some of them

Re: Help: DNS Resolver and Root Shell

2013-10-27 Thread Tito
, do you have a symbolic link /lib/libnss_files.so.2 = /lib/libnss_files-2.17.so ? Ciao, Tito PS.: maybe you can post the output of: ldconfig -v from your rootfs. This is the busybox version: [huli@dhcp-193-161 bin]$ file busybox busybox: ELF 32-bit LSB executable, ARM, version 1 (SYSV

Re: [PATCH 1/2] wget: make default timeout configurable, remove a duplicate line

2013-10-20 Thread Tito
On Sunday 20 October 2013 14:57:44 Denys Vlasenko wrote: On Friday 18 October 2013 23:21, Harald Becker wrote: Hi Tito ! IMO you got the best solution, ... one more solution without the need to modify scripts is to create a wrapper to wget: #!/bin/sh busybox wget -T xxx

Re: Help: DNS Resolver and Root Shell

2013-10-20 Thread Tito
/libnss_files*, and /lib/libresolv*). Shameless Plug: As an alternative, one could use a C library such as uClibc. In addition to making your system significantly smaller, uClibc does not require the use of any NSS support files or libraries. Hope this helps. Ciao, Tito And I also took reference

Re: [PATCH 1/2] wget: make default timeout configurable, remove a duplicate line

2013-10-18 Thread Tito
. There is nothing wrong to have such a constant as a #define at start of the applet source, but do we pollute the configuration step with this constant? Hi, can the wget scripts not be modified like [ -r /etc/default/wget.conf ] . /etc/default/wget.conf wget -t $WGET_TIMEOUT Ciao, Tito

Re: [PATCH 1/2] wget: make default timeout configurable, remove a duplicate line

2013-10-18 Thread Tito
On Friday 18 October 2013 17:56:57 you wrote: On Fri, Oct 18, 2013, at 12:52, Tito wrote: Hi, can the wget scripts not be modified like [ -r /etc/default/wget.conf ] . /etc/default/wget.conf wget -t $WGET_TIMEOUT Hi Tito, The whole point of this patch was to avoid having

Re: [PATCH 1/2] wget: make default timeout configurable, remove a duplicate line

2013-10-18 Thread Tito
On Friday 18 October 2013 23:21:41 Harald Becker wrote: Hi Tito ! IMO you got the best solution, ... one more solution without the need to modify scripts is to create a wrapper to wget: #!/bin/sh busybox wget -T xxx $@ ... except, I would do an exec here: #!/bin/sh exec busybox

Re: Ash internal 'read' command and pipes

2013-10-09 Thread Tito
; }; { echo main shell 2; echo $got; } This should as you expect it to. $ read got -EOF $(echo testing) EOF $ echo $got testing Cheers, -- Cristian Hi, also this works at least on bash. echo testing | while read line do echo $line done testing ciao, Tito

Re: [PATCH 3/3] wall: Temporarily drop privileges when opening files

2013-10-08 Thread Tito
); xseteuid(old_euid); xsetegid(old_egid); return fd } Ciao, Tito ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: [PATCH 3/3] wall: Temporarily drop privileges when opening files

2013-10-08 Thread Tito
/ produces ut_line entries like :0, and a write to /dev/:0 fails. */ Cannot say if it is worth to add them to busybox. Ciao, Tito ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo

Re: [PATCH] Fix potential filesystem race in crontab

2013-10-02 Thread Tito
(old_euid); + if (err) + bb_perror_msg_and_die(failed to restore privileges); + + return fd; } int crontab_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; Ciao, Tito ___ busybox mailing list busybox@busybox.net http

Re: [PATCH] Fix incorrect OS reporting in uname -o

2013-09-18 Thread Tito
the native one or use a simple wrapper: #!/bin/sh busybox uname $@ | sed 's/GNU\/Linux/MyLibc\/MyKernel/' Ciao, Tito ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: [PATCH alternative v2] swapon: adhere swap priority in fstab

2013-08-07 Thread Tito
On Wednesday 07 August 2013 20:09:29 you wrote: 2013/8/5 Tito farmat...@tiscali.it: On Sunday 04 August 2013 14:08:54 Dennis Groenen wrote: We already had the mount opts from fstab, but didn't do anything with them. Check mnt_opts and set g_flags accordingly prior to enabling

Re: [PATCH alternative] swapon: adhere swap priority in fstab

2013-08-04 Thread Tito
(); } else { errno = EINVAL; } } } return v; } Maybe I'm just to tired now. Ciao, Tito Add priority handling to swapon -a with error checking Signed-off-by: Tito Ragusa farmat...@tiscali.it

Re: [PATCH alternative] ifplugd: fix netlink recv

2013-07-08 Thread Tito
: 255 ^Cifplugd(eth0): executing '/etc/ifplugd/ifplugd.action eth0 down' ifplugd(eth0): exit code: 255 ifplugd(eth0): exiting Hope this helps. Ciao, Tito diff -uNp networking/ifplugd.c.orig networking/ifplugd.c --- networking/ifplugd.c.orig 2013-07-08 22:51:22.748468426 +0200 +++ networking

Re: [PATCH] ubimkvol: add -m option to create volume of maximum size

2013-06-03 Thread Tito
On Monday 03 June 2013 20:32:58 Paul B. Henson wrote: On 6/2/2013 10:44 PM, Tito wrote: + bb_error_msg_and_die(%s device node not in correct format, UBI); Why not bb_error_msg_and_die(UBI device node not in correct format); I'm just

Re: [PATCH] man: use less as default pager and parse DEFINE lines defining pager

2013-06-02 Thread Tito
? Maybe we should check at config time that at least one of the pagers (more, less) is enabled an use that as default and eventually if both are enabled prefer less. Just my 2 cents. Ciao, Tito ___ busybox mailing list busybox@busybox.net http

Re: [PATCH] man: use less as default pager and parse DEFINE lines defining pager

2013-06-02 Thread Tito
On Sunday 02 June 2013 14:01:01 John Spencer wrote: On 06/02/2013 01:48 PM, Tito wrote: On Sunday 02 June 2013 12:51:21 John Spencer wrote: man.config can define lines such as DEFINE pager less -s this patch parses them, additionally it always sets pager to less instead

Re: [PATCH] ubimkvol: add -m option to create volume of maximum size

2013-06-02 Thread Tito
); if (!(opts OPTION_N)) Ciao, Tito ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: [PATCH] ubi_tools: enhance -s option to allow size multiplier to match mtd-utils

2013-06-02 Thread Tito
, 10); if (opts OPTION_s) { + size_bytes = xstrtou_sfx(size_str, 10, size_suffixes); input_fd = 0; } else { if (!argv[optind+1]) Ciao, Tito

Re: [PATCH] sulogin: allow system maintenance login if root password is empty

2013-05-20 Thread Tito
method test: 'prova ' test: ' rova ' test: ' rova ' test: ' rova ' test: ' rova ' test: this proves that the buffer is not zeroed every time. An alternative solution could be to propagate CTRL-D EOL or \n to the calling function and do the check there. Hope this helps. Ciao, Tito

[PATCH] make bb_ask zero its memory every time

2013-05-20 Thread Tito
) - passwd = xmalloc(sizeof_passwd); + passwd = xzalloc(sizeof_passwd); + else + memset(passwd, 0, sizeof_passwd); + ret = passwd; i = 0; while (1) { This is mostly paranoia. Ciao, Tito Make bb_ask really zero its memory every time as stated

Re: [PATCH v2] sulogin: allow system maintenance login if root password is empty

2013-05-20 Thread Tito
; } Hi, looks good to me. Ciao, Tito ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: [PATCH 4/5] udhcpc: obtain hostname from OS by default

2013-03-20 Thread Tito
] == '?') hostname = xstrdup(Linux); client_config.hostname = alloc_dhcp_option(DHCP_HOST_NAME, hostname, 0); free(hostname); } Untested and probably stupid. Just my 2 cents, Ciao, Tito

Re: nfs mount succeeds but apps don't find the files

2013-01-27 Thread Tito
,errors=remount-ro 0 0 Hope it helps. Ciao, Tito ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: AW: bb 1.20.2 with glibc 2.16.0

2013-01-11 Thread Tito
it? Ciao, Tito ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: [PATCH 2/4] gstreamer: port to gstreamer-1.0

2012-12-19 Thread Tito
, or provide both 0.10 and 1.0 (E.G. add a BR2_PACKAGE_GSTREAMER_10 package)? Arnout, you mentioned something about a gst-fsl package, which presumably only works with gstreamer 0.1? Are sure this is busybox stuff? ;-) Ciao, Tito ___ busybox mailing

Re: [PATCH] CONFIG_PID_FILE_PATH: new configuration option for pidfile paths

2012-12-10 Thread Tito
add some if (ENABLE_FEATURE_PIDFILE) in front of all this calls to show clearly that this calls are turned on and off by a config option and thus make the code more readable. This would be dead code optimized away by the compiler. Ciao, Tito if there are no complaints, i'll merge this in a bit

Re: [PATCH] CONFIG_PID_FILE_PATH: new configuration option for pidfile paths

2012-12-08 Thread Tito
EXIT_SUCCESS; } Just my little contribution. Ciao, Tito ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: [PATCH] Write pid files for klogd, ntpd and watchdog

2012-12-05 Thread Tito
/klogd.pid); + used = 0; while (!bb_got_signal) { int n; Hi, maybe moving all the hardcoded paths to include/libbb.h could be a good idea. Ciao, Tito ___ busybox mailing list busybox@busybox.net http://lists.busybox.net

Re: [PATCH] Write pid files for klogd, ntpd and watchdog

2012-12-05 Thread Tito
, Tito ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: busybox telnetd security/misconfiguration

2012-11-14 Thread Tito
at first connection to web config 2) ask user to add an account + passwd at first connection to web config just my 0.2 cents. Ciao, Tito ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: busybox telnetd security/misconfiguration

2012-11-14 Thread Tito
/* Don't check the password if password entry is empty (!) */ if (!pw-pw_passwd[0]) break; You can change this hardcoded behaviour easily: 1) lock the account or 2) setup a passwd or 3) delete the user Ciao, Tito MirOS Project Armored Secure Operating System

Re: coordinated compliance efforts addresses the issues of this thread

2012-11-12 Thread Tito
On Monday 12 November 2012 14:59:44 Felipe Contreras wrote: On Mon, Nov 12, 2012 at 12:09 AM, Tito farmat...@tiscali.it wrote: On Friday 09 November 2012 23:55:19 Felipe Contreras wrote: *You* should not mix terms, we are not talking about a collection of works that have a character

Re: coordinated compliance efforts addresses the issues of this thread

2012-11-11 Thread Tito
On Friday 09 November 2012 23:55:19 Felipe Contreras wrote: On Thu, Nov 8, 2012 at 9:35 PM, Tito farmat...@tiscali.it wrote: On Wednesday 07 November 2012 20:03:52 you wrote: On Sat, Oct 20, 2012 at 10:19 PM, farmat...@tiscali.it farmat...@tiscali.it wrote: I would like to bring

Re: coordinated compliance efforts addresses the issues of this thread

2012-11-08 Thread Tito
is the one that decides. Best regards and Ciao, Tito ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: Fwd: Re: [PATCH] v5 mktemp: make -u option work more like coreutils

2012-10-08 Thread Tito
On Monday 08 October 2012 11:50:09 you wrote: On Wednesday 03 October 2012 14:38, Tito wrote: Hi Denys, maybe this patch slipped through? Applying! - /* -q is ignored */ - opt_complementary = ?1; /* 1 argument max */ + /* -p implies -t */ + opt_complementary = ?1:pt; /* 1

Re: Fwd: Re: [PATCH] v5 mktemp: make -u option work more like coreutils

2012-10-08 Thread Tito
On Monday 08 October 2012 14:40:29 Denys Vlasenko wrote: On Mon, Oct 8, 2012 at 1:50 PM, Tito farmat...@tiscali.it wrote: + /* Don't allow directory separator in template */ + if ((opts OPT_t) bb_basename(chp) != chp) { + errno = EINVAL; + goto error

Re: [PATCH 15/19] id: disable supplementary groups handling for older uClibc versions

2012-09-26 Thread Tito
On Wednesday 26 September 2012 11:47:20 walter harms wrote: Am 25.09.2012 21:04, schrieb Tito: On Tuesday 25 September 2012 17:52:17 walter harms wrote: Am 25.09.2012 14:06, schrieb Florian Fainelli: From: Nicolas Thill n...@openwrt.org This patch disable supplementary groups

Re: [PATCH 15/19] id: disable supplementary groups handling for older uClibc versions

2012-09-25 Thread Tito
and group functions rather than system functions, that provides getgrouplist, unless there is some reason not to do so. Ciao, Tito ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: coordinated compliance efforts addresses the issues of this thread (was Re: Amusing article about busybox)

2012-09-24 Thread Tito
On Monday 24 September 2012 16:37:11 you wrote: On Fri, Aug 24, 2012 at 10:24 PM, Tito farmat...@tiscali.it wrote: On Friday 24 August 2012 18:20:12 Felipe Contreras wrote: On Wed, Aug 15, 2012 at 9:45 PM, Bradley M. Kuhn bk...@ebb.org wrote: Felipe Contreras wrote at 11:31 (EDT) on Monday

Re: [PATCH] v5 mktemp: make -u option work more like coreutils

2012-09-21 Thread Tito
silently, print some error messages 6) don't ignore -q 7) don't allow directory separator in template Due to the several changes in the code review and more testing from list menbers is needed. Hints and critics are welcome. Ciao, Tito --- debianutils/mktemp.c.original 2012-09-21 22:15

Re: [PATCH] mktemp: fix -u option if TMPDIR is set

2012-09-20 Thread Tito
On Thursday 20 September 2012 14:21:45 walter harms wrote: I can no reproduce that. What libc you are using ? What mktemp ? (busybox or others ? if Busybox what version ?) Hi, I can reproduce it on Debian 6.0.5 32bit. but have a cleaner fix. Ciao, Tito re, wh Am 20.09.2012 13:31

Re: [PATCH] V2 mktemp: fix -u option if TMPDIR is set

2012-09-20 Thread Tito
= bb_get_last_path_component_strip(chp); goto ret; } This seems to work for me as expected eventually needs more testing. Ciao, Tito Fix ./busybox mktemp -u temp.XX returning garbage: mp/temp.ddTkNr when TMPDIR env var is set. Signed-off by Tito Ragusa farmat...@tiscali.it

Re: [PATCH] V2 mktemp: fix -u option if TMPDIR is set

2012-09-20 Thread Tito
On Thursday 20 September 2012 15:58:07 you wrote: Tito farmat...@tiscali.it wrote: This seems to work for me as expected eventually needs more testing. It doesn't work correctly in this case: $ mktemp -t -p /var/tmp -u temp.XX /var/tmp/temp.Jj1aWI $ export TMPDIR=/tmp

Re: [PATCH] V2 mktemp: fix -u option if TMPDIR is set

2012-09-20 Thread Tito
On Thursday 20 September 2012 16:11:03 Tito wrote: On Thursday 20 September 2012 15:58:07 you wrote: Tito farmat...@tiscali.it wrote: This seems to work for me as expected eventually needs more testing. It doesn't work correctly in this case: $ mktemp -t -p /var/tmp -u

[ PATCH] was Re: How to add an existing user to an existing group

2012-09-18 Thread Tito
On Tuesday 18 September 2012 14:27:16 Tito wrote: On Tuesday 18 September 2012 09:24:58 Jan Pohanka wrote: Hello, I can't found proper command to add an existing user to an existing group. I have tried following: user daemon exists as well as group mygroup # adduser -D -H -G

Re: [ PATCH] was Re: How to add an existing user to an existing group

2012-09-18 Thread Tito
Hi, attached v2 of the patch with a minor cleanup. Hints and critics are welcome. Ciao, Tito Allow adduser user group v2 Signed off by Tito Ragusa farmat...@tiscali.it --- loginutils/adduser.c.original 2012-07-31 21:23:24.0 +0200 +++ loginutils/adduser.c2012-09-18 21:46

Re: [PATCH] Add xorpipe utility

2012-09-12 Thread Tito
) +{ + bb_error_msg_and_die ? fprintf(stderr, xorpipe: error writing to output\n); +exit(1); +} +} + + } + return 0; +} Ciao, Tito

<    1   2   3   4   5   6   7   >