Re: [PATCH 3/3] ash: use JOBS as the compile time option it actually is

2017-07-14 Thread Johannes Schindelin
Hi Denys, On Fri, 14 Jul 2017, Denys Vlasenko wrote: > On Fri, Jul 14, 2017 at 4:11 PM, Johannes Schindelin > wrote: > > Using the constant in a regular `if (...)` pretends that this is > > anything but a compile time option. Let's use `#if JOBS` instead, > > making

Re: [PATCH 3/3] ash: use JOBS as the compile time option it actually is

2017-07-14 Thread Johannes Schindelin
Hi Xabier, On Fri, 14 Jul 2017, Xabier Oneca -- xOneca wrote: > 2017-07-14 16:11 GMT+02:00 Johannes Schindelin : > > @@ -4182,7 +4186,9 @@ dowait(int block, struct job *job) > > goto out; > > } > > /* The process wasn't found in job

Re: [PATCH 3/3] ash: use JOBS as the compile time option it actually is

2017-07-14 Thread Denys Vlasenko
On Fri, Jul 14, 2017 at 4:11 PM, Johannes Schindelin wrote: > Using the constant in a regular `if (...)` pretends that this is > anything but a compile time option. Let's use `#if JOBS` instead, > making it *much* clearer what `JOBS` actually is. > > Incidentally, this

Re: [PATCH 3/3] ash: use JOBS as the compile time option it actually is

2017-07-14 Thread Xabier Oneca -- xOneca
Hello Johannes, 2017-07-14 16:11 GMT+02:00 Johannes Schindelin : > Using the constant in a regular `if (...)` pretends that this is > anything but a compile time option. Let's use `#if JOBS` instead, > making it *much* clearer what `JOBS` actually is. > > Incidentally,

[PATCH 3/3] ash: use JOBS as the compile time option it actually is

2017-07-14 Thread Johannes Schindelin
Using the constant in a regular `if (...)` pretends that this is anything but a compile time option. Let's use `#if JOBS` instead, making it *much* clearer what `JOBS` actually is. Incidentally, this change fixes the build in setups where there are no headers defining WIFSTOPPED and WSTOPSIG