Re: [PATCH] miscutils/microcom: Fixed segfault

It's hardly a critical error :) On Fri, Aug 4, 2017 at 10:25 AM, Natanael Copa wrote: > On Fri, 4 Aug 2017 02:02:36 +0200 > Denys Vlasenko wrote: > >> On Thu, Aug 3, 2017 at 7:11 AM, Marian Buschsieweke >> wrote: >> > microcom did not check if requ

Re: [PATCH] miscutils/microcom: Fixed segfault

On Fri, 4 Aug 2017 02:02:36 +0200 Denys Vlasenko wrote: > On Thu, Aug 3, 2017 at 7:11 AM, Marian Buschsieweke > wrote: > > microcom did not check if required parameter TTY is present. Thus, > > bb_basename() was called with a NULL pointer if TTY was missing. > > This

Re: [PATCH] miscutils/microcom: Fixed segfault

On Thu, Aug 3, 2017 at 7:11 AM, Marian Buschsieweke wrote: > microcom did not check if required parameter TTY is present. Thus, > bb_basename() was called with a NULL pointer if TTY was missing. > This commit adds the missing check. Fixed, thanks! (A bit differently) > ---

Re: [PATCH] miscutils/microcom: Fixed segfault

Hi, just a hint: On 08/03/2017 07:11 AM, Marian Buschsieweke wrote: microcom did not check if required parameter TTY is present. Thus, bb_basename() was called with a NULL pointer if TTY was missing. This commit adds the missing check. --- miscutils/microcom.c | 5 + 1 file changed, 5

[PATCH] miscutils/microcom: Fixed segfault

microcom did not check if required parameter TTY is present. Thus, bb_basename() was called with a NULL pointer if TTY was missing. This commit adds the missing check. --- miscutils/microcom.c | 5 + 1 file changed, 5 insertions(+) diff --git a/miscutils/microcom.c b/miscutils/microcom.c

Re: Problem running Buildroot2 microcom package with Busybox

On Friday 21 March 2008, Kelvin wrote: > The PATH is correct, it does contain the path where microcom is located. > Even if I run microcom in its current directory (using the command > "./microcom"), somehow I always get the "-sh: microcom: not found" error. > I&

RE: Problem running Buildroot2 microcom package with Busybox

The PATH is correct, it does contain the path where microcom is located. Even if I run microcom in its current directory (using the command "./microcom"), somehow I always get the "-sh: microcom: not found" error. I'm clueless why the Busybox shell can'

Re: Problem running Buildroot2 microcom package with Busybox

> > I'm building an embedded Linux OS using Buildroot2 with kernel version 2.4, > Busybox version 1.00 and JFFS2 filesystem. I included the microcom package > from Buildroot2 in my Linux build. However, when I boot up my built OS, I > have problem running the microcom app

Problem running Buildroot2 microcom package with Busybox

Hi, I'm building an embedded Linux OS using Buildroot2 with kernel version 2.4, Busybox version 1.00 and JFFS2 filesystem. I included the microcom package from Buildroot2 in my Linux build. However, when I boot up my built OS, I have problem running the microcom application even though

Re: Microcom: fdprintf: -17 bytes

On Wednesday 27 February 2008 20:03, [EMAIL PROTECTED] wrote: > Hello! > > If only I knew about fdprintf() earlier :) Applied. fdprintf() is typically twice as slow as printf, so don't use it massively. In this case, it was ok. -- vda ___ busybox maili

Microcom: fdprintf: -17 bytes

Hello! If only I knew about fdprintf() earlier :) Plz, consider applying. -- Vladimir microcom.patch Description: Binary data ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo/busybox

Re: Microcom again

On Sunday 10 February 2008 15:19, [EMAIL PROTECTED] wrote: > Hello, Denys! > > Plz, take a look at the contents of main loop -- I rewrote it slightly. Applied, thanks. -- vda ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailma

Re: Microcom fixed

On Monday 04 February 2008 19:28, [EMAIL PROTECTED] wrote: > Attached is microcom updated. // without this we never get POLLIN on sfd // until piped stdin is drained if (-1 != time

Re: Using microcom

Vladimir Dronnikov schrieb: > 2008/2/8, Nico Erfurth <[EMAIL PROTECTED] >: > > Hi, > > I'm currently trying to get a single AT command into my usb-modem. > > > Do you use current version of busybox? I use 1.9.0 with microcom.c from the svn. Nico _

Using microcom

Hi, I'm currently trying to get a single AT command into my usb-modem. I thought it would be as easy as echo "ATXXX" | ./busybox microcom /dev/ttyUSB0 But microcom tries to set some attr on stdin, so I get this error: microcom: can't tcsetattr for stdin: Invalid argument An

Microcom fixed

Hello! Attached is microcom updated. Added new options: -t msecs -- Set inactivity timeout when STDIN is redirected -X -- Turn off Ctrl-X (exit) and Ctrl-@ (send break) processing Fixed device responsibility when stdin is redirected Please, consider applying -- Vladimir microcom.patch

Microcom updated

Hello! I' ve prepared new version of microcom applet. It now should correctly handle slow devices when used non-interactively. Also added -X option which turns off special processing of Ctrl-X -- immediately quit microcom and Ctrl+@ -- send break sequence to device Denys, please con

Re: Microcom++

On Monday 28 January 2008 10:09, Vladimir Dronnikov wrote: > > About usleep(10) - why is it needed? Because if we ^X > > fast enough, comm port is shut down too fast and last char(s) > > are not xmitted? > > Right you are! > This delay is not needed unless we have piped input. > When input is pipe

Re: Microcom++

On Friday 25 January 2008 09:52, Vladimir Dronnikov wrote: > Hello! > > Attached is heavily rewritten microcom BB applet. > It now 1) deals with lock file cleaner; 2) can be run as a filter > > Denys, plz, consider to commit it. Applied with minor changes. Thanks! Yell if

Re: PATCH] microcom enhancements and fixes

I have made some additional changes based on input from Bernhard Fischer and Vladimir Dronnikov to reduce stack and code size. Vladimir had some concern about the compatibility of removing the input flushes. I don't think that they are needed and removing them is less code, so this patch removes

Re: PATCH] microcom enhancements and fixes

On Fri, Jan 18, 2008 at 08:38:47PM -0800, Steven Bradshaw wrote: >On Jan 18, 2008 12:41 AM, Bernhard Fischer <[EMAIL PROTECTED]> wrote: >> On Wed, Jan 16, 2008 at 10:02:10PM -0800, Steve Bradshaw wrote: >... >> > >> >diff -ur busybox-1.8.2.orig/miscutils/microcom.c >> >busybox-1.8.2.new/miscutils/

Re: PATCH] microcom enhancements and fixes

On Jan 18, 2008 12:41 AM, Bernhard Fischer <[EMAIL PROTECTED]> wrote: > On Wed, Jan 16, 2008 at 10:02:10PM -0800, Steve Bradshaw wrote: ... > > > >diff -ur busybox-1.8.2.orig/miscutils/microcom.c > >busybox-1.8.2.new/miscutils/microcom.c > >--- busybox-1.8.2.orig/miscutils/microcom.c2007-11-09

Re: PATCH] microcom enhancements and fixes

On Wed, Jan 16, 2008 at 10:02:10PM -0800, Steve Bradshaw wrote: > Hello, > > I have made some modifications to microcom to make it > more useful to me. In particular, I needed to send > a ^C and a Break to the remote device (Cisco router). > > Here are the more detailed c

PATCH] microcom enhancements and fixes

I have made some modifications to microcom to make it more useful to me. In particular, I needed to send a ^C and a Break to the remote device (Cisco router). Here are the more detailed changes: . Catch common signals to clean up the lock file and TTY modes. . Allow stdin to not

PATCH] microcom enhancements and fixes

Hello, I have made some modifications to microcom to make it more useful to me. In particular, I needed to send a ^C and a Break to the remote device (Cisco router). Here are the more detailed changes: . Catch common signals to clean up the lock file and TTY modes. . Allow stdin

Re: Microcom

Hi Vladimir, Plese let us know what copyright and license terms should be at the top of microcom.c On Saturday 22 September 2007 16:03, Vladimir Dronnikov wrote: > Still have 2 comments > > 1. > The code > - > // %4d to make mgetty happy. It treats 4-bytes lock files as binary, > //

Re: Fwd: New applet: microcom

Hi Vladimir, Applet is in current svn now. Thanks! -- vda ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo/busybox

Re: Fwd: New applet: microcom

On Thu, Sep 20, 2007 at 10:02:37PM +0100, Denys Vlasenko wrote: >On Wednesday 19 September 2007 07:58, Vladimir Dronnikov wrote: >> Hello! >> >> I've added new applet microcom which can be used to communicate with serial >> ports. >> Inspired by mgetty&#

Re: Fwd: New applet: microcom

On Wednesday 19 September 2007 07:58, Vladimir Dronnikov wrote: > Hello! > > I've added new applet microcom which can be used to communicate with serial > ports. > Inspired by mgetty's microcom utility. > > Comments are welcome! Edited it a bit. There were many

Fwd: New applet: microcom

Hello! I've added new applet microcom which can be used to communicate with serial ports. Inspired by mgetty's microcom utility. Comments are welcome! Regards, Vladimir Dronnikov (mailto:[EMAIL PROTECTED])17.09.2007, 11:15 microcom.diff Description: B

Re: Microcom: new applet, mount: make better use of fstab

On Wednesday 12 September 2007 08:18, Vladimir Dronnikov wrote: > Hello, Denis! > > 1) microcom + // compose lock file name + if ( !device ) return ENODEV; + if ( strchr(device, '/') ) device = strrchr(device, '/')+1; +