Patch for udhcpc hwtype

2010-10-19 Thread Sam Liddicott
--- networking/udhcp/dhcpc.c.orig 2010-10-11 14:15:04.0 +0100 +++ networking/udhcp/dhcpc.c 2010-10-11 14:15:28.0 +0100 @@ -145,6 +145,7 @@ int tryagain_timeout = 20; int discover_timeout = 3; int discover_retries = 3; + int hwtype = 1; uint32_t server_addr = server_addr; /*

Re: Compiling using LLVM Clang : Nested functions

2013-05-16 Thread Sam Liddicott
0001-Support-compilers-without-nested-functions.patch Description: Binary data ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: bug in busybox sed with non-ascii chars

2014-05-05 Thread Sam Liddicott
One of the advantages of utf-8 encoding was that it was easy to re-sync after an invalid sequence. It's a bit of a waste to then not do that. Minus points for musl. Can you not run sed with LANG=C or LANG=POSIX? Sam On 4 May 2014 15:57, Rich Felker dal...@libc.org wrote: On Sun, May 04, 2014

Re: [PATCH] getty: remove the statement of pid and sid comparison

2014-05-12 Thread Sam Liddicott
Maybe true is better than ; true so that the correct exit code will also be returned. Sam On 10 May 2014 23:19, Denys Vlasenko vda.li...@googlemail.com wrote: On Saturday 10 May 2014 04:17, Zhenhua Luo wrote: when setsid failed, the pid and sid doesn't equal, so remove following condition

Re: shutdown busybox and start another PID1 process

2014-08-09 Thread Sam Liddicott
You can replace /sbin/init with a bind mount; e.g. mount /tmpfs/sbin/init.shutdown /sbin/init -o bind that will replace init, but only till the next reboot. When debugging the first couple of lines should be something like: exec /dev/ttyS0 21 # if serial console exec /dev/tty1 21 # if normal

Re: shutdown busybox and start another PID1 process

2014-08-10 Thread Sam Liddicott
Don't forgot umount -fl which pretends to unmount now but actually does it as soon as all files are closed. Not sure right now if busybox supports it. Sam On 10 Aug 2014 22:51, Laurent Bercot ska-dietl...@skarnet.org wrote: I don't quite understand what you are suggesting. Ah, I'm sorry, I

Re: shutdown busybox and start another PID1 process

2014-08-11 Thread Sam Liddicott
I wonder if cgroups or namespaces have any role here. The initrd mounts NTFS and then creates a new namespace for new init which can't see or kill fuse. Sam On 11 Aug 2014 17:34, James B jamesbond3...@gmail.com wrote: Hi James (from another James). On Mon, 11 Aug 2014 03:17:52 -0600 James

Re: shutdown busybox and start another PID1 process

2014-08-13 Thread Sam Liddicott
This works in busybox ash getch() { read -t 1 -n 1 $1 } getch key echo $key you probably also want stty -echo before you start Sam On Tue, Aug 12, 2014 at 5:44 AM, James Bowlin bit...@gmail.com wrote: On Mon, Aug 11, 2014 at 07:35 PM, Harald Becker said: Did I get it right? This is

Re: In regard to CVE-2014-7169 CVE-2014-6271

2014-09-27 Thread Sam Liddicott
Many of the programs that inject environment variables could rightly sanitise their data. It may provide relief for system builders that provide updated busybox but not updated bash. Or safety where stupid use of eval is made in scripts, or careless use of system/popen is made in programs. To

Re: ntpd daemon

2015-03-23 Thread Sam Liddicott
On Thu, Mar 5, 2015 at 1:03 PM, Denys Vlasenko vda.li...@googlemail.com wrote: On Thu, Mar 5, 2015 at 11:43 AM, Laszlo Papp lp...@kde.org wrote: The problem is not when no peer is defined. The problem is when the peer is defined, but we cannot talk to it. Therefore, the issue that I raised

Re: [PATCH 2/2] ash: use alloca to get rid of setjmp

2015-07-02 Thread Sam Liddicott
On 1 Jul 2015 19:36, Rich Felker dal...@libc.org wrote: On Wed, Jul 01, 2015 at 04:46:18PM +0100, Ron Yorston wrote: Now that the only thing protected by setjmp/longjmp is the saved string, we can allocate it on the stack to get rid of the jump. Based on commit bd35d8e from git://

Re: Good Bye

2015-11-10 Thread Sam Liddicott
I give my sincere thanks for the gift of your intellect and effort to the world, for the care in the upkeep and maintenance of this work. I wish you well for whatever you do next. Sam Liddicott On Mon, Nov 9, 2015 at 8:13 PM, Harald Becker <ra...@gmx.de> wrote: > Hi All, > > e

Re: [PATCH] umount: always use umount2 syscall with specified flags

2015-10-05 Thread Sam Liddicott
Some discussion on better encapsulations of the technique here: http://stackoverflow.com/questions/174356/ways-to-assert-expressions-at-build-time-in-c Sam On Sat, Oct 3, 2015 at 11:58 AM, Xabier Oneca -- xOneca wrote: > Hello, > > Excuse my ignorance, but what does this

Re: [PATCH] blkdiscard: check that the file is a block device before opening

2016-01-05 Thread Sam Liddicott
This patch just trades one undefined behaviour for another. I'd open first and then do fstat. Otherwise change your comment, because it isn't really enforcing anything with a race condition between the stat and the open. Sam On Tue, Jan 5, 2016 at 11:50 AM, Ari Sundholm wrote:

Re: [PATCH] Compress common substrings in applet names to save space

2016-04-20 Thread Sam Liddicott
On Wed, Apr 20, 2016 at 1:03 PM, Denys Vlasenko wrote: > On Wed, Apr 20, 2016 at 12:55 PM, Guillermo Rodriguez Garcia > wrote: > >>> When strings are abbreviated the new find_applet_by_name() is about > >>> 34% slower than currently. (All

Re: potential error with adduser

2016-12-14 Thread Sam Liddicott
You are allowed to have inaccurate information in /etc/passwd. For instance, there is nothing to check that the information in the GECOS field [https://en.wikipedia.org/wiki/Gecos_field] is correct. There is nothing to stop you deleting the created home directory afterwards, and nothing to force

Re: Problem with cat

2017-03-15 Thread Sam Liddicott
On 14 March 2017 at 14:44, Grant Edwards wrote: > On 2017-03-14, Lauri Kasanen wrote: > > On Mon, 13 Mar 2017 19:24:17 + (UTC) > > Grant Edwards wrote: > > > >> That paragraph is wrong (or at least misleading). I've

Re: less Idle time with busybox ash as bash vs bash

2018-09-07 Thread Sam Liddicott
Bash has some built-in too. Sam On 31 Aug 2018 19:11, "James Hanley" wrote: > We had some bash scripts that we converted to use busybox ash as bash > (removed any array constructs) and when comparing the two scripts - it > seems that running them under busybox yields less idle time compared >

Re: [PATCH] libarchive: add a function to unpack embedded data

2018-11-02 Thread Sam Liddicott
Will that support an embedded .profile there as well? Sam On Fri, 2 Nov 2018 at 13:19, Denys Vlasenko wrote: > Applied, thanks! > On Fri, Nov 2, 2018 at 9:34 AM Ron Yorston wrote: > > > > Similar code to unpack embedded data is used to decompress usage > > messages, embedded scripts and the

Re: License concerns when embedding script in busybox binary

2018-11-10 Thread Sam Liddicott
On Fri, 9 Nov 2018 16:51 Michael Conrad On 11/7/2018 10:49 AM, Ron Yorston wrote: > > Kang-Che Sung wrote: > > Specifically, I think the current state of config ASH_EMBEDDED_SCRIPTS > help text did not yet warn builders that the binary may be distributed **only > when the embedding scripts are

Re: git clone fail

2018-12-04 Thread Sam Liddicott
Looks like a failing disk to me, with sporadic disk read failures. Sam On Tue, 4 Dec 2018 at 08:34, Xabier Oneca -- xOneca wrote: > Hello, > > I also got a different error clonning: > > $ git clone https://git.busybox.net/busybox bb > Cloning into 'bb'... <-- stalls here for a few minutes >

Re: SIGPIPE and tee

2019-09-13 Thread Sam Liddicott
elf_with_sig(SIGPIPE); retval = EXIT_FAILURE; break; } Sam On Thu, 12 Sep 2019 at 20:03, Sam Liddicott wrote: > In https://git.busybox.net/busybox/tree/coreutils/tee.c we read: > > /* gnu tee ignores SIGPIPE in case one of the output files is a pipe > * that doesn't cons

Re: SIGPIPE and tee

2019-09-13 Thread Sam Liddicott
operands shall be supported: *file*A pathname of an output file. If a *file* operand is '-', it shall refer to a file named *-*; implementations shall not treat it as meaning standard output. On Thu, 12 Sep 2019 at 20:03, Sam Liddicott wrote: > In https://git.busybox.net/busybox/tree/coreut

SIGPIPE and tee

2019-09-12 Thread Sam Liddicott
In https://git.busybox.net/busybox/tree/coreutils/tee.c we read: /* gnu tee ignores SIGPIPE in case one of the output files is a pipe * that doesn't consume all its input. Good idea... */ signal(SIGPIPE, SIG_IGN); Sadly, this breaks POSIX SIGPIPE behaviour with respect to

[PATCH] Re: SIGPIPE and tee

2019-10-04 Thread Sam Liddicott
nudge on this attached patch -- Forwarded message - From: Sam Liddicott Date: Fri, 13 Sep 2019 at 11:15 Subject: Re: SIGPIPE and tee To: busybox Here is a patch which invokes kill_myself_with_sig(SIGPIPE) if fwrite fails with errno=EPIPE. Quitting with a signal rather than

Re: [PATCH] Re: SIGPIPE and tee

2019-10-07 Thread Sam Liddicott
Thanks - that change is great. Busybox tee now propagates SIGPIPE just like GNU tee does by default. Sam On Mon, 7 Oct 2019 at 13:27, Denys Vlasenko wrote: > On Fri, Oct 4, 2019 at 11:20 AM Sam Liddicott wrote: > > nudge on this attached patch > > > > ---

Re: RFC: initialize /dev/urandom, is it necessary? Can we do it in a better way?

2023-09-19 Thread Sam Liddicott
This is also a problem with many virtual appliances. There is no easy answer to this kernel bootup entropy problem and it is lamentable that solutions are delegated to user space, and even to scripts, and to non-experts who will do a bad job of it but not know it. You may as well feed what random