Re: [PATCH] shell: fix $(()) precedence bug in "X=A?B:C" (it is _not_ "(X=A)?..)"

2022-09-05 Thread Steffen Nurpmeso
alice wrote in : |On Mon Sep 5, 2022 at 4:58 PM CEST, Steffen Nurpmeso wrote: |> Steffen Nurpmeso wrote in |> <20220905143118.ysd0g%stef...@sdaoden.eu>: ... |what does any of this have to do with busybox? Nothing. Sorry. --steffen | |Der Kragenbaer,The moon bear, |der

Re: [PATCH] shell: fix $(()) precedence bug in "X=A?B:C" (it is _not_ "(X=A)?..)"

2022-09-05 Thread Steffen Nurpmeso
Steffen Nurpmeso wrote in <20220905215546.2vfqe%stef...@sdaoden.eu>: |Xabier Oneca -- xOneca wrote in | : ||busybox tree has no file named "shexp-arith.h", ||> yet your patch is against that file. ||> ||> Do you see this file here? ||> https://git.busybox.net/busybox/tree/shell || ||

Re: [PATCH] shell: fix $(()) precedence bug in "X=A?B:C" (it is _not_ "(X=A)?..)"

2022-09-05 Thread Steffen Nurpmeso
Xabier Oneca -- xOneca wrote in : |busybox tree has no file named "shexp-arith.h", |> yet your patch is against that file. |> |> Do you see this file here? |> https://git.busybox.net/busybox/tree/shell | | |That file is added in one of his first patches a while ago. Later, he has |sent

Re: [PATCH] shell: fix $(()) precedence bug in "X=A?B:C" (it is _not_ "(X=A)?..)"

2022-09-05 Thread Steffen Nurpmeso
Denys Vlasenko wrote in : |On Mon, Sep 5, 2022 at 4:31 PM Steffen Nurpmeso wrote: |> Sure is that Kyiv Rus _never_ owned anything of the country that |> is currently being fight in on the ground. It was a gift, a gift |> to overcome a century old i-do-not-know-what in between some |>

Re: [PATCH] shell: fix $(()) precedence bug in "X=A?B:C" (it is _not_ "(X=A)?..)"

2022-09-05 Thread tito
On Mon, 05 Sep 2022 16:58:07 +0200 Steffen Nurpmeso wrote: > Steffen Nurpmeso wrote in > <20220905143118.ysd0g%stef...@sdaoden.eu>: Man, you have a lot of energy for writing, rediffing your patch series would have done it. Ciao, Tito ___ busybox

Re: [PATCH] shell: fix $(()) precedence bug in "X=A?B:C" (it is _not_ "(X=A)?..)"

2022-09-05 Thread Xabier Oneca -- xOneca
Hi, Denys busybox tree has no file named "shexp-arith.h", > yet your patch is against that file. > > Do you see this file here? > https://git.busybox.net/busybox/tree/shell That file is added in one of his first patches a while ago. Later, he has sent patches fixing bugs for that unapplied

Re: [PATCH] shell: fix $(()) precedence bug in "X=A?B:C" (it is _not_ "(X=A)?..)"

2022-09-05 Thread Denys Vlasenko
On Mon, Sep 5, 2022 at 4:31 PM Steffen Nurpmeso wrote: > Sure is that Kyiv Rus _never_ owned anything of the country that > is currently being fight in on the ground. It was a gift, a gift > to overcome a century old i-do-not-know-what in between some > Ukrainians, and Russia. I believe solely

Re: [PATCH] shell: fix $(()) precedence bug in "X=A?B:C" (it is _not_ "(X=A)?..)"

2022-09-05 Thread Denys Vlasenko
On Mon, Sep 5, 2022 at 2:46 PM Steffen Nurpmeso wrote: > > Denys Vlasenko wrote in > : > |On Wed, Aug 31, 2022 at 1:35 AM Steffen Nurpmeso \ > |wrote: > |> > |> Denys Vlasenko wrote in > |> : > |>|Your patches seem to be against dash, not busybox git tree? > |> > |> No? I think dash

Re: [PATCH] shell: fix $(()) precedence bug in "X=A?B:C" (it is _not_ "(X=A)?..)"

2022-09-05 Thread Steffen Nurpmeso
Steffen Nurpmeso wrote in <20220905143118.ysd0g%stef...@sdaoden.eu>: ... |Yes. If i had to say anything, our Bundeskanzler would be charged |and brought to the international court in Den Haag i think it is. |But then again, i am sure nothing bad would happen to him, which |i do not

Re: [PATCH] shell: fix $(()) precedence bug in "X=A?B:C" (it is _not_ "(X=A)?..)"

2022-09-05 Thread Steffen Nurpmeso
Steffen Nurpmeso wrote in <20220905124655.m6q1h%stef...@sdaoden.eu>: |Denys Vlasenko wrote in | : ||On Wed, Aug 31, 2022 at 1:35 AM Steffen Nurpmeso \ ||wrote: ||> ||> Denys Vlasenko wrote in ||> : ||>|Your patches seem to be against dash, not busybox git tree? ||> ||> No? I think

Re: [PATCH] shell: fix $(()) precedence bug in "X=A?B:C" (it is _not_ "(X=A)?..)"

2022-09-05 Thread Steffen Nurpmeso
Denys Vlasenko wrote in : |On Wed, Aug 31, 2022 at 1:35 AM Steffen Nurpmeso \ |wrote: |> |> Denys Vlasenko wrote in |> : |>|Your patches seem to be against dash, not busybox git tree? |> |> No? I think dash uses a yacc thing..? (That only supports the |> most basic things, as per

Re: [PATCH] shell: fix $(()) precedence bug in "X=A?B:C" (it is _not_ "(X=A)?..)"

2022-09-05 Thread Denys Vlasenko
On Wed, Aug 31, 2022 at 1:35 AM Steffen Nurpmeso wrote: > > Denys Vlasenko wrote in > : > |Your patches seem to be against dash, not busybox git tree? > > No? I think dash uses a yacc thing..? (That only supports the > most basic things, as per POSIX, which is two steps back for > busybox.

Re: [PATCH] shell: fix $(()) precedence bug in "X=A?B:C" (it is _not_ "(X=A)?..)"

2022-08-30 Thread Steffen Nurpmeso
Denys Vlasenko wrote in : |Your patches seem to be against dash, not busybox git tree? No? I think dash uses a yacc thing..? (That only supports the most basic things, as per POSIX, which is two steps back for busybox. But smaller i presume.) And sorry for lots of noise over weeks! I have

Re: [PATCH] shell: fix $(()) precedence bug in "X=A?B:C" (it is _not_ "(X=A)?..)"

2022-08-30 Thread Denys Vlasenko
Your patches seem to be against dash, not busybox git tree? On Thu, Aug 11, 2022 at 6:16 PM Steffen Nurpmeso wrote: > > > --- > It was a one line fix. Five more tests > > +s I1=5 I2=10 I3=20;p "<$((I1-=5,1?I2:I3))>";e "<$I1><$I2><$I3>" > +s I1=5 Ix=6 I2=10 I3=20;p "<$((I1=Ix,1?I2:I3))>";e

Re: [PATCH] shell: fix $(()) precedence bug in "X=A?B:C" (it is _not_ "(X=A)?..)"

2022-08-18 Thread Steffen Nurpmeso
I just fixed two other bugs regarding $: ternary resolution which affect strange cases regarding precedence in whiteouts $((0?I1=10:(1?I3:I2=12))) vs $((0?I1=10:(0?I3:I2=12))) as well as a missing variable-expansion prevention in a whiteout. (Let me allow to keep saying whiteout, please.)