Re: [Cake] [PATCH net] sch_cake: diffserv8 CS1 should be bulk

2022-01-27 Thread Sebastian Moeller
> On Jan 27, 2022, at 10:00, Kevin 'ldir' Darbyshire-Bryant via Cake > wrote: > > > >> On 25 Jan 2022, at 10:58, Toke Høiland-Jørgensen wrote: >> >> Matt Johnston writes: >> >>> The CS1 priority (index 0x08) was changed from 0 to 1 when LE (index >>> 0x01) was added. This looks

Re: [Cake] [PATCH net] sch_cake: diffserv8 CS1 should be bulk

2022-01-27 Thread Sebastian Moeller
Hi Matt, > On Jan 27, 2022, at 04:14, Matt Johnston wrote: > > On Tue, 2022-01-25 at 12:54 +0100, Sebastian Moeller wrote: >> >> LE(1) is tin 0 the lowest >> CS1(8) is 1 slightly above LE >> CS0/BE(0) is 2 >> AF1x (10, 12, 14) are all in tin 1 as is CS1 > ... >> Just as documented in the

Re: [Cake] [PATCH net] sch_cake: diffserv8 CS1 should be bulk

2022-01-27 Thread Matt Johnston
On Tue, 2022-01-25 at 12:54 +0100, Sebastian Moeller wrote: > > LE(1) is tin 0 the lowest > CS1(8) is 1 slightly above LE > CS0/BE(0) is 2 > AF1x (10, 12, 14) are all in tin 1 as is CS1 ... > Just as documented in the code: > > *Bog Standard (CS0 etc.) > *

Re: [Cake] [PATCH net] sch_cake: diffserv8 CS1 should be bulk

2022-01-27 Thread Kevin 'ldir' Darbyshire-Bryant via Cake
> On 25 Jan 2022, at 10:58, Toke Høiland-Jørgensen wrote: > > Matt Johnston writes: > >> The CS1 priority (index 0x08) was changed from 0 to 1 when LE (index >> 0x01) was added. This looks unintentional, it doesn't match the >> docs and CS1 shouldn't be the same tin as AF1x > > Hmm, Kevin,