Re: [Cake] [PATCH iproute2-next v10] Add support for CAKE qdisc

2018-07-19 Thread David Ahern
On 7/19/18 9:20 AM, Toke Høiland-Jørgensen wrote: > David Ahern writes: > >> On 7/19/18 4:53 AM, Toke Høiland-Jørgensen wrote: >>> A few comments below; will fix the rest. >>> > + print_uint(PRINT_JSON, "bandwidth", NULL, bandwidth); > +

Re: [Cake] [PATCH iproute2-next v10] Add support for CAKE qdisc

2018-07-19 Thread Toke Høiland-Jørgensen
David Ahern writes: > On 7/19/18 4:53 AM, Toke Høiland-Jørgensen wrote: >> A few comments below; will fix the rest. >> + print_uint(PRINT_JSON, "bandwidth", NULL, bandwidth); + print_string(PRINT_FP, NULL, "bandwidth %s ", sprint_rate(bandwidth,

Re: [Cake] [PATCH iproute2-next v10] Add support for CAKE qdisc

2018-07-19 Thread David Ahern
On 7/19/18 4:53 AM, Toke Høiland-Jørgensen wrote: > A few comments below; will fix the rest. > >>> + print_uint(PRINT_JSON, "bandwidth", NULL, bandwidth); >>> + print_string(PRINT_FP, NULL, "bandwidth %s ", >>> sprint_rate(bandwidth, b1)); >>> + }

Re: [Cake] [PATCH iproute2-next v10] Add support for CAKE qdisc

2018-07-19 Thread Toke Høiland-Jørgensen
A few comments below; will fix the rest. >> +print_uint(PRINT_JSON, "bandwidth", NULL, bandwidth); >> +print_string(PRINT_FP, NULL, "bandwidth %s ", >> sprint_rate(bandwidth, b1)); >> +} else >> +print_string(PRINT_ANY,

Re: [Cake] [PATCH iproute2-next v10] Add support for CAKE qdisc

2018-07-18 Thread David Ahern
On 7/16/18 10:39 AM, Toke Høiland-Jørgensen wrote: > +static int cake_parse_opt(struct qdisc_util *qu, int argc, char **argv, > + struct nlmsghdr *n, const char *dev) > +{ > + int unlimited = 0; > + __u64 bandwidth = 0; > + unsigned interval = 0; > + unsigned

Re: [Cake] [PATCH iproute2-next v10] Add support for CAKE qdisc

2018-07-16 Thread Stephen Hemminger
On Mon, 16 Jul 2018 19:56:00 +0200 Toke Høiland-Jørgensen wrote: > Stephen Hemminger writes: > > > On Mon, 16 Jul 2018 18:39:26 +0200 > > Toke Høiland-Jørgensen wrote: > > > >> +#define PRINT_TSTAT(name, attr, fmts, val)do {\ > >> + if (GET_TSTAT(0,

Re: [Cake] [PATCH iproute2-next v10] Add support for CAKE qdisc

2018-07-16 Thread Toke Høiland-Jørgensen
Stephen Hemminger writes: > On Mon, 16 Jul 2018 18:39:26 +0200 > Toke Høiland-Jørgensen wrote: > >> +#define PRINT_TSTAT(name, attr, fmts, val) do {\ >> +if (GET_TSTAT(0, attr)) { \ >> +fprintf(f, name); \

Re: [Cake] [PATCH iproute2-next v10] Add support for CAKE qdisc

2018-07-16 Thread Stephen Hemminger
On Mon, 16 Jul 2018 18:39:26 +0200 Toke Høiland-Jørgensen wrote: > +#define PRINT_TSTAT(name, attr, fmts, val) do {\ > + if (GET_TSTAT(0, attr)) { \ > + fprintf(f, name); \ > +

[Cake] [PATCH iproute2-next v10] Add support for CAKE qdisc

2018-07-16 Thread Toke Høiland-Jørgensen
sch_cake is intended to squeeze the most bandwidth and latency out of even the slowest ISP links and routers, while presenting an API simple enough that even an ISP can configure it. Example of use on a cable ISP uplink: tc qdisc add dev eth0 cake bandwidth 20Mbit nat docsis ack-filter To shape