Re: [Cake] overheads or rate calculation changed?

2018-01-07 Thread Jonathan Morton
> On 7 Jan, 2018, at 10:19 am, Sebastian Moeller wrote: > > We really need this "behave like all other qdiscs" mode so that cake can be > used with "tc stab" exactly as awkward as all other qdiscs, it would be > really unfortunate if cake would require different "tc stab" magic than say > HTB+

Re: [Cake] overheads or rate calculation changed?

2018-01-07 Thread Sebastian Moeller
Hi Jonathan, > On Jan 7, 2018, at 01:33, Jonathan Morton wrote: > >> On 7 Jan, 2018, at 12:46 am, Sebastian Moeller wrote: >> >> I thibk cake should offer a mode in which it behaves as all other qdiscs >> currently do and not do auto correction at all and a mode where it corrects >> for the

Re: [Cake] overheads or rate calculation changed?

2018-01-06 Thread Jonathan Morton
> On 7 Jan, 2018, at 12:46 am, Sebastian Moeller wrote: > > I thibk cake should offer a mode in which it behaves as all other qdiscs > currently do and not do auto correction at all and a mode where it corrects > for the right amount, but keeping the current ake cbehavior will not help > anybo

Re: [Cake] overheads or rate calculation changed?

2018-01-06 Thread Sebastian Moeller
Hi Jonathan, > On Jan 6, 2018, at 21:44, Jonathan Morton wrote: > >> On 23 Dec, 2017, at 11:03 pm, Sebastian Moeller wrote: >> >> just had a look for hard_header_len in the linux kernel: >> linux/include/linux/netdevice.h: >> * @hard_header_len: Maximum hardware header length. >> * @

Re: [Cake] overheads or rate calculation changed?

2018-01-06 Thread Jonathan Morton
> On 23 Dec, 2017, at 11:03 pm, Sebastian Moeller wrote: > > just had a look for hard_header_len in the linux kernel: > linux/include/linux/netdevice.h: > * @hard_header_len: Maximum hardware header length. > * @min_header_len: Minimum hardware header length > > this seems to corrobor

Re: [Cake] overheads or rate calculation changed?

2017-12-24 Thread Sebastian Moeller
Hi Kevin, hi all, On December 24, 2017 11:46:31 AM GMT+01:00, Kevin Darbyshire-Bryant wrote: > > >> On 24 Dec 2017, at 10:39, Jonathan Morton >wrote: >> >> If you combine the 'raw' keyword with an overhead spec, that disables >the hard_header_len compensation. >> >> - Jonathan Morton > >Indee

Re: [Cake] overheads or rate calculation changed?

2017-12-24 Thread Sebastian Moeller
Hi Kevin, On December 24, 2017 11:34:15 AM GMT+01:00, Kevin Darbyshire-Bryant wrote: > > >> On 23 Dec 2017, at 21:03, Sebastian Moeller wrote: >> >> Hi All, >> >> just had a look for hard_header_len in the linux kernel: >> linux/include/linux/netdevice.h: >> * @hard_header_len: Maximum h

Re: [Cake] overheads or rate calculation changed?

2017-12-24 Thread Kevin Darbyshire-Bryant
> On 24 Dec 2017, at 10:39, Jonathan Morton wrote: > > If you combine the 'raw' keyword with an overhead spec, that disables the > hard_header_len compensation. > > - Jonathan Morton Indeed. I think all I’m proving is ‘make something idiot proof…..they’ll only go and improve the idiot’… i.

Re: [Cake] overheads or rate calculation changed?

2017-12-24 Thread Jonathan Morton
If you combine the 'raw' keyword with an overhead spec, that disables the hard_header_len compensation. - Jonathan Morton ___ Cake mailing list Cake@lists.bufferbloat.net https://lists.bufferbloat.net/listinfo/cake

Re: [Cake] overheads or rate calculation changed?

2017-12-24 Thread Kevin Darbyshire-Bryant
> On 23 Dec 2017, at 21:03, Sebastian Moeller wrote: > > Hi All, > > just had a look for hard_header_len in the linux kernel: > linux/include/linux/netdevice.h: > * @hard_header_len: Maximum hardware header length. > * @min_header_len: Minimum hardware header length > > this seems

Re: [Cake] overheads or rate calculation changed?

2017-12-23 Thread Jonathan Morton
> On 23 Dec, 2017, at 11:03 pm, Sebastian Moeller wrote: > > just had a look for hard_header_len in the linux kernel: > linux/include/linux/netdevice.h: > * @hard_header_len: Maximum hardware header length. > * @min_header_len: Minimum hardware header length > > this seems to corrobor

Re: [Cake] overheads or rate calculation changed?

2017-12-23 Thread Sebastian Moeller
Hi All, just had a look for hard_header_len in the linux kernel: linux/include/linux/netdevice.h: * @hard_header_len: Maximum hardware header length. * @min_header_len: Minimum hardware header length this seems to corroborate our observation that hard_header_len is not a veridical re

Re: [Cake] overheads or rate calculation changed?

2017-12-23 Thread Sebastian Moeller
Hi Ryan, > On Dec 23, 2017, at 14:11, Ryan Mounce wrote: > > On 4.9 I am seeing a max_len equal to my IP MTU of on PPPoE > interfaces, That is the traditional indicator, that the kernel does not automatically add overhead for ppp interfaces, and that still seems valid. > for both egress (har

Re: [Cake] overheads or rate calculation changed?

2017-12-23 Thread Ryan Mounce
On 4.9 I am seeing a max_len equal to my IP MTU of on PPPoE interfaces, for both egress (hard_header_len = 26) and ingress via ifb (hard_header_len = 14). At least this issue had been offset by the double-overhead bug for a little while :) Regards, Ryan Mounce On 23 December 2017 at 23:25, Sebas

Re: [Cake] overheads or rate calculation changed?

2017-12-23 Thread Sebastian Moeller
> On Dec 23, 2017, at 10:59, Andy Furniss wrote: > > Sebastian Moeller wrote: > >>> qdisc cake 1: dev enp6s0 root refcnt 2 bandwidth 19690Kbit diffserv3 >>> triple-isolate rtt 100.0ms noatm overhead 48 via-ethernet total_overhead 48 >>> hard_header_len 14 >> This looks like expected, the

Re: [Cake] overheads or rate calculation changed?

2017-12-23 Thread Andy Furniss
Sebastian Moeller wrote: qdisc cake 1: dev enp6s0 root refcnt 2 bandwidth 19690Kbit diffserv3 triple-isolate rtt 100.0ms noatm overhead 48 via-ethernet total_overhead 48 hard_header_len 14 This looks like expected, the in-kernel overhead is added to the specified overhead, just like

Re: [Cake] overheads or rate calculation changed?

2017-12-23 Thread Sebastian Moeller
Hi Andy, > On Dec 23, 2017, at 00:38, Andy Furniss wrote: > > Jonathan Morton wrote: >>> On 21 Dec, 2017, at 2:54 am, Andy Furniss wrote: >>> >>>refactor cake_advance_shaper and ack_filter >>> >>>cake_advance_shaper now returns a modified len argument to >>>reflect cake_overhead.

Re: [Cake] overheads or rate calculation changed?

2017-12-22 Thread Andy Furniss
Jonathan Morton wrote: On 21 Dec, 2017, at 2:54 am, Andy Furniss wrote: refactor cake_advance_shaper and ack_filter cake_advance_shaper now returns a modified len argument to reflect cake_overhead. skb_ack_filter variable replaced with ack Fixed. At one point cake_advance_sh

Re: [Cake] overheads or rate calculation changed?

2017-12-22 Thread Dave Taht
Thx andy and jon for the bisect and the fix. I am deep in the jungles of nicaragua at the moment, and won't be doing much with any codebases until I get out in mid january - the internet is terrible here, and where I am hasn't had power in a couple days, either! Expect sparse emails from me til th

Re: [Cake] overheads or rate calculation changed?

2017-12-22 Thread Kevin Darbyshire-Bryant
> On 22 Dec 2017, at 10:00, Jonathan Morton wrote: > > Git seems to regularly get confused when similar code changes occur in > parallel in different branches. In this case, I had the original version of > ingress mode while the public tree had the reconstructed version - almost > identical

Re: [Cake] overheads or rate calculation changed?

2017-12-22 Thread Jonathan Morton
Git seems to regularly get confused when similar code changes occur in parallel in different branches. In this case, I had the original version of ingress mode while the public tree had the reconstructed version - almost identical, but still constituting a merge conflict. I really don't know why

Re: [Cake] overheads or rate calculation changed?

2017-12-21 Thread Kevin Darbyshire-Bryant
> On 22 Dec 2017, at 06:38, Jonathan Morton wrote: > >> On 21 Dec, 2017, at 2:54 am, Andy Furniss wrote: >> >> refactor cake_advance_shaper and ack_filter >> >> cake_advance_shaper now returns a modified len argument to >> reflect cake_overhead. >> skb_ack_filter variable replaced wi

Re: [Cake] overheads or rate calculation changed?

2017-12-21 Thread Jonathan Morton
> On 21 Dec, 2017, at 2:54 am, Andy Furniss wrote: > >refactor cake_advance_shaper and ack_filter > >cake_advance_shaper now returns a modified len argument to >reflect cake_overhead. >skb_ack_filter variable replaced with ack Fixed. At one point cake_advance_shaper() was still

Re: [Cake] overheads or rate calculation changed?

2017-12-20 Thread Andy Furniss
Andy Furniss wrote: Been running a cake cobolt from april for some time using tc qdisc add dev ppp0 handle 1:0 root cake bandwidth 19690kbit raw overhead 34 diffserv4 dual-srchost nat rtt 200ms tc -s qdisc ls dev ppp0 (ppp0 is pppoe) qdisc cake 1: root refcnt 2 bandwidth 19690Kbit diffserv4

[Cake] overheads or rate calculation changed?

2017-12-18 Thread Andy Furniss
Been running a cake cobolt from april for some time using tc qdisc add dev ppp0 handle 1:0 root cake bandwidth 19690kbit raw overhead 34 diffserv4 dual-srchost nat rtt 200ms tc -s qdisc ls dev ppp0 (ppp0 is pppoe) qdisc cake 1: root refcnt 2 bandwidth 19690Kbit diffserv4 dual-srchost nat rtt