Re: [Cake] Munin-Plugins

2018-09-13 Thread Toke Høiland-Jørgensen
Ruben writes: > Hey guys, > > I've already mentioned this in a response to dtaht on GitHub, but here > again for everyone: > > I was wondering if it's possible to extend the tin statistics by > packets for backlog. Why do you need packets when there's already bytes? > Also I haven't found

Re: [Cake] Munin-Plugins

2018-09-13 Thread Ruben
Hey guys, I've already mentioned this in a response to dtaht on GitHub, but here again for everyone:I was wondering if it's possible to extend the tin statistics by packets for backlog.Also I haven't found details on the man page, but haven't looked in the code how exactly flows are defined for

Re: [Cake] [PATCH net] gso_segment: Reset skb->mac_len after modifying network header

2018-09-13 Thread Eric Dumazet
On 09/11/2018 03:19 PM, Toke Høiland-Jørgensen wrote: > When splitting a GSO segment that consists of encapsulated packets, the > skb->mac_len of the segments can end up being set wrong, causing packet > drops in particular when using act_mirred and ifb interfaces in > combination with a qdisc

Re: [Cake] [PATCH net] gso_segment: Reset skb->mac_len after modifying network header

2018-09-13 Thread Toke Høiland-Jørgensen
On 13 September 2018 16:11:18 CEST, Eric Dumazet wrote: > > >On 09/11/2018 03:19 PM, Toke Høiland-Jørgensen wrote: >> When splitting a GSO segment that consists of encapsulated packets, >the >> skb->mac_len of the segments can end up being set wrong, causing >packet >> drops in particular when

[Cake] [PATCH net v2] gso_segment: Reset skb->mac_len after modifying network header

2018-09-13 Thread Toke Høiland-Jørgensen
When splitting a GSO segment that consists of encapsulated packets, the skb->mac_len of the segments can end up being set wrong, causing packet drops in particular when using act_mirred and ifb interfaces in combination with a qdisc that splits GSO packets. This happens because at the time

Re: [Cake] [PATCH net] gso_segment: Reset skb->mac_len after modifying network header

2018-09-13 Thread Dave Taht
On Thu, Sep 13, 2018 at 7:11 AM Eric Dumazet wrote: > > > > On 09/11/2018 03:19 PM, Toke Høiland-Jørgensen wrote: > > When splitting a GSO segment that consists of encapsulated packets, the > > skb->mac_len of the segments can end up being set wrong, causing packet > > drops in particular when

Re: [Cake] Munin-Plugins

2018-09-13 Thread Ruben
Hey Toke,Thanks for your fast response!Am 13.09.2018 12:27 schrieb Toke Høiland-Jørgensen :Ruben writes: > Hey guys, > > I've already mentioned this in a response to dtaht on GitHub, but here > again for everyone: > > I was wondering if it's possible to extend the tin statistics by >

Re: [Cake] Munin-Plugins

2018-09-13 Thread Toke Høiland-Jørgensen
Ruben writes: > Hey Toke, > > Thanks for your fast response! > > Am 13.09.2018 12:27 schrieb Toke Høiland-Jørgensen : > > > Ruben writes: > > > Hey guys, > > > > I've already mentioned this in a response to dtaht on GitHub, but here > > again for everyone: > > > > I

Re: [Cake] [PATCH net v2] gso_segment: Reset skb->mac_len after modifying network header

2018-09-13 Thread David Miller
From: Toke Høiland-Jørgensen Date: Thu, 13 Sep 2018 16:43:07 +0200 > When splitting a GSO segment that consists of encapsulated packets, the > skb->mac_len of the segments can end up being set wrong, causing packet > drops in particular when using act_mirred and ifb interfaces in > combination