Re: Download the calligra suite.

2023-04-30 Thread Dag
404 Not Found URI: /job/Calligra_Nightly_win64/ STATUS: 404 MESSAGE: Not Found SERVLET: Stapler -- Powered by Jetty:// 9.4.33.v20201020 <https://eclipse.org/jetty> Could you please put back the windows downloads please? Thank you! -- Mvh Dag

Re: Usability Testing for Calligra as part of study project

2023-04-05 Thread Dag
the amount of support may be limited. @thomas Is it something you would be interrested in? It would be interresting to hear your reasons for selecting calligra for this study. -- Mvh Dag

Re: Calligra Downloads not working

2023-01-23 Thread Dag
://binary-factory.kde.org/job/Calligra_Nightly_win32/ I know why you want to remove the downloads. Probably because to save bandwidth. Not quite, they were removed because calligra does not build atm and has not for quite some time. We need somebody with windows/mac knowledge to fix it. -- Mvh Dag

Re: Autocorrect functionality

2022-10-26 Thread Dag
data and LO data. . Copy data automatically from LO at release time keeping data format, Install both calligra data and LO data. I don't particulary like any of these, but trying to be practical... -- Mvh Dag

Re: How do I install and use Calligra Plan?

2022-07-27 Thread Dag
://binary-factory.kde.org/ But note that it is a development version so bugs must be expected. That said, any testing/feedback is appreciated. Mvh Dag Thank you. Regards, Mr. Turritopsis Dohrnii Teo En Ming Targeted Individual in Singapore 20 July 2022 Wed Blogs: https://tdtemcerts.blogspot.com

Re: Release

2021-12-15 Thread Dag
tirsdag den 14. december 2021 12.08.46 CET skrev Pierre: On Monday, December 13, 2021 8:28:44 AM CET Dag wrote: @pierre: If I'm not mistaken you are planning a new release soon? I cannot see that you have created a release branch, so presumely string- and feature freeze are in effect? Do you

Release

2021-12-12 Thread Dag
@pierre: If I'm not mistaken you are planning a new release soon? I cannot see that you have created a release branch, so presumely string- and feature freeze are in effect? Do you have a target date in mind? Also I have created a few merge requests that you might want to get in. -- Mvh Dag

Re: Krita donation proposal

2021-11-17 Thread Dag
to spend that money, so what should we do? Not that I want to be greedy, but if Calligra cannot spend it on anything, I'm find with taking a larger share for Krita... No objections from me. And is there a way to spend it on Plan? No, I don't think so. Mvh, Dag Cheers, Halla Rempt

Words and large files

2021-03-22 Thread Dag
by e.g. only re-layout dirty pages before and including the displayed page(s). -- Mvh Dag

Merge requests

2020-07-17 Thread Dag
https://invent.kde.org/office/calligra/-/merge_requests -- Mvh Dag

Re: Annotation shape

2020-06-17 Thread Dag
tirsdag den 16. juni 2020 12.30.00 CEST skrev Dag: The annotation shape seems only to be usable as a comment in words. Adding it as a plain shape does not make sence as it will behave as any shape with run-around text etc, but it will never be printed: Goodby wysiwyg. I can also add

Annotation shape

2020-06-16 Thread Dag
know what that means) -- Mvh Dag

Re: Merge request sheets

2020-06-11 Thread Dag
To be notified, everyone interested should star the repo (right top part of the repo's main page) and make it watched (the bell icon). Ahh, thanks. Best regards, Yuri

Merge request sheets

2020-06-11 Thread Dag
Hi, added my first merge request to invent. Doesn't seem to produce any notifications and I have not figured out how to add reviewers, hence this mail. The request: https://invent.kde.org/office/calligra/-/merge_requests/1 -- Cheers, Dag

Bugfix release 3.2.1 planned tomorrow Thursday 2020-05-14

2020-05-13 Thread Dag
Release needs to be tomorrow because of move to invent.kde.org -- Cheers, Dag

D29542: Refactor canvas event handling

2020-05-13 Thread Dag Andersen
danders added a comment. This seems to work fine, I also tested with only pageapp changes. Imho I would prefer to separate the pageapp and KoMainWindow changes into separate commits, The pageapp changes should go into 3.2 branch followed by a swift release. I don't think the

D29542: Refactor MainWindow view

2020-05-11 Thread Dag Andersen
danders added a comment. In D29542#668076 , @anthonyfieroni wrote: > `d->rootPart->createView(doc, this);` Creates the view which parent is main window. Ahh, yes, but then... Why will it not crash if a new document is set so that

D29542: Refactor MainWindow view

2020-05-11 Thread Dag Andersen
danders added a comment. Hmmm, it seems to me you are creating a leak in your lines 544, 545? (Have not tested, I might be wrong) Afaics the problem is that a focus event is issued that accesses the view after death. Possibly a deleteLater() would do it, but I tried with setting paret

Version 3.2.0 released, changelog

2020-04-24 Thread Dag
Freezes lifted. I have extracted changes from git log and tried to weed out everything not interresting to a user. Please check it out and correct mistakes, omissions etc. @leinir clueless on gemini, so please review. -- Cheers, Dag Gemini: --- Author: Andrew den Exter Add a readOnly

D28820: Chart: Fix Bug 240520 - No axes lines when creating new chart

2020-04-17 Thread Dag Andersen
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:240fb4f60810: Chart: Fix Bug 240520 - No axes lines when creating new chart (authored by danders). REPOSITORY R8

Re: Calligra release 3.2 next Thursday 23.

2020-04-16 Thread Dag
On 16-04-2020 11:31, Dag wrote: We plan to release calligra next Thursday 23rd and string freeze is in effect. There are not a lot of new strings so I hope the time frame is ok. Any protests, and we will dealy. Ahhh, release from trunk.

Calligra release 3.2 next Thursday 23.

2020-04-16 Thread Dag
We plan to release calligra next Thursday 23rd and string freeze is in effect. There are not a lot of new strings so I hope the time frame is ok. Any protests, and we will dealy. -- Cheers, Dag

D28820: Chart: Fix Bug 240520 - No axes lines when creating new chart

2020-04-14 Thread Dag Andersen
danders created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Turns out KChart needs a explicitly set pen to draw ruler lines. KChart 2.7.0 will have the option to set a pen int

Re: Translation issues with the calligraplan documentation

2020-03-27 Thread Dag
Dag skrev den 2020-03-26 09:57: I have adjusted the structure so now xml2po extracts all texts, at least. Haven't tested if xml2po works. Also noted there are problems with keycode/keycap, but let's see if my changes is enough to generate translated docs. After further investigation

Re: stable branch

2020-03-26 Thread Dag
Jonathan Riddell skrev den 2020-03-26 17:44: The stable branch for calligra is still set to calligra/3.1 but the current release series is 3.2 from master. Can this be fixed? Calligra stable is still 3.1. Could this be a mixup with calligraplan? Dag Jonathan

Re: Translation issues with the calligraplan documentation

2020-03-26 Thread Dag
I have adjusted the structure so now xml2po extracts all texts, at least. Haven't tested if xml2po works. Also noted there are problems with keycode/keycap, but let's see if my changes is enough to generate translated docs. --- Cheers, Dag Luigi Toscano skrev den 2020-03-24 23:33: >

T12815: Create Calligra Framework by separating out applications and libraries

2020-03-19 Thread Dag Andersen
danders added a comment. I think where leinir has landed is more doable than a frameworks. Also if compiletime is a big hurdle, I see a couple of things that can be done: - Remove pigment, see T5738 . - Make more finegrained productsets. Pt the

D7228: SpellCheck: Fix markup rebasing when simple edits are done (one char added)

2020-03-13 Thread Dag Andersen
danders abandoned this revision. danders added a comment. Herald added a subscriber: Calligra-Devel-list. Has been comitted REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D7228 To: danders, boemann Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb,

D11191: Remove Plan dependencies from CMakeLists.txt

2020-03-13 Thread Dag Andersen
danders closed this revision. Herald added a subscriber: Calligra-Devel-list. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D11191 To: kavindap, #calligra:_3.0, staniek Cc: Calligra-Devel-list, staniek, danders, davidllewellynjones, dcaliste, ognarb, cochise,

D15775: Make the item background color and page cache properties available from View component

2020-03-13 Thread Dag Andersen
danders added a comment. ping REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15775 To: dcaliste, leinir, danders, anthonyfieroni, #calligra:_3.0 Cc: boemann, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D25034: Fix decoding of strings with wingdings/symbol characters in excel TxO records.

2020-03-13 Thread Dag Andersen
danders added a comment. ping REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25034 To: denexter, pvuorela, mkruisselbrink Cc: danders, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D26050: Fix build with poppler 82

2020-03-13 Thread Dag Andersen
danders added a reviewer: danders. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26050 To: tcanabrava, #calligra:_3.0, danders Cc: danders, rjvbb, awilcox, dcaliste, leinir, asturmlechner, ognarb, anthonyfieroni, Calligra-Devel-list, davidllewellynjones, cochise,

D22545: Add missing include QDate

2020-03-13 Thread Dag Andersen
danders closed this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D22545 To: usta, #calligra:_3.0, Calligra-Devel-list, boemann Cc: dfaure, pino, boemann, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D25714: [WIP]: Port away from deprecated KHtml

2020-03-12 Thread Dag Andersen
danders added a comment. Still wip, or... REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25714 To: ognarb, #calligra:_3.0 Cc: danders, leinir, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D25008: Add XLSX spreadsheets import optimisations for small/readonly devices

2020-03-12 Thread Dag Andersen
danders added a comment. ping? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25008 To: davidllewellynjones, #calligra:_3.0, pvuorela, dcaliste Cc: danders, anthonyfieroni, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D24852: Remove list style from headings

2020-03-12 Thread Dag Andersen
danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. Most seems to be positive, so go for it. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24852 To: akomakhin, pvuorela, #calligra:_3.0, boemann, danders Cc:

D26050: Fix build with poppler 82

2020-03-12 Thread Dag Andersen
danders added a comment. @tcanabrava please abondone this. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26050 To: tcanabrava, #calligra:_3.0 Cc: danders, rjvbb, awilcox, dcaliste, leinir, asturmlechner, ognarb, anthonyfieroni, Calligra-Devel-list,

D2577: KoResourcePaths: Fix handling of wildcards in directories and files

2020-03-12 Thread Dag Andersen
danders abandoned this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D2577 To: danders, #calligra:_3.0, staniek, Calligra-Devel-list Cc: anthonyfieroni, staniek, davidllewellynjones, dcaliste, ognarb, barman, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

2020-03-12 Thread Dag Andersen
danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. There are unit tests that fail without this, so if somebody doas not come up with code that shows this is wrong, please commit. REPOSITORY R8 Calligra REVISION DETAIL

D26328: Calculate and display proper number for headings started with lower level for DOC, DOCX and ODT.

2020-03-12 Thread Dag Andersen
danders added a comment. Any comments, anyone? I have not tested and does not know if it is the right way to do it. If nobody have comments, I'm willing to trust the author and say go for it! REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26328 To: mphilippov,

D26328: Calculate and display proper number for headings started with lower level for DOC, DOCX and ODT.

2020-03-09 Thread Dag Andersen
danders added a reviewer: boemann. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26328 To: mphilippov, pvuorela, denexter, dcaliste, davidllewellynjones, boemann Cc: davidllewellynjones, dcaliste, denexter, pvuorela, Calligra-Devel-list, #calligra:_3.0, ognarb,

D25423: Fill table cells with color for ODS and XLSX files

2020-03-09 Thread Dag Andersen
danders added a comment. ping? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25423 To: mphilippov, denexter, pvuorela, davidllewellynjones, dcaliste Cc: danders, dcaliste, davidllewellynjones, denexter, Calligra-Devel-list, #calligra:_3.0, ognarb, cochise,

D25422: Handle custom-shapes to display text in ODP files

2020-03-09 Thread Dag Andersen
danders added a comment. ping? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25422 To: mphilippov, denexter, davidllewellynjones, pvuorela, dcaliste Cc: danders, denexter, pvuorela, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D26050: Fix build with poppler 82

2020-03-09 Thread Dag Andersen
danders added a comment. Ooops, seems I fixed this (+ 0.83) in separate commits, so this can be closed. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26050 To: tcanabrava, #calligra:_3.0 Cc: danders, rjvbb, awilcox, dcaliste, leinir, asturmlechner, ognarb,

D26221: Use QQC2 Dialog

2020-03-09 Thread Dag Andersen
danders added a comment. ping? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26221 To: ognarb, #calligra:_3.0, leinir Cc: danders, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D25254: Remove flow, not needed since karbon can do it all

2020-03-03 Thread Dag Andersen
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:f8786b001b75: Remove flow, not needed since karbon can do it all (authored by danders). REPOSITORY R8 Calligra

Re: New website

2020-03-03 Thread Dag
of more maintainers would like access, but I'm sure they can speak up for themselves :) --- Cheers, Dag Carl Schwan skrev den 2020-03-02 16:42: > Hello, > the website progressed a lot during Season of KDE and it was completly > updated. Thanks a lot to Anuj Bansal for

D27056: Stage: Add automatic slide transition

2020-02-05 Thread Dag Andersen
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:4f4141727401: Stage: Add automatic slide transition (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST

D27056: Stage: Add automatic slide transition

2020-01-31 Thread Dag Andersen
danders created this revision. danders added a reviewer: zachmann. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Introduces 2 modes for slide transitions: Manual: Slide transition and

D25664: [WIP]: Port away from deprecated QSignalMapper

2019-12-02 Thread Dag Andersen
danders added a comment. Afaik we still support qt5.3, I don't think qAsConst is availabel. Disregard if this has changed. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25664 To: ognarb, #calligra:_3.0, #kf6, dfaure Cc: danders, dfaure, Calligra-Devel-list,

D25254: Remove flow, not needed since karbon can do it all

2019-11-14 Thread Dag Andersen
danders added a comment. In D25254#561131 , @boemann wrote: > To be honest I kind of liked the idea of a dedicated flow drawing tool and a dedicated vector drawing tool, but since they have so little between them, and no one seem to be

D25254: Remove flow, not needed since karbon can do it all

2019-11-11 Thread Dag Andersen
danders added a comment. Yeah, well. If flow had some special functionallity that made it much easier to crate flow charts, I would also be reluctant to just remove it. As it stands flow has nothing special, it is only a few line of code actually, and as I see it, the karbon ui is very

D25254: Remove flow, not needed since karbon can do it all

2019-11-11 Thread Dag Andersen
danders created this revision. danders added a reviewer: anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Since karbon is multipage app and stencils docker can be used by all apps,

D25214: Karbon image filter: Add multipage support

2019-11-11 Thread Dag Andersen
This revision was automatically updated to reflect the committed changes. Closed by commit R8:0daf145a929a: Karbon image filter: Add multipage support (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25214?vs=69566=69567 REVISION DETAIL

D25214: Karbon image filter: Add multipage support

2019-11-11 Thread Dag Andersen
danders updated this revision to Diff 69566. danders added a comment. Remove unused include REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25214?vs=69438=69566 BRANCH multipage_image_danders REVISION DETAIL https://phabricator.kde.org/D25214 AFFECTED

D25214: Karbon image filter: Add multipage support

2019-11-08 Thread Dag Andersen
danders created this revision. danders added a reviewer: anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Adds ability to select page in the options dialog TEST PLAN Export to

D25171: PDF Import: Add multipage support

2019-11-08 Thread Dag Andersen
This revision was automatically updated to reflect the committed changes. Closed by commit R8:c81c23998e09: PDF Import: Add multipage support (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25171?vs=69423=69424 REVISION DETAIL

D25171: PDF Import: Add multipage support

2019-11-06 Thread Dag Andersen
danders created this revision. danders added a reviewer: anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY Imports multipage pdf files as svg using poppler to generate an svg file pr

D20400: Karbon: Enable multi page capability

2019-11-05 Thread Dag Andersen
This revision was automatically updated to reflect the committed changes. Closed by commit R8:5a9a18f484a4: Karbon: Enable multi page capability (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20400?vs=69263=69300 REVISION DETAIL

D20400: Karbon: Enable multi page capability

2019-11-05 Thread Dag Andersen
danders added a comment. In D20400#475477 , @anthonyfieroni wrote: > Now we have insert page, but we don't exports them :) If you think that's ok for now go for it. Just for the record: The pdf filter goes through the svg filter and as

D20400: Karbon: Enable multi page capability

2019-11-04 Thread Dag Andersen
danders updated this revision to Diff 69263. danders added a comment. KarbonView: Add slot to handle replaceActivePage REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20400?vs=69262=69263 BRANCH karbon_multipage_danders REVISION DETAIL

D20400: Karbon: Enable multi page capability

2019-11-04 Thread Dag Andersen
danders updated this revision to Diff 69262. danders added a comment. SvgImport: Add the new layer to the page REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20400?vs=69152=69262 BRANCH karbon_multipage_danders REVISION DETAIL

D20400: Karbon: Enable multi page capability

2019-11-01 Thread Dag Andersen
danders updated this revision to Diff 69152. danders added a comment. Handle removing pages from a pageapp properly REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20400?vs=59256=69152 BRANCH karbon_multipage_danders REVISION DETAIL

D20400: Karbon: Enable multi page capability

2019-06-07 Thread Dag Andersen
danders added a comment. In D20400#475477 , @anthonyfieroni wrote: > Now we have insert page, but we don't exports them :) If you think that's ok for now go for it. If you mean export to svg here, afaics there are no page element in

D20400: Karbon: Enable multi page capability

2019-06-06 Thread Dag Andersen
danders updated this revision to Diff 59256. danders added a comment. Add dependence on LIB_KOPAGEAPP REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20400?vs=55797=59256 BRANCH karbon_multipage_danders REVISION DETAIL

D20400: Karbon: Enable multi page capability

2019-06-05 Thread Dag Andersen
danders added a comment. I have been pondering why we disagreed so much on the background color, and I *think* I have an answer. My take is it's because we have not been talking about quite the same thing: I have looked at karbon as an *odg* editor, since it uses odg as its native file

D20400: Karbon: Enable multi page capability

2019-04-09 Thread Dag Andersen
danders added a comment. Ooops, this didn't work as expected. This should have been a revision of D19327 . There is only small changes: 1. Updated commit message. 2. In karbon/ui/KarbonFactory.cpp: Loading of the calligra/pageapp tools. 3. In

D20400: Karbon: Enable multi page capability

2019-04-09 Thread Dag Andersen
danders created this revision. danders added a reviewer: anthonyfieroni. danders added a project: Calligra: 3.0. danders requested review of this revision. REVISION SUMMARY Since odg spec supports multiple pages, I feel karbon also needs to support it. The main things that has changed:

T10760: Calligra website unwanted blog content

2019-04-05 Thread Dag Andersen
danders added a comment. It seems I have not the privileges to fix this. Can someone else have a look? TASK DETAIL https://phabricator.kde.org/T10760 To: danders Cc: danders, #sysadmin, Calligra-Devel-list, #calligra:_3.0, ongunkanat, sysadmin

D11971: Use same keyword separator for read and write

2019-03-25 Thread Dag Andersen
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:e52edfd1b50f: D11971: Use same keyword separator for read and write (authored by danders). CHANGED PRIOR TO COMMIT

D11971: Use same keyword separator for read and write

2019-03-25 Thread Dag Andersen
danders added a comment. Yes, looks sane, I'll deal with it. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D11971 To: michaelh, #calligra:_3.0, leinir, danders Cc: Calligra-Devel-list, anthonyfieroni, dcaliste, cochise, vandenoever

D19884: Avoid deprecated QAbstractItemModel::reset()

2019-03-25 Thread Dag Andersen
danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. I think this should be ok REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19884 To: pvuorela, danders Cc: danders, dcaliste, Calligra-Devel-list, cochise,

D19973: MsooXmlCommonRead: protect member for double free

2019-03-25 Thread Dag Andersen
danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19973 To: pvuorela, #calligra:_3.0, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19941: Avoid deprecated setSupportedDragActions

2019-03-22 Thread Dag Andersen
danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19941 To: pvuorela, #calligra:_3.0, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19938: Avoid deprecated QRegion::subtract()

2019-03-21 Thread Dag Andersen
danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19938 To: pvuorela, #calligra:_3.0, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19912: Implement logging category for rtf-qt

2019-03-20 Thread Dag Andersen
danders added a comment. In D19912#435067 , @pvuorela wrote: > In D19912#435058 , @danders wrote: > > > Strange indents, could you fix it? > > > That's what I commented on the summary. On some

D19912: Implement logging category for rtf-qt

2019-03-20 Thread Dag Andersen
danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. Strange indents, could you fix it? Otherwise ok. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19912 To: pvuorela, danders Cc: danders, Calligra-Devel-list,

D19885: Implement logging category for excel plugins

2019-03-20 Thread Dag Andersen
danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19885 To: pvuorela, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19759: Remove Qt::WA_InputMethodEnabled attribute from QGraphicsWidgets

2019-03-15 Thread Dag Andersen
danders added a reviewer: boemann. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19759 To: pvuorela, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19760: Support Qt <5.7 on KoShape flag usage

2019-03-15 Thread Dag Andersen
danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19760 To: pvuorela, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19761: Remove obsolete syncX() workaround

2019-03-15 Thread Dag Andersen
danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19761 To: pvuorela, danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

2019-03-07 Thread Dag Andersen
danders added a comment. In D19216#421689 , @rjvbb wrote: > > That is actual a valid point, although in say Krita with transparent pixels a checkerboard is shown. > > Heh, I've had the opportunity to work closely with professional

D19327: Karbon: Enable multi page capability

2019-02-25 Thread Dag Andersen
danders created this revision. danders added a reviewer: anthonyfieroni. danders added a project: Calligra: 3.0. danders requested review of this revision. REVISION SUMMARY Since odg spec supports multiple pages, I feel karbon also needs to support it. Ported to use pageapp classes.

D15428: [textlayout] Don't enter infinite loop when table is misfit

2019-02-25 Thread Dag Andersen
danders added a comment. Can we get a conclussion to this? @Camilla Have you come up with any more unit tests? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15428 To: anthonyfieroni, #calligra:_3.0, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise,

D19216: Karbon: Enable multi page capability

2019-02-25 Thread Dag Andersen
danders marked an inline comment as done. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19216 To: danders, anthonyfieroni Cc: boemann, rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

2019-02-25 Thread Dag Andersen
danders added inline comments. INLINE COMMENTS > anthonyfieroni wrote in KarbonConfigInterfacePage.cpp:73-90 > We can remove "number of recent files" since other apps does not have it. but > for other 2 i don't see why we remove them, someone can found useful > (somehow). About me, i want them

D19216: Karbon: Enable multi page capability

2019-02-25 Thread Dag Andersen
danders added a comment. In D19216#417502 , @rjvbb wrote: > > Canvas color: > > I don't quite see what it is for. You can set a background color for the canvas but it is only for the views, it is not printed. > > A custom canvas colour

D19216: Karbon: Enable multi page capability

2019-02-22 Thread Dag Andersen
danders added inline comments. INLINE COMMENTS > anthonyfieroni wrote in KarbonConfigInterfacePage.cpp:73-90 > I want to discuss comments in the review, i don't want to have in. why we > remove this? Recent file & docker font: Why does karbon need these, none of the other apps have it.

D19216: Karbon: Enable multi page capability

2019-02-22 Thread Dag Andersen
danders added a comment. In D19216#417288 , @rjvbb wrote: > This would indeed be great to have; even a page selector when importing a multi-page document would be an improvement (the Adobe Illustrator version I've use had that; IIRC it would

D19132: Update libs/widgets to c++11

2019-02-21 Thread Dag Andersen
danders added a comment. > Thanks for the review, I will work next on libs/{pigment,version,widgetutils}. Hmm, maybe wait with pigment, according to rempt, only krita actually used it. I haven't looked into it, but if that is the case probably we should dump it. REPOSITORY R8

D19132: Update libs/widgets to c++11

2019-02-21 Thread Dag Andersen
danders accepted this revision. danders added a comment. This revision is now accepted and ready to land. Ok, I can't say I have scrutinized every change, but... Could you give a heads up when you continue with other parts or else there may be merge problems. I'm working on karbon and

D19132: Update libs/widgets to c++11

2019-02-19 Thread Dag Andersen
danders added a reviewer: leinir. danders added a comment. Hmmm. wasn't it somethng with ms windows and for loops, leinir? Also, I think there may be detachment issues with them, clazy can tell. There is a qAsConst() solution but that is not supported in the qt version we need to support.

D18466: Fixed calligra crashing when opening remote document

2019-02-14 Thread Dag Andersen
danders added a comment. Thanks, I'm checking it out now... Just a couple of things: Keywords needs to be on a separate line to have effect, see https://community.kde.org/Infrastructure/Git/Hooks Also FIXED-IN is nice to add. I've updated and closed the bug, so no problem.

D18963: Improve KoModeBox display in horizontal Mode

2019-02-13 Thread Dag Andersen
danders added a comment. Please remove trailing whitespace. REPOSITORY R8 Calligra BRANCH calligra/3.1 REVISION DETAIL https://phabricator.kde.org/D18963 To: ognarb, #calligra:_3.0, #vdg, boemann Cc: danders, boemann, anthonyfieroni, abetts, ngraham, Calligra-Devel-list, dcaliste,

D18466: Fixed calligra crashing when opening remote document

2019-02-13 Thread Dag Andersen
danders added a comment. In D18466#411248 , @boemann wrote: > Dan can you please reply - I'm fine with the account but I can't reply to Ben as I am not able to send email Yes, I have, and just answered again in case something went wrong

D18866: Use check_symbol_exists instead of check_function_exists

2019-02-11 Thread Dag Andersen
danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra BRANCH master REVISION DETAIL https://phabricator.kde.org/D18866 To: heikobecker, danders Cc: pino, danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18866: Use check_symbol_exists instead of check_function_exists

2019-02-09 Thread Dag Andersen
danders added a comment. What about the other ​check_function_exists, should they also be changed? Also, do you know when ​check_symbol_exists was introduced? We still use cmake 2.8.12. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18866 To: heikobecker Cc:

D18843: Activate stencils docker in all apps

2019-02-08 Thread Dag Andersen
danders created this revision. danders added reviewers: boemann, anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY The docker now loads in separate thread and is hidden by default,

D18841: StencilBoxDocker: Make the docker collapsed by default

2019-02-08 Thread Dag Andersen
danders abandoned this revision. danders added a comment. mistake REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18841 To: danders Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18841: StencilBoxDocker: Make the docker collapsed by default

2019-02-08 Thread Dag Andersen
danders created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY WIP REPOSITORY R8 Calligra BRANCH activate_stencils_danders REVISION DETAIL

  1   2   3   4   >