Re: Review Request: fix KisPaintOpPresetsPopup to use an existing icon for the paintPresetIcon button

2012-07-22 Thread Friedrich W. H. Kossebau
/#review16207 --- On July 22, 2012, 3:48 p.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105669

Review Request: fixes Karbon using icon effectimages which is only installed by kipi plugins

2012-07-22 Thread Friedrich W. H. Kossebau
/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: remove use of non-existing icon duplicate in Braindump

2012-07-22 Thread Friedrich W. H. Kossebau
with no icon here? (should be used in Karbon and possibly elsewhere as well) Okay to backport to 2.5? Diffs - braindump/src/View.cpp 4356654 Diff: http://git.reviewboard.kde.org/r/105672/diff/ Testing --- Thanks, Friedrich W. H. Kossebau

Re: Missing icons in music shape

2012-07-22 Thread Friedrich W. H. Kossebau
Am Dienstag, 10. Juli 2012, 12:04:32 schrieb Friedrich W. H. Kossebau: Hi Marijn, pushing for icon completeness, I found the music shape misses the following icons in the repository: music-clef-trebble plugins/musicshape/actions/SetClefAction.cpp:41 music-clef plugins

Really missing icons in C 2.5

2012-07-22 Thread Friedrich W. H. Kossebau
Hi, so after another review of the missing icons, where I managed to find solutions for some (see e.g. today's small patch flood :) ), this email now might have the final list of icons which are definitely missing for Calligra (2.5 and surely also master). Missing icons can be grouped into:

Re: Review Request: fixes Karbon using icon effectimages which is only installed by kipi plugins

2012-07-22 Thread Friedrich W. H. Kossebau
, visit: http://git.reviewboard.kde.org/r/105671/#review16238 --- On July 22, 2012, 5:23 p.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply

Re: Anybody working on text column separators?

2012-07-21 Thread Friedrich W. H. Kossebau
Am Freitag, 20. Juli 2012, 07:24:13 schrieb C. Boemann: On Thursday 19 July 2012 17:50:12 Friedrich W. H. Kossebau wrote: Hi, I came across the issue that columns in texts are not yet completely supported. Is anyone working on that? For a start I did a patch (attached) which makes

Re: Review Request: adds a VectorShapeConfigWidget which gets shown on shape creation (like with PictureShape)

2012-07-20 Thread Friedrich W. H. Kossebau
--- On July 20, 2012, 2:59 a.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105624

Re: Review Request: adds a VectorShapeConfigWidget which gets shown on shape creation (like with PictureShape)

2012-07-20 Thread Friedrich W. H. Kossebau
renderer in Qt. Friedrich W. H. Kossebau wrote: So the new text should be A shape that shows a vector image (EMF/WMF/SVM), you mean? For consistency that would need a change in the tool's text as well: setToolTip( i18n( EMF/WMF/SVM Vector Shape tool ) ); Can we expect SVM

Anybody working on text column separators?

2012-07-19 Thread Friedrich W. H. Kossebau
Hi, I came across the issue that columns in texts are not yet completely supported. Is anyone working on that? For a start I did a patch (attached) which makes at least the column separator data survive a roundtrip through Words. Might be worth to add as bugfix to 2.5. What do you think? For

Re: Review Request: adds a VectorShapeConfigWidget which gets shown on shape creation (like with PictureShape)

2012-07-19 Thread Friedrich W. H. Kossebau
://git.reviewboard.kde.org/r/105624/diff/ Testing (updated) --- Edited ODT files with WMF files (adding, removing, changing) and did roundtrips with LO 3.5.3 Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https

Re: [calligra] libs/kotext/styles: fixes wrong writing of double-border style also with a non-double border

2012-07-17 Thread Friedrich W. H. Kossebau
Am Dienstag, 17. Juli 2012, 18:01:44 schrieb Thorsten Zachmann: Hello Friedrich, On Tuesday 17 July 2012 17:10:44 Friedrich W. H. Kossebau wrote: Aha, thanks. So this means the parsing code is broken. And fixing it needs somebody writing non-trivial parsing code :/ Anyknown knows

Review Request: fix parsing of fo:border in KoParagraphStyle

2012-07-17 Thread Friedrich W. H. Kossebau
/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: fix parsing and writing of style:shadow value

2012-07-17 Thread Friedrich W. H. Kossebau
testParagraphStyle no longer fails on anything for me. Okay to backport to 2.5? Diffs - libs/kotext/styles/tests/TestOpenDocumentStyle.cpp d0aadd4 libs/odf/KoShadowStyle.cpp c12ee92 Diff: http://git.reviewboard.kde.org/r/105606/diff/ Testing --- Thanks, Friedrich W. H

Re: Review Request: Fixed 'value may be used uninitialized' warnings

2012-07-16 Thread Friedrich W. H. Kossebau
m_svgChWidth; //! set by read_chExt() int m_svgChHeight; //! set by read_chExt() All are never initialized if their string is empty. And as the other STRING_TO_* macros seem to follow the same pattern, there is even more to do :) - Friedrich W. H. Kossebau On July 11, 2012, 9:43 p.m., Jarosław

Review Request: fix icon of picture tool

2012-07-15 Thread Friedrich W. H. Kossebau
/pictureshape/PictureToolFactory.cpp cc47406 Diff: http://git.reviewboard.kde.org/r/105581/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: RC readiness, not

2012-07-14 Thread Friedrich W. H. Kossebau
Hi, Am Freitag, 13. Juli 2012, 19:07:21 schrieb Thorsten Zachmann: Hello, On Friday 13 July 2012 16:11:24 Cyrille Berger Skott wrote: Hum, the question that needs to be answered at this point is: is calligra 2.5 worse or better than calligra 2.4.3. If it is better (ie no regressions,

Review Request: fixes KWOdfWriter to write tracked changes before declarations (ODF 1.2 spec wants that)

2012-07-13 Thread Friedrich W. H. Kossebau
- words/part/KWOdfWriter.cpp b061b96 Diff: http://git.reviewboard.kde.org/r/105545/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: fix improve template generation code

2012-07-13 Thread Friedrich W. H. Kossebau
http://git.reviewboard.kde.org/r/105406/s/631/ Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: fix improve template generation code

2012-07-13 Thread Friedrich W. H. Kossebau
. patch http://git.reviewboard.kde.org/r/105406/s/631/ Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: RC readiness, not

2012-07-13 Thread Friedrich W. H. Kossebau
Am Donnerstag, 12. Juli 2012, 17:06:51 schrieb C. Boemann: On Thursday 12 July 2012 16:46:34 Cyrille Berger Skott wrote: On Thursday 12 Jul 2012, C. Boemann wrote: Hi We still have two release blockers, so it would seem we need another week before RC tagging That would be

Re: Review Request: make parsing of fo:clip more strict, but also backward compatible

2012-07-12 Thread Friedrich W. H. Kossebau
. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105528/#review15738 --- On July 12, 2012, 6:52 p.m., Friedrich W. H. Kossebau wrote

Re: Review Request: make parsing of fo:clip more strict, but also backward compatible

2012-07-12 Thread Friedrich W. H. Kossebau
://git.reviewboard.kde.org/r/105528/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: make parsing of fo:clip more strict, but also backward compatible

2012-07-12 Thread Friedrich W. H. Kossebau
://git.reviewboard.kde.org/r/105528/#review15740 --- On July 12, 2012, 7:17 p.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: fix/restore thumbnailing for Words

2012-07-12 Thread Friedrich W. H. Kossebau
the issues here. Anyway no objection for me if it works. ok to backport too (I trust you have tested well) Friedrich W. H. Kossebau wrote: Seemed to me like the only way to get a shapemanager. But after your nagging I researched a little more and now found what

Review Request: fixes broken writing of number:text-style

2012-07-12 Thread Friedrich W. H. Kossebau
/r/105530/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: replace deprecated KLocale::fragDigits with KLocale::monetaryDecimalNumbers in Calligra Sheets

2012-07-12 Thread Friedrich W. H. Kossebau
--- On July 10, 2012, 6:18 a.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105501

Review Request: replace deprecated KLocale::fragDigits with KLocale::monetaryDecimalNumbers in Calligra Sheets

2012-07-10 Thread Friedrich W. H. Kossebau
://git.reviewboard.kde.org/r/105501/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Missing icons in music shape

2012-07-10 Thread Friedrich W. H. Kossebau
Hi Marijn, pushing for icon completeness, I found the music shape misses the following icons in the repository: music-clef-trebble plugins/musicshape/actions/SetClefAction.cpp:41 music-clef plugins/musicshape/actions/SetClefAction.cpp:44 music-clef-alto

Review Request: fix writing empty strings for attribut xml:id of draw:plugin elements

2012-07-10 Thread Friedrich W. H. Kossebau
/pluginshape/PluginShape.h 38c67db plugins/pluginshape/PluginShape.cpp c1e19ec Diff: http://git.reviewboard.kde.org/r/105503/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https

Re: Review Request: fix writing empty strings for attribut xml:id of draw:plugin elements

2012-07-10 Thread Friedrich W. H. Kossebau
. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105503/#review15608 --- On July 10, 2012, 12:39 p.m., Friedrich W. H. Kossebau wrote

Re: Review Request: fix writing empty strings for attribut xml:id of draw:plugin elements

2012-07-10 Thread Friedrich W. H. Kossebau
/105503/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: replace deprecated KLocale::fragDigits with KLocale::monetaryDecimalNumbers in Calligra Plan

2012-07-09 Thread Friedrich W. H. Kossebau
://git.reviewboard.kde.org/r/105500/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: fix writing of text:time values

2012-07-07 Thread Friedrich W. H. Kossebau
://git.reviewboard.kde.org/r/105463/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: fix writing of text:time values

2012-07-07 Thread Friedrich W. H. Kossebau
., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105463/ --- (Updated July 7, 2012, 10:16 a.m

Re: Review Request: make Calligra thumbnailer functional again

2012-07-07 Thread Friedrich W. H. Kossebau
://git.reviewboard.kde.org/r/105373/#review15500 --- On July 4, 2012, 1:08 p.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http

Review Request: [calligratests] fixes bad strings Formula.hidden and protected Formula.hidden for style:cell-protect in Sheets

2012-07-07 Thread Friedrich W. H. Kossebau
://git.reviewboard.kde.org/r/105471/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

On master remove your calligrathumbnail.desktop from the installation (was: Re: [calligra] /: pimp the thumbnailer)

2012-07-07 Thread Friedrich W. H. Kossebau
a range of file types for which there can be previews. Good stuff IMHO :) Any format in the filters which should be added because there is no other thumbnailer existing for that type? Am Samstag, 7. Juli 2012, 17:25:48 schrieb Friedrich W. H. Kossebau: Git commit

Re: On master remove your calligrathumbnail.desktop from the installation

2012-07-07 Thread Friedrich W. H. Kossebau
Two more notes: Yes, there are no thumbnails created for xfig and wmf files yet, because the kdelibs thumbnail system just picks the first in the list of thumbnail creators which claim support for a type, and sadly the plain image thumbnail creator coming with kde-runtime does that for both

Re: Review Request: fix writing of text:time values

2012-07-07 Thread Friedrich W. H. Kossebau
/#review15518 --- On July 7, 2012, 10:16 a.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105463

Repeating rounding errors with svg:viewBox, svg:d friends

2012-07-07 Thread Friedrich W. H. Kossebau
Hi, is anyone currently looking into improving graph data handling? Because things are slightly screwed there IMHO. E.g. I was trying to fix EnhancedPathShape::saveOdf(...), which is currently saving non-integer data for svg:viewBox, by code like

Re: Review Request: QIcon'ize KoRecentDocumentsPane, fetch big previews only on demand (save memory)

2012-07-06 Thread Friedrich W. H. Kossebau
--- On July 5, 2012, 1:18 p.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105428/ --- (Updated July

Re: Review Request: QIcon'ize KoRecentDocumentsPane, fetch big previews only on demand (save memory)

2012-07-06 Thread Friedrich W. H. Kossebau
). Explanation: http://stackoverflow.com/questions/4470802/exporting-constants-from-a-dll?answertab=active#tab-top Friedrich W. H. Kossebau wrote: These extent values are currently only used in the library, and only by KoDetailsPane and subclasses, not by any consumers of those

Review Request: fix writing of text:time values

2012-07-06 Thread Friedrich W. H. Kossebau
, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: fix writing of text:time values

2012-07-06 Thread Friedrich W. H. Kossebau
--- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: QIcon'ize KoRecentDocumentsPane, fetch big previews only on demand (save memory)

2012-07-05 Thread Friedrich W. H. Kossebau
/KoRecentDocumentsPane.cpp 521c7e6 libs/main/KoTemplatesPane.cpp cc76c05 Diff: http://git.reviewboard.kde.org/r/105428/diff/ Testing (updated) --- Tried the recent template pane at least in Krita, Words, Sheets Thanks, Friedrich W. H. Kossebau

Review Request: [kofficetests-odt/odf/odt/parag-decorations.odt] fixes wrong writing of double-border style also with a non-double border

2012-07-04 Thread Friedrich W. H. Kossebau
and only then writing style:border-line-width*. Okay to backport to 2.5? Diffs - libs/kotext/styles/KoParagraphStyle.cpp 844903a Diff: http://git.reviewboard.kde.org/r/105431/diff/ Testing --- validateODF.py parag-decorations.odt gives zero output. Thanks, Friedrich W. H. Kossebau

Re: Review Request: make Calligra thumbnailer functional again

2012-07-04 Thread Friedrich W. H. Kossebau
/thumbnail/sheetsodsthumbnail.desktop PRE-CREATION tools/thumbnail/stageodpthumbnail.desktop PRE-CREATION tools/thumbnail/wordsodtthumbnail.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105373/diff/ Testing --- Thanks, Friedrich W. H. Kossebau

Review Request: [calligratests] fix table cell style code wrongly saving/loading draw:opacity with ODF

2012-07-04 Thread Friedrich W. H. Kossebau
/ Testing --- tools/scripts/validateODF.py reports no more errors on oow_template_note_tracker.odt and oow_template_blank_musical_sheet.odt Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org

Re: [PATCH] make KoDocument::nativeFormatMimeType() non-virtual

2012-07-03 Thread Friedrich W. H. Kossebau
Am Dienstag, 3. Juli 2012, 07:39:50 schrieb C. Boemann: On Sunday 01 July 2012 19:05:20 Friedrich W. H. Kossebau wrote: Hi, another little clean-up-which-would-be-quicker-to-do-on-irc-but-async- communication-saves-me. The kounavail part has gone, so virtual and the comment

Review Request: [CRASH FIX] fix Konquerer crashing with Calligra parts

2012-07-03 Thread Friedrich W. H. Kossebau
/diff/ Testing --- Tried to preview files with Konqueror to load them with Calligra programs. Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: [CRASH FIX] fix Konquerer crashing with Calligra parts

2012-07-03 Thread Friedrich W. H. Kossebau
e1f5ce6 words/part/wordspart.desktop f0ca727 Diff: http://git.reviewboard.kde.org/r/105425/diff/ Testing --- Tried to preview files with Konqueror to load them with Calligra programs. Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing

Review Request: QIcon'ize KoRecentDocumentsPane

2012-07-03 Thread Friedrich W. H. Kossebau
/KoRecentDocumentsPane.cpp 521c7e6 Diff: http://git.reviewboard.kde.org/r/105428/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: use the global iconloader for KoTemplate::loadPicture(), so calligra icons are found

2012-07-03 Thread Friedrich W. H. Kossebau
c6b79f8 libs/main/KoTemplatesPane.cpp cc76c05 Diff: http://git.reviewboard.kde.org/r/105429/diff/ Testing --- Used Template creation dialog and Templates pane in Words, Krita, and others. Thanks, Friedrich W. H. Kossebau ___ calligra-devel

(was: Re: [calligra] /: remove claim of CalligraParts to be real KParts/ReadOnlyPart, KParts/ReadWritePart)

2012-07-03 Thread Friedrich W. H. Kossebau
Am Dienstag, 3. Juli 2012, 21:13:55 schrieb Friedrich W. H. Kossebau: Git commit 92e6bb6583b43eb4d3d552f497931f6303323faf by Friedrich W. H. Kossebau. Committed on 03/07/2012 at 21:13. Pushed by kossebau into branch 'master'. remove claim of CalligraParts to be real KParts/ReadOnlyPart

Re: Fwd: [Bug 290875] [thumbnailer] Images files thumbnails generated by calligra have an obstrusive overlay icons

2012-07-02 Thread Friedrich W. H. Kossebau
Hi Boudewijn, Am Montag, 2. Juli 2012, 08:13:13 schrieb Boudewijn Rempt: Friedrich, Could this regression be because of your thumbnailer work? We don't want the icon to show up for .kra or .ora documents. There is not yet any commit merged from me to the thumbnailer plugin, so I feel

Re: Fwd: [Bug 290875] [thumbnailer] Images files thumbnails generated by calligra have an obstrusive overlay icons

2012-07-02 Thread Friedrich W. H. Kossebau
Am Montag, 2. Juli 2012, 16:58:10 schrieb David Revoy: Hi Friedrich, (bug :https://bugs.kde.org/show_bug.cgi?id=290875 ) On the screenshot (http://img861.imageshack.us/img861/7954/20120107screenshot01.jpg ) the one without the blendicon are *.ora files saved by Mypaint. Mypaint have

Re: Fwd: [Bug 290875] [thumbnailer] Images files thumbnails generated by calligra have an obstrusive overlay icons

2012-07-02 Thread Friedrich W. H. Kossebau
Am Montag, 2. Juli 2012, 17:34:07 schrieb Friedrich W. H. Kossebau: Am Montag, 2. Juli 2012, 16:58:10 schrieb David Revoy: Hi Friedrich, (bug :https://bugs.kde.org/show_bug.cgi?id=290875 ) On the screenshot (http://img861.imageshack.us/img861/7954/20120107screenshot01.jpg

Re: Fwd: [Bug 290875] [thumbnailer] Images files thumbnails generated by calligra have an obstrusive overlay icons

2012-07-02 Thread Friedrich W. H. Kossebau
Am Montag, 2. Juli 2012, 18:15:10 schrieb Friedrich W. H. Kossebau: Investigating... And think I found the reason. See comment on bug. Cheers Friedrich ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request: fix/restore thumbnailing for Words

2012-07-01 Thread Friedrich W. H. Kossebau
. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105385/#review15270 --- On June 29, 2012, 4:42 p.m., Friedrich W. H. Kossebau wrote

Re: Review Request: fix/restore thumbnailing for Words

2012-07-01 Thread Friedrich W. H. Kossebau
if it works. ok to backport too (I trust you have tested well) Friedrich W. H. Kossebau wrote: Seemed to me like the only way to get a shapemanager. But after your nagging I researched a little more and now found what that canvasitem is. So I will change the patch to first look

Re: Review Request: Fix some icon names to reference existing icons (2.5 branch)

2012-07-01 Thread Friedrich W. H. Kossebau
standard. Friedrich W. H. Kossebau wrote: yes, had the -postfix-stripping-until-found systematic of the icon theme in mind when doing this. But not another thing I might have just found out: icons from locations added to the icon dirs to use only with KIconLoader::global

Re: Review Request: fixes thumbnails of KoPADocuments to be without empty spaces around (Flow, Stage)

2012-07-01 Thread Friedrich W. H. Kossebau
better thumbnails after the patch :) E.g. when browsing the templates. Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

[PATCH] make KoDocument::nativeFormatMimeType() non-virtual

2012-07-01 Thread Friedrich W. H. Kossebau
Hi, another little clean-up-which-would-be-quicker-to-do-on-irc-but-async- communication-saves-me. The kounavail part has gone, so virtual and the comment are no longer needed. Okay to commit to master? @Boud: If you had my unstable internet connection, you would never even think about making

Re: [calligra] krita/data/templates: Add design templates from deevad

2012-07-01 Thread Friedrich W. H. Kossebau
Am Montag, 2. Juli 2012, 02:54:17 schrieb Friedrich W. H. Kossebau: Hi Timothée, Am Sonntag, 1. Juli 2012, 12:25:38 schrieb Timothée Giet: Git commit 08e1c0a139f19e2bbbd620dbbcaafcf9e991d9c0 by Timothée Giet. Committed on 01/07/2012 at 11:59. Pushed by timotheegiet into branch 'master

Re: Review Request: fixes thumbnails of KoPADocuments to be without empty spaces around (Flow, Stage)

2012-06-30 Thread Friedrich W. H. Kossebau
--- On June 29, 2012, 9:25 p.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105390

Re: Review Request: fixes thumbnails of KoPADocuments to be without empty spaces around (Flow, Stage)

2012-06-30 Thread Friedrich W. H. Kossebau
the thumbnail cache in ~/.thumbnails and enjoyed better thumbnails after the patch :) E.g. when browsing the templates. Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Thumbnail in Words broken? (was: Re: How to know when a KoDocument is ready for generatePreview(...)?)

2012-06-29 Thread Friedrich W. H. Kossebau
Am Freitag, 29. Juni 2012, 06:21:18 schrieb Boudewijn Rempt: And shouldn't words just save a thumbnail in the odt file that can be used? Hm, is the thumbnail stored in an ODT by Words just a white square also for everyone else in master? Is KoDocument::d-pageLayout possibly not used in

Review Request: fix/restore thumbnailing for Words

2012-06-29 Thread Friedrich W. H. Kossebau
a8d8ae4 words/part/KWDocument.cpp d5c4c2e words/part/KWPage.cpp 8ce9554 Diff: http://git.reviewboard.kde.org/r/105385/diff/ Testing --- Created a few new files and looked at the thumbnails stored in the saved odf. Thanks, Friedrich W. H. Kossebau

Review Request: fixes thumbnails of KoPADocuments to be without empty spaces around (Flow, Stage)

2012-06-29 Thread Friedrich W. H. Kossebau
/105390/diff/ Testing --- Cleared the thumbnail cache in ~/.thumbnails and enjoyed better thumbnails after the patch :) E.g. when browsing the templates. Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https

Re: Review Request: use right mimetype for PPT files in stage desktop files

2012-06-28 Thread Friedrich W. H. Kossebau
sheets only has the one with the prefix in the list. Friedrich W. H. Kossebau wrote: I think it does not hurt to have both there, the official and (one of) the inofficial. E.g. some webservers might use an inofficial, and if the lookup mechanism does not translate it to the official

Review Request: remove AI as supported mimetype from Karbon desktop files

2012-06-28 Thread Friedrich W. H. Kossebau
/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: make Calligra thumbnailer functional again

2012-06-28 Thread Friedrich W. H. Kossebau
tools/thumbnail/sheetsodsthumbnail.desktop PRE-CREATION tools/thumbnail/stageodpthumbnail.desktop PRE-CREATION tools/thumbnail/wordsodtthumbnail.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105373/diff/ Testing --- Thanks, Friedrich W. H. Kossebau

Re: Review Request: fix the Print services for Dolphin/Konqueror

2012-06-28 Thread Friedrich W. H. Kossebau
installed service description. Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

How to know when a KoDocument is ready for generatePreview(...)?

2012-06-28 Thread Friedrich W. H. Kossebau
Hi, I am currently restoring the functionality of the Calligra thumbnail generator in tools/thumbnail. Works fine on a first look (so I pushed a review request in https://git.reviewboard.kde.org/r/105373/ ), but on a closer look there are some issues. E.g. just waiting for the signal

Re: How to know when a KoDocument is ready for generatePreview(...)?

2012-06-28 Thread Friedrich W. H. Kossebau
Hi Thorsten, Am Freitag, 29. Juni 2012, 06:20:19 schrieb Thorsten Zachmann: Hello Friedrich, On Thursday 28 June 2012 23:23:19 Friedrich W. H. Kossebau wrote: Hi, I am currently restoring the functionality of the Calligra thumbnail generator in tools/thumbnail. Works fine on a first

Re: How to know when a KoDocument is ready for generatePreview(...)?

2012-06-28 Thread Friedrich W. H. Kossebau
Hi Boudewijn, Am Freitag, 29. Juni 2012, 06:21:18 schrieb Boudewijn Rempt: And shouldn't words just save a thumbnail in the odt file that can be used? Still ODF files without a thumbnail (coming from somewhere else) need to be supported. And, most output of import filter chains e.g. also does

Sharing template folders with LO/AOO Co.

2012-06-26 Thread Friedrich W. H. Kossebau
Hi, has it been discussed before if and how templates installed on the system could be shared with other ODF programs? At least (by idea of OpenDocument) theoretically templates should be usable by any ODF program. For those templates which make use of special features only available in a

Re: Missing OTP template files: curious_penguin.otp and kde_events.otp

2012-06-26 Thread Friedrich W. H. Kossebau
Am Dienstag, 26. Juni 2012, 06:30:46 schrieb Thorsten Zachmann: Hello Friedrich, On Monday 25 June 2012 19:42:25 Friedrich W. H. Kossebau wrote: Hi Thorsten, more than a year ago you added a few desktop files for not yet done kpresenter templates, without the templates, but to prevent

Review Request: fix the Print services for Dolphin/Konqueror

2012-06-26 Thread Friedrich W. H. Kossebau
PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105363/diff/ Testing --- Printed a few files of supported mimetypes, at least once for any installed service description. Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list

Missing OTP template files: curious_penguin.otp and kde_events.otp

2012-06-25 Thread Friedrich W. H. Kossebau
Hi Thorsten, more than a year ago you added a few desktop files for not yet done kpresenter templates, without the templates, but to prevent the string freeze. See https://projects.kde.org/projects/calligra/repository/revisions/b122340ca068a15a657078f0b7c633410fd7427f Excerpt from commit

Re: Review Request: Fix some icon names to reference existing icons (2.5 branch)

2012-06-24 Thread Friedrich W. H. Kossebau
-edit-table-cell-merge.png PRE-CREATION plugins/textshape/pics/ox22-actions-edit-table-cell-split.png PRE-CREATION plugins/vectorshape/VectorTool.cpp 79742fd sheets/ui/CellToolBase.cpp 89b79f9 Diff: http://git.reviewboard.kde.org/r/105284/diff/ Testing --- Thanks, Friedrich W. H

Re: Review Request: Fix some icon names to reference existing icons (2.5 branch)

2012-06-19 Thread Friedrich W. H. Kossebau
standard. Friedrich W. H. Kossebau wrote: yes, had the -postfix-stripping-until-found systematic of the icon theme in mind when doing this. But not another thing I might have just found out: icons from locations added to the icon dirs to use only with KIconLoader::global

Re: Review Request: Fix some icon names to reference existing icons (2.5 branch)

2012-06-19 Thread Friedrich W. H. Kossebau
standard. Friedrich W. H. Kossebau wrote: yes, had the -postfix-stripping-until-found systematic of the icon theme in mind when doing this. But not another thing I might have just found out: icons from locations added to the icon dirs to use only with KIconLoader::global

Re: Review Request: Fix some icon names to reference existing icons (2.5 branch)

2012-06-19 Thread Friedrich W. H. Kossebau
plugins/vectorshape/VectorTool.cpp 79742fd sheets/ui/CellToolBase.cpp 89b79f9 Diff: http://git.reviewboard.kde.org/r/105284/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https

Re: List of missing icons around 2.5 branching

2012-06-19 Thread Friedrich W. H. Kossebau
Am Sonntag, 17. Juni 2012, 23:22:45 schrieb Jaroslaw Staniek: On 17 June 2012 05:40, Friedrich W. H. Kossebau kosse...@kde.org wrote: [..] Below the list which is currently created by my script. But I added also some comments. Its not sorted, but maintainers surely will see where

Re: List of missing icons around 2.5 branching

2012-06-19 Thread Friedrich W. H. Kossebau
Hi, so to help with finding which icons the Calligra team needs to go shopping for I sorted the not yet commented or patch-treated missing icons by program/shape below, so the maintainers have a more easy time to find what icon is missing in their code and comment. Please everyone follow the

Re: Review Request: Fix some icon names to reference existing icons (2.5 branch)

2012-06-19 Thread Friedrich W. H. Kossebau
standard. Friedrich W. H. Kossebau wrote: yes, had the -postfix-stripping-until-found systematic of the icon theme in mind when doing this. But not another thing I might have just found out: icons from locations added to the icon dirs to use only with KIconLoader::global

Re: Review Request: Fix some icon names to reference existing icons (2.5 branch)

2012-06-18 Thread Friedrich W. H. Kossebau
., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105284/ --- (Updated June 17, 2012, 8:54 p.m

Review Request: Fix some icon names to reference existing icons (2.5 branch)

2012-06-17 Thread Friedrich W. H. Kossebau
/CellToolBase.cpp 89b79f9 Diff: http://git.reviewboard.kde.org/r/105284/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix some icon names to reference existing icons (2.5 branch)

2012-06-17 Thread Friedrich W. H. Kossebau
W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Calligra 2.5 has been branched

2012-06-16 Thread Friedrich W. H. Kossebau
Am Sonntag, 17. Juni 2012, 01:59:01 schrieb Inge Wallin: On Friday, June 15, 2012 20:45:17 Cyrille Berger Skott wrote: Hi, Calligra 2.5 has been branched in calligra/2.5 (this branch is only open for bug fixes, no new strings, no new features). The hash for Calligra 2.5 Beta is

List of missing icons around 2.5 branching

2012-06-16 Thread Friedrich W. H. Kossebau
Hi, so unless I failed with my first Python script ever (or elsewhere) I can give you an automatically created list with the currenty missing icons. I used a primitive approach to create the list (will by improved by the time, but its at least a start): with xgettext all icon names are

Re: Review Request: Add support for wheel events in the page navigator in the status bar (Stage/Flow)

2012-06-14 Thread Friedrich W. H. Kossebau
f7fdc26 Diff: http://git.reviewboard.kde.org/r/105229/diff/ Testing --- Scrolled with a few slides, with and without page number editing mode. Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https

Re: Review Request: Add support for wheel events in the page navigator in the status bar (Stage/Flow)

2012-06-14 Thread Friedrich W. H. Kossebau
. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105229/#review14753 --- On June 14, 2012, 4:12 p.m., Friedrich W. H. Kossebau wrote

Review Request: Add support for wheel events in the page navigator in the status bar (Stage/Flow)

2012-06-12 Thread Friedrich W. H. Kossebau
- libs/kopageapp/widgets/KoPageNavigator.cpp 2ecdc9a libs/kopageapp/widgets/KoPageNavigatorButton_p.h f7fdc26 Diff: http://git.reviewboard.kde.org/r/105229/diff/ Testing --- Scrolled with a few slides, with and without page number editing mode. Thanks, Friedrich W. H. Kossebau

Re: Review Request: Add support for wheel events in the page navigator in the status bar (Stage/Flow)

2012-06-12 Thread Friedrich W. H. Kossebau
? Diffs (updated) - libs/kopageapp/widgets/KoPageNavigator.cpp 2ecdc9a libs/kopageapp/widgets/KoPageNavigatorButton_p.h f7fdc26 Diff: http://git.reviewboard.kde.org/r/105229/diff/ Testing --- Scrolled with a few slides, with and without page number editing mode. Thanks, Friedrich W

Re: Review Request: make UI texts for exporting Kexi reports more consistent (and solve Kexi i18n TODOs for 2.5)

2012-06-11 Thread Friedrich W. H. Kossebau
--- On June 7, 2012, 12:13 a.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105164

Re: Review Request: make UI texts for exporting Kexi reports more consistent (and solve Kexi i18n TODOs for 2.5)

2012-06-11 Thread Friedrich W. H. Kossebau
Friedrich W. H. Kossebau wrote: Yes, agree that could be improved as well, so picked up your proposal. Also modified the message slightly (give CSS reference, make relative clauses non-defining). No idea about title, just that old Styles is not perfect. Adam Pigg wrote: How about

Re: Review Request: make UI texts for exporting Kexi reports more consistent (and solve Kexi i18n TODOs for 2.5)

2012-06-11 Thread Friedrich W. H. Kossebau
Friedrich W. H. Kossebau wrote: Yes, agree that could be improved as well, so picked up your proposal. Also modified the message slightly (give CSS reference, make relative clauses non-defining). No idea about title, just that old Styles is not perfect. Adam Pigg wrote: How about

<    3   4   5   6   7   8   9   10   >