Re: Review Request: Adds a page/slide navigator control for the statusbar, used in Stage Flow

2012-06-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105180/#review14691 --- This review has been submitted with commit

Re: Review Request: Adds a page/slide navigator control for the statusbar, used in Stage Flow

2012-06-09 Thread Friedrich W. H. Kossebau
Am Samstag, 9. Juni 2012, 06:06:02 schrieben Sie: Hello Friedrich, One thing I noticed which is not due to your code but only visible when your code is there is that if you enter the first/last page in the widget the actions do not get enabled/disabled and therefore it shows the old

Re: Review Request: Adds a page/slide navigator control for the statusbar, used in Stage Flow

2012-06-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105180/#review14514 --- This review has been submitted with commit

Re: Review Request: Adds a page/slide navigator control for the statusbar, used in Stage Flow

2012-06-08 Thread Friedrich W. H. Kossebau
On June 8, 2012, 5:23 a.m., Thorsten Zachmann wrote: Please commit after fixing the details I noticied. If I miss someting on the inline stuff lets discuss it before committing. One thing I noticed which is not due to your code but only visible when your code is there is that if

Re: Review Request: Adds a page/slide navigator control for the statusbar, used in Stage Flow

2012-06-08 Thread Friedrich W. H. Kossebau
Am Freitag, 8. Juni 2012, 05:23:16 schrieb Thorsten Zachmann: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105180/#review14507 ---

Re: Review Request: Adds a page/slide navigator control for the statusbar, used in Stage Flow

2012-06-08 Thread Thorsten Zachmann
Hello Friedrich, One thing I noticed which is not due to your code but only visible when your code is there is that if you enter the first/last page in the widget the actions do not get enabled/disabled and therefore it shows the old state of the actions, e.g. when entering the last page

Re: Review Request: Adds a page/slide navigator control for the statusbar, used in Stage Flow

2012-06-07 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105180/#review14507 --- Ship it! Please commit after fixing the details I noticied.