Re: Download the calligra suite.

[Dag]

On Monday, 24 April 2023 18:19:35 CEST, RamenMaster 12 wrote:

Hi. I am looking for a download for Windows.

When I go to the windows download page it is dead.
The link:https://binary-factory.kde.org/job/Calligra_Nightly_win64/

It's up again.
Any feedback is appreciated.



It says:

HTTP ERROR 404 Not Found
URI: /job/Calligra_Nightly_win64/
STATUS: 404
MESSAGE: Not Found
SERVLET: Stapler
--
Powered by Jetty:// 9.4.33.v20201020 <https://eclipse.org/jetty>

Could you please put back the windows downloads please?

Thank you!




--
Mvh Dag

Re: Usability Testing for Calligra as part of study project

[Dag]

On Tuesday, 4 April 2023 14:29:47 CEST, Quan Nguyen wrote:

Hello,

We are a team of information processing science students 
currently taking a course on user experience and usability 
evaluation that lead by Mikko Rajanen. Our aim is to conduct a 
usability test on the Calligra office suite, and we would 
greatly appreciate your input on the desired functionality and 
any previous tests conducted on it. We value your time and thank 
you in advance for your assistance.

Hi, all.
Afaik there hasn't been any previous studies, but I might be wrong.
We are very few active developers atm so the amount of support may be 
limited.

@thomas Is it something you would be interrested in?

It would be interresting to hear your reasons for selecting calligra for 
this study.


--
Mvh Dag

Re: Calligra Downloads not working

[Dag]

On fredag den 20. januar 2023 01.55.45 CET, RamenMaster 12 wrote:

The downloads for the calligra office suite are gone. 404 not found error.
Could you please provide me with the download links?

The old broken download links:

https://binary-factory.kde.org/job/Calligra_Nightly_win64/
https://binary-factory.kde.org/job/Calligra_Nightly_win32/

I know why you want to remove the downloads. Probably because to save
bandwidth.
Not quite, they were removed because calligra does not build atm and has 
not for quite some time. We need somebody with windows/mac knowledge to fix 
it.

--
Mvh Dag

Re: Autocorrect functionality

[Dag]

On onsdag den 19. oktober 2022 17.42.29 CEST, Volker Krause wrote:

On Mittwoch, 19. Oktober 2022 01:05:19 CEST Albert Astals Cid wrote:

Sorry for the cross-posting.
Please CC me, i'm on none of the two lists


Both pimcommon and calligra have Autocorrect functionality, but PIM one
broke at some point and I guess no one realized?


[...]


Solutions:
 A) Make PIM look for files also in GenericDataDir/calligra and live with
the dependency to calligra for the feature B) Accept that the feature in
PIM was broken for a long time and just remove it C) Make a library that
both PIM and Calligra use

Ideally we would go with C but we all know it's not like we have lots of
people with time available to jump and work on this...


Right, that's ultimately what I'd like to see as well, all the auto-
correction, grammar checking and translation features moving 
into Frameworks, 
alongside spell-checking. Those are all features you would like to have 
everywhere you write more than a few words of text IMHO.


But lacking time for this, it's not more than a wishlist item 
unfortunately...

I think there are two separate issues here:
1) The data, where to host/maintain/install, and
2) code duplication. To reduce the amount of work we could postpone this
  until needs get pressing or sombody finds the time.

The data we have in calligra atm is not very comprehensive. This makes it 
pretty useless if it is not updated.
The data in libreoffice is pretty good though, so using that data would be 
nice.

But how to do that? Could we:
. Merge current LO data with calligra data,
   A job to do now, and data must be maintained two places.
. Copy current data from LO into our repo keeping data format,
   When data is updated in LO, somebody needs to make a new copy.
   Install both calligra data and LO data.
. Copy data automatically from LO at release time keeping data format,
   Install both calligra data and LO data.
   
I don't particulary like any of these, but trying to be practical...


--
Mvh Dag

Re: How do I install and use Calligra Plan?

[Dag]

On onsdag den 20. juli 2022 10.04.16 CEST, Turritopsis Dohrnii Teo En Ming 
wrote:

Subject: How do I install and use Calligra Plan?

Good day from Singapore,

How do I install and use Calligra Plan?
On Linux based systems most distributions have packages of current stable 
release 3.0.0.


On mac and windows this release does not build. The current development 
version does build and on winows it seems to run ok. I do  not know if it 
runs on mac, but I suspect there are the same problems as most other kde 
apps have.


If you want to test, you can find builds for mac and windows on:
https://binary-factory.kde.org/

But note that it is a development version so bugs must be expected.
That said, any testing/feedback is appreciated.

Mvh Dag


Thank you.

Regards,

Mr. Turritopsis Dohrnii Teo En Ming
Targeted Individual in Singapore
20 July 2022 Wed
Blogs:
https://tdtemcerts.blogspot.com
https://tdtemcerts.wordpress.com




--
Mvh Dag

Re: Release

[Dag]

tirsdag den 14. december 2021 12.08.46 CET skrev Pierre:

On Monday, December 13, 2021 8:28:44 AM CET Dag wrote:

@pierre:
If I'm not mistaken you are planning a new release soon?
I cannot see that you have created a release branch, so presumely string-
and feature freeze are in effect?
Do you have a target date in mind?

Also I have created a few merge requests that you might want to get in.


Hi

I've looked a bit at the merge requests, thank you very much for these.
The release will happen "soon", but I can't say when, my wife 
is now staying 
at the maternity ward so I can't really spend much time on 
anything yet (nor 
could I in the past weeks).

Very understandable. Best wishes to you all!

--
Mvh Dag

Release

[Dag]

@pierre:
If I'm not mistaken you are planning a new release soon?
I cannot see that you have created a release branch, so presumely string- 
and feature freeze are in effect?

Do you have a target date in mind?

Also I have created a few merge requests that you might want to get in.
--
Mvh Dag

Re: Krita donation proposal

[Dag]

tirsdag den 16. november 2021 11.35.21 CET skrev Halla Rempt:

Hi,

The KDE e.V. board still sits on this money, since there's 
almost nothing happening in calligra land. Of everything that 
used to be Calligra, only Plan and Krita show activity. Kexi 
also seems dormant. But the board needs to spend that money, so 
what should we do? 

Not that I want to be greedy, but if Calligra cannot spend it 
on anything, I'm find with taking a larger share for Krita... 

No objections from me.

And is there a way to spend it on Plan?

No, I don't think so.

Mvh,
Dag



Cheers,

Halla Rempt

On woensdag 17 oktober 2018 10:35:30 CET Dan Leinir Turthra Jensen wrote:
Yes, i agree with Dag. Handshake's donation does seem to have been a 
historical congratulations type thing more than anything else, 
so certainly 
Krita deserves a chunk of this.


On Wednesday, 17 October 2018 09:31:54 BST Dag wrote: ...









--
Mvh Dag

Words and large files

[Dag]

Hi, opened the odf spec in words the other day.
This is a document with 800+ pages and a TOC of 60+ pages.
I did the same in LO to compare.
Don't take the absolute times too seriously as my box is well into its 
teenage years.

But, I think comparison with LO says a lot:

Open: 2,5 mins, LO: 40 secs.
Except that TOC page numers is not shown (just ###), navigation, scrolling 
etc works fine.

Save: 4 mins, LO: 30 secs.

And now to the bad part:
When a try to type a character words freezes for about 50 secs.
It seems the whole doc is re-layouted and also the TOC is updated (page 
numbers appear).


Then when auto-save kicks in words freezes again without any feedback. I 
expected to see a status meassage and a progress bar, but no.


Krita solved freeze by making a copy of the doc and save in the background.

LO is better (but not good).
Generally you can type new text wo problems but it freezes for shorter 
periods (maybe when updating page numbers), and it freezes when 
auto-saving.


It never updates the TOC, this needs to be done manually.

Suggestions (just my 2 cents):
1) TOC should be updated manually to avoid re-layout.
2) Auto-save in the background.
3) Minimize re-layout by e.g. only re-layout dirty pages before and 
including the displayed page(s).


--
Mvh Dag

Merge requests

[Dag]

https://invent.kde.org/office/calligra/-/merge_requests
--
Mvh Dag

Re: Annotation shape

[Dag]

tirsdag den 16. juni 2020 12.30.00 CEST skrev Dag:

The annotation shape seems only to be usable as a comment in words.
Adding it as a plain shape does not make sence as it will 
behave as any shape with run-around text etc, but it will never 
be printed: Goodby wysiwyg.


I can also add it as a comment to a TextShape in stage or 
sheets, but a comment will never be shown and also stage crashes 
on undo.


So, what to do?
* Remove it from the 'Add Shape' docker and only enable comments in words.
* Keep it as a fancy textshape and enable printing in this case.
* Disable comments for textshapes exept in words.
* Fix it 'properly' (Don't quite know what that means)

Ok, after sleeping on it, I cannot see any use of the annotation shape 
except as a review comment.

So unless somebody protest, a will:
* Disable the review tool except in words, and
* remove the annotation shape from the shapecollection docker

--
Mvh Dag

Annotation shape

[Dag]

The annotation shape seems only to be usable as a comment in words.
Adding it as a plain shape does not make sence as it will behave as any 
shape with run-around text etc, but it will never be printed: Goodby 
wysiwyg.


I can also add it as a comment to a TextShape in stage or sheets, but a 
comment will never be shown and also stage crashes on undo.


So, what to do?
* Remove it from the 'Add Shape' docker and only enable comments in words.
* Keep it as a fancy textshape and enable printing in this case.
* Disable comments for textshapes exept in words.
* Fix it 'properly' (Don't quite know what that means)

--
Mvh Dag

Re: Merge request sheets

[Dag]

To be notified, everyone interested should star the repo (right top 
part of

the repo's main page) and make it watched (the bell icon).

Ahh, thanks.


Best regards,
Yuri

Merge request sheets

[Dag]

Hi, added my first merge request to invent.
Doesn't seem to produce any notifications and I have not figured out how 
to add reviewers, hence this mail.


The request:
https://invent.kde.org/office/calligra/-/merge_requests/1
--
Cheers, Dag

Bugfix release 3.2.1 planned tomorrow Thursday 2020-05-14

[Dag]

Release needs to be tomorrow because of move to invent.kde.org

--
Cheers, Dag

D29542: Refactor canvas event handling

[Dag Andersen]

danders added a comment.


  This seems to work fine, I also tested with only pageapp changes.
  Imho I would prefer to separate the pageapp and KoMainWindow changes into 
separate commits,
  The pageapp changes should go into 3.2 branch followed by a swift release.
  I don't think the KoMainWindow changes should go into the branch as it only 
removes unused functionallity.
  I'm a bit in two minds if it should go in at all actually, so I'll leave it 
you or maybe somebody else has an opinion.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D29542

To: anthonyfieroni, boemann, danders, #calligra:_3.0
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D29542: Refactor MainWindow view

[Dag Andersen]

danders added a comment.


  In D29542#668076 , @anthonyfieroni 
wrote:
  
  >   `d->rootPart->createView(doc, this);` Creates the view which parent is 
main window.
  
  
  Ahh, yes, but then...
  Why will it not crash if a new document is set so that d->rootView != 0 ?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D29542

To: anthonyfieroni, boemann, danders, #calligra:_3.0
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D29542: Refactor MainWindow view

[Dag Andersen]

danders added a comment.


  Hmmm, it seems to me you are creating a leak in your lines 544, 545? (Have 
not tested, I might be wrong)
  
  Afaics the problem is that a focus event is issued that accesses the view 
after death.
  Possibly a deleteLater() would do it, but I tried with setting paret to 
nullptr:
  
while(!oldRootViews.isEmpty()) {
KoView *v = oldRootViews.takeFirst();
v->setParent(nullptr);
delete v;
}
  
  (Also in KoMainWindow dtor to be consistent.)

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D29542

To: anthonyfieroni, boemann, danders, #calligra:_3.0
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

Version 3.2.0 released, changelog

[Dag]

Freezes lifted.

I have extracted changes from git log and tried to weed out everything 
not interresting to a user.

Please check it out and correct mistakes, omissions etc.
@leinir clueless on gemini, so please review.

--
Cheers, Dag
Gemini:
---
Author: Andrew den Exter 
Add a readOnly property to the QtQuick2 Document type which disables the 
loading of editor UI controls.

Summary: This speeds up load times when simply viewing a document.

Author: Dan Leinir Turthra Jensen 
Add enabled property to DocumentTile component

Author: Dan Leinir Turthra Jensen 
Make the document tile more reasonable when resized

Also make the three places it is used more sensible

Author: Dan Leinir Turthra Jensen 
Remove the no longer used CloudAccounts page

Author: Dan Leinir Turthra Jensen 
Make the cloud welcome page more welcoming

Author: Dan Leinir Turthra Jensen 
A touch of visibility juggling for Kirigami controls


Author: Dan Leinir Turthra Jensen 
Kirigami page for MainPage (and make navigating back work)

Author: Dan Leinir Turthra Jensen 
Make RecentFileManager less potentially crashy

This is a funky little situation where some of the assumptions
are just a little off. In short: There are going to be multiple
files with the same file name in different locations on the
filesystem. This will result in two lists ending up out of sync,
if we simply clear multiple instances of the same string. Solution:
switch to a less assumptioney and more strict container.

Author: Dan Leinir Turthra Jensen 
Further work on Kirigamifying Calligra Gemini

This time it's the cloud bits getting some attention. More to be done,
but progress!

Author: Dan Leinir Turthra Jensen 
Add text to CloudModel entries' account details

Author: Dan Leinir Turthra Jensen 
Some cleanup and refactoring of the load process

Author: Dan Leinir Turthra Jensen 
Actually sort the two Words subpages

Author: Dan Leinir Turthra Jensen 
Kirigamify the Stage welcomepage

Author: Dan Leinir Turthra Jensen 
Ensure the pages are given full width

Author: Dan Leinir Turthra Jensen 
Rework the Words page as more Kirigami-esque

Author: Dan Leinir Turthra Jensen 
Clean up recent and library pages a touch

Author: Dan Leinir Turthra Jensen 
Add a context drawer, and set the app bar style

Author: Dan Leinir Turthra Jensen 
Make the Calligra Gemini flow more Kirigami based (much more work to do)

Author: Dan Leinir Turthra Jensen 
Pull out the Document Tile as a component

Author: Dan Leinir Turthra Jensen 
Postpone the loading, remove crash in cloud support

Author: Anthony Fieroni 
[gemini] Clarify touch <-> desktop view switch

Author: Anthony Fieroni 
[gemini] Fix loading of templates and files creation


Author: Damien Caliste 
Correct anchor detection in QML components.

Summary: The loop to translate the anchor shape position in 
TextDocumentImpl was mis-written, always testing shape's parent, instead of 
parent's parent. This was creating an infinite loop in case an email address 
was present in a table for instance.

Author: Pekka Vuorela 
Migrate away from deprecated interfaces in gemini dropbox parts

Summary: Having trouble getting Gemini Dropbox working here, but should be 
simple enough and at least quite isolated code.

Author: Dan Leinir Turthra Jensen 
Use a Loader for the webview (and handle nonloading)

Author: Dan Leinir Turthra Jensen 
Make touch view accept touch events on recent Qt versions

Based on a patch for Krita, and caused, in the end, by
https://bugreports.qt.io/browse/QTBUG-66718

Author: Dan Leinir Turthra Jensen 
Ensure Gemini drawer's open and non-modal (for static sidebarness)

Words:
--
* Do not popup contextmenu twice

* Fix Bug 378527 - "Distraction free mode" should be called "Full screen mode"

* Fix Bug 358581 - Calligra word crashes on trying to print web page from 
Konqueror
Fixed calligra crashing when opening remote document

* Fix crash after loading of template file fails

* Save anchor info also for page-anchored shapes
LO needs anchor info to position shapes correctly.

* Fix interoperability problem with LibreOffice
Words creates pagestyles with name "Standard" and displayname "Default".

LibreOffice creates a "Default" style where all words style attributes go.
The style is never used by LibreOffice, effectivly discarding all 
attributes.

Karbon:
---

* Karbon: Enable multi page capability

* Karbon image filter: Add multipage support
Adds ability to select page in the options dialog


* PDF Import: Add multipage support
Imports multipage pdf files as svg using poppler to generate an svg file pr 
page.


* Use Krita toolbar in Karbon
I copied all KoToolBox* file and KissKineticScroller (renamed to 

D28820: Chart: Fix Bug 240520 - No axes lines when creating new chart

[Dag Andersen]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:240fb4f60810: Chart: Fix Bug 240520 - No axes lines when 
creating new chart (authored by danders).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28820?vs=80089=80360

REVISION DETAIL
  https://phabricator.kde.org/D28820

AFFECTED FILES
  plugins/chartshape/Axis.cpp
  plugins/chartshape/Axis.h
  plugins/chartshape/PlotArea.cpp

To: danders
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

Re: Calligra release 3.2 next Thursday 23.

[Dag]

On 16-04-2020 11:31, Dag wrote:
We plan to release calligra next Thursday 23rd and string freeze is in 
effect.

There are not a lot of new strings so I hope the time frame is ok.
Any protests, and we will dealy.

Ahhh, release from trunk.

Calligra release 3.2 next Thursday 23.

[Dag]

We plan to release calligra next Thursday 23rd and string freeze is in 
effect.

There are not a lot of new strings so I hope the time frame is ok.
Any protests, and we will dealy.

--
Cheers, Dag

D28820: Chart: Fix Bug 240520 - No axes lines when creating new chart

[Dag Andersen]

danders created this revision.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
danders requested review of this revision.

REVISION SUMMARY
  Turns out KChart needs a explicitly set pen to draw ruler lines.
  KChart 2.7.0 will have the option to set a pen int KChart::RulerAttributes
  
  BUG: 240520

REPOSITORY
  R8 Calligra

BRANCH
  no_rulerline

REVISION DETAIL
  https://phabricator.kde.org/D28820

AFFECTED FILES
  plugins/chartshape/Axis.cpp
  plugins/chartshape/Axis.h
  plugins/chartshape/PlotArea.cpp

To: danders
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

Re: Translation issues with the calligraplan documentation

[Dag]

Dag skrev den 2020-03-26 09:57:

I have adjusted the structure so now xml2po extracts all texts, at 
least.


Haven't tested if xml2po works.

Also noted there are problems with keycode/keycap, but let's see if my 
changes is enough to generate translated docs.


After further investigation it seems xml2po cannot handle docs that are 
split into several files (despite man page indicates so).
Docbook operates by including files effectively creating one document 
out of all the files, while xml2po operates on each file individually. 
This means that entities etc will not be available to xml2po as you 
cannot have 

A see two ways to fix this:
1) Make xml2po understand included files.
2) Have the whole document in one file.

A don't think 1) will happen soon, so I will go with 2).
 ---
Cheers, Dag


Luigi Toscano skrev den 2020-03-24 23:33:


Hi,

it seems that the translations system does not work with the 
calligraplan
documentation. I believe the problem is connected with the way the 
split is
done: only the first top-level tag in each document is extract. If I 
remember
correctly we hit this problem in the past and we ended up with 
restructing the

documentation, but I can't investigate right now.

Re: stable branch

[Dag]

Jonathan Riddell skrev den 2020-03-26 17:44:

The stable branch for calligra is still set to calligra/3.1 but the 
current release series is 3.2 from master.  Can this be fixed?

Calligra stable is still 3.1. Could this be a mixup with calligraplan?

Dag


Jonathan

Re: Translation issues with the calligraplan documentation

[Dag]

I have adjusted the structure so now xml2po extracts all texts, at
least. 

Haven't tested if xml2po works. 

Also noted there are problems with keycode/keycap, but let's see if my
changes is enough to generate translated docs.

---
Cheers, Dag 

Luigi Toscano skrev den 2020-03-24 23:33:

> Hi,
> 
> it seems that the translations system does not work with the calligraplan
> documentation. I believe the problem is connected with the way the split is
> done: only the first top-level tag in each document is extract. If I remember
> correctly we hit this problem in the past and we ended up with restructing the
> documentation, but I can't investigate right now.

T12815: Create Calligra Framework by separating out applications and libraries

[Dag Andersen]

danders added a comment.


  I think where leinir has landed is more doable than a frameworks.
  Also if compiletime is a big hurdle, I see a couple of things that can be 
done:
  
  - Remove pigment, see T5738 .
  
  - Make more finegrained productsets. Pt the only thing you can control (if I 
haven't missed anything) is which apps to build.
  
  E.g. if you want to work on the innards of words for gemini, you select 
gemini and get words, sheets and stage. In addition you get almost all plugins 
and all relevant filters. Probably *some* plugins are necessary but you should 
be able to do without most plugins and no filters at all.
  
  Another problem is how new users find out how to use productsets. A front-end 
would have been nice, but a bit of documantation should go a long way.

TASK DETAIL
  https://phabricator.kde.org/T12815

To: danders
Cc: danders, davidllewellynjones, ndavis, jtamate, rempt, anthonyfieroni, 
dcaliste, boemann, pino, rjvbb, ngraham, ognarb, Calligra-Devel-list, 
#calligra:_3.0, leinir, cochise, vandenoever

D7228: SpellCheck: Fix markup rebasing when simple edits are done (one char added)

[Dag Andersen]

danders abandoned this revision.
danders added a comment.
Herald added a subscriber: Calligra-Devel-list.


  Has been comitted

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D7228

To: danders, boemann
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D11191: Remove Plan dependencies from CMakeLists.txt

[Dag Andersen]

danders closed this revision.
Herald added a subscriber: Calligra-Devel-list.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D11191

To: kavindap, #calligra:_3.0, staniek
Cc: Calligra-Devel-list, staniek, danders, davidllewellynjones, dcaliste, 
ognarb, cochise, vandenoever

D15775: Make the item background color and page cache properties available from View component

[Dag Andersen]

danders added a comment.


  ping

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15775

To: dcaliste, leinir, danders, anthonyfieroni, #calligra:_3.0
Cc: boemann, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

D25034: Fix decoding of strings with wingdings/symbol characters in excel TxO records.

[Dag Andersen]

danders added a comment.


  ping

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25034

To: denexter, pvuorela, mkruisselbrink
Cc: danders, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

D26050: Fix build with poppler 82

[Dag Andersen]

danders added a reviewer: danders.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D26050

To: tcanabrava, #calligra:_3.0, danders
Cc: danders, rjvbb, awilcox, dcaliste, leinir, asturmlechner, ognarb, 
anthonyfieroni, Calligra-Devel-list, davidllewellynjones, cochise, vandenoever

D22545: Add missing include QDate

[Dag Andersen]

danders closed this revision.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D22545

To: usta, #calligra:_3.0, Calligra-Devel-list, boemann
Cc: dfaure, pino, boemann, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D25714: [WIP]: Port away from deprecated KHtml

[Dag Andersen]

danders added a comment.


  Still wip, or...

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25714

To: ognarb, #calligra:_3.0
Cc: danders, leinir, Calligra-Devel-list, davidllewellynjones, dcaliste, 
ognarb, cochise, vandenoever

D25008: Add XLSX spreadsheets import optimisations for small/readonly devices

[Dag Andersen]

danders added a comment.


  ping?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25008

To: davidllewellynjones, #calligra:_3.0, pvuorela, dcaliste
Cc: danders, anthonyfieroni, Calligra-Devel-list, davidllewellynjones, 
dcaliste, ognarb, cochise, vandenoever

D24852: Remove list style from headings

[Dag Andersen]

danders accepted this revision.
danders added a comment.
This revision is now accepted and ready to land.


  Most seems to be positive, so go for it.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D24852

To: akomakhin, pvuorela, #calligra:_3.0, boemann, danders
Cc: danders, anthonyfieroni, boemann, Calligra-Devel-list, davidllewellynjones, 
dcaliste, ognarb, cochise, vandenoever

D26050: Fix build with poppler 82

[Dag Andersen]

danders added a comment.


  @tcanabrava please abondone this.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D26050

To: tcanabrava, #calligra:_3.0
Cc: danders, rjvbb, awilcox, dcaliste, leinir, asturmlechner, ognarb, 
anthonyfieroni, Calligra-Devel-list, davidllewellynjones, cochise, vandenoever

D2577: KoResourcePaths: Fix handling of wildcards in directories and files

[Dag Andersen]

danders abandoned this revision.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D2577

To: danders, #calligra:_3.0, staniek, Calligra-Devel-list
Cc: anthonyfieroni, staniek, davidllewellynjones, dcaliste, ognarb, barman, 
cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Dag Andersen]

danders accepted this revision.
danders added a comment.
This revision is now accepted and ready to land.


  There are unit tests that fail without this, so if somebody doas not come up 
with code that shows this is wrong, please commit.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D26328: Calculate and display proper number for headings started with lower level for DOC, DOCX and ODT.

[Dag Andersen]

danders added a comment.


  Any comments, anyone?
  I have not tested and does not know if it is the right way to do it.
  If nobody have comments, I'm willing to trust the author and say go for it!

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D26328

To: mphilippov, pvuorela, denexter, dcaliste, davidllewellynjones, boemann
Cc: danders, davidllewellynjones, dcaliste, denexter, pvuorela, 
Calligra-Devel-list, #calligra:_3.0, ognarb, cochise, vandenoever

D26328: Calculate and display proper number for headings started with lower level for DOC, DOCX and ODT.

[Dag Andersen]

danders added a reviewer: boemann.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D26328

To: mphilippov, pvuorela, denexter, dcaliste, davidllewellynjones, boemann
Cc: davidllewellynjones, dcaliste, denexter, pvuorela, Calligra-Devel-list, 
#calligra:_3.0, ognarb, cochise, vandenoever

D25423: Fill table cells with color for ODS and XLSX files

[Dag Andersen]

danders added a comment.


  ping?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25423

To: mphilippov, denexter, pvuorela, davidllewellynjones, dcaliste
Cc: danders, dcaliste, davidllewellynjones, denexter, Calligra-Devel-list, 
#calligra:_3.0, ognarb, cochise, vandenoever

D25422: Handle custom-shapes to display text in ODP files

[Dag Andersen]

danders added a comment.


  ping?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25422

To: mphilippov, denexter, davidllewellynjones, pvuorela, dcaliste
Cc: danders, denexter, pvuorela, Calligra-Devel-list, davidllewellynjones, 
dcaliste, ognarb, cochise, vandenoever

D26050: Fix build with poppler 82

[Dag Andersen]

danders added a comment.


  Ooops, seems I fixed this (+ 0.83) in separate commits, so this can be closed.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D26050

To: tcanabrava, #calligra:_3.0
Cc: danders, rjvbb, awilcox, dcaliste, leinir, asturmlechner, ognarb, 
anthonyfieroni, Calligra-Devel-list, davidllewellynjones, cochise, vandenoever

D26221: Use QQC2 Dialog

[Dag Andersen]

danders added a comment.


  ping?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D26221

To: ognarb, #calligra:_3.0, leinir
Cc: danders, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

D25254: Remove flow, not needed since karbon can do it all

[Dag Andersen]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:f8786b001b75: Remove flow, not needed since karbon can do 
it all (authored by danders).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25254?vs=69579=76900

REVISION DETAIL
  https://phabricator.kde.org/D25254

AFFECTED FILES
  CMakeLists.txt
  CalligraProducts.cmake
  flow/AUTHORS
  flow/CMakeLists.txt
  flow/LICENSE
  flow/Mainpage.dox
  flow/Messages.sh
  flow/NOTES
  flow/flow_dock.desktop
  flow/part/CMakeLists.txt
  flow/part/FlowAboutData.h
  flow/part/FlowDocument.cpp
  flow/part/FlowDocument.h
  flow/part/FlowFactory.cpp
  flow/part/FlowFactory.h
  flow/part/FlowFactoryInit.cpp
  flow/part/FlowFactoryInit.h
  flow/part/FlowPart.cpp
  flow/part/FlowPart.h
  flow/part/FlowView.cpp
  flow/part/FlowView.h
  flow/part/flow.rc
  flow/part/flowpart.desktop
  flow/part/flowrc
  flow/part/main.cpp
  flow/part/org.kde.calligraflow.appdata.xml
  flow/part/org.kde.calligraflow.desktop
  flow/pics/1024-apps-calligraflow.png
  flow/pics/128-apps-calligraflow.png
  flow/pics/16-apps-calligraflow.png
  flow/pics/22-apps-calligraflow.png
  flow/pics/256-apps-calligraflow.png
  flow/pics/32-apps-calligraflow.png
  flow/pics/48-apps-calligraflow.png
  flow/pics/512-apps-calligraflow.png
  flow/pics/64-apps-calligraflow.png
  flow/pics/CMakeLists.txt
  flow/pics/sc-apps-calligraflow.svgz
  flow/templates/CMakeLists.txt
  flow/templates/basic/.directory
  flow/templates/basic/48-actions-template_basicflow.png
  flow/templates/basic/48-actions-template_empty_landscape.png
  flow/templates/basic/48-actions-template_empty_portrait.png
  flow/templates/basic/CMakeLists.txt
  flow/templates/basic/basicflow.desktop
  flow/templates/basic/empty-landscape.desktop
  flow/templates/basic/empty-landscape.otg
  flow/templates/basic/empty-portrait.desktop
  flow/templates/basic/empty-portrait.otg
  flow/templates/basic/sc-actions-template_basicworkflow.svgz
  flow/templates/basic/sc-actions-template_empty_landscape.svgz
  flow/templates/basic/sc-actions-template_empty_portrait.svgz

To: danders, anthonyfieroni, #calligra:_3.0
Cc: boemann, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

Re: New website

[Dag]

Great work! 

old-components are propably ok, although we have not actually axed flow
and braindump yet. They will however, go on next release, if somebody
does not step up to maintain them. 

So, probably we should consider a new release soonish... 

As for web site access, probably a couple of more maintainers would like
access, but I'm sure they can speak up for themselves :)

---
Cheers, 

Dag 

Carl Schwan skrev den 2020-03-02 16:42:

> Hello,
> the website progressed a lot during Season of KDE and it was completly 
> updated. Thanks a lot to Anuj Bansal for his work on that and in improving 
> the Jekyll theme with new components.
> 
> It now use the Jekyll KDE theme, the screenshots are all updated with the 
> latest version of Calligra and use the Breeze theme. A demo version is 
> available at https://irl.carlschwan.eu/. It would be nice, if someone could 
> take a look at it and reports any errors or problems found. Particulary if 
> the information present on https://irl.carlschwan.eu/old-components/ are 
> correct.
> 
> The website git repository is located at 
> invent.kde.org/anujbansal/calligra-website/ and will be moved to 
> invent.kde.org/websites/calligra-org in the future, after the review.
> 
> For the sysadmin request and the deployment, I will need to know who need to 
> access the website. From reading the logs, I think it should be at least 
> Jarosław Staniek and danders, but if anyone else want access please let me 
> know. Just make sure you have an account in invent.kde.org (just login with 
> your identity.kde.org identifier one time), otherwise Sysadmin can't grant 
> you access :-).
> 
> I hope not many problems will be found. My plan will be to deploy the website 
> before the end of this month, so that it can appear on my second monthly KDE 
> web news :-)
> 
> Cheers,
> 
> Carl Schwan
> https://carlschwan.eu
> KDE Web developer
> 
> ‐‐‐ Original Message ‐‐‐
> Le mardi, janvier 7, 2020 9:53 PM, Carl Schwan  a écrit :
> 
>> Hi,
> 
>> I already spoke a bit about it with Leinir, but I will mentor a Season of 
>> KDE project about updating the Calligra website. The idea of updating the 
>> Calligra website was really popular and I received more than 10 proposals 
>> for the website. I choose Anuj Bansal since he already contributed to the 
>> juk.kde.org website and he is familiar with the current KDE web tooling.
> 
>> The goal of the new website is to bring new users and new contributors to 
>> Calligra.
> 
>> The website update will be focused around the content, the design, and the 
>> infrastructure.
> 
>> -   Content:
>> -   the screenshots need to be updated to use the Breeze theme
>> -   the text need be checked to see if it is still actual
>> -   Url should remain the same for compatibility with the old links
>> -   Old content needs to be ported. We should not lose any announcements
>> -   The planet feature is easy to reproduce using the Jekyll planet 
>> component.
>> -   Add get-involved page with links to developer information and other 
>> useful information to start hacking on Calligra ;)
>> -   Design:
>> -   The updated website will use the Aether theme. This is the theme used 
>> for kde.org and was designed for KDE.
>> -   Potentially we could use some small variation from the main theme to 
>> make the website more unique.
>> -   A good example about how the website could look in the future is 
>> kontact.kde.org
>> -   New design will be also compatible with mobile phone.
>> -   Infrastructure:
>> -   The new website will use Jekyll a static site generator (the CI build 
>> the website and the server only serve plain html content). This means the 
>> website will be faster to load for the visitor and more secure.
>> -   All the content is stored in git as markdown files and this makes it 
>> easier to contribute to the website (we can use gitlab as CMS)
> 
>> As the first step for Anuj, I think the best would be to set up a repository 
>> in invent.kde.org and create the base structure with a lot of boilerplate 
>> content (copied from the existing website) and the basic Jekyll 
>> configuration. When we can iterate over the content and design until 
>> everyone is happy with it. :)
> 
>> Any questions? or other requirements for the website I forgot to mention?
> 
>> Regards,
> 
>> Carl

D27056: Stage: Add automatic slide transition

[Dag Andersen]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:4f4141727401: Stage: Add automatic slide transition 
(authored by danders).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27056?vs=74748=75033

REVISION DETAIL
  https://phabricator.kde.org/D27056

AFFECTED FILES
  stage/part/CMakeLists.txt
  stage/part/KPrAnimationDirector.cpp
  stage/part/KPrAnimationDirector.h
  stage/part/KPrPage.cpp
  stage/part/KPrPageApplicationData.cpp
  stage/part/KPrPageApplicationData.h
  stage/part/KPrPageTransition.cpp
  stage/part/KPrPageTransition.h
  stage/part/commands/KPrPageTransitionSetCommand.cpp
  stage/part/commands/KPrPageTransitionSetCommand.h
  stage/part/tools/animationtool/KPrPageEffectDocker.cpp
  stage/part/tools/animationtool/KPrPageEffectDocker.h

To: danders, zachmann
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D27056: Stage: Add automatic slide transition

[Dag Andersen]

danders created this revision.
danders added a reviewer: zachmann.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
danders requested review of this revision.

REVISION SUMMARY
  Introduces 2 modes for slide transitions:
  Manual: Slide transition and animations must be activated manually (any page 
effect is always run)
  Automatic: Slide transition included page effects and animations is activated 
automatically after a user selectable time.
  
  Known bug:
  The animation docker ui is not updated after undo but this is general bug
  and not introduced by this patch.
  See bug 416979.

REPOSITORY
  R8 Calligra

BRANCH
  pagetransition_danders

REVISION DETAIL
  https://phabricator.kde.org/D27056

AFFECTED FILES
  stage/part/CMakeLists.txt
  stage/part/KPrAnimationDirector.cpp
  stage/part/KPrAnimationDirector.h
  stage/part/KPrPage.cpp
  stage/part/KPrPageApplicationData.cpp
  stage/part/KPrPageApplicationData.h
  stage/part/KPrPageTransition.cpp
  stage/part/KPrPageTransition.h
  stage/part/commands/KPrPageTransitionSetCommand.cpp
  stage/part/commands/KPrPageTransitionSetCommand.h
  stage/part/tools/animationtool/KPrPageEffectDocker.cpp
  stage/part/tools/animationtool/KPrPageEffectDocker.h

To: danders, zachmann
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D25664: [WIP]: Port away from deprecated QSignalMapper

[Dag Andersen]

danders added a comment.


  Afaik we still support qt5.3, I don't think qAsConst is availabel.
  Disregard if this has changed.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25664

To: ognarb, #calligra:_3.0, #kf6, dfaure
Cc: danders, dfaure, Calligra-Devel-list, davidllewellynjones, dcaliste, 
ognarb, cochise, vandenoever

D25254: Remove flow, not needed since karbon can do it all

[Dag Andersen]

danders added a comment.


  In D25254#561131 , @boemann wrote:
  
  > To be honest I kind of liked the idea of a dedicated flow drawing tool and 
a dedicated vector drawing tool, but since they have so little between them, 
and no one seem to be maintaining flow.
  
  
  Yes, I agree. 
  It is however, a problem having two apps using same native mimetype for realy 
different content.
  I would certainly think it was worth it if flow had really good support for 
flow charts,
  but it is really just the minimum needed to create a pageapp.
  All functionallity is in the plugins, so flow does not offer any advantage 
over karbon or words.
  
  I'll let this patch rest fttb, a decission can be made closer to next release.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25254

To: danders, anthonyfieroni, #calligra:_3.0
Cc: boemann, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

D25254: Remove flow, not needed since karbon can do it all

[Dag Andersen]

danders added a comment.


  Yeah, well.
  If flow had some special functionallity that made it much easier to crate 
flow charts, I would also be reluctant to just remove it.
  As it stands flow has nothing special, it is only a few line of code 
actually, and as I see it, the karbon ui is very similar to flow.
  Granted, karbon can do a lot more, but I don't think it is disturibing the 
user as this is 'hidden' in separate menus.
  
  Also, on a technical note, having two apps that handle the same mimetype 
(they are using the odg file format both) confuses the filter system.
  E.g: You might try to open an svg file in karbon, but it might be opened in 
flow. In this case the only thing you can do as is to uninstall flow.
  
  If you look to LO, they just use their regular draw app for flow charts too.
  
  Now, if there was sombody that was interested in creating a fantastic flow 
app and maintaining it, maybe it should stay, but...
  
  In short, I don't see any good reason to keep it.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25254

To: danders, anthonyfieroni
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever

D25254: Remove flow, not needed since karbon can do it all

[Dag Andersen]

danders created this revision.
danders added a reviewer: anthonyfieroni.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
danders requested review of this revision.

REVISION SUMMARY
  Since karbon is multipage app and stencils docker can be used by all apps,
  there is no need for flow anymore.
  
  Removing flow also 'fixes' problem with filter system, as it does not
  know which app to open when two apps handle the same mimetype.

TEST PLAN
  Tested with visio files.

REPOSITORY
  R8 Calligra

BRANCH
  danders_remove_flow

REVISION DETAIL
  https://phabricator.kde.org/D25254

AFFECTED FILES
  CMakeLists.txt
  CalligraProducts.cmake
  flow/AUTHORS
  flow/CMakeLists.txt
  flow/LICENSE
  flow/Mainpage.dox
  flow/Messages.sh
  flow/NOTES
  flow/flow_dock.desktop
  flow/part/CMakeLists.txt
  flow/part/FlowAboutData.h
  flow/part/FlowDocument.cpp
  flow/part/FlowDocument.h
  flow/part/FlowFactory.cpp
  flow/part/FlowFactory.h
  flow/part/FlowFactoryInit.cpp
  flow/part/FlowFactoryInit.h
  flow/part/FlowPart.cpp
  flow/part/FlowPart.h
  flow/part/FlowView.cpp
  flow/part/FlowView.h
  flow/part/flow.rc
  flow/part/flowpart.desktop
  flow/part/flowrc
  flow/part/main.cpp
  flow/part/org.kde.calligraflow.appdata.xml
  flow/part/org.kde.calligraflow.desktop
  flow/pics/1024-apps-calligraflow.png
  flow/pics/128-apps-calligraflow.png
  flow/pics/16-apps-calligraflow.png
  flow/pics/22-apps-calligraflow.png
  flow/pics/256-apps-calligraflow.png
  flow/pics/32-apps-calligraflow.png
  flow/pics/48-apps-calligraflow.png
  flow/pics/512-apps-calligraflow.png
  flow/pics/64-apps-calligraflow.png
  flow/pics/CMakeLists.txt
  flow/pics/sc-apps-calligraflow.svgz
  flow/templates/CMakeLists.txt
  flow/templates/basic/.directory
  flow/templates/basic/48-actions-template_basicflow.png
  flow/templates/basic/48-actions-template_empty_landscape.png
  flow/templates/basic/48-actions-template_empty_portrait.png
  flow/templates/basic/CMakeLists.txt
  flow/templates/basic/basicflow.desktop
  flow/templates/basic/empty-landscape.desktop
  flow/templates/basic/empty-landscape.otg
  flow/templates/basic/empty-portrait.desktop
  flow/templates/basic/empty-portrait.otg
  flow/templates/basic/sc-actions-template_basicworkflow.svgz
  flow/templates/basic/sc-actions-template_empty_landscape.svgz
  flow/templates/basic/sc-actions-template_empty_portrait.svgz

To: danders, anthonyfieroni
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever

D25214: Karbon image filter: Add multipage support

[Dag Andersen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:0daf145a929a: Karbon image filter: Add multipage support 
(authored by danders).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25214?vs=69566=69567

REVISION DETAIL
  https://phabricator.kde.org/D25214

AFFECTED FILES
  filters/karbon/image/ImageExport.cpp
  filters/karbon/image/ImageExportOptionsWidget.cpp
  filters/karbon/image/ImageExportOptionsWidget.h
  filters/karbon/image/ImageExportOptionsWidget.ui

To: danders, anthonyfieroni
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever

D25214: Karbon image filter: Add multipage support

[Dag Andersen]

danders updated this revision to Diff 69566.
danders added a comment.


  Remove unused include

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25214?vs=69438=69566

BRANCH
  multipage_image_danders

REVISION DETAIL
  https://phabricator.kde.org/D25214

AFFECTED FILES
  filters/karbon/image/ImageExport.cpp
  filters/karbon/image/ImageExportOptionsWidget.cpp
  filters/karbon/image/ImageExportOptionsWidget.h
  filters/karbon/image/ImageExportOptionsWidget.ui

To: danders, anthonyfieroni
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever

D25214: Karbon image filter: Add multipage support

[Dag Andersen]

danders created this revision.
danders added a reviewer: anthonyfieroni.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
danders requested review of this revision.

REVISION SUMMARY
  Adds ability to select page in the options dialog

TEST PLAN
  Export to png and jpeg from page > 1.

REPOSITORY
  R8 Calligra

BRANCH
  multipage_image_danders

REVISION DETAIL
  https://phabricator.kde.org/D25214

AFFECTED FILES
  filters/karbon/image/ImageExport.cpp
  filters/karbon/image/ImageExportOptionsWidget.cpp
  filters/karbon/image/ImageExportOptionsWidget.h
  filters/karbon/image/ImageExportOptionsWidget.ui

To: danders, anthonyfieroni
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever

D25171: PDF Import: Add multipage support

[Dag Andersen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:c81c23998e09: PDF Import: Add multipage support (authored 
by danders).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25171?vs=69423=69424

REVISION DETAIL
  https://phabricator.kde.org/D25171

AFFECTED FILES
  filters/karbon/pdf/CMakeLists.txt
  filters/karbon/pdf/Pdf2OdgImport.cpp
  filters/karbon/pdf/Pdf2OdgImport.h
  filters/karbon/pdf/PdfImportDebug.cpp
  filters/karbon/pdf/calligra_filter_pdf2odg.desktop

To: danders, anthonyfieroni
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever

D25171: PDF Import: Add multipage support

[Dag Andersen]

danders created this revision.
danders added a reviewer: anthonyfieroni.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
danders requested review of this revision.

REVISION SUMMARY
  Imports multipage pdf files as svg using poppler to generate an svg file pr 
page.

REPOSITORY
  R8 Calligra

BRANCH
  multipagepdf

REVISION DETAIL
  https://phabricator.kde.org/D25171

AFFECTED FILES
  filters/karbon/pdf/CMakeLists.txt
  filters/karbon/pdf/Pdf2OdgImport.cpp
  filters/karbon/pdf/Pdf2OdgImport.h
  filters/karbon/pdf/PdfImportDebug.cpp
  filters/karbon/pdf/calligra_filter_pdf2odg.desktop

To: danders, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D20400: Karbon: Enable multi page capability

[Dag Andersen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:5a9a18f484a4: Karbon: Enable multi page capability 
(authored by danders).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20400?vs=69263=69300

REVISION DETAIL
  https://phabricator.kde.org/D20400

AFFECTED FILES
  CalligraProducts.cmake
  filters/karbon/CMakeLists.txt
  filters/karbon/image/CMakeLists.txt
  filters/karbon/image/ImageExport.cpp
  filters/karbon/svg/CMakeLists.txt
  filters/karbon/svg/SvgExport.cpp
  filters/karbon/svg/SvgImport.cpp
  filters/karbon/wmf/CMakeLists.txt
  filters/karbon/wmf/WmfExport.cpp
  karbon/CMakeLists.txt
  karbon/data/karbon.rc
  karbon/ui/CMakeLists.txt
  karbon/ui/KarbonDocument.cpp
  karbon/ui/KarbonDocument.h
  karbon/ui/KarbonDocumentMergeCommand.cpp
  karbon/ui/KarbonDocumentMergeCommand.h
  karbon/ui/KarbonFactory.cpp
  karbon/ui/KarbonPart.cpp
  karbon/ui/KarbonPart.h
  karbon/ui/KarbonPrintJob.cpp
  karbon/ui/KarbonPrintJob.h
  karbon/ui/KarbonView.cpp
  karbon/ui/KarbonView.h
  karbon/ui/ProxyView.cpp
  karbon/ui/ProxyView.h
  karbon/ui/dockers/KarbonLayerDocker.cpp
  karbon/ui/dockers/KarbonLayerDocker.h
  karbon/ui/dockers/KarbonLayerModel.cpp
  karbon/ui/dockers/KarbonLayerModel.h
  karbon/ui/dockers/KarbonLayerSortingModel.cpp
  karbon/ui/dockers/KarbonLayerSortingModel.h
  karbon/ui/widgets/KarbonCanvas.cpp
  karbon/ui/widgets/KarbonCanvas.h
  karbon/ui/widgets/KarbonConfigInterfacePage.cpp
  karbon/ui/widgets/KarbonSmallStylePreview.h
  libs/pageapp/KoPADocument.cpp
  libs/pageapp/KoPADocument.h
  libs/pageapp/KoPAView.cpp
  libs/pageapp/KoPAView.h
  libs/pageapp/widgets/KoPageNavigator.cpp
  libs/pageapp/widgets/KoPageNavigator.h

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D20400: Karbon: Enable multi page capability

[Dag Andersen]

danders added a comment.


  In D20400#475477 , @anthonyfieroni 
wrote:
  
  > Now we have insert page, but we don't exports them :) If you think that's 
ok for now go for it.
  
  
  Just for the record: The pdf filter goes through the svg filter and as since 
svg does not know about pages, all but first page is lost.
  We need a new pdf->odg filter that can handle the pages.

REPOSITORY
  R8 Calligra

BRANCH
  karbon_multipage_danders

REVISION DETAIL
  https://phabricator.kde.org/D20400

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D20400: Karbon: Enable multi page capability

[Dag Andersen]

danders updated this revision to Diff 69263.
danders added a comment.


  KarbonView: Add slot to handle replaceActivePage

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20400?vs=69262=69263

BRANCH
  karbon_multipage_danders

REVISION DETAIL
  https://phabricator.kde.org/D20400

AFFECTED FILES
  CalligraProducts.cmake
  filters/karbon/CMakeLists.txt
  filters/karbon/image/CMakeLists.txt
  filters/karbon/image/ImageExport.cpp
  filters/karbon/svg/CMakeLists.txt
  filters/karbon/svg/SvgExport.cpp
  filters/karbon/svg/SvgImport.cpp
  filters/karbon/wmf/CMakeLists.txt
  filters/karbon/wmf/WmfExport.cpp
  karbon/CMakeLists.txt
  karbon/data/karbon.rc
  karbon/ui/CMakeLists.txt
  karbon/ui/KarbonDocument.cpp
  karbon/ui/KarbonDocument.h
  karbon/ui/KarbonDocumentMergeCommand.cpp
  karbon/ui/KarbonDocumentMergeCommand.h
  karbon/ui/KarbonFactory.cpp
  karbon/ui/KarbonPart.cpp
  karbon/ui/KarbonPart.h
  karbon/ui/KarbonPrintJob.cpp
  karbon/ui/KarbonPrintJob.h
  karbon/ui/KarbonView.cpp
  karbon/ui/KarbonView.h
  karbon/ui/ProxyView.cpp
  karbon/ui/ProxyView.h
  karbon/ui/dockers/KarbonLayerDocker.cpp
  karbon/ui/dockers/KarbonLayerDocker.h
  karbon/ui/dockers/KarbonLayerModel.cpp
  karbon/ui/dockers/KarbonLayerModel.h
  karbon/ui/dockers/KarbonLayerSortingModel.cpp
  karbon/ui/dockers/KarbonLayerSortingModel.h
  karbon/ui/widgets/KarbonCanvas.cpp
  karbon/ui/widgets/KarbonCanvas.h
  karbon/ui/widgets/KarbonConfigInterfacePage.cpp
  karbon/ui/widgets/KarbonSmallStylePreview.h
  libs/pageapp/KoPADocument.cpp
  libs/pageapp/KoPADocument.h
  libs/pageapp/KoPAView.cpp
  libs/pageapp/KoPAView.h
  libs/pageapp/widgets/KoPageNavigator.cpp
  libs/pageapp/widgets/KoPageNavigator.h

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D20400: Karbon: Enable multi page capability

[Dag Andersen]

danders updated this revision to Diff 69262.
danders added a comment.


  SvgImport: Add the new layer to the page

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20400?vs=69152=69262

BRANCH
  karbon_multipage_danders

REVISION DETAIL
  https://phabricator.kde.org/D20400

AFFECTED FILES
  CalligraProducts.cmake
  filters/karbon/CMakeLists.txt
  filters/karbon/image/CMakeLists.txt
  filters/karbon/image/ImageExport.cpp
  filters/karbon/svg/CMakeLists.txt
  filters/karbon/svg/SvgExport.cpp
  filters/karbon/svg/SvgImport.cpp
  filters/karbon/wmf/CMakeLists.txt
  filters/karbon/wmf/WmfExport.cpp
  karbon/CMakeLists.txt
  karbon/data/karbon.rc
  karbon/ui/CMakeLists.txt
  karbon/ui/KarbonDocument.cpp
  karbon/ui/KarbonDocument.h
  karbon/ui/KarbonDocumentMergeCommand.cpp
  karbon/ui/KarbonDocumentMergeCommand.h
  karbon/ui/KarbonFactory.cpp
  karbon/ui/KarbonPart.cpp
  karbon/ui/KarbonPart.h
  karbon/ui/KarbonPrintJob.cpp
  karbon/ui/KarbonPrintJob.h
  karbon/ui/KarbonView.cpp
  karbon/ui/KarbonView.h
  karbon/ui/ProxyView.cpp
  karbon/ui/ProxyView.h
  karbon/ui/dockers/KarbonLayerDocker.cpp
  karbon/ui/dockers/KarbonLayerDocker.h
  karbon/ui/dockers/KarbonLayerModel.cpp
  karbon/ui/dockers/KarbonLayerModel.h
  karbon/ui/dockers/KarbonLayerSortingModel.cpp
  karbon/ui/dockers/KarbonLayerSortingModel.h
  karbon/ui/widgets/KarbonCanvas.cpp
  karbon/ui/widgets/KarbonCanvas.h
  karbon/ui/widgets/KarbonConfigInterfacePage.cpp
  karbon/ui/widgets/KarbonSmallStylePreview.h
  libs/pageapp/KoPADocument.cpp
  libs/pageapp/KoPADocument.h
  libs/pageapp/KoPAView.cpp
  libs/pageapp/KoPAView.h
  libs/pageapp/widgets/KoPageNavigator.cpp
  libs/pageapp/widgets/KoPageNavigator.h

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D20400: Karbon: Enable multi page capability

[Dag Andersen]

danders updated this revision to Diff 69152.
danders added a comment.


  Handle removing pages from a pageapp properly

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20400?vs=59256=69152

BRANCH
  karbon_multipage_danders

REVISION DETAIL
  https://phabricator.kde.org/D20400

AFFECTED FILES
  CalligraProducts.cmake
  filters/karbon/CMakeLists.txt
  filters/karbon/image/CMakeLists.txt
  filters/karbon/image/ImageExport.cpp
  filters/karbon/svg/CMakeLists.txt
  filters/karbon/svg/SvgExport.cpp
  filters/karbon/svg/SvgImport.cpp
  filters/karbon/wmf/CMakeLists.txt
  filters/karbon/wmf/WmfExport.cpp
  karbon/CMakeLists.txt
  karbon/data/karbon.rc
  karbon/ui/CMakeLists.txt
  karbon/ui/KarbonDocument.cpp
  karbon/ui/KarbonDocument.h
  karbon/ui/KarbonDocumentMergeCommand.cpp
  karbon/ui/KarbonDocumentMergeCommand.h
  karbon/ui/KarbonFactory.cpp
  karbon/ui/KarbonPart.cpp
  karbon/ui/KarbonPart.h
  karbon/ui/KarbonPrintJob.cpp
  karbon/ui/KarbonPrintJob.h
  karbon/ui/KarbonView.cpp
  karbon/ui/KarbonView.h
  karbon/ui/ProxyView.cpp
  karbon/ui/ProxyView.h
  karbon/ui/dockers/KarbonLayerDocker.cpp
  karbon/ui/dockers/KarbonLayerDocker.h
  karbon/ui/dockers/KarbonLayerModel.cpp
  karbon/ui/dockers/KarbonLayerModel.h
  karbon/ui/dockers/KarbonLayerSortingModel.cpp
  karbon/ui/dockers/KarbonLayerSortingModel.h
  karbon/ui/widgets/KarbonCanvas.cpp
  karbon/ui/widgets/KarbonCanvas.h
  karbon/ui/widgets/KarbonConfigInterfacePage.cpp
  karbon/ui/widgets/KarbonSmallStylePreview.h
  libs/pageapp/KoPADocument.cpp
  libs/pageapp/KoPADocument.h
  libs/pageapp/KoPAView.cpp
  libs/pageapp/KoPAView.h
  libs/pageapp/widgets/KoPageNavigator.cpp
  libs/pageapp/widgets/KoPageNavigator.h

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D20400: Karbon: Enable multi page capability

[Dag Andersen]

danders added a comment.


  In D20400#475477 , @anthonyfieroni 
wrote:
  
  > Now we have insert page, but we don't exports them :) If you think that's 
ok for now go for it.
  
  
  If you mean export to svg here, afaics there are no page element in svg. Have 
I missed it?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D20400

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D20400: Karbon: Enable multi page capability

[Dag Andersen]

danders updated this revision to Diff 59256.
danders added a comment.


  Add dependence on LIB_KOPAGEAPP

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20400?vs=55797=59256

BRANCH
  karbon_multipage_danders

REVISION DETAIL
  https://phabricator.kde.org/D20400

AFFECTED FILES
  CalligraProducts.cmake
  filters/karbon/CMakeLists.txt
  filters/karbon/image/CMakeLists.txt
  filters/karbon/image/ImageExport.cpp
  filters/karbon/svg/CMakeLists.txt
  filters/karbon/svg/SvgExport.cpp
  filters/karbon/svg/SvgImport.cpp
  filters/karbon/wmf/CMakeLists.txt
  filters/karbon/wmf/WmfExport.cpp
  karbon/CMakeLists.txt
  karbon/data/karbon.rc
  karbon/ui/CMakeLists.txt
  karbon/ui/KarbonDocument.cpp
  karbon/ui/KarbonDocument.h
  karbon/ui/KarbonDocumentMergeCommand.cpp
  karbon/ui/KarbonDocumentMergeCommand.h
  karbon/ui/KarbonFactory.cpp
  karbon/ui/KarbonPart.cpp
  karbon/ui/KarbonPart.h
  karbon/ui/KarbonPrintJob.cpp
  karbon/ui/KarbonPrintJob.h
  karbon/ui/KarbonView.cpp
  karbon/ui/KarbonView.h
  karbon/ui/ProxyView.cpp
  karbon/ui/ProxyView.h
  karbon/ui/dockers/KarbonLayerDocker.cpp
  karbon/ui/dockers/KarbonLayerDocker.h
  karbon/ui/dockers/KarbonLayerModel.cpp
  karbon/ui/dockers/KarbonLayerModel.h
  karbon/ui/dockers/KarbonLayerSortingModel.cpp
  karbon/ui/dockers/KarbonLayerSortingModel.h
  karbon/ui/widgets/KarbonCanvas.cpp
  karbon/ui/widgets/KarbonCanvas.h
  karbon/ui/widgets/KarbonConfigInterfacePage.cpp
  karbon/ui/widgets/KarbonSmallStylePreview.h
  libs/pageapp/KoPAView.cpp
  libs/pageapp/KoPAView.h

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D20400: Karbon: Enable multi page capability

[Dag Andersen]

danders added a comment.


  I have been pondering why we disagreed so much on the background color, and I 
*think* I have an answer.
  My take is it's because we have not been talking about quite the same thing:
  I have looked at karbon as an *odg* editor, since it uses odg as its native 
file format.
  Since odg is wysiwyg nothing outside the doc should in any way affect the way 
it is presented, hence a background that is not saved to file doesn't make 
sence.
  
  OTOH, if one looks at karbon as an *svg* editor, the current background color 
implementation makes much more sence,
  since svg is meant to be embedded in an environment outside of the svg doc 
itself like screen, html, odg, etc.
  
  This leads me to two possible paths to take:
  
  1. Karbon as odg editor means this patch goes in.
  2. Karbon as svg editor means swicth to svg as native format and add odg 
export/import.
  
  (One could of course also keep karbon as svg editor and add a calligradraw 
app, but well, probably a bit of work...)

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D20400

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D20400: Karbon: Enable multi page capability

[Dag Andersen]

danders added a comment.


  Ooops, this didn't work as expected. This should have been a revision of 
D19327 .
  There is only small changes:
  
  1. Updated commit message.
  2. In karbon/ui/KarbonFactory.cpp: Loading of the calligra/pageapp tools.
  3. In karbon/data/karbon.rc: Removal of the "format" menu (not used) and 
adding the "format_pagelayout" action  to "settings" menu (where it was 
originally).
  
  This takes care of the page backround issue we have been discussing.
  The change is that the color is now saved to the odg document (as it should 
be, imo).
  Since the svg export filter does not save background color, there is no 
change here.
  
  (Sorry for the inconvinience, I've never been very friendly with arc/phab)

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D20400

To: danders, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D20400: Karbon: Enable multi page capability

[Dag Andersen]

danders created this revision.
danders added a reviewer: anthonyfieroni.
danders added a project: Calligra: 3.0.
danders requested review of this revision.

REVISION SUMMARY
  Since odg spec supports multiple pages, I feel karbon also needs to support 
it.
  
  The main things that has changed:
  
  1. Since multiple pages is supported, adding/copying/deleting pages is now 
possible.
  2. The page background color is now set with a tool in the tool box. The 
entry for background color in the Settings dialog is superflous and has been 
removed.
  
  Ported to use pageapp classes.
  
  A lot of code was duplicated between pageapp and karbon
  and has been removed from karbon:
  
  - Save/load
  - Layers docker and all layer operations
  - Grid, guides, rulers and zoom
  - Event handlers
  - Printing
  - Show page margins has been moved to pageapp
  
  In general, import/export needs review to determine how to
  handle multiple pages when e.g. exporting to a format that
  does not support pages.
  
  Known bugs:
  
  - "Separate paths" command:
- Execute command, the shape disappears.
- Undo crashes. Note: Afaics this code is not touched so probably a libs 
bug.
  
  - Snap to grid does not work
  
  - Number of recent files does not work properly

TEST PLAN
  I am not an avid user of karbon, so would be nice if some that where could 
test.
  Also, do not have all types of different format docs for filter testing.
  Some that work are pdf, svg, jpg and karbon files.

REPOSITORY
  R8 Calligra

BRANCH
  karbon_multipage_danders

REVISION DETAIL
  https://phabricator.kde.org/D20400

AFFECTED FILES
  filters/karbon/CMakeLists.txt
  filters/karbon/image/CMakeLists.txt
  filters/karbon/image/ImageExport.cpp
  filters/karbon/svg/CMakeLists.txt
  filters/karbon/svg/SvgExport.cpp
  filters/karbon/svg/SvgImport.cpp
  filters/karbon/wmf/CMakeLists.txt
  filters/karbon/wmf/WmfExport.cpp
  karbon/CMakeLists.txt
  karbon/data/karbon.rc
  karbon/ui/CMakeLists.txt
  karbon/ui/KarbonDocument.cpp
  karbon/ui/KarbonDocument.h
  karbon/ui/KarbonDocumentMergeCommand.cpp
  karbon/ui/KarbonDocumentMergeCommand.h
  karbon/ui/KarbonFactory.cpp
  karbon/ui/KarbonPart.cpp
  karbon/ui/KarbonPart.h
  karbon/ui/KarbonPrintJob.cpp
  karbon/ui/KarbonPrintJob.h
  karbon/ui/KarbonView.cpp
  karbon/ui/KarbonView.h
  karbon/ui/ProxyView.cpp
  karbon/ui/ProxyView.h
  karbon/ui/dockers/KarbonLayerDocker.cpp
  karbon/ui/dockers/KarbonLayerDocker.h
  karbon/ui/dockers/KarbonLayerModel.cpp
  karbon/ui/dockers/KarbonLayerModel.h
  karbon/ui/dockers/KarbonLayerSortingModel.cpp
  karbon/ui/dockers/KarbonLayerSortingModel.h
  karbon/ui/widgets/KarbonCanvas.cpp
  karbon/ui/widgets/KarbonCanvas.h
  karbon/ui/widgets/KarbonConfigInterfacePage.cpp
  karbon/ui/widgets/KarbonSmallStylePreview.h
  libs/pageapp/KoPAView.cpp
  libs/pageapp/KoPAView.h

To: danders, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

T10760: Calligra website unwanted blog content

[Dag Andersen]

danders added a comment.


  It seems I have not the privileges to fix this.
  Can someone else have a look?

TASK DETAIL
  https://phabricator.kde.org/T10760

To: danders
Cc: danders, #sysadmin, Calligra-Devel-list, #calligra:_3.0, ongunkanat, 
sysadmin

D11971: Use same keyword separator for read and write

[Dag Andersen]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:e52edfd1b50f: D11971: Use same keyword separator for read 
and write (authored by danders).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11971?vs=31423=54770#toc

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11971?vs=31423=54770

REVISION DETAIL
  https://phabricator.kde.org/D11971

AFFECTED FILES
  libs/main/tests/documentstructuretest.cpp
  libs/odf/KoDocumentInfo.cpp
  libs/odf/KoDocumentInfo.h

To: michaelh, #calligra:_3.0, leinir, danders
Cc: Calligra-Devel-list, anthonyfieroni, dcaliste, cochise, vandenoever

D11971: Use same keyword separator for read and write

[Dag Andersen]

danders added a comment.


  Yes, looks sane, I'll deal with it.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D11971

To: michaelh, #calligra:_3.0, leinir, danders
Cc: Calligra-Devel-list, anthonyfieroni, dcaliste, cochise, vandenoever

D19884: Avoid deprecated QAbstractItemModel::reset()

[Dag Andersen]

danders accepted this revision.
danders added a comment.
This revision is now accepted and ready to land.


  I think this should be ok

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19884

To: pvuorela, danders
Cc: danders, dcaliste, Calligra-Devel-list, cochise, vandenoever

D19973: MsooXmlCommonRead: protect member for double free

[Dag Andersen]

danders accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19973

To: pvuorela, #calligra:_3.0, danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19941: Avoid deprecated setSupportedDragActions

[Dag Andersen]

danders accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19941

To: pvuorela, #calligra:_3.0, danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19938: Avoid deprecated QRegion::subtract()

[Dag Andersen]

danders accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19938

To: pvuorela, #calligra:_3.0, danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19912: Implement logging category for rtf-qt

[Dag Andersen]

danders added a comment.


  In D19912#435067 , @pvuorela wrote:
  
  > In D19912#435058 , @danders 
wrote:
  >
  > > Strange indents, could you fix it?
  >
  >
  > That's what I commented on the summary. On some parts rtf-qt uses plain 
spaces for indentation and those parts look good. Then in the same file other 
methods might have a hard tab or a hard tab followed by spaces. If you really 
want, I can try to retain the old whitespace, but it's indentation-wise more or 
less broken already anyway :) Alternatively could run astyle for the 
subdirectory, though maybe best done as separate commit.
  
  
  Yes, sorry, as you say better done separatly.
  
  > The directory README also states "Temporary local copy of Brad Hards' 
rtf-qt library.", though as upstream hasn't had changes since 2011, it seems 
like a permanent one by now.
  
  Probably.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19912

To: pvuorela, danders
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19912: Implement logging category for rtf-qt

[Dag Andersen]

danders accepted this revision.
danders added a comment.
This revision is now accepted and ready to land.


  Strange indents, could you fix it?
  Otherwise ok.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19912

To: pvuorela, danders
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19885: Implement logging category for excel plugins

[Dag Andersen]

danders accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19885

To: pvuorela, danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19759: Remove Qt::WA_InputMethodEnabled attribute from QGraphicsWidgets

[Dag Andersen]

danders added a reviewer: boemann.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19759

To: pvuorela, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19760: Support Qt <5.7 on KoShape flag usage

[Dag Andersen]

danders accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19760

To: pvuorela, danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19761: Remove obsolete syncX() workaround

[Dag Andersen]

danders accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19761

To: pvuorela, danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

[Dag Andersen]

danders added a comment.


  In D19216#421689 , @rjvbb wrote:
  
  > >   That is actual a valid point, although in say Krita with transparent 
pixels a checkerboard is shown.
  >
  > Heh, I've had the opportunity to work closely with professional 
infographists so I picked up a thing or two about using applications like 
Illustrator and InDesign :)
  >
  > How to indicate a transparent area of an object is yet another subject, 
with a related but not identical purpose.
  >
  > >   That said it might make more sense for this "testing background" to be 
part of the document and not a general setting - if the use case is as you say 
then the testing background would also be different for different projects
  >
  > True. I was reacting to *re*moving a setting completely, not to moving it 
to a more appropriate context.
  
  
  Ok, after another rethink...
  It starts to make sence if karbon is used not as an odg editor but as an svg 
editor.
  Let's say you create an icon that should be shown on certain background 
color(s), it would be a help if you could check your design aginst those colors.
  In his case you are not concerned with wysiwyg or printing  as you would be 
with an odg document.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19216

To: danders, anthonyfieroni
Cc: boemann, rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19327: Karbon: Enable multi page capability

[Dag Andersen]

danders created this revision.
danders added a reviewer: anthonyfieroni.
danders added a project: Calligra: 3.0.
danders requested review of this revision.

REVISION SUMMARY
  Since odg spec supports multiple pages, I feel karbon also needs to support 
it.
  
  Ported to use pageapp classes.
  
  Karbon has config group "Interface" that is not precent in other apps.
  Some of the options have been disabled atm. Imho they should be
  harmonized with other apps and/or moved to View menu.
  
  A lot of code was duplicated between pageapp and karbon
  and has been removed from karbon:
  
  - Save/load
  - Layers docker and all layer operations
  - Grid, guides, rulers and zoom
  - Event handlers
  - Printing
  - Show page margins has been moved to pageapp
  
  In general, import/export needs review to determine how to
  handle multiple pages when e.g. exporting to a format that
  does not support pages.
  
  Known bugs:
  
  - "Separate paths" command:
- Execute command, the shape disappears.
- Undo crashes. Note: Afaics this code is not touched so probably a libs 
bug.
  
  - Snap to grid does not work
  
  - Number of recent files does not work properly

TEST PLAN
  I am not an avid user of karbon, so would be nice if some that where could 
test.
  Also, do not have all types of different format docs for filter testing.
  Some that work are pdf, svg, jpg and karbon files.

REPOSITORY
  R8 Calligra

BRANCH
  karbon_multipage_danders

REVISION DETAIL
  https://phabricator.kde.org/D19327

AFFECTED FILES
  filters/karbon/CMakeLists.txt
  filters/karbon/image/CMakeLists.txt
  filters/karbon/image/ImageExport.cpp
  filters/karbon/svg/CMakeLists.txt
  filters/karbon/svg/SvgExport.cpp
  filters/karbon/svg/SvgImport.cpp
  filters/karbon/wmf/CMakeLists.txt
  filters/karbon/wmf/WmfExport.cpp
  karbon/CMakeLists.txt
  karbon/data/karbon.rc
  karbon/ui/CMakeLists.txt
  karbon/ui/KarbonDocument.cpp
  karbon/ui/KarbonDocument.h
  karbon/ui/KarbonDocumentMergeCommand.cpp
  karbon/ui/KarbonDocumentMergeCommand.h
  karbon/ui/KarbonPart.cpp
  karbon/ui/KarbonPart.h
  karbon/ui/KarbonPrintJob.cpp
  karbon/ui/KarbonPrintJob.h
  karbon/ui/KarbonView.cpp
  karbon/ui/KarbonView.h
  karbon/ui/ProxyView.cpp
  karbon/ui/ProxyView.h
  karbon/ui/dockers/KarbonLayerDocker.cpp
  karbon/ui/dockers/KarbonLayerDocker.h
  karbon/ui/dockers/KarbonLayerModel.cpp
  karbon/ui/dockers/KarbonLayerModel.h
  karbon/ui/dockers/KarbonLayerSortingModel.cpp
  karbon/ui/dockers/KarbonLayerSortingModel.h
  karbon/ui/widgets/KarbonCanvas.cpp
  karbon/ui/widgets/KarbonCanvas.h
  karbon/ui/widgets/KarbonConfigInterfacePage.cpp
  karbon/ui/widgets/KarbonSmallStylePreview.h
  libs/pageapp/KoPAView.cpp
  libs/pageapp/KoPAView.h

To: danders, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15428: [textlayout] Don't enter infinite loop when table is misfit

[Dag Andersen]

danders added a comment.


  Can we get a conclussion to this?
  @Camilla Have you come up with any more unit tests?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

[Dag Andersen]

danders marked an inline comment as done.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19216

To: danders, anthonyfieroni
Cc: boemann, rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

[Dag Andersen]

danders added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in KarbonConfigInterfacePage.cpp:73-90
> We can remove "number of recent files" since other apps does not have it. but 
> for other 2 i don't see why we remove them, someone can found useful 
> (somehow). About me, i want them back, recent file complete remove not 
> commented.

I reconsiddered this, sheets actually also implements this so I'll leave it in.
(It does not work properly neither for karbon nor sheets, but that for 
different rainy day)

> danders wrote in KarbonConfigInterfacePage.cpp:73-90
> Recent file & docker font:
> Why does karbon need these, none of the other apps have it.
> Personally I would remove it, alternativly implent for all apps.
> Canvas color:
> I don't quite see what it is for. You can set a background color for the 
> canvas but it is only for the views, it is not printed.
> Also, if you have multiple views, it sets it in all views.

I also reconsidder docker font setting. It is useful and (partially) 
implemented in libs. You have to restart to get the new setting.
This should be impleneted for all apps, but that's for a different patch.

But, when it comes to canvas background, the more a look into it the more I 
dislike it.
Afaics it goes against both odf spec, wysiwyg and pageapp implementation.
Unfortunatly it was implemented so long ago that there is not mail archive any 
longer and
the git log doesn't give any reason.
Unless I get a *very* good reason to implement this I will not include it.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19216

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

[Dag Andersen]

danders added a comment.


  In D19216#417502 , @rjvbb wrote:
  
  > > Canvas color:
  > > I don't quite see what it is for. You can set a background color for the 
canvas but it is only for the views, it is not printed.
  >
  > A custom canvas colour feature doesn't strike me as odd, nor that it isn't 
printed (printing it WITHOUT setting a dedicated option would seem wrong to me).
  >
  > What about when you use an inversed theme, isn't a custom canvas colour 
required then if you want to see your black line art on a light (white) canvas?
  
  
  No, the canvas is part of the document and must never be themed. The canvas 
background is as much part of your drawing as any line you put on it.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19216

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

[Dag Andersen]

danders added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in KarbonConfigInterfacePage.cpp:73-90
> I want to discuss comments in the review, i don't want to have in. why we 
> remove this?

Recent file & docker font:
Why does karbon need these, none of the other apps have it.
Personally I would remove it, alternativly implent for all apps.
Canvas color:
I don't quite see what it is for. You can set a background color for the canvas 
but it is only for the views, it is not printed.
Also, if you have multiple views, it sets it in all views.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19216

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19216: Karbon: Enable multi page capability

[Dag Andersen]

danders added a comment.


  In D19216#417288 , @rjvbb wrote:
  
  > This would indeed be great to have; even a page selector when importing a 
multi-page document would be an improvement (the Adobe Illustrator version I've 
use had that; IIRC it would just leave all other pages of the document alone).
  >
  > You should also test with PDF documents; in my experience Karbon 3.1 works 
well enough with them.
  
  
  Yes, pdf docs work, it is almost 100% handled by poppler.
  
  > ...
  > 
  >> A lot of code was duplicated between pageapp and karbon
  >>  and has been removed from karbon:
  > 
  > Shouldn't that be a separate change - or does multi-page support come 
automatically with this change?
  
  Well, my initial thought, but there was going to be quite a few intermidiate 
solutions mainly because
  the KoPACanvas cannot be subclassed, so I decided to do everything in one go.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19216

To: danders, anthonyfieroni
Cc: rjvbb, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19132: Update libs/widgets to c++11

[Dag Andersen]

danders added a comment.


  > Thanks for the review, I will work next on 
libs/{pigment,version,widgetutils}.
  
  Hmm, maybe wait with pigment, according to rempt, only krita actually used it.
  I haven't looked into it, but if that is the case probably we should dump it.

REPOSITORY
  R8 Calligra

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19132

To: ognarb, #calligra:_3.0, leinir, danders
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19132: Update libs/widgets to c++11

[Dag Andersen]

danders accepted this revision.
danders added a comment.
This revision is now accepted and ready to land.


  Ok, I can't say I have scrutinized every change, but...
  Could you give a heads up when you continue with other parts or else there 
may be merge problems.
  I'm working on karbon and pageapp atm, so please keep off :)

REPOSITORY
  R8 Calligra

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19132

To: ognarb, #calligra:_3.0, leinir, danders
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19132: Update libs/widgets to c++11

[Dag Andersen]

danders added a reviewer: leinir.
danders added a comment.


  Hmmm. wasn't it somethng with ms windows and for loops, leinir?
  Also, I think there may be detachment issues with them, clazy can tell.
  There is a qAsConst() solution but that is not supported in the qt version we 
need to support.
  If there are issues, maybe drop the for loops for now.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19132

To: ognarb, #calligra:_3.0, leinir
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

[Dag Andersen]

danders added a comment.


  Thanks, I'm checking it out now...
  Just a couple of things:
  Keywords needs to be on a separate line to have effect, see 
https://community.kde.org/Infrastructure/Git/Hooks
  Also FIXED-IN is nice to add.
  
  I've updated and closed the bug, so no problem.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18466

To: niccolove, danders
Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18963: Improve KoModeBox display in horizontal Mode

[Dag Andersen]

danders added a comment.


  Please remove trailing whitespace.

REPOSITORY
  R8 Calligra

BRANCH
  calligra/3.1

REVISION DETAIL
  https://phabricator.kde.org/D18963

To: ognarb, #calligra:_3.0, #vdg, boemann
Cc: danders, boemann, anthonyfieroni, abetts, ngraham, Calligra-Devel-list, 
dcaliste, cochise, vandenoever

D18466: Fixed calligra crashing when opening remote document

[Dag Andersen]

danders added a comment.


  In D18466#411248 , @boemann wrote:
  
  > Dan can you please reply - I'm fine with the account but I can't reply to 
Ben as I am not able to send email
  
  
  Yes, I have, and just answered again in case something went wrong first time.
  Let's see if something happens soon.

REPOSITORY
  R8 Calligra

BRANCH
  print-remote-files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18466

To: niccolove, danders
Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18866: Use check_symbol_exists instead of check_function_exists

[Dag Andersen]

danders accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R8 Calligra

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18866

To: heikobecker, danders
Cc: pino, danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18866: Use check_symbol_exists instead of check_function_exists

[Dag Andersen]

danders added a comment.


  What about the other ​check_function_exists, should they also be changed?
  Also, do you know when ​check_symbol_exists was introduced?
  We still use cmake 2.8.12.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18866

To: heikobecker
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18843: Activate stencils docker in all apps

[Dag Andersen]

danders created this revision.
danders added reviewers: boemann, anthonyfieroni.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
danders requested review of this revision.

REVISION SUMMARY
  The docker now loads in separate thread and is hidden by default,
  so does not have any performance impact and is non-intrusive.
  
  From a user perspective (me):
  Why words: My weapon of choice to create a flow chart is words,
  because of things like headers/footers and even TOC.
  
  Why sheets: Just for consistency.

TEST PLAN
  Open words, immediately start typing: words is responsive.

REPOSITORY
  R8 Calligra

BRANCH
  activate_stencils_danders

REVISION DETAIL
  https://phabricator.kde.org/D18843

AFFECTED FILES
  stage/part/KPrFactory.cpp
  words/part/KWFactory.cpp

To: danders, boemann, anthonyfieroni
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18841: StencilBoxDocker: Make the docker collapsed by default

[Dag Andersen]

danders abandoned this revision.
danders added a comment.


  mistake

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18841

To: danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18841: StencilBoxDocker: Make the docker collapsed by default

[Dag Andersen]

danders created this revision.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
danders requested review of this revision.

REVISION SUMMARY
  WIP

REPOSITORY
  R8 Calligra

BRANCH
  activate_stencils_danders

REVISION DETAIL
  https://phabricator.kde.org/D18841

AFFECTED FILES
  plugins/stencilsdocker/StencilBoxDockerFactory.h
  stage/part/KPrFactory.cpp
  words/part/KWFactory.cpp

To: danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever