'Save
Actions'.
-Misagh
> -Original Message-
> From: jleleu [mailto:lel...@gmail.com]
> Sent: Tuesday, July 17, 2012 10:14 AM
> To: cas-dev@lists.jasig.org
> Subject: Re:[cas-dev] Updates to CAS coding conventions wiki
>
> Hi,
>
> It's a good sta
> Plus it requires us to be disciplined about making sure to generate toString
> methods (and also then about avoiding ToStringBuilder's reflection methods
> ;-))
Sounds like consensus to me :) I'll try to distill this discussion
into some guidelines on the coding conventions wiki page and ping t
Plus it requires us to be disciplined about making sure to generate
toString methods (and also then about avoiding ToStringBuilder's reflection
methods ;-))
On Tue, Jul 17, 2012 at 10:00 AM, Marvin Addison
wrote:
> > Okay, this assumes that there is no heavy cost in the construction of the
> > p
> Okay, this assumes that there is no heavy cost in the construction of the
> parameters passed in. We should continue to be careful about using the
> check *if* the cost of the parameters is heavy (i.e .more than just moving
> string concatenation to using the message formatter).
That's a good p
Okay, this assumes that there is no heavy cost in the construction of the
parameters passed in. We should continue to be careful about using the
check *if* the cost of the parameters is heavy (i.e .more than just moving
string concatenation to using the message formatter).
I'm hopeful that we don
> Are you saying its more performant than the existing if
> (log.isDebugEnabled()) or more performant in the scenarios where we don't
> wrap it in the if statement?
I was tempted to simply write "yes," but I didn't want to sound
dismissive for what could potentially be a win for both clarity and
o
Are you saying its more performant than the existing if
(log.isDebugEnabled()) or more performant in the scenarios where we don't
wrap it in the if statement?
On Tue, Jul 17, 2012 at 8:16 AM, Marvin Addison wrote:
> > The “Logging” section got the most of my
> > attention, but I also made some f
> The “Logging” section got the most of my
> attention, but I also made some fairly minor edits to the snippets.
Thanks for that. I intend to create a "Refactor Log Messages" task
for a future release to encourage review of existing logging
statements for use with slf4j parameterization. I find
