Re: [ccache] Support for color diagnostics

2014-08-07 Thread Joel Rosdahl
> > Attached is an updated patch that passes also all the tests. Applied on master, thanks! (Sorry for the massive delay.) -- Joel On 26 June 2014 18:44, Lubos Lunak wrote: > On Saturday 14 of June 2014, Joel Rosdahl wrote: > > Hi Lubos, > > > > Sorry about the ping delay. I've now looked a

Re: [ccache] Support for color diagnostics

2014-06-26 Thread Lubos Lunak
On Thursday 26 of June 2014, Paul Smith wrote: > On Thu, 2014-06-26 at 18:44 +0200, Lubos Lunak wrote: > > Caveats: > > - Compiles with and without colors are considered different from each > > other (so they are "duplicated"). > > This doesn't seem ideal, does it? No, it doesn't seem ideal. It d

Re: [ccache] Support for color diagnostics

2014-06-26 Thread Paul Smith
On Thu, 2014-06-26 at 18:44 +0200, Lubos Lunak wrote: > Caveats: > - Compiles with and without colors are considered different from each > other (so they are "duplicated"). This doesn't seem ideal, does it? If I'm understanding this correctly won't this cause rebuilds based on whether you're redi

Re: [ccache] Support for color diagnostics

2014-06-26 Thread Lubos Lunak
On Saturday 14 of June 2014, Joel Rosdahl wrote: > Hi Lubos, > > Sorry about the ping delay. I've now looked at your patch and it looks > promising. ... > I suggest passing the argument list as an argument to the compiler_is_* > functions instead of relying on global variables. > > When extracting

Re: [ccache] Support for color diagnostics

2014-06-14 Thread Joel Rosdahl
Hi Lubos, Sorry about the ping delay. I've now looked at your patch and it looks promising. The most immediate issue is this: > % make -j4 test > [...] > test/main > make: *** [test] Segmentation fault (core dumped) > % gdb test/main core > [...] > Program terminated with signal SIGSEGV, Segment

Re: [ccache] Support for color diagnostics

2014-06-01 Thread Lubos Lunak
On Friday 29 of November 2013, Lubos Lunak wrote: > Hello, > > the attached patch adds ccache support for compiler color diagnostics > (also reported by somebody as #10075). Ping? Any "official" comments on the patch? I've been using the patch for half a year by now without problems. > > Cla

Re: [ccache] Support for color diagnostics

2014-02-18 Thread interfaSys Sàrl
Hello, I've just tested the patch with a patched gcc48 with -fdiagnostics-color support on FreeBSD 9 and it works with one exception. GCC's documentations says: "‘auto’ means to use color only when the standard error is a terminal" So, if my understanding is correct, this means that, when usin

Re: [ccache] Support for color diagnostics

2014-02-18 Thread Lubos Lunak
On Tuesday 18 of February 2014, interfaSys Sàrl wrote: > Hello, > > I've just tested the patch with a patched gcc48 with -fdiagnostics-color > support on FreeBSD 9 and it works with one exception. > > GCC's documentations says: > "‘auto’ means to use color only when the standard error is a terminal

Re: [ccache] Support for color diagnostics

2014-02-12 Thread Lubos Lunak
On Wednesday 12 of February 2014, Ryan Hill wrote: > On Fri, 29 Nov 2013 12:39:25 +0100 > > Lubos Lunak wrote: > > Clang automatically uses colors for output automatically if used in > > terminal. Ccache's redirecting to a file disables this. GCC 4.8 has got a > > similar support, except that it

Re: [ccache] Support for color diagnostics

2014-02-11 Thread Ryan Hill
On Fri, 29 Nov 2013 12:39:25 +0100 Lubos Lunak wrote: > Clang automatically uses colors for output automatically if used in > terminal. Ccache's redirecting to a file disables this. GCC 4.8 has got a > similar support, except that it apparently requires also $GCC_COLORS or an > explicit option.

Re: [ccache] Support for color diagnostics

2014-02-11 Thread Lubos Lunak
Ping? On Friday 29 of November 2013, Lubos Lunak wrote: > Hello, > > the attached patch adds ccache support for compiler color diagnostics > (also reported by somebody as #10075). > > Clang automatically uses colors for output automatically if used in > terminal. Ccache's redirecting to a fil

Re: [ccache] Support for color diagnostics

2013-12-12 Thread Eitan Adler
On Fri, Nov 29, 2013 at 6:39 AM, Lubos Lunak wrote: > 100% reliable anyway), the code merely guesses from the binary name. If the > compiler used will be e.g. the 'cc' symlink, there'll be no colors. No big > deal. Most users should be calling their compiler via the name 'cc' and not 'gcc' or 'cl

Re: [ccache] Support for color diagnostics

2013-12-04 Thread Lubos Lunak
On Saturday 30 of November 2013, Loïc Yhuel wrote: > Le 30/11/2013 11:07, Lubos Lunak a écrit : > > On Saturday 30 of November 2013, Loïc Yhuel wrote: > >> Le 29/11/2013 14:08, Lubos Lunak a écrit : > >>> On Friday 29 of November 2013, Lubos Lunak wrote: > Hello, > > the attach

Re: [ccache] Support for color diagnostics

2013-11-30 Thread Loïc Yhuel
Le 30/11/2013 11:07, Lubos Lunak a écrit : On Saturday 30 of November 2013, Loïc Yhuel wrote: Le 29/11/2013 14:08, Lubos Lunak a écrit : On Friday 29 of November 2013, Lubos Lunak wrote: Hello, the attached patch adds ccache support for compiler color diagnostics (also reported by someb

Re: [ccache] Support for color diagnostics

2013-11-30 Thread Lubos Lunak
On Saturday 30 of November 2013, Loïc Yhuel wrote: > Le 29/11/2013 14:08, Lubos Lunak a écrit : > > On Friday 29 of November 2013, Lubos Lunak wrote: > >> Hello, > >> > >> the attached patch adds ccache support for compiler color diagnostics > >> (also reported by somebody as #10075). ... > I t

Re: [ccache] Support for color diagnostics

2013-11-29 Thread Loïc Yhuel
Le 29/11/2013 14:08, Lubos Lunak a écrit : On Friday 29 of November 2013, Lubos Lunak wrote: Hello, the attached patch adds ccache support for compiler color diagnostics (also reported by somebody as #10075). ... Caveats: I forgot one: - The function color_output_possible() may look s

Re: [ccache] Support for color diagnostics

2013-11-29 Thread Lubos Lunak
On Friday 29 of November 2013, Lubos Lunak wrote: > Hello, > > the attached patch adds ccache support for compiler color diagnostics > (also reported by somebody as #10075). ... > Caveats: I forgot one: - The function color_output_possible() may look simplistic, but as far as I can tell it wo