On 2012-07-28 11:24, Joel Rosdahl wrote:
Eric, I've now applied your patch with some tweaks in
2df269a3121889ebcdfa5d98dfb4d675f690e039 (see
http://git.samba.org/?p=ccache.git;a=commit;h=2df269a3121889ebcdfa5d98dfb4d675f690e039).
Thanks!
Thanks for fixing this up the patch and applying it. I
On 27 July 2012 14:33, Joel Rosdahl wrote:
> [...] So, the code needs to handle x_realpath returning NULL.
Eric, I've now applied your patch with some tweaks in
2df269a3121889ebcdfa5d98dfb4d675f690e039 (see
http://git.samba.org/?p=ccache.git;a=commit;h=2df269a3121889ebcdfa5d98dfb4d675f690e039).
T
Hi,
It seems you forgot to make cwd_canonicalized static? Currently, it
has no effect.
Also, the test suite crashes with your patch. I recommend running the
test suite during development even for minor patches (and for bonus
points: add new tests for the new functionality :-)). The crash
happens
On 2012-07-20 13:09, Joel Rosdahl wrote:
Thanks. Two things:
1. The patch canonicalizes the "from" parameter, but I think that the
"to" parameter should be canonicalized as well, for two reasons: a)
realpath() expands symlinks, and comparing (see
common_dir_prefix_length) an expanded path with a
On 19 July 2012 21:21, Eric Blau wrote:
> Sorry for the slow response, but I have a patch attached for this issue.
> Please let me know if you have any comments.
Thanks. Two things:
1. The patch canonicalizes the "from" parameter, but I think that the
"to" parameter should be canonicalized as we
On 2012-06-11 07:54, Eric Blau wrote:
On 2012-06-10 16:09, Joel Rosdahl wrote:
> My suggestion is that get_relative_path essentially should stay the
> same and continue to assume that the paths are well-formed and
> canonical. make_relative_path (the only caller of get_relative_path)
> should can
On 2012-06-10 16:09, Joel Rosdahl wrote:
My suggestion is that get_relative_path essentially should stay the
same and continue to assume that the paths are well-formed and
canonical. make_relative_path (the only caller of get_relative_path)
should canonicalize current_working_dir and path by ca
On 5 June 2012 17:47, Blau, Eric wrote:
> [...] I'm seeing ccache do inappropriate replacements of absolute paths with
> relative paths. [...] This code is not considering if there is a "/./" in the
> absolute path, but is blindly replacing this with "..".
Right, that's a bug; the code is assumin
