Re: [cdesktopenv-devel] [PATCH] SIGSEGV while compiling dthelp on 64 bit systems

2012-08-06 Thread Jon Trulson
> segmentation fault. > context uses the function m_malloc() which is missing a correct prototype > sometimes. Then it's treated to return int instead of void * . On 64bit > systems this cuts off the higher 32 bits because void * is 64bit whereas int > is only 32bit. > A

Re: [cdesktopenv-devel] Replacement README

2012-08-07 Thread Jon Trulson
supported, we can also add links to the FreeBSD instructions, Solaris instructions, etc... [...] -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, referring to

Re: [cdesktopenv-devel] INSTALL file

2012-08-07 Thread Jon Trulson
often as we go. The README should point people to where they need to go for information - information that is likely to always be up to date. [...] -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out.&q

Re: [cdesktopenv-devel] Partial fixes for some Linux Systems

2012-08-07 Thread Jon Trulson
;d love to know why it is null. If you could: - Leave the warning there - use idef blocks (for linux and CSRG_BASED) to omit the 'ExitWM' call - check the return value of your 'pAData->font = XLoadQueryFont(wmGD.display, "fixed");', exiting (via ExitWM) if it

Re: [cdesktopenv-devel] OpenBSD port

2012-08-07 Thread Jon Trulson
ys, > though this will need to be merged with the other porting efforts > (FreeBSD ...). > Excellent :) I saw this link over irc - it has some fbsd patches that might help. http://forums.freebsd.org/showthread.php?t=33824 kpedersen has been doing some fbsd hacking, though I think he&#

Re: [cdesktopenv-devel] (no subject)

2012-08-07 Thread Jon Trulson
Applied (though I had to remove some extraneous whitespace - blank lines that started with spaces). 'git diff' will usually show these before commit. Thanks! [...] -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fa

Re: [cdesktopenv-devel] (no subject)

2012-08-07 Thread Jon Trulson
l1/MMDb.c | 10 -- > 1 file changed, 10 deletions(-) > git would not apply this, so I did it manually. Both of these should probably have just been done as a single commit. :) Applied, and thanks! [...] -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get

Re: [cdesktopenv-devel] Replacement README And install

2012-08-07 Thread Jon Trulson
, and more OS's will be added, so multiple install instruction files, etc should be avoided (IMO). But I don't want to clutter up the topdir with multiple 'install' files that will perhaps frequently be out of date, and require maintenance. -- Jon Trulson "If the Martian rope-

[cdesktopenv-devel] Why rpcbind -i (insecure mode)?

2012-08-07 Thread Jon Trulson
r of those OS's, so someone else will have to check them. Good luck! -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, referring to the Curiosity landing. --

Re: [cdesktopenv-devel] Partial fixes for some Linux Systems

2012-08-08 Thread Jon Trulson
act this info by itself apparently, though I haven't tried this yet. So, perhaps I'll formalize all of this in some seperate post. Oh, and thanks for the fixes, they've been hitting alot of people! :) [...] -- Jon Trulson "If the Martian rope-a-dope don't get hi

Re: [cdesktopenv-devel] Partial fixes for some Linux Systems

2012-08-08 Thread Jon Trulson
C++ style comments or if > we shouldn't stick with pure C comments? (Which I personally would > prefer, so stay compatible with older compilers) > > Well, this is a C++ file. Using C++ comments in a C++ file is certainly ok. For regular C files, yes, use regular C-style commenting.

Re: [cdesktopenv-devel] Use antialiased fonts...

2012-08-08 Thread Jon Trulson
n goes black and displays the > sandwatch cursor (Debian Linux 64 bit). > Keep tracking git master... there are some good patches going in. [...] -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast

Re: [cdesktopenv-devel] 64b issues (was: (no subject))

2012-08-08 Thread Jon Trulson
pes' feature and get these all fixed. Would be painful, but neccessary. [...] -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, referring to the Curiosity l

Re: [cdesktopenv-devel] [PATCH] Don't use "%wc" in format strings

2012-08-08 Thread Jon Trulson
On Wed, 8 Aug 2012, Douglas Mencken wrote: > "%wc" is Microsoft extension, not supported in every Std C Library. So > if we don't want to print "%wc%wc%wc%wc%..." instead of real chars, we > shall not use it. > Applied, thanks for sending as attachment

Re: [cdesktopenv-devel] Fix a segfault on Debian squeeze 64 bit (and possibly other systems)

2012-08-08 Thread Jon Trulson
apply I will apply manually, however in the future, please send patches as attachment, and base it off of current master HEAD, as there have already been other commits to this file. :) Also, this code is using tmpnam, might want to use mkstemp like a patch that was made earlier to cde/lib/DtSvc/DtU

Re: [cdesktopenv-devel] [PATCH] Fix buffer overflow due to sizeof has been used in the place of strlen

2012-08-08 Thread Jon Trulson
gt;at DtsMM.c:574 > #4 0x7748512a in _DtDtsMMInit (override=0) at DtsMM.c:319 > ... > > This fixes it: > Hi, a patch fixing this bug was already submitted by Marc Balmer and applied as commit facb50dfde50d087a7c72ae5da0e080a208625ff. Thanks though! -- Jon Trulson &qu

Re: [cdesktopenv-devel] Fix a segfault on Debian squeeze 64 bit (and possibly other systems)

2012-08-08 Thread Jon Trulson
sed. > Email clients particularly relish destroying a programmer's hard work. > Yep, why I'm recommending submitted patches be sent as attachments. [...] -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll

Re: [cdesktopenv-devel] OpenBSD port

2012-08-08 Thread Jon Trulson
n have some hope of reviewing, commenting on, commiting, or rejecting. Perhaps you and others working on the BSD ports could contribute to a shared repo (maybe yours, I don't know) and arrange this. We might even be willing to create a seperate 'BSD' branch where the BSD patches coul

Re: [cdesktopenv-devel] [PATCH] dtterm - minor warning fixes

2012-08-08 Thread Jon Trulson
On Wed, 8 Aug 2012, Robert Tomsick wrote: > As the subject line says, two minor fixes to dtterm. > > -Rob > Applied, thanks... -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out.&quo

Re: [cdesktopenv-devel] [PATCH] dtaction: Fix unsafe use of sprintf

2012-08-08 Thread Jon Trulson
On Wed, 8 Aug 2012, Robert Tomsick wrote: > I believe this fixes vulnerability #3 from CERT CA-1999-11.[1] The other > uses of sprintf in DtAction seem to be safe. Applied thanks. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll

Re: [cdesktopenv-devel] [PATCH 1/2] dthelpview: Main.c - Cleanup variable init

2012-08-09 Thread Jon Trulson
is going to be in it :) [...] -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, referring to the Curiosity landing. ---

Re: [cdesktopenv-devel] [PATCH 1/2] dtscreen: include stdlib to avoid exit redeclaration

2012-08-09 Thread Jon Trulson
On Wed, 8 Aug 2012, Robert Tomsick wrote: These havve also been applied, thanks. [...] -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, referring

Re: [cdesktopenv-devel] OpenBSD port

2012-08-09 Thread Jon Trulson
On Thu, 9 Aug 2012, Pascal Stumpf wrote: > On Wed, 8 Aug 2012 19:53:23 -0600 (MDT), Jon Trulson wrote: >> On Wed, 8 Aug 2012, Pascal Stumpf wrote: >> >>> On Tue, 07 Aug 2012 21:51:14 +0200, Pascal Stumpf wrote: >>>> Ohai. >>>> [...] &g

Re: [cdesktopenv-devel] OpenBSD port

2012-08-09 Thread Jon Trulson
-OS. There should be > one codebase and one repository to work from. > No problem. There will be 'Only One Repository To Rule Them All'. :) [...] -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll

Re: [cdesktopenv-devel] [PATCH] Fix for dtmail execution group error

2012-08-09 Thread Jon Trulson
min/IntegTools/post_install/linux/configRun.src. I have attached a > patch to add this to the linux configRun.src. > > This is my first time sending a patch in to any project, so I apologize in > advance if its not formatted correctly. > Actually it applied just fine, thanks! git for

Re: [cdesktopenv-devel] use sizeof when converting from sprintf() to snprintf()

2012-08-09 Thread Jon Trulson
On Thu, 9 Aug 2012, Marc Balmer wrote: > When converting sprintf() to snprintf(), don't use the idiom Applied (with a a minor first-line commit msg fix). Thanks! [...] -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in to

Re: [cdesktopenv-devel] Suggesting to build on Linux with debug symbols enabled by default

2012-08-09 Thread Jon Trulson
gt; > The attached patch would turn debugging smbols on, on Linux that is. > I'm all for it. Applied (with typo fix on commit msg line). Thanks -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch

Re: [cdesktopenv-devel] Fix more sprintf() calls

2012-08-09 Thread Jon Trulson
stions? > Hmmm... I'm leary of introducing further dependancies... Is it really worth it? Do you have any idea how many strcpy et. al. are in CDE? :) -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himse

Re: [cdesktopenv-devel] Fix more sprintf() calls

2012-08-09 Thread Jon Trulson
e in the src > string, and it will also pad null bytes if there is room left > in dest. I think he's refering to the case where the src is longer than the dest, then the the dest will not be null terminated. I always hated that about strncpy... to be truly safe, you usually need to do s

Re: [cdesktopenv-devel] config/cf and programs/dtinfo/config bits for OpenBSD

2012-08-09 Thread Jon Trulson
programs/dtinfo/config dir some > time in the future? Having two versions of this around is kind of a > pain. > Yes. I've created a ticket on this. Feel free to not bother patching any of the config stuff in dtinfo in the future. [...] -- Jon Trulson "If the Martian rope-a-d

Re: [cdesktopenv-devel] scoping of var declarations in for loops

2012-08-09 Thread Jon Trulson
but I think it is the wrong approach. > Applied, Thanks. -fpermissive was added to get things to build. It is definitely a goal to remove this crutch in the future. > Sorry, couldn't help sneaking in a || defined(CSRG_BASED) and some casts > needed for other reasons ... >

Re: [cdesktopenv-devel] istr_string() fix

2012-08-09 Thread Jon Trulson
On Thu, 9 Aug 2012, Pascal Stumpf wrote: > At least on OpenBSD/amd64, this macro returns a bogus value if its > argument is NULL. So check for this first like the other macros in this > file do, and don't cast an istring to int. > Applied, and thanks! [...] -- Jon Trulson

Re: [cdesktopenv-devel] SIGCLD -> SIGCHLD

2012-08-09 Thread Jon Trulson
On Thu, 9 Aug 2012, Pascal Stumpf wrote: > The official POSIX name for this signal is SIGCHLD. Linux probably has > SIGCLD only for SysV compatibility, but BSD does not. > Applied, thanks! [...] -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get hims

Re: [cdesktopenv-devel] BSD & Linux: use socklen_t where appropriate

2012-08-09 Thread Jon Trulson
On Thu, 9 Aug 2012, Pascal Stumpf wrote: > This should use socklen_t where available, really ... > Applied, and agreed :) [...] -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out."

Re: [cdesktopenv-devel] BSD & Linux: use socklen_t where appropriate

2012-08-09 Thread Jon Trulson
On Thu, 9 Aug 2012, Marc Balmer wrote: > Am 09.08.12 11:16, schrieb Pascal Stumpf: >> This should use socklen_t where available, really ... > > this reminds that CDE should eventually be IPv6 ready.. That will be a fun patch :) -- Jon Trulson "If the Martian rope-a-dope

Re: [cdesktopenv-devel] New README

2012-08-09 Thread Jon Trulson
gt; > Or via git: > > git clone git://git.code.sf.net/p/cdesktopenv/code cdesktopenv-code > > *** > > Installing this release: > > Complete installation instructions can be found on the CDE wiki: > > http://sourceforge.net/p/cdesktopenv/wiki/Ho

Re: [cdesktopenv-devel] OS X port

2012-08-09 Thread Jon Trulson
malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > ___ > cdesktopenv-devel mailing list > cdesktopenv-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel > -- Jon

Re: [cdesktopenv-devel] Patches to some of the config tools

2012-08-09 Thread Jon Trulson
static void (*sourceproc[])() = { DefaultWriteSource, ArrayperWriteSource, @@ -464,8 +434,7 @@ static void WriteSource(tagline, abi) if (tmpl) CopyTmplEpilog (tmpl, stdout); } -static void DoLine(buf) -char* buf; +static void DoLine(char *buf) { #define X_NO_TOKEN 0 #d

Re: [cdesktopenv-devel] OS X port

2012-08-09 Thread Jon Trulson
On Thu, 9 Aug 2012, Marc Balmer wrote: > > > Am 09.08.2012 um 20:56 schrieb Alex Kornilov : > >> On 8/9/12 8:35 PM, Jon Trulson wrote: >>> Not that I know of... Is it even possible? ie: can OSX run X11/Motif? >> X11 is available in all OS X versions. But I d

Re: [cdesktopenv-devel] Warning patrol 1/3

2012-08-09 Thread Jon Trulson
x27;ve applied all 3 patches. Very nice :) -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my

Re: [cdesktopenv-devel] FAILED: [PATCH] Rename getline() to not conflict with the standard POSIX interface of the same name.

2012-08-09 Thread Jon Trulson
. So, needless to say: not applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brot

Re: [cdesktopenv-devel] FAILED: [PATCH] Rename getline() to not conflict with the standard POSIX interface of the same name.

2012-08-09 Thread Jon Trulson
On Thu, 9 Aug 2012, Jon Trulson wrote: > On Thu, 9 Aug 2012, Pascal Stumpf wrote: > > This one failed to apply, probably corrupted. If it's easier, you can > simply attach the patches as MIME attachments. > > Or look into setting up 'git send-email' :) This wi

Re: [cdesktopenv-devel] [PATCH] Provide support for installation under OpenBSD. Don't override PATH in the install script, it may hide needed tools, and the location of these binaries is highly OS-dep

2012-08-09 Thread Jon Trulson
On Thu, 9 Aug 2012, Pascal Stumpf wrote: > Also, allow overriding some variables in the install script. > Applied, thanks. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out."

Re: [cdesktopenv-devel] OS X port

2012-08-09 Thread Jon Trulson
On Thu, 9 Aug 2012, Marc Balmer wrote: > Am 09.08.12 21:25, schrieb Jon Trulson: >> On Thu, 9 Aug 2012, Marc Balmer wrote: >> >>> >>> >>> Am 09.08.2012 um 20:56 schrieb Alex Kornilov : >>> >>>> On 8/9/12 8:35 PM, Jon Trulson wrote: &g

Re: [cdesktopenv-devel] [PATCH] Imakefile diffs for OpenBSD.

2012-08-10 Thread Jon Trulson
lly is definitely wrong), allow to specify > the location of the tcl library by defining TclLibrary; and don't build > dttype on OpenBSD (needs to be modified to not use advance/compile). > Can't apply - as Simon points out, it disables the building of dtmail. -- Jon Trulson &

Re: [cdesktopenv-devel] [PATCH] SIGPWR is not present everywhere.

2012-08-10 Thread Jon Trulson
On Thu, 9 Aug 2012, Pascal Stumpf wrote: Applied, thanks. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, referring

Re: [cdesktopenv-devel] OpenBSD fixes for lib/DtSvc

2012-08-10 Thread Jon Trulson
On Thu, 9 Aug 2012, Pascal Stumpf wrote: > I'll sort the remaining fixes per subdirectory. This fixes another for > loop, adds appropriate #ifdefs, provides a prototype for _DtsDbListDB() > and defines MAXINT to INT_MAX (BSD doesn't have values.h). > Thanks, applied. --

Re: [cdesktopenv-devel] Cleanup of some implicit definitions in dtwm

2012-08-10 Thread Jon Trulson
ite nasty. > Maybe holdovers from the cde1/'custom motif' days... Applied, thanks! -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself

Re: [cdesktopenv-devel] OpenBSD fixes for lib/DtTerm

2012-08-10 Thread Jon Trulson
erm/TermPrim/TermPrimGetPty-bsd.c You have a new line around 166: #if defined(ALPHA_ARCHITECTURE) || defined(OpenBSDArchitecture) Shouldn't 'OpenBSDArchitecture' be 'OPENBSD_ARCHITECTURE' in this context? -- Jon Trulson "If the Martian rope-a-dope don't get him,

Re: [cdesktopenv-devel] Proposed README-2.2.0

2012-08-10 Thread Jon Trulson
On Thu, 9 Aug 2012, Christopher Turkel wrote: > Okay, now with 50% less ***s! > Looks awesome, thanks! :) -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one o

Re: [cdesktopenv-devel] (no subject)

2012-08-10 Thread Jon Trulson
On Fri, 10 Aug 2012, Aaron W. Hsu wrote: > Jon Trulson writes: > >> Applied (though I had to remove some extraneous whitespace - blank >> lines that started with spaces). 'git diff' will usually show these >> before commit. > > I had some problems with g

Re: [cdesktopenv-devel] Fixes for DtPrint and csa

2012-08-10 Thread Jon Trulson
On Fri, 10 Aug 2012, Pascal Stumpf wrote: > Easy fixes ... > Easy apply :) -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, ref

Re: [cdesktopenv-devel] Tooltalk patches for OpenBSD

2012-08-10 Thread Jon Trulson
On Fri, 10 Aug 2012, Pascal Stumpf wrote: > Mostly #ifdefs and missing casts. > Some nice cleanups too... Applied, thanks. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out."

Re: [cdesktopenv-devel] dtterm pty allocation fix

2012-08-10 Thread Jon Trulson
On Fri, 10 Aug 2012, Pascal Stumpf wrote: > This should be applied in addition to my previous DtTerm patches. > Applied, thanks. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out."

Re: [cdesktopenv-devel] fixes for DtWidget, dtaction and dtappbuilder

2012-08-10 Thread Jon Trulson
On Fri, 10 Aug 2012, Pascal Stumpf wrote: > another round of easy fixes. > Applied, thanks. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, ref

Re: [cdesktopenv-devel] dtcm fixes for BSD

2012-08-10 Thread Jon Trulson
On Fri, 10 Aug 2012, Pascal Stumpf wrote: > timezone() is actually a function on BSD. > Applied, thanks. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my broth

Re: [cdesktopenv-devel] dtfile patches

2012-08-10 Thread Jon Trulson
On Fri, 10 Aug 2012, Pascal Stumpf wrote: > Fixes for dtfile. Still not completely functional, but I will work on > that. > Applied, thanks. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself ou

Re: [cdesktopenv-devel] Fix more sprintf() calls

2012-08-11 Thread Jon Trulson
On Fri, 10 Aug 2012, Marc Balmer wrote: > Am 10.08.12 07:57, schrieb Marc Balmer: >> Am 10.08.12 04:29, schrieb Aaron W. Hsu: >>> Jon Trulson writes: >>> >>>> Hmmm... I'm leary of introducing further dependancies... Is it really >>>> worth

Re: [cdesktopenv-devel] ANSIfication of imake

2012-08-11 Thread Jon Trulson
ke isn't linked with anything where it would matter. I do like the K&R->ANSI conversion and other fix ups, but I would prefer that no more 'static-ification' patches be submitted unless they are solving a real problem. -- Jon Trulson "If the Martian rope-a-dope don

Re: [cdesktopenv-devel] [PATCH] dtcreate: fix exit with TT_ERR_PTYPE and fix several sprintf related segfaults.

2012-08-11 Thread Jon Trulson
On Sat, 11 Aug 2012, William Schaub wrote: > I also found a double free error in parser.c that caused me some grief. > Attached are both the original patch and the parser.c patch for dtcreate. > Applied both of these, thanks! -- Jon Trulson "If the Martian rope-a-dope don&#x

Re: [cdesktopenv-devel] Next round of OpenBSD patches

2012-08-11 Thread Jon Trulson
I don't want to hunt down rejected patches anymore. Assume that once they are rejected, they are deleted :) Thanks. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one

Re: [cdesktopenv-devel] dtinfo on OpenBSD

2012-08-11 Thread Jon Trulson
On Sat, 11 Aug 2012, Pascal Stumpf wrote: > See patch. > Applied, thanks. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, ref

Re: [cdesktopenv-devel] dtinfo on OpenBSD

2012-08-11 Thread Jon Trulson
is patch I only bothered with making it work. > Replacing mallog(a*b) with calloc should be done as a separate effort > across the whole tree. > Agreed, lets save wholesale code changes like this for some time in the future... My goal is to get as much of CDE as possible, working on as many pla

Re: [cdesktopenv-devel] dtlogin on OpenBSD

2012-08-11 Thread Jon Trulson
On Sat, 11 Aug 2012, Pascal Stumpf wrote: > See patch. > Applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, ref

Re: [cdesktopenv-devel] dtmail on OpenBSD

2012-08-11 Thread Jon Trulson
On Sat, 11 Aug 2012, Pascal Stumpf wrote: > See patch. > Applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, ref

Re: [cdesktopenv-devel] dtsearchpath, dtscreen, dtsessiony

2012-08-11 Thread Jon Trulson
On Sat, 11 Aug 2012, Pascal Stumpf wrote: > See patch. > Applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, ref

Re: [cdesktopenv-devel] localisations

2012-08-11 Thread Jon Trulson
On Sat, 11 Aug 2012, Pascal Stumpf wrote: > See patch. > Applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, ref

Re: [cdesktopenv-devel] nsgmls

2012-08-11 Thread Jon Trulson
On Sat, 11 Aug 2012, Pascal Stumpf wrote: > See patch. > Applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, ref

Re: [cdesktopenv-devel] ttsnoop

2012-08-11 Thread Jon Trulson
On Sat, 11 Aug 2012, Pascal Stumpf wrote: > See patch. > Applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, ref

Re: [cdesktopenv-devel] Couple of warning fixing patches

2012-08-11 Thread Jon Trulson
ERR_INTERNAL comes back. > Applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of m

Re: [cdesktopenv-devel] 64-bit tooltalk fix

2012-08-12 Thread Jon Trulson
this because we don't want to delete code that works on other systems (#idef __osf__, etc). But I believe your code is actually the better code and will still work on __osf__ :) Applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll

Re: [cdesktopenv-devel] CDE on 64 bit Linux

2012-08-12 Thread Jon Trulson
s is important, you could also use the '__LP64__' define to detect systems where long == pointer in terms of size. But just globally changing ints to long is a bad idea... pointers should be used where possible, and longs where not (on LP64) systems. -- Jon Trulson "If the Martian ro

Re: [cdesktopenv-devel] some low hanging fruit..

2012-08-12 Thread Jon Trulson
On Sun, 12 Aug 2012, Marc Balmer wrote: > Am 12.08.12 11:54, schrieb Marc Balmer: >> A first round to fix some compile time warnings. > > Please don't apply this patch. There is bug lurking in it... > consider it deleted. -- Jon Trulson "If the Martian rope-a-d

Re: [cdesktopenv-devel] dtmail actually does compile on OpenBSD ...

2012-08-12 Thread Jon Trulson
On Sun, 12 Aug 2012, Pascal Stumpf wrote: > Seems there were some other changes that made it work, so disabling it > was unnecessary. > Applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself

Re: [cdesktopenv-devel] DtHelp: Do not use internal libjpeg

2012-08-12 Thread Jon Trulson
On Sun, 12 Aug 2012, Pascal Stumpf wrote: > See patch. > Applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, ref

Re: [cdesktopenv-devel] Get rid of malloc.h.

2012-08-12 Thread Jon Trulson
On Sun, 12 Aug 2012, Pascal Stumpf wrote: > See patch. > Applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, ref

Re: [cdesktopenv-devel] cpp -traditional

2012-08-12 Thread Jon Trulson
On Sun, 12 Aug 2012, Pascal Stumpf wrote: > See patch. > Applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, ref

Re: [cdesktopenv-devel] security fix for udbToAny.ksh

2012-08-12 Thread Jon Trulson
On Sun, 12 Aug 2012, Pascal Stumpf wrote: > Always use mktemp(1) for generating a random filename in a shell script. > Applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out."

Re: [cdesktopenv-devel] Fix sym2num on OpenBSD

2012-08-12 Thread Jon Trulson
On Sun, 12 Aug 2012, Pascal Stumpf wrote: > See patch. > Applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, ref

Re: [cdesktopenv-devel] warning fixes for libDtSearch

2012-08-12 Thread Jon Trulson
osed to work. Can someone else have a look? > I have run into several bits of CDE that make me ask that question - "how did this ever work" :) I haven't looked at this yet, FYI - maybe someone beats me to it. -- Jon Trulson "If the Martian ro

Re: [cdesktopenv-devel] [PATCH] some tweaks for configRun: add -h/--usage option, use portable print instead of echo \c, etc.

2012-08-12 Thread Jon Trulson
On Sun, 12 Aug 2012, Douglas Mencken wrote: > http://ftp.osuosl.org/pub/manulix/CDE/cde-configRun_tweaks.patch > I don't really like this... How ubiquitous is printf in shell anyway? I am pretty sure that 'echo -n' and 'echo -e' work everywhere. Why not use those

Re: [cdesktopenv-devel] [PATCH] dtcreate: check for TT_ERR_PTYPE the correct way

2012-08-12 Thread Jon Trulson
#x27;t > have that problem. > Applied. I should have looked at the original patch more closely - it did seem wrong :) -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one

Re: [cdesktopenv-devel] [PATCH] some tweaks for configRun: add -h/--usage option, use portable print instead of echo \c, etc.

2012-08-12 Thread Jon Trulson
ic > No, I have yet to see a system where echo -n/-e was not supported, even on ancient systems. I had thought printf was a bash addition. ksh supports print, but even there -n/-e for echo works.. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he&#

Re: [cdesktopenv-devel] CDE on 64 bit Linux

2012-08-12 Thread Jon Trulson
s addition + dereferencing. > > For whatever reason, C does not allow you to perform bitwise > operations on pointers; that's probably > why they're being converted to int/longs. > Possibly. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll ge

Re: [cdesktopenv-devel] [PATCH] some tweaks for configRun: add -h/--usage option, use portable print instead of echo \c, etc.

2012-08-12 Thread Jon Trulson
On Sun, 12 Aug 2012, Pascal Stumpf wrote: > On Sun, 12 Aug 2012 14:41:42 -0600 (MDT), Jon Trulson wrote: >> On Sun, 12 Aug 2012, Douglas Mencken wrote: >> >>>> I am pretty sure that 'echo -n' and 'echo -e' work everywhere. Why >>>> no

Re: [cdesktopenv-devel] [PATCH] some tweaks for configRun: add -h/--usage option, use portable print instead of echo \c, etc.

2012-08-12 Thread Jon Trulson
On Sun, 12 Aug 2012, Douglas Mencken wrote: > http://ftp.osuosl.org/pub/manulix/CDE/cde-configRun_tweaks.patch > Applied, but in the future please use 'git format patch' format. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he&

[cdesktopenv-devel] DtHelp/Imakefile jpeg patch broke linux builds

2012-08-12 Thread Jon Trulson
(I've updated the wiki). This is already in master. Please be more careful in the future Pascal. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers,

[cdesktopenv-devel] dtbuilder broken?

2012-08-12 Thread Jon Trulson
nd callback list in XtAddCallback ... ... ... And it comes up in all black. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, referring to the Curiosity landing.

Re: [cdesktopenv-devel] [PATCH} Adjust cpp location for FreeBSD

2012-08-12 Thread Jon Trulson
On Sun, 12 Aug 2012, Marcin Cieslak wrote: All 4 of these patches have been applied, thanks. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, referring

Re: [cdesktopenv-devel] dtbuilder broken?

2012-08-13 Thread Jon Trulson
On Sun, 12 Aug 2012, Jon Trulson wrote: > > Seems dtbuilder isn't working well - I get: > > Warning: Color name "(nil)" is not defined I've reverted the guilty patch. Reverting 0d2f7866ac676ab0f3c8ac3eabcec06f580a9d62 seems to fix the problem (for others as w

Re: [cdesktopenv-devel] [PATCH 5/7] NULL is a pointer, not string terminator

2012-08-13 Thread Jon Trulson
On Mon, 13 Aug 2012, Marcin Cieslak wrote: > Replace some instances of NULL to '\0', when > referring to string terminator. Applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out.

Re: [cdesktopenv-devel] [PATCH 6/7] Cast registerrpc args to xdrproc_t explicitly

2012-08-13 Thread Jon Trulson
om incompatible > pointer type > agent.c:167: warning: passing argument 5 of 'registerrpc' from incompatible > pointer type > agent.c:167: warning: passing argument 6 of 'registerrpc' from incompatible > pointer type Applied. -- Jon Trulson "If the Mar

Re: [cdesktopenv-devel] [PATCH] lib/csa: Use ANSI C prototypes

2012-08-13 Thread Jon Trulson
On Mon, 13 Aug 2012, Marcin Cieslak wrote: > Improve type compatibility and enable > ANSI C prototypes. Applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one o

Re: [cdesktopenv-devel] [PATCH] lib/csa: Use ANSI C prototypes

2012-08-13 Thread Jon Trulson
ll! I haven't seen any issues. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, referring to the Curiosity landing.

Re: [cdesktopenv-devel] WIP: dtbuilder on 64bit, fix it on 32bit

2012-08-13 Thread Jon Trulson
ing patch had been reverted. Works well, thanks! -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers,

Re: [cdesktopenv-devel] [PATCH] FreeBSD port: dtsearch, dtterm, dtwidget, dthelp

2012-08-13 Thread Jon Trulson
On Mon, 13 Aug 2012, Marcin Cieslak wrote: > FreeBSD portability of dtsearch, dtterm, dtwidget, dthelp > Applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one o

Re: [cdesktopenv-devel] [PATCH] Compile dtksh on FreeBSD

2012-08-13 Thread Jon Trulson
On Mon, 13 Aug 2012, Marcin Cieslak wrote: >>> Peter Howkins wrote: >> Comments inline > > Thanks! > Hi, I can't apply this patch - could you send it in a seperate email, an attachment, or via git-send-email? Thanks. (git am is confused) -- Jon Trulson &quo

Re: [cdesktopenv-devel] git 2b8bd074: inetd on Ubuntu does not need/support -s

2012-08-13 Thread Jon Trulson
On Sun, 12 Aug 2012, ibid...@lavabit.com wrote: > I'm guessing that whoever made this change: > @@ -324,7 +343,7 @@ DEFAULT_PRINTER="DtPrint" missed this one - applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll

Re: [cdesktopenv-devel] [PATCH] Compile dtksh on FreeBSD

2012-08-14 Thread Jon Trulson
On Tue, 14 Aug 2012, Marcin Cieslak wrote: Applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, referring

Re: [cdesktopenv-devel] [PATCH 09/10] Use $(SHELL) and $(KORNSHELL) for shell scripts

2012-08-14 Thread Jon Trulson
On Tue, 14 Aug 2012, Marcin Cieslak wrote: Applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, referring

  1   2   3   4   5   6   7   8   9   10   >