Re: [CF-metadata] [cf-convention/cf-conventions] Update the "Release Checklist" in the Pull Request template (#325)

2021-05-04 Thread Ethan Davis
Hi @davidhassell, @erget, all - In the current `history.doc`, the release/version history is hard to scan while the change/issue history is easy (though verbose) to scan. Whether dates are only on releases or on both releases and change/issue, I would like to suggest we move towards a "Release

[CF-metadata] [cf-convention/cf-conventions] Lossy compression through coordinate sampling (#326)

2021-05-04 Thread Daniel Lee
See issue #XXX for discussion of these changes. To do before completion of this PR: - [ ] @AndersMS finish appendix after coordinate system rotation - [ ] @davidhassell Add references to examples to `toc-extra.adoc` as described in

Re: [CF-metadata] [cf-convention/cf-conventions] Section 6.1.2 Taxon Names and Identifiers standard name for biological taxon identifier (#308)

2021-05-04 Thread Roy Lowry
The slightly embarrassing answer is biological_taxon_lsid. However, this will fail compliance checkers because the defect correction specified above last November still hasn't been actioned. I did issue an e-mail reminder and was promised it would be in the next Standard Name update which I

Re: [CF-metadata] [cf-convention/cf-conventions] Update the "Release Cheklist" in the Pull Request template (#325)

2021-05-04 Thread David Hassell
Hi @erget, >From what you describe, should the dates _always_ be the date of minting a >release, rather than the date merging. That could clear things up? I think a >quick chat later would be good! I'd also like to add a _merger_ item for the data model: Merger checklist - [ ] - [ ]

Re: [CF-metadata] [cf-convention/cf-conventions] Update the "Release Cheklist" in the Pull Request template (#325)

2021-05-04 Thread Daniel Lee
Hi @davidhassell as secretary I consider you the oracle of minting releases, so I'm sure you're right. The thought that I had was, if we're merging continuously into master, and then only tagging at certain points on master, then we'd be updating the dates in the history superfluously, no?

Re: [CF-metadata] [cf-convention/cf-conventions] Update the "Release Cheklist" in the Pull Request template (#325)

2021-05-04 Thread David Hassell
Hi @erget, I don't know. I had thought that we would merge PRs into master at the time of their acceptance, so that future PRs for the same next release can build on the accepted changes. I may well have misunderstood things, apologies if so, but in any event, if we say "Set the date when

Re: [CF-metadata] [cf-convention/cf-conventions] Update the "Release Cheklist" in the Pull Request template (#325)

2021-05-04 Thread Daniel Lee
@davidhassell the author checklist looks correct for me. From my side I have 1 more question about the merger checklist - does `history.adoc` get its date updated when merged, or when tagged? My understanding is that we might merge multiple PRs into a tag-ready branch, but then only tag it when

Re: [CF-metadata] [cf-convention/cf-conventions] Update the "Release Cheklist" in the Pull Request template (#325)

2021-05-04 Thread David Hassell
Sounds good, thanks. How about: Author checklist - [ ] Authors updated in cf-conventions.adoc? - [ ] Conformance document up-to-date? - [ ] Related issues registered in history.adoc, with placeholders for the dates? Merger checklist - [ ] Set dates for new history.adoc entries?