Hi @erget,
>From what you describe, should the dates _always_ be the date of minting a
>release, rather than the date merging. That could clear things up? I think a
>quick chat later would be good!
I'd also like to add a _merger_ item for the data model:
Merger checklist
- [ ]
- [ ]
Hi @davidhassell as secretary I consider you the oracle of minting releases, so
I'm sure you're right. The thought that I had was, if we're merging
continuously into master, and then only tagging at certain points on master,
then we'd be updating the dates in the history superfluously, no?
Hi @erget,
I don't know. I had thought that we would merge PRs into master at the time of
their acceptance, so that future PRs for the same next release can build on
the accepted changes.
I may well have misunderstood things, apologies if so, but in any event, if we
say "Set the date when
@davidhassell the author checklist looks correct for me. From my side I have 1
more question about the merger checklist - does `history.adoc` get its date
updated when merged, or when tagged? My understanding is that we might merge
multiple PRs into a tag-ready branch, but then only tag it when
Sounds good, thanks. How about:
Author checklist
- [ ] Authors updated in cf-conventions.adoc?
- [ ] Conformance document up-to-date?
- [ ] Related issues registered in history.adoc, with placeholders for the
dates?
Merger checklist
- [ ] Set dates for new history.adoc entries?
Dear both
I agree with David on making such a change, and with Daniel that we should ask
the author to supply the information for their update in the history, even
though they can't add the date and version.
Thanks
Jonathan
--
You are receiving this because you are subscribed to this
@davidhassell you have my support, since we're merging continually and minting
releases periodically this makes sense to me.
Rather than removing "history.adoc up to date?" we might consider using
"history.adoc updated?" in order to ensure that we note the changes, and then
when creating a
Hello,
I would like to suggest a couple of changes to the Pull Request template.
The release checklist currently has:
- [ ] Authors updated in cf-conventions.adoc?
- [ ] Next version in cf-conventions.adoc up to date? Versioning inspired by
SemVer.
- [ ] history.adoc up to date?
- [ ]
