[cfe-commits] r166245 - in /cfe/trunk: include/clang/Driver/Arg.h include/clang/Driver/ArgList.h include/clang/Driver/OptTable.h include/clang/Driver/Option.h lib/Driver/Arg.cpp lib/Driver/ArgList.cpp

2012-10-18 Thread Argyrios Kyrtzidis
Author: akirtzidis Date: Thu Oct 18 17:42:31 2012 New Revision: 166245 URL: http://llvm.org/viewvc/llvm-project?rev=166245view=rev Log: Revert r166223 and the subsequent commits that depend on it, r166230 r166235. This seems to have introduced assertion hit when building compiler-rt. Modified:

Re: [cfe-commits] r166236 - in /cfe/trunk: include/clang/Driver/CC1Options.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CGDebugInfo.cpp lib/Driver/Tools.cpp l

2012-10-18 Thread Craig Topper
Gating the code doesn't actually hide the perf problem. Because the perf problem occurs in getPresumedLoc which calculates line and column number. The debug code was calling getPresumedLoc twice once to only get the line and once to only get the column, but this results in line and column actually

Re: [cfe-commits] r166236 - in /cfe/trunk: include/clang/Driver/CC1Options.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CGDebugInfo.cpp lib/Driver/Tools.cpp l

2012-10-18 Thread Eric Christopher
On Thu, Oct 18, 2012 at 4:21 PM, Craig Topper craig.top...@gmail.com wrote: Gating the code doesn't actually hide the perf problem. Because the perf problem occurs in getPresumedLoc which calculates line and column number. The debug code was calling getPresumedLoc twice once to only get the

Re: [cfe-commits] Fwd: Bug 11709 Fix: va_list on ARM is not following AAPCS 7.1.4

2012-10-18 Thread Eli Friedman
On Thu, Oct 18, 2012 at 8:23 AM, Logan Chien tzuhsiang.ch...@gmail.com wrote: -- Forwarded message -- From: Logan Chien tzuhsiang.ch...@gmail.com Date: Thu, Oct 18, 2012 at 11:20 PM Subject: Re: [cfe-commits] Bug 11709 Fix: va_list on ARM is not following AAPCS 7.1.4 To:

Re: [cfe-commits] [Patch] Add -Wmissing-variable-declarations

2012-10-18 Thread Eli Friedman
On Thu, Oct 18, 2012 at 2:57 AM, Ed Schouten e...@80386.nl wrote: Hi Eli, 2012/8/1 Eli Friedman eli.fried...@gmail.com: On Tue, Jul 24, 2012 at 7:06 AM, Ed Schouten e...@80386.nl wrote: I've updated the patch. As usual, it can be downloaded from:

[cfe-commits] r166250 - /cfe/trunk/test/Index/annotate-comments.cpp

2012-10-18 Thread NAKAMURA Takumi
Author: chapuni Date: Thu Oct 18 19:22:54 2012 New Revision: 166250 URL: http://llvm.org/viewvc/llvm-project?rev=166250view=rev Log: clang/test/Index/annotate-comments.cpp: Mark this as XFAIL on msvc. Investigating. Modified: cfe/trunk/test/Index/annotate-comments.cpp Modified:

Re: [cfe-commits] clang patch for bug 14021

2012-10-18 Thread Jan Voung
On Thu, Oct 18, 2012 at 2:24 PM, David Blaikie dblai...@gmail.com wrote: On Thu, Oct 18, 2012 at 2:07 PM, Jan Voung jvo...@chromium.org wrote: On Thu, Oct 18, 2012 at 1:20 PM, David Blaikie dblai...@gmail.com wrote: On Thu, Oct 18, 2012 at 1:15 PM, Jan Voung jvo...@chromium.org wrote:

Re: [cfe-commits] clang patch for bug 14021

2012-10-18 Thread Douglas Gregor
On Oct 18, 2012, at 5:25 PM, Jan Voung jvo...@chromium.org wrote: On Thu, Oct 18, 2012 at 2:24 PM, David Blaikie dblai...@gmail.com wrote: On Thu, Oct 18, 2012 at 2:07 PM, Jan Voung jvo...@chromium.org wrote: On Thu, Oct 18, 2012 at 1:20 PM, David Blaikie dblai...@gmail.com wrote:

[cfe-commits] r166251 - in /cfe/trunk: include/clang/Serialization/ASTBitCodes.h include/clang/Serialization/ASTReader.h include/clang/Serialization/ASTWriter.h include/clang/Serialization/Module.h li

2012-10-18 Thread Douglas Gregor
Author: dgregor Date: Thu Oct 18 19:38:02 2012 New Revision: 166251 URL: http://llvm.org/viewvc/llvm-project?rev=166251view=rev Log: Move the set of files to be validated in an AST file into the control block, so the input files are validated early on, before we've committed to loading the AST

[cfe-commits] r166252 - /cfe/trunk/lib/Serialization/ASTWriter.cpp

2012-10-18 Thread Douglas Gregor
Author: dgregor Date: Thu Oct 18 19:45:00 2012 New Revision: 166252 URL: http://llvm.org/viewvc/llvm-project?rev=166252view=rev Log: Describe the new input-files block and its record, for llvm-bcanalyzer. Modified: cfe/trunk/lib/Serialization/ASTWriter.cpp Modified:

[cfe-commits] r166253 - /cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h

2012-10-18 Thread Nick Lewycky
Author: nicholas Date: Thu Oct 18 19:47:07 2012 New Revision: 166253 URL: http://llvm.org/viewvc/llvm-project?rev=166253view=rev Log: Fix typo in comment. Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h URL:

[cfe-commits] r166254 - in /cfe/trunk: lib/Sema/SemaDeclCXX.cpp test/SemaCXX/warn-overloaded-virtual.cpp

2012-10-18 Thread David Blaikie
Author: dblaikie Date: Thu Oct 18 19:53:08 2012 New Revision: 166254 URL: http://llvm.org/viewvc/llvm-project?rev=166254view=rev Log: Handle diamond inheritance in -Woverloaded-virtual. Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp cfe/trunk/test/SemaCXX/warn-overloaded-virtual.cpp

Re: [cfe-commits] r165283 - in /cfe/trunk: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp test/Sema/parentheses.cpp

2012-10-18 Thread Matt Beaumont-Gay
A little belated bikeshed-painting... On Thu, Oct 4, 2012 at 5:41 PM, David Blaikie dblai...@gmail.com wrote: Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td URL:

[cfe-commits] r166257 - /cfe/trunk/lib/Serialization/ASTWriter.cpp

2012-10-18 Thread NAKAMURA Takumi
Author: chapuni Date: Thu Oct 18 20:53:57 2012 New Revision: 166257 URL: http://llvm.org/viewvc/llvm-project?rev=166257view=rev Log: ASTWriter.cpp: Fix a warning. [-Wunused-variable] Modified: cfe/trunk/lib/Serialization/ASTWriter.cpp Modified: cfe/trunk/lib/Serialization/ASTWriter.cpp URL:

[cfe-commits] r166261 - /cfe/trunk/test/Index/annotate-comments.cpp

2012-10-18 Thread NAKAMURA Takumi
Author: chapuni Date: Thu Oct 18 22:27:50 2012 New Revision: 166261 URL: http://llvm.org/viewvc/llvm-project?rev=166261view=rev Log: clang/test/Index/annotate-comments.cpp: Relax the expression to be matched to -fms-compatibility. Then XFAIL can be removed. FYI, it can be reproduced with

Re: [cfe-commits] r163917 - in /cfe/trunk: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp lib/Sema/SemaExprCXX.cpp test/ARCMT/cxx-checking.mm

2012-10-18 Thread Nico Weber
Hi, Xcode 4.5 passes -Wno-arc-abi to clang, which makes a clang newer than r163917 warn that it doesn't understand -Wno-arc-abi. Would you guys hate it if we added a no-op -Warc-abi flag back until an Xcode ships that no longer adds -Wno-arc-abi? I understand running head clang with xcode isn't

[cfe-commits] r166263 - /cfe/trunk/lib/CodeGen/BackendUtil.cpp

2012-10-18 Thread Nadav Rotem
Author: nadav Date: Thu Oct 18 23:15:32 2012 New Revision: 166263 URL: http://llvm.org/viewvc/llvm-project?rev=166263view=rev Log: Reintroduce the TargetTransformInfo to the clang pass manager. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp

[cfe-commits] r166265 - /cfe/trunk/lib/Basic/SourceManager.cpp

2012-10-18 Thread Craig Topper
Author: ctopper Date: Thu Oct 18 23:40:38 2012 New Revision: 166265 URL: http://llvm.org/viewvc/llvm-project?rev=166265view=rev Log: Teach getColumnNumber to use the line cache to get the start of the line if its on the same line as the last call to getLineNumber. Prevents needing to scan

[cfe-commits] r166266 - in /cfe/trunk: lib/CodeGen/ABIInfo.h lib/CodeGen/CGCall.cpp lib/CodeGen/TargetInfo.cpp test/CodeGenCXX/regparm.cpp

2012-10-18 Thread Rafael Espindola
Author: rafael Date: Fri Oct 19 00:04:37 2012 New Revision: 166266 URL: http://llvm.org/viewvc/llvm-project?rev=166266view=rev Log: Fix handling of the regparm attribute in the presence of classes with copy constructors. When I first moved regparm support to TargetInfo.cpp I tried to isolate it

Re: [cfe-commits] Fwd: Bug 11709 Fix: va_list on ARM is not following AAPCS 7.1.4

2012-10-18 Thread Logan Chien
Thanks for the review. I have updated the comments, and the test cases for ARM. The new patch file is attached. Thanks. Logan On Fri, Oct 19, 2012 at 7:47 AM, Eli Friedman eli.fried...@gmail.comwrote: On Thu, Oct 18, 2012 at 8:23 AM, Logan Chien tzuhsiang.ch...@gmail.com wrote:

<    1   2