[cfe-commits] [PATCH] Move hardcoded GNUstep exceptions to CGObjCGNUstep

2012-11-10 Thread Jonathan Schleifer
[PATCH] Move hardcoded GNUstep exceptions to CGObjCGNUstep Not only were they referencing symbols in the GNUstep namespace, they had the mangled version of the symbol hardcoded instead of using the mangler. This broke it completely for every GNU-based runtime which is not the GNUstep runtime. ---

Re: [cfe-commits] r167647 - in /cfe/trunk: include/clang/Basic/BuiltinsNVPTX.def test/CodeGen/builtins-nvptx.c

2012-11-10 Thread Justin Holewinski
Blah, for some reason I was thinking popc == sync. :( membar should be n. Thanks for the catch! Side question though: what does Clang actually do with the const modifier? The intrinsics are not marked as affecting memory, so the optimizers should be be unaffected. On Fri, Nov 9, 2012 at 4:02

Re: [cfe-commits] [libcxx] r167490 - /libcxx/trunk/www/index.html

2012-11-10 Thread Jonathan Sauer
Hello, - pTo build on Mac OS X 10.6 (Snow Leopard), you need a helper library and header -a href=http://home.roadrunner.com/~hinnant/libcppabi.zip;found here/a. -cp cxxabi.h to /usr/include, and cp libc++abi.dylib to /usr/lib. On Mac OS -X 10.7 (Lion) and later, this

Re: [cfe-commits] [libcxx] r167490 - /libcxx/trunk/www/index.html

2012-11-10 Thread Charles Davis
On Nov 10, 2012, at 10:17 AM, Jonathan Sauer wrote: Hello, - pTo build on Mac OS X 10.6 (Snow Leopard), you need a helper library and header -a href=http://home.roadrunner.com/~hinnant/libcppabi.zip;found here/a. -cp cxxabi.h to /usr/include, and cp libc++abi.dylib to

[cfe-commits] r167678 - in /cfe/trunk: lib/CodeGen/CGBlocks.h test/CodeGenObjC/arc-blocks.m

2012-11-10 Thread Fariborz Jahanian
Author: fjahanian Date: Sat Nov 10 12:30:40 2012 New Revision: 167678 URL: http://llvm.org/viewvc/llvm-project?rev=167678view=rev Log: objective-C blocks: Change BLOCK_HAS_EXTENDED_LAYOUT to be 131. lower 24bit is currently being used. Modified: cfe/trunk/lib/CodeGen/CGBlocks.h

Re: [cfe-commits] r167643 - /cfe/trunk/include/clang/Driver/Options.td

2012-11-10 Thread Matt Beaumont-Gay
On Fri, Nov 9, 2012 at 3:18 PM, Richard Smith richard-l...@metafoo.co.uk wrote: Author: rsmith Date: Fri Nov 9 17:18:31 2012 New Revision: 167643 URL: http://llvm.org/viewvc/llvm-project?rev=167643view=rev Log: -Wlarge-by-value-copy may be awesome, but it really shouldn't be the one and

Re: [cfe-commits] r167678 - in /cfe/trunk: lib/CodeGen/CGBlocks.h test/CodeGenObjC/arc-blocks.m

2012-11-10 Thread Jordan Rose
Should we maybe put that in a comment, so that this won't happen again? We're out of bits now. :-( Jordan On Nov 10, 2012, at 10:30 , Fariborz Jahanian fjahan...@apple.com wrote: Author: fjahanian Date: Sat Nov 10 12:30:40 2012 New Revision: 167678 URL:

Re: [cfe-commits] [Patch] Fix to Build Clang on Amazon Linux

2012-11-10 Thread st...@steck.com
Hola,I added test cases as suggested. Please review and commit as I don't have commit privileges.Cheers,Steve Steckon Nov 08, 2012, Nico Weber tha...@chromium.org wrote:Thanks for the patch! Can you add a simple test for this, similar

Re: [cfe-commits] [Patch] Fix to Build Clang on Amazon Linux

2012-11-10 Thread Nico Weber
Thanks for the test! I applied your patch and ran your test `../../utils/lit/lit.py -v test/Driver/amazon-gcc-toolchain.c`, and it passed without me having to rebuild to apply your code change. Is it possible to have a test that fails without your code change but passes with it? Nico On Sat, Nov

[cfe-commits] [patch] s/BCPLComment/LineComment/

2012-11-10 Thread Nico Weber
Hi, I was reading Lexer.cpp today and didn't know what BCPLComment means -- it's just a regular // comment. Would you mind if that got renamed to LineComment? That's easier to understand and consistent with BlockComment which is used for /**/. Nico clang-line-comment.patch Description: Binary

Re: [cfe-commits] [patch] s/BCPLComment/LineComment/

2012-11-10 Thread Dmitri Gribenko
On Sun, Nov 11, 2012 at 12:22 AM, Nico Weber tha...@chromium.org wrote: I was reading Lexer.cpp today and didn't know what BCPLComment means -- it's just a regular // comment. Would you mind if that got renamed to LineComment? That's easier to understand and consistent with BlockComment which

Re: [cfe-commits] [cfe-dev][patch] Strange LLVM IR result on recursive type

2012-11-10 Thread Jin Gu Kang
I misunderstood something about ABI converting. struct S1 { int x; }; struct S2 { struct S1 (*g)(void); }; struct S2 g; Above example, struct S1 is changed to shadow parameter as following. %struct.S2 = type { void (%struct.S1*)* } %struct.S1 = type { i32 } @g = common global %struct.S2

Re: [cfe-commits] r167374 - in /cfe/trunk: lib/CodeGen/CGObjCMac.cpp test/CodeGenObjC/arc-captured-block-var-inlined-layout.m test/CodeGenObjC/mrr-captured-block-var-inlined-layout.m

2012-11-10 Thread John McCall
On Nov 4, 2012, at 10:19 AM, Fariborz Jahanian wrote: Author: fjahanian Date: Sun Nov 4 12:19:40 2012 New Revision: 167374 URL: http://llvm.org/viewvc/llvm-project?rev=167374view=rev Log: Fixes liftime of captured block variables in mrr mode, per John's feedback, as well as couple of

[cfe-commits] r167679 - /cfe/trunk/include/clang/Driver/Options.td

2012-11-10 Thread Richard Smith
Author: rsmith Date: Sat Nov 10 18:28:33 2012 New Revision: 167679 URL: http://llvm.org/viewvc/llvm-project?rev=167679view=rev Log: Fix a typo which Matt pointed out. Modified: cfe/trunk/include/clang/Driver/Options.td Modified: cfe/trunk/include/clang/Driver/Options.td URL:

Re: [cfe-commits] r167643 - /cfe/trunk/include/clang/Driver/Options.td

2012-11-10 Thread Richard Smith
On Sat, Nov 10, 2012 at 10:34 AM, Matt Beaumont-Gay matthe...@google.com wrote: On Fri, Nov 9, 2012 at 3:18 PM, Richard Smith richard-l...@metafoo.co.uk wrote: Author: rsmith Date: Fri Nov 9 17:18:31 2012 New Revision: 167643 URL: http://llvm.org/viewvc/llvm-project?rev=167643view=rev

[cfe-commits] r167680 - /cfe/trunk/test/Lexer/dollar-idents.c

2012-11-10 Thread Nico Weber
Author: nico Date: Sat Nov 10 19:35:05 2012 New Revision: 167680 URL: http://llvm.org/viewvc/llvm-project?rev=167680view=rev Log: FileCheckize test Modified: cfe/trunk/test/Lexer/dollar-idents.c Modified: cfe/trunk/test/Lexer/dollar-idents.c URL:

Re: [cfe-commits] r167647 - in /cfe/trunk: include/clang/Basic/BuiltinsNVPTX.def test/CodeGen/builtins-nvptx.c

2012-11-10 Thread Eli Friedman
On Sat, Nov 10, 2012 at 7:06 AM, Justin Holewinski justin.holewin...@gmail.com wrote: Blah, for some reason I was thinking popc == sync. :( membar should be n. Thanks for the catch! Side question though: what does Clang actually do with the const modifier? The intrinsics are not marked as

Re: [cfe-commits] [libcxx] r167490 - /libcxx/trunk/www/index.html

2012-11-10 Thread Howard Hinnant
On Nov 10, 2012, at 12:17 PM, Jonathan Sauer jonathan.sa...@gmx.de wrote: Hello, - pTo build on Mac OS X 10.6 (Snow Leopard), you need a helper library and header -a href=http://home.roadrunner.com/~hinnant/libcppabi.zip;found here/a. -cp cxxabi.h to /usr/include, and cp

Re: [cfe-commits] r167596 - in /cfe/trunk: lib/Sema/SemaOverload.cpp test/SemaCXX/ambiguous-conversion-show-overload.cpp

2012-11-10 Thread Dmitri Gribenko
Hi Matt, On Thu, Nov 8, 2012 at 10:50 PM, Matt Beaumont-Gay matthe...@google.com wrote: Author: matthewbg Date: Thu Nov 8 14:50:02 2012 New Revision: 167596 URL: http://llvm.org/viewvc/llvm-project?rev=167596view=rev Log: Fix a bug I found while preparing my devmtg talk: When passing NULL

Re: [cfe-commits] [patch] s/BCPLComment/LineComment/

2012-11-10 Thread Chris Lattner
On Nov 10, 2012, at 2:22 PM, Nico Weber tha...@chromium.org wrote: Hi, I was reading Lexer.cpp today and didn't know what BCPLComment means -- it's just a regular // comment. Would you mind if that got renamed to LineComment? That's easier to understand and consistent with BlockComment

Re: [cfe-commits] [patch] s/BCPLComment/LineComment/

2012-11-10 Thread Nico Weber
r167690, thanks! On Sat, Nov 10, 2012 at 10:47 PM, Chris Lattner clatt...@apple.com wrote: On Nov 10, 2012, at 2:22 PM, Nico Weber tha...@chromium.org wrote: Hi, I was reading Lexer.cpp today and didn't know what BCPLComment means -- it's just a regular // comment. Would you mind if that

[cfe-commits] r167690 - in /cfe/trunk: include/clang/Basic/DiagnosticLexKinds.td include/clang/Basic/LangOptions.def include/clang/Frontend/LangStandard.h include/clang/Frontend/LangStandards.def incl

2012-11-10 Thread Nico Weber
Author: nico Date: Sun Nov 11 01:02:14 2012 New Revision: 167690 URL: http://llvm.org/viewvc/llvm-project?rev=167690view=rev Log: s/BCPLComment/LineComment/ Modified: cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td cfe/trunk/include/clang/Basic/LangOptions.def