r174863 - Fix formatting of overloaded operator definitions.

2013-02-11 Thread Daniel Jasper
Author: djasper Date: Mon Feb 11 02:01:18 2013 New Revision: 174863 URL: http://llvm.org/viewvc/llvm-project?rev=174863view=rev Log: Fix formatting of overloaded operator definitions. Before: operatorvoid*(); operator vector A A(); After: operator void *(); operator vectorAA (); Modified:

r174866 - Update test to not fail with attribute groups.

2013-02-11 Thread Bill Wendling
Author: void Date: Mon Feb 11 02:35:52 2013 New Revision: 174866 URL: http://llvm.org/viewvc/llvm-project?rev=174866view=rev Log: Update test to not fail with attribute groups. Modified: cfe/trunk/test/CodeGen/attr-minsize.cpp Modified: cfe/trunk/test/CodeGen/attr-minsize.cpp URL:

Re: [PATCH][libcxx] Support command line configuration of ABI libraries for testing

2013-02-11 Thread Michael van der Westhuizen
Hi Daniel,I've attached an updated patch that implements this flag as "link_flags", still respecting the use_system_lib flag.Lines are wrapped to 80 columns - I've wrapped a few extra lines too, so the whole file should now confirm to this standard.Michael libcxx-test-link_flags.patch

[PATCH] add __attribute__ no_uninitialized_checks. Map no_uninitialized_checks/no_thread_safety_analysis to LLVM function attributes.

2013-02-11 Thread Kostya Serebryany
Hi void, eugenis, dvyukov, - Adding __attribute__((no_uninitialized_checks)) - Mapping __attribute__((no_uninitialized_checks)) to llvm::Attribute::UninitializedChecks (under MSAN) - Mapping __attribute__((no_thread_safety_analysis)) llvm::Attribute::ThreadSafety (under TSAN) - Updating Docs

RE: r174768 - Excise cctype from Clang (except clang-tblgen) in favor of CharInfo.h.

2013-02-11 Thread Benyei, Guy
OK, I'll take care of it. Thanks Guy -Original Message- From: Jordan Rose [mailto:jordan_r...@apple.com] Sent: Sunday, February 10, 2013 20:56 To: Benyei, Guy Cc: cfe-commits@cs.uiuc.edu Subject: Re: r174768 - Excise cctype from Clang (except clang-tblgen) in favor of CharInfo.h.

r174878 - Fixes handling of empty lines in macros.

2013-02-11 Thread Manuel Klimek
Author: klimek Date: Mon Feb 11 06:33:24 2013 New Revision: 174878 URL: http://llvm.org/viewvc/llvm-project?rev=174878view=rev Log: Fixes handling of empty lines in macros. Now correctly formats: #define A \ \ b; to #define A b; Added the state whether an unwrapped line is a macro to

r174879 - Fix invalid formatting with spaces before trailing comments.

2013-02-11 Thread Daniel Jasper
Author: djasper Date: Mon Feb 11 06:36:37 2013 New Revision: 174879 URL: http://llvm.org/viewvc/llvm-project?rev=174879view=rev Log: Fix invalid formatting with spaces before trailing comments. In google style, trailing comments are separated by two spaces. This patch fixes the counting of these

r174880 - Get rid of manual debug output, now that the test runner supports it.

2013-02-11 Thread Manuel Klimek
Author: klimek Date: Mon Feb 11 06:37:30 2013 New Revision: 174880 URL: http://llvm.org/viewvc/llvm-project?rev=174880view=rev Log: Get rid of manual debug output, now that the test runner supports it. You can run tests with -debug instead now. Modified: cfe/trunk/lib/Format/Format.cpp

Re: [PATCH] add __attribute__ no_uninitialized_checks. Map no_uninitialized_checks/no_thread_safety_analysis to LLVM function attributes.

2013-02-11 Thread Dmitri Gribenko
Comment at: lib/Sema/SemaDeclAttr.cpp:655-656 @@ +654,4 @@ + if (!isaFunctionDecl(D) !isaFunctionTemplateDecl(D)) { +S.Diag(Attr.getLoc(), diag::warn_attribute_wrong_decl_type) + Attr.getName() ExpectedFunctionOrMethod; +return; Can we promote

Re: [PATCH] Intercept allocation to skim allocated types

2013-02-11 Thread Dai MIKURUBE
Hi Doug, 2013/2/7 Dai MIKURUBE dmikur...@acm.org Thank you, Douglas. Ok, I'll give it a try. I think it'll take a few weeks. I may ask more questions later since I might not understand this design well. 2013/2/6 Douglas Gregor dgre...@apple.com On Feb 4, 2013, at 9:18 AM, Dai

RE: [PATCHJ] Fix for diagnosing half pointers/arrays

2013-02-11 Thread Joey Gouly
Hi John, Just check whether the lvalue expression's type isHalfType() instead of trying to enumerate all the syntactic cases that can give rise to it. Thanks. Please find a revised patch. I also removed the opencl_cast_from_half diagnostic, since there isn't a valid case for (float) expr, where

Re: [PATCH] add __attribute__ no_uninitialized_checks. Map no_uninitialized_checks/no_thread_safety_analysis to LLVM function attributes.

2013-02-11 Thread Kostya Serebryany
Comment at: lib/Sema/SemaDeclAttr.cpp:655-656 @@ +654,4 @@ + if (!isaFunctionDecl(D) !isaFunctionTemplateDecl(D)) { +S.Diag(Attr.getLoc(), diag::warn_attribute_wrong_decl_type) + Attr.getName() ExpectedFunctionOrMethod; +return; Dmitri Gribenko

Re: [PATCH] add __attribute__ no_uninitialized_checks. Map no_uninitialized_checks/no_thread_safety_analysis to LLVM function attributes.

2013-02-11 Thread Dmitri Gribenko
Comment at: lib/Sema/SemaDeclAttr.cpp:655-656 @@ +654,4 @@ + if (!isaFunctionDecl(D) !isaFunctionTemplateDecl(D)) { +S.Diag(Attr.getLoc(), diag::warn_attribute_wrong_decl_type) + Attr.getName() ExpectedFunctionOrMethod; +return; Kostya

r174889 - Formatter: Detect ObjC message expressions after 'in' in loop

2013-02-11 Thread Nico Weber
Author: nico Date: Mon Feb 11 09:32:15 2013 New Revision: 174889 URL: http://llvm.org/viewvc/llvm-project?rev=174889view=rev Log: Formatter: Detect ObjC message expressions after 'in' in loop Before: for (id foo in[self getStuffFor : bla]) { } Now: for (id foo in [self getStuffFor:bla]) {

Re: [PATCH] Formatter: Detect ObjC message expressions after 'in' in loop

2013-02-11 Thread Nico Weber
r174889, thanks! http://llvm-reviews.chandlerc.com/D385 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [cfe-commits] [PATCH] PR13824 warn if reinterpret_cast used for up/downcast

2013-02-11 Thread Alexander Zinenko
Ping? On 28 January 2013 23:03, Alexander Zinenko fty...@gmail.com wrote: Hello! If this patch is good enough, could someone commit it, please? On 24 January 2013 21:55, Alexander Zinenko fty...@gmail.com wrote: On 24 January 2013 04:33, Jordan Rose jordan_r...@apple.com wrote: On

Re: r174866 - Update test to not fail with attribute groups.

2013-02-11 Thread David Blaikie
On Mon, Feb 11, 2013 at 12:35 AM, Bill Wendling isanb...@gmail.com wrote: Author: void Date: Mon Feb 11 02:35:52 2013 New Revision: 174866 URL: http://llvm.org/viewvc/llvm-project?rev=174866view=rev Log: Update test to not fail with attribute groups. Modified:

[PATCH] Introducing initial UseAuto transform

2013-02-11 Thread Edwin Vane
Hi klimek, Initial draft of UseAuto replaces the type specifier for declarations of variables that inherit from std::iterator or have iterator type traits with the C++11 'auto' keyword. http://llvm-reviews.chandlerc.com/D392 Files: cpp11-migrate/CMakeLists.txt cpp11-migrate/Makefile

[PATCH] Use 'auto' with 'new' expressions

2013-02-11 Thread Edwin Vane
Hi klimek, For variable declarations initialized with new expressions, use 'auto' for the type specifier. - Some slight refactoring. - Added a new test case. http://llvm-reviews.chandlerc.com/D393 Files: cpp11-migrate/UseAuto/UseAuto.cpp cpp11-migrate/UseAuto/UseAutoActions.cpp

Re: [PATCH] Use 'auto' with 'new' expressions

2013-02-11 Thread Edwin Vane
I have one more patch for factory functions that's not quite ready for review. It's coming soon. http://llvm-reviews.chandlerc.com/D393 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] Formatter: Correctly format stars in `sizeof(int**)` and similar places.

2013-02-11 Thread Nico Weber
Hi djasper, http://llvm-reviews.chandlerc.com/D384 CHANGE SINCE LAST DIFF http://llvm-reviews.chandlerc.com/D384?vs=932id=946#toc Files: unittests/Format/FormatTest.cpp lib/Format/TokenAnnotator.cpp Index: unittests/Format/FormatTest.cpp

Re: [PATCH] Formatter: Correctly format stars in `sizeof(int**)` and similar places.

2013-02-11 Thread Nico Weber
Comment at: lib/Format/TokenAnnotator.cpp:541 @@ -540,1 +540,3 @@ +} else if (Current.is(tok::kw_return) || Current.is(tok::kw_throw) || (Current.is(tok::l_paren) !Line.MustBeDeclaration + (Current.Parent == NULL || Current.Parent-isNot(tok::kw_for {

Re: [cfe-commits] r171263 - in /cfe/trunk: lib/Sema/SemaDecl.cpp test/SemaCXX/function-extern-c.cpp

2013-02-11 Thread Rafael Espíndola
Ping? Sorry, I was away. I am debugging this now. I am almost sure the added test was failing, I will double check that and make sure we don't warn for static. Cheers, Rafael ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

Re: [PATCH] Formatter: Correctly format stars in `sizeof(int**)` and similar places.

2013-02-11 Thread Nico Weber
On Mon, Feb 11, 2013 at 9:10 AM, Nico Weber tha...@chromium.org wrote: Hi djasper, http://llvm-reviews.chandlerc.com/D384 CHANGE SINCE LAST DIFF (This is misleading. I changed the diff to have more context lines, which apparently confuses phab.)

Re: [PATCH] Formatter: Correctly format stars in `sizeof(int**)` and similar places.

2013-02-11 Thread Manuel Klimek
On Mon, Feb 11, 2013 at 6:11 PM, Nico Weber tha...@chromium.org wrote: Comment at: lib/Format/TokenAnnotator.cpp:541 @@ -540,1 +540,3 @@ +} else if (Current.is(tok::kw_return) || Current.is(tok::kw_throw) || (Current.is(tok::l_paren) !Line.MustBeDeclaration

Re: [PATCH] Use 'auto' with 'new' expressions

2013-02-11 Thread Dmitri Gribenko
Comment at: test/cpp11-migrate/UseAuto/new.cpp:15-17 @@ +14,5 @@ + + MyType *b = new MyDerivedType(); + // CHECK: MyType *b = new MyDerivedType(); + + void *c = new MyType(); Please add tests with: * const and volatile qualifiers; * new[]; * `MyType *a(new

Re: [cfe-commits] unix.Malloc static checker improvement: memory.LeakPtrValChanged

2013-02-11 Thread Anna Zaks
On Feb 9, 2013, at 4:31 AM, Dmitri Gribenko griboz...@gmail.com wrote: On Sat, Feb 9, 2013 at 6:04 AM, Branden Archer b.m.arch...@gmail.com wrote: The attached patch removes memory.LeakPtrValChanged from the potential checker list. I don't know if this is something Clang SA wants to do,

r174895 - [Modules] Cope better with top-level declarations loaded after being declared in the current translation unit rdar://problem/13189985.

2013-02-11 Thread Douglas Gregor
Author: dgregor Date: Mon Feb 11 12:16:18 2013 New Revision: 174895 URL: http://llvm.org/viewvc/llvm-project?rev=174895view=rev Log: [Modules] Cope better with top-level declarations loaded after being declared in the current translation unit rdar://problem/13189985. These two related tweaks to

Re: [PATCH] Introducing initial UseAuto transform

2013-02-11 Thread Dmitri Gribenko
Comment at: cpp11-migrate/UseAuto/UseAutoActions.cpp:40-48 @@ +39,11 @@ + + if (const MaterializeTemporaryExpr *MTE = + dyn_castMaterializeTemporaryExpr(E)) { +E = MTE-GetTemporaryExpr(); + } + if (const CastExpr *CE = dyn_castCastExpr(E)) { +if

Re: [PATCH] Introducing initial UseAuto transform

2013-02-11 Thread Edwin Vane
Comment at: cpp11-migrate/UseAuto/UseAutoActions.cpp:38 @@ +37,3 @@ + // Drill down to the as-written initializer. + const Expr *E = *Construct-arg_begin(); + Dmitri Gribenko wrote: An assertion to check the number of arguments would be nice. The matcher this

Re: [PATCH] Introducing initial UseAuto transform

2013-02-11 Thread Edwin Vane
Comment at: cpp11-migrate/UseAuto/UseAutoMatchers.cpp:62-63 @@ +61,4 @@ + +/// \brief Overload of allOf accepting 5 args. +template typename M1, typename M2, typename M3, typename M4, typename M5 +internal::PolymorphicMatcherWithParam2 Edwin Vane wrote: Dmitri

Re: [PATCH] Add user documentation for cpp11-migrate

2013-02-11 Thread Sean Silva
Hi jy7.yang, are you planning on addressing these review comments? We really need a place for documentation for these tools. http://llvm-reviews.chandlerc.com/D339 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

Re: r174866 - Update test to not fail with attribute groups.

2013-02-11 Thread Bill Wendling
On Feb 11, 2013, at 8:27 AM, David Blaikie dblai...@gmail.com wrote: On Mon, Feb 11, 2013 at 12:35 AM, Bill Wendling isanb...@gmail.com wrote: Author: void Date: Mon Feb 11 02:35:52 2013 New Revision: 174866 URL: http://llvm.org/viewvc/llvm-project?rev=174866view=rev Log: Update test to

r174898 - objective-C modern translator: Fixes a mistranslation

2013-02-11 Thread Fariborz Jahanian
Author: fjahanian Date: Mon Feb 11 13:30:33 2013 New Revision: 174898 URL: http://llvm.org/viewvc/llvm-project?rev=174898view=rev Log: objective-C modern translator: Fixes a mistranslation of @throw statement by finding location of the ';' correctly. // rdar://13186010 Modified:

Re: [PATCH] Introducing initial UseAuto transform

2013-02-11 Thread Dmitri Gribenko
Comment at: cpp11-migrate/UseAuto/UseAutoMatchers.cpp:51-52 @@ +50,4 @@ +} +ImplicitInit = Construct-getNumArgs() == 0 || + Construct-getArg(0)-isDefaultArgument(); + } else { Edwin Vane wrote: Dmitri Gribenko wrote: Please add

Re: [PATCH] Introducing initial UseAuto transform

2013-02-11 Thread Sean Silva
Comment at: test/cpp11-migrate/UseAuto/iterator.cpp:1 @@ +1,2 @@ +// RUN: grep -Ev // *[A-Z-]+: %s %t.cpp +// RUN: cpp11-migrate -use-auto %t.cpp -- --std=c++11 What is the purpose of this grep? Comment at: cpp11-migrate/UseAuto/UseAuto.h:27

Re: [cfe-commits] [PATCH] Smarter implicit copy-construction/copy-assignment.

2013-02-11 Thread John McCall
On Feb 8, 2013, at 12:21 AM, Lang Hames lha...@gmail.com wrote: Thanks very much for all the help guys. I've attached an updated patch incorporating your feedback. It also fixes a bug - I had been memcpying members with defaulted but non-trivial assignment operators. +// Get source

Re: [PATCH] Introducing initial UseAuto transform

2013-02-11 Thread Edwin Vane
Comment at: cpp11-migrate/UseAuto/UseAuto.cpp:43-46 @@ +42,6 @@ + + if (int result = UseAutoTool.run(newFrontendActionFactory(Finder))) { +llvm::errs() Error encountered during translation.\n; +return result; + } + Sean Silva wrote:

Re: [PATCH] Introducing initial UseAuto transform

2013-02-11 Thread Dmitri Gribenko
Comment at: cpp11-migrate/UseAuto/UseAuto.h:27 @@ +26,3 @@ +/// In addition to being used as the type specifier for variable declarations +/// auto can be used in these ways (c++11 §7.1.6.4.2): +/// * With functions with trailing return type Sean Silva wrote:

Re: [PATCH] Introducing initial UseAuto transform

2013-02-11 Thread Edwin Vane
Comment at: cpp11-migrate/UseAuto/UseAuto.h:27 @@ +26,3 @@ +/// In addition to being used as the type specifier for variable declarations +/// auto can be used in these ways (c++11 §7.1.6.4.2): +/// * With functions with trailing return type Dmitri Gribenko

Re: [PATCH] Introducing initial UseAuto transform

2013-02-11 Thread Dmitri Gribenko
Comment at: cpp11-migrate/UseAuto/UseAuto.h:27 @@ +26,3 @@ +/// In addition to being used as the type specifier for variable declarations +/// auto can be used in these ways (c++11 §7.1.6.4.2): +/// * With functions with trailing return type Edwin Vane wrote:

[PATCH] Adding more overloads for allOf matcher

2013-02-11 Thread Edwin Vane
Hi klimek, gribozavr, Adding overloads of allOf accepting 4 and 5 arguments. http://llvm-reviews.chandlerc.com/D394 Files: include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/ASTMatchersTest.cpp Index: include/clang/ASTMatchers/ASTMatchers.h

[libcxx] r174902 - [tests] Another batch of timeout increases.

2013-02-11 Thread Daniel Dunbar
Author: ddunbar Date: Mon Feb 11 15:04:34 2013 New Revision: 174902 URL: http://llvm.org/viewvc/llvm-project?rev=174902view=rev Log: [tests] Another batch of timeout increases. Modified: libcxx/trunk/test/thread/futures/futures.unique_future/wait_for.pass.cpp

Re: [PATCH] Adding more overloads for allOf matcher

2013-02-11 Thread Manuel Klimek
I'd compose the allOfs differently - but I don't feel strongly about it. LG. Comment at: include/clang/ASTMatchers/ASTMatchers.h:1195 @@ +1194,3 @@ +allOf(const M1 P1, const M2 P2, const M3 P3, const M4 P4) { + return allOf(allOf(P1, P2), allOf(P3, P4)); +}

r174906 - Don't bother reconciling external visible decls against our current set of

2013-02-11 Thread Richard Smith
Author: rsmith Date: Mon Feb 11 16:02:16 2013 New Revision: 174906 URL: http://llvm.org/viewvc/llvm-project?rev=174906view=rev Log: Don't bother reconciling external visible decls against our current set of declarations if we didn't have a lookup map when the external decls were added. Modified:

[PATCH] Improve attributes printing.

2013-02-11 Thread Michael Han
Hi rsmith, This patch improves attribute printing by taking the source location of attributes into account when print them out. Previously, we hard code the print out locations for attributes and this has some issues especially for C++11 attributes for example: void foo [[noreturn]] (); would

r174918 - Timing data was removed years ago. Remove these links.

2013-02-11 Thread Tanya Lattner
Author: tbrethou Date: Mon Feb 11 17:32:10 2013 New Revision: 174918 URL: http://llvm.org/viewvc/llvm-project?rev=174918view=rev Log: Timing data was removed years ago. Remove these links. Modified: cfe/trunk/www/performance.html Modified: cfe/trunk/www/performance.html URL:

[PATCH] Ok to remove performance web pages?

2013-02-11 Thread Tanya Lattner
The performance.html page has not been updated in over 3 years. Is everyone ok in removing it? It had some broken links as the directory timing-data was removed a couple years back. I also would like to remove the other two performance pages. -Tanya removePerfHtml.patch Description: Binary

r174919 - When generating IR for default copy-constructors, copy-assignment operators,

2013-02-11 Thread Lang Hames
Author: lhames Date: Mon Feb 11 17:44:11 2013 New Revision: 174919 URL: http://llvm.org/viewvc/llvm-project?rev=174919view=rev Log: When generating IR for default copy-constructors, copy-assignment operators, move-constructors and move-assignment operators, use memcpy to copy adjacent POD

[patch] Misc fixes to our handling of language linkage.

2013-02-11 Thread Rafael Espíndola
The attached patch adds a getLanguageLinkage method that explicit models the possible language linkages (C, C++, none). This fixes some cases we were producing wrong answers when a function or variable has no language linkage. In particular, with this patch we don't warn anymore in extern C {

Re: [cfe-commits] [PATCH] Smarter implicit copy-construction/copy-assignment.

2013-02-11 Thread Lang Hames
Thanks John. Committed the requested changes in r174919. Thanks to both of you for your help. - Lang. On Mon, Feb 11, 2013 at 11:52 AM, John McCall rjmcc...@apple.com wrote: On Feb 8, 2013, at 12:21 AM, Lang Hames lha...@gmail.com wrote: Thanks very much for all the help guys. I've attached

Re: [patch] Misc fixes to our handling of language linkage.

2013-02-11 Thread Richard Smith
On Mon, Feb 11, 2013 at 3:49 PM, Rafael Espíndola rafael.espind...@gmail.com wrote: The attached patch adds a getLanguageLinkage method that explicit models the possible language linkages (C, C++, none). This fixes some cases we were producing wrong answers when a function or variable has no

r174922 - In ARC, emit non-peepholed +1s within the full-expression instead

2013-02-11 Thread John McCall
Author: rjmccall Date: Mon Feb 11 18:25:08 2013 New Revision: 174922 URL: http://llvm.org/viewvc/llvm-project?rev=174922view=rev Log: In ARC, emit non-peepholed +1s within the full-expression instead of immediately afterwards. Modified: cfe/trunk/lib/CodeGen/CGObjC.cpp

r174921 - Split a couple of tests out into their own file.

2013-02-11 Thread John McCall
Author: rjmccall Date: Mon Feb 11 18:25:02 2013 New Revision: 174921 URL: http://llvm.org/viewvc/llvm-project?rev=174921view=rev Log: Split a couple of tests out into their own file. Added: cfe/trunk/test/CodeGenObjC/arc-ternary-op.m Modified: cfe/trunk/test/CodeGenObjC/arc.m Added:

Re: r174919 - When generating IR for default copy-constructors, copy-assignment operators,

2013-02-11 Thread NAKAMURA Takumi
Lang, seems it broke selfhosting... http://bb.pgr.jp/builders/clang-3stage-x86_64-linux/builds/1011 2013/2/12 Lang Hames lha...@gmail.com: Author: lhames Date: Mon Feb 11 17:44:11 2013 New Revision: 174919 URL: http://llvm.org/viewvc/llvm-project?rev=174919view=rev Log: When generating IR

r174925 - Backing out r174919 while I investigate a self-host bug on Takumi's builder.

2013-02-11 Thread Lang Hames
Author: lhames Date: Mon Feb 11 18:44:43 2013 New Revision: 174925 URL: http://llvm.org/viewvc/llvm-project?rev=174925view=rev Log: Backing out r174919 while I investigate a self-host bug on Takumi's builder. Modified: cfe/trunk/lib/CodeGen/CGClass.cpp

Re: [PATCH] Ok to remove performance web pages?

2013-02-11 Thread Ted Kremenek
I'm fine with removing it. When new data is available we can easily add the page back. On Feb 11, 2013, at 3:40 PM, Tanya Lattner latt...@apple.com wrote: The performance.html page has not been updated in over 3 years. Is everyone ok in removing it? It had some broken links as the directory

Re: r174919 - When generating IR for default copy-constructors, copy-assignment operators,

2013-02-11 Thread Lang Hames
Interesting. I'll back out the patch while I try to reproduce. Thanks Takumi! - Lang. On Mon, Feb 11, 2013 at 4:33 PM, NAKAMURA Takumi geek4ci...@gmail.comwrote: Lang, seems it broke selfhosting... http://bb.pgr.jp/builders/clang-3stage-x86_64-linux/builds/1011 2013/2/12 Lang Hames

Re: [PATCH] Expose AST Record layout attributes to libclang

2013-02-11 Thread Loïc Jaquemet
Hello, This patch is 3 functions in libclang to get more Record Layout information from the AST when using libclang. I am trying to implement the python ctypeslib record generator by replacing gccxml with libclang. Following your comments, I corrected my submission. Yet I have no idea how to

Re: [PATCHJ] Fix for diagnosing half pointers/arrays

2013-02-11 Thread Tanya Lattner
LGTM. -Tanya On Feb 11, 2013, at 6:14 AM, Joey Gouly joey.go...@arm.com wrote: Hi John, Just check whether the lvalue expression's type isHalfType() instead of trying to enumerate all the syntactic cases that can give rise to it. Thanks. Please find a revised patch. I also removed the

r174928 - Diagnose loads of 'half' l-values in OpenCL.

2013-02-11 Thread John McCall
Author: rjmccall Date: Mon Feb 11 19:29:43 2013 New Revision: 174928 URL: http://llvm.org/viewvc/llvm-project?rev=174928view=rev Log: Diagnose loads of 'half' l-values in OpenCL. Patch by Joey Gouly! Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCHJ] Fix for diagnosing half pointers/arrays

2013-02-11 Thread John McCall
On Feb 11, 2013, at 6:14 AM, Joey Gouly joey.go...@arm.com wrote: Hi John, Just check whether the lvalue expression's type isHalfType() instead of trying to enumerate all the syntactic cases that can give rise to it. Thanks. Please find a revised patch. I also removed the

Re: r174928 - Diagnose loads of 'half' l-values in OpenCL.

2013-02-11 Thread Richard Smith
On Mon, Feb 11, 2013 at 5:29 PM, John McCall rjmcc...@apple.com wrote: Author: rjmccall Date: Mon Feb 11 19:29:43 2013 New Revision: 174928 URL: http://llvm.org/viewvc/llvm-project?rev=174928view=rev Log: Diagnose loads of 'half' l-values in OpenCL. Patch by Joey Gouly! Modified:

Re: r174928 - Diagnose loads of 'half' l-values in OpenCL.

2013-02-11 Thread Richard Smith
On Mon, Feb 11, 2013 at 5:37 PM, Richard Smith rich...@metafoo.co.ukwrote: On Mon, Feb 11, 2013 at 5:29 PM, John McCall rjmcc...@apple.com wrote: Author: rjmccall Date: Mon Feb 11 19:29:43 2013 New Revision: 174928 URL: http://llvm.org/viewvc/llvm-project?rev=174928view=rev Log: Diagnose

Re: [PATCH] Expose AST Record layout attributes to libclang

2013-02-11 Thread Dmitri Gribenko
On Tue, Feb 12, 2013 at 3:04 AM, Loïc Jaquemet loic.jaque...@gmail.com wrote: Hello, This patch is 3 functions in libclang to get more Record Layout information from the AST when using libclang. I am trying to implement the python ctypeslib record generator by replacing gccxml with

r174930 - Perform placeholder conversions on the controller of a _Generic

2013-02-11 Thread John McCall
Author: rjmccall Date: Mon Feb 11 20:08:12 2013 New Revision: 174930 URL: http://llvm.org/viewvc/llvm-project?rev=174930view=rev Log: Perform placeholder conversions on the controller of a _Generic expression. Added: cfe/trunk/test/SemaObjC/generic-selection.m Modified:

r174931 - Remove an assert which triggers when a decl context in a module hits the 'has

2013-02-11 Thread Richard Smith
Author: rsmith Date: Mon Feb 11 20:32:35 2013 New Revision: 174931 URL: http://llvm.org/viewvc/llvm-project?rev=174931view=rev Log: Remove an assert which triggers when a decl context in a module hits the 'has lexical storage but not visible storage' case in C++. It's unclear whether we even need

Re: [patch] Misc fixes to our handling of language linkage.

2013-02-11 Thread Rafael Espíndola
+/// \brief Describes the different kinds of language linkage +/// (C++ [dcl.link]) that an entity may have. +enum LanguageLinkage { + CLanguageLinkage, + CXXLanguageLinkage, + NoLanguageLinkage +}; Is there a reason to keep this separate from LinkageSpecDecl::LanguageIDs? That has

Re: [PATCH] Expose AST Record layout attributes to libclang

2013-02-11 Thread Loïc Jaquemet
This looks better now, but still not there yet. + * \brief Return the alignment value for a record, in bytes. Return the alignment of a record (struct or class), in bytes ? + * \brief Return the offset of a field in a record in bits. What does this return for bitfields? Is it possible

r174939 - Change some CGF parameters to CGMs.

2013-02-11 Thread John McCall
Author: rjmccall Date: Mon Feb 11 21:51:38 2013 New Revision: 174939 URL: http://llvm.org/viewvc/llvm-project?rev=174939view=rev Log: Change some CGF parameters to CGMs. Modified: cfe/trunk/lib/CodeGen/CGException.cpp Modified: cfe/trunk/lib/CodeGen/CGException.cpp URL:

r174940 - Call __cxa_begin_catch with the current exception before

2013-02-11 Thread John McCall
Author: rjmccall Date: Mon Feb 11 21:51:46 2013 New Revision: 174940 URL: http://llvm.org/viewvc/llvm-project?rev=174940view=rev Log: Call __cxa_begin_catch with the current exception before calling std::terminate(). rdar://11904428 Modified: cfe/trunk/lib/CodeGen/CGException.cpp

r174941 - + centered progress cells

2013-02-11 Thread Anton Yartsev
Author: ayartsev Date: Mon Feb 11 22:45:48 2013 New Revision: 174941 URL: http://llvm.org/viewvc/llvm-project?rev=174941view=rev Log: + centered progress cells + added progress information for several checkers Modified: cfe/trunk/www/analyzer/content.css

r174942 - + specified progress information

2013-02-11 Thread Anton Yartsev
Author: ayartsev Date: Mon Feb 11 23:02:54 2013 New Revision: 174942 URL: http://llvm.org/viewvc/llvm-project?rev=174942view=rev Log: + specified progress information Modified: cfe/trunk/www/analyzer/potential_checkers.html Modified: cfe/trunk/www/analyzer/potential_checkers.html URL:

[PATCH][Review request] unix.Malloc checker improvement: +handling new/delete, +memory.MismatchedFree, +memory.MismatchedDelete, +improved display names for allocators/deallocators

2013-02-11 Thread Anton Yartsev
Hi all, the attached patch has three goals: 1) Bring handling of new/delete operators to the unix.Malloc checker. This enables memory.LeakNeverReleased, memory.MultipleDelete, memory.DeallocateNonPtr and memory.LeakPtrValChanged checkers from the List of potential checkers

Re: [cfe-commits] unix.Malloc static checker improvement: memory.LeakPtrValChanged

2013-02-11 Thread Anton Yartsev
On 11.02.2013 22:14, Anna Zaks wrote: On Feb 9, 2013, at 4:31 AM, Dmitri Gribenko griboz...@gmail.com wrote: On Sat, Feb 9, 2013 at 6:04 AM, Branden Archer b.m.arch...@gmail.com wrote: The attached patch removes memory.LeakPtrValChanged from the potential checker list. I don't know if this

Re: [PATCH] Expose AST Record layout attributes to libclang

2013-02-11 Thread Loïc Jaquemet
Hello, This patch is 3 functions in libclang to get more Record Layout information from the AST when using libclang. I am trying to implement the python ctypeslib record generator by replacing gccxml with libclang. Files: 001: include/clang-c/Index.h tools/libclang/libclang.exports

r174946 - Properly assemble PHIs after a null-checked invoke of objc_msgSend.

2013-02-11 Thread John McCall
Author: rjmccall Date: Mon Feb 11 23:53:35 2013 New Revision: 174946 URL: http://llvm.org/viewvc/llvm-project?rev=174946view=rev Log: Properly assemble PHIs after a null-checked invoke of objc_msgSend. rdar://12046763 Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp

r174943 - Fix a bug reduced from a crash when trying to use modules with libc++. We check

2013-02-11 Thread Richard Smith
Author: rsmith Date: Mon Feb 11 23:48:23 2013 New Revision: 174943 URL: http://llvm.org/viewvc/llvm-project?rev=174943view=rev Log: Fix a bug reduced from a crash when trying to use modules with libc++. We check the linkage of functions and variables while merging declarations from modules, and