[patch] [libcxx] memory - small fixes to remove warnings in msvc

2013-10-14 Thread G M
memory.diff Description: Binary data ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

r192570 - Fixed ArgSize may be used uninitialised error when compiling with gcc.

2013-10-14 Thread Andy Gibbs
Author: andyg Date: Mon Oct 14 02:02:04 2013 New Revision: 192570 URL: http://llvm.org/viewvc/llvm-project?rev=192570view=rev Log: Fixed ArgSize may be used uninitialised error when compiling with gcc. Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp Modified:

r192572 - Fix use-after-free in PPCallbacksTest detected by ASan bootstrap bot

2013-10-14 Thread Alexey Samsonov
Author: samsonov Date: Mon Oct 14 02:13:59 2013 New Revision: 192572 URL: http://llvm.org/viewvc/llvm-project?rev=192572view=rev Log: Fix use-after-free in PPCallbacksTest detected by ASan bootstrap bot Modified: cfe/trunk/unittests/Lex/PPCallbacksTest.cpp Modified:

Re: [PATCH] Header guard warning is too agressive

2013-10-14 Thread Ismail Pazarbasi
Committed in r192547. http://llvm-reviews.chandlerc.com/D1506 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

[PATCH] AST: Mangle templated local classes instead of crashing

2013-10-14 Thread David Majnemer
Hi eli.friedman, rsmith, rjmccall, On builds of clang compiled with asserts, we would crash during mangling. On builds of clang compiler without asserts, we would mangle in an extra prefix. i.e. Funtion()::Function::Typevoid[...] rather than Funtion()::Typevoid[...]

Re: r192312 - Initialize vtorDisp in class constructors and destructors

2013-10-14 Thread Timur Iskhodzhanov
Yep, disregard my previous suspicion :) The vtorDisp for the vbase is at -4; it's just that B uses C's vtorDisp in thunks. 2013/10/11 Warren Hunt wh...@google.com: When I run that through cl.exe with my test harness I get the following layouts: A : 4 : 4 0 : 00FC8144 vfp B : 4 : 4 0 :

RE: [PATCH] AArch32 target support

2013-10-14 Thread James Molloy
Hi Bernie, Patch 0001: Trivial, LGTM. Patch 0002: I'm not sure about crypto being enabled by default. The ARMARM describes this as an extension (and one which may be disabled due to cryptographic/weapons export rules). Do we expect this to be so prevalent that it should be enabled by default?

XCore target, getPreferredTypeAlign() *MUST* return preferred alignment.

2013-10-14 Thread Robert Lytton
Hi Here is a suggest patch to support the XCore target. This is required as the the xcore llvm backend does not handle 8 byte alignment viz: %BadAlignment = alloca i64, align 8 (llvm will reject the above as an error) The patch prevents the default behavior running: ///

RE: [PATCH] AArch32 target support

2013-10-14 Thread Bernie Ogden
Hi James, Thanks for the review! Patch 0002: The fpu option here is for GNU tools being driven by clang. I've just done the minimum here to give the same level of support in v8 as in v7, which assumes fp + neon are supported. Crypto is the only extra assumption and, given that crypto

RE: [PATCH] AArch32 target support

2013-10-14 Thread James Molloy
Hi Bernie, OK, you had me at GNU compatibility. I agree with (a). Coding style nits: * Please do something about the textual-numeric comparison. StringRef::compare_numeric or StringRef::getAsInteger() are both cheap and available. * This brace doesn't follow LLVM coding style: } +

r192594 - Do not use typo correction that is unaccessible.

2013-10-14 Thread Serge Pavlov
Author: sepavloff Date: Mon Oct 14 09:05:48 2013 New Revision: 192594 URL: http://llvm.org/viewvc/llvm-project?rev=192594view=rev Log: Do not use typo correction that is unaccessible. This patch fixes PR17019. When doing typo correction, Sema::CorrectTypo uses correction already seen for the same

Re: [PATCH] Modularize assistant mode

2013-10-14 Thread John Thompson
This update addresses the comments on the previous revision, except for revising the ensureNoCollisionWithReservedName argument, which I couldn't understand. Also, I eliminated the ModuleAssistant.h file, merging it with Modularize.h, since it only declared one function. Hi doug.gregor,

r192597 - [AArch64] Add support for NEON scalar integer compare instructions.

2013-10-14 Thread Chad Rosier
Author: mcrosier Date: Mon Oct 14 09:37:40 2013 New Revision: 192597 URL: http://llvm.org/viewvc/llvm-project?rev=192597view=rev Log: [AArch64] Add support for NEON scalar integer compare instructions. Modified: cfe/trunk/include/clang/Basic/arm_neon.td

Re: r192515 - Consumed analysis: replace the consumes attribute with a set_typestate

2013-10-14 Thread Delesley Hutchins
Thanks for the review, Aaron! Excellent points -- I'll fix those issues in a future patch. FYI, my goal right now is to get all of Chris's stuff working and upstream first; I'll go back and refine the code afterword. You had some good comments earlier regarding use of raw pointers that I want

r192598 - Reduce double set lookups by using the result of insert.

2013-10-14 Thread Benjamin Kramer
Author: d0k Date: Mon Oct 14 10:16:10 2013 New Revision: 192598 URL: http://llvm.org/viewvc/llvm-project?rev=192598view=rev Log: Reduce double set lookups by using the result of insert. No functionality change. Modified: cfe/trunk/lib/AST/VTableBuilder.cpp

Re: [PATCH] Modularize assistant mode

2013-10-14 Thread Sean Silva
LGTM with a couple tiny changes. Doug, could you take a look at this? Btw, does this need user-facing documentation yet? (that can be a separate commit if so) Comment at: modularize/ModuleAssistant.cpp:272 @@ +271,3 @@ + +} // end anonymous namespace. +

PATCH [libcxx] Implement sized deletion

2013-10-14 Thread Marshall Clow
Implement n3778 http://isocpp.org/files/papers/n3778.html sized deletion. Two implementations; one in libc++abi, and one in libc++. And tests. -- Marshall Marshall Clow Idio Software mailto:mclow.li...@gmail.com A.D. 1517: Martin Luther nails his 95 Theses to the church door and is

r192601 - Don't hardcode the order of the aliases.

2013-10-14 Thread Rafael Espindola
Author: rafael Date: Mon Oct 14 11:05:12 2013 New Revision: 192601 URL: http://llvm.org/viewvc/llvm-project?rev=192601view=rev Log: Don't hardcode the order of the aliases. Modified: cfe/trunk/test/CodeGen/pragma-weak.c Modified: cfe/trunk/test/CodeGen/pragma-weak.c URL:

Re: r192570 - Fixed ArgSize may be used uninitialised error when compiling with gcc.

2013-10-14 Thread David Blaikie
On Mon, Oct 14, 2013 at 12:02 AM, Andy Gibbs andyg1...@hotmail.co.ukwrote: Author: andyg Date: Mon Oct 14 02:02:04 2013 New Revision: 192570 URL: http://llvm.org/viewvc/llvm-project?rev=192570view=rev Log: Fixed ArgSize may be used uninitialised error when compiling with gcc. Modified:

r192603 - Also don't hardcode the order on this test.

2013-10-14 Thread Rafael Espindola
Author: rafael Date: Mon Oct 14 11:18:39 2013 New Revision: 192603 URL: http://llvm.org/viewvc/llvm-project?rev=192603view=rev Log: Also don't hardcode the order on this test. Modified: cfe/trunk/test/CodeGen/alias.c Modified: cfe/trunk/test/CodeGen/alias.c URL:

Re: Unavailable method checker

2013-10-14 Thread Jordan Rose
On Oct 11, 2013, at 1:32 , Richard tarka.t.ot...@gmail.com wrote: On 11 Oct 2013, at 03:00, Jordan Rose jordan_r...@apple.com wrote: On Oct 10, 2013, at 8:06 , Richard tarka.t.ot...@gmail.com wrote: I'm not sure if this is exactly what is happening. It is not at the beginning of

RE: r192570 - Fixed ArgSize may be used uninitialised error when compiling with gcc.

2013-10-14 Thread Robert Lytton
Hi David, Just to confirm that the initialization was needless. All enum types are covered in switch statement. Each case assigns to the variable. Robert ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

[patch][pr17535] Reject alias attributes that point to undefined names.

2013-10-14 Thread Rafael Espíndola
The attached patch causes clang to reject alias attributes that point to undefined names. For example, with this patch we now reject void f1(void) __attribute__((alias(g1))); if g1 is not defined in this file. This matches modern gcc (= 4.2 at least) behavior. What is different in this

Re: PATCH [libcxx] Implement sized deletion

2013-10-14 Thread Chandler Carruth
FYI, I think we may want to wait until we fully understand the nature of the IFUNC implementations possible on Linux and Darwin as that may in turn impact whether these are required to call the non-sized variants on those platforms for compatibility. On Mon, Oct 14, 2013 at 8:51 AM, Marshall

Re: [PATCH] AST: Mangle templated local classes instead of crashing

2013-10-14 Thread Richard Smith
Does this also affect generic lambdas? If not, this is in conflict with another patch out for review that makes us reject template members of local classes. http://llvm-reviews.chandlerc.com/D1932 ___ cfe-commits mailing list

Re: [PATCH] AST: Mangle templated local classes instead of crashing

2013-10-14 Thread Richard Smith
Does this also affect generic lambdas? If not, this is in conflict with another patch out for review that makes us reject template members of local classes. On 14 Oct 2013 03:19, David Majnemer david.majne...@gmail.com wrote: Hi eli.friedman, rsmith, rjmccall, On builds of clang compiled with

Re: r192345 - Sema: Taking the address of a dtor is illegal per C++ [class.dtor]p2.

2013-10-14 Thread Richard Smith
Ha, I wondered if that would be the case. That parse error is also a bug. On 10 Oct 2013 12:33, Benjamin Kramer benny@gmail.com wrote: On 10.10.2013, at 20:31, Richard Smith rich...@metafoo.co.uk wrote: What do we do in the corresponding case for constructors? It seems like we should

[libcxx] r192609 - r192075 broke the buildbot at

2013-10-14 Thread Howard Hinnant
Author: hhinnant Date: Mon Oct 14 13:02:02 2013 New Revision: 192609 URL: http://llvm.org/viewvc/llvm-project?rev=192609view=rev Log: r192075 broke the buildbot at http://lab.llvm.org:8013/builders/libcxx_clang-x86_64-darwin11-RA lit.py: string:230: note: inferred use_system_lib as: False

Re: [PATCH] AST: Mangle templated local classes instead of crashing

2013-10-14 Thread David Majnemer
No, it does not affect generic lambdas. It sounded like you wanted local classes to allow templated members so it seemed logical to beef them up a bit On Monday, October 14, 2013, Richard Smith wrote: Does this also affect generic lambdas? If not, this is in conflict with another patch

Re: [PATCH] Modularize assistant mode

2013-10-14 Thread John Thompson
Thank you! Revised anonymous namespace as suggested, and removed unnecessary comment. The user docs will follow. Hi doug.gregor, silvas, http://llvm-reviews.chandlerc.com/D1891 CHANGE SINCE LAST DIFF http://llvm-reviews.chandlerc.com/D1891?vs=4898id=4899#toc Files:

r192611 - GetExprRange() (used by -Wconversion checking) should look through OpaqueValueExprs.

2013-10-14 Thread Ted Kremenek
Author: kremenek Date: Mon Oct 14 13:55:27 2013 New Revision: 192611 URL: http://llvm.org/viewvc/llvm-project?rev=192611view=rev Log: GetExprRange() (used by -Wconversion checking) should look through OpaqueValueExprs. Fixes a false positive with -Wconversion involving Objective-C properties.

r192613 - Move comment to its proper place.

2013-10-14 Thread Ted Kremenek
Author: kremenek Date: Mon Oct 14 14:11:25 2013 New Revision: 192613 URL: http://llvm.org/viewvc/llvm-project?rev=192613view=rev Log: Move comment to its proper place. Modified: cfe/trunk/lib/Sema/AnalysisBasedWarnings.cpp Modified: cfe/trunk/lib/Sema/AnalysisBasedWarnings.cpp URL:

Re: [PATCH] [libc++abi] unwinder: conditionalise availability

2013-10-14 Thread kled...@apple.com
LGTM. http://llvm-reviews.chandlerc.com/D1906 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

SV: [PATCH] [StaticAnalyzer] New checker Sizeof on expression

2013-10-14 Thread Daniel Marjamäki
Hello! As I understood it.. you wanted to know what the hit ratio is. I have investigated the hit ratio on a number of packages in debian. Below is the negative and positives I've found. I provide the package URLs so you can look for yourself.. I will continue investigating and let you know

Re: [PATCH] Add new warning to Clang to detect when all code paths in a function has a call back to the function.

2013-10-14 Thread Richard Trieu
Warn on non-templated member functions of templated classes. http://llvm-reviews.chandlerc.com/D1864 CHANGE SINCE LAST DIFF http://llvm-reviews.chandlerc.com/D1864?vs=4752id=4900#toc Files: lib/Sema/AnalysisBasedWarnings.cpp lib/Lex/Pragma.cpp test/Sema/unused-expr-system-header.c

Re: r192362 - Implement AArch64 vector load/store multiple N-element structure class SIMD(lselem).

2013-10-14 Thread mcrosier
Hi Hao, I noticed this commit caused many warning int test/CodeGen/aarch64-neon-intrinsics.c. For example, /local/mnt/workspace/mrosier/llvm-clean/llvm/tools/clang/test/CodeGen/aarch64-neon-intrinsics.c:5711:20: warning: incompatible pointer types assigning to 'const unsigned short *' from

r192615 - For NetBSD/current on X86 do not use libgcc and default to libc++.

2013-10-14 Thread Joerg Sonnenberger
Author: joerg Date: Mon Oct 14 15:13:05 2013 New Revision: 192615 URL: http://llvm.org/viewvc/llvm-project?rev=192615view=rev Log: For NetBSD/current on X86 do not use libgcc and default to libc++. Adjust linkage to make more sense for older releases. Added: cfe/trunk/test/Driver/netbsd.c

r192616 - Correctly check for distructors when realizing vtordisps

2013-10-14 Thread Warren Hunt
Author: whunt Date: Mon Oct 14 15:14:09 2013 New Revision: 192616 URL: http://llvm.org/viewvc/llvm-project?rev=192616view=rev Log: Correctly check for distructors when realizing vtordisps This patch fixes the distructor test when checking for vtordisp requirements in microsoft record layout. A

Re: r192615 - For NetBSD/current on X86 do not use libgcc and default to libc++.

2013-10-14 Thread David Blaikie
On Mon, Oct 14, 2013 at 1:13 PM, Joerg Sonnenberger jo...@bec.de wrote: Author: joerg Date: Mon Oct 14 15:13:05 2013 New Revision: 192615 URL: http://llvm.org/viewvc/llvm-project?rev=192615view=rev Log: For NetBSD/current on X86 do not use libgcc and default to libc++. Adjust linkage to

r192625 - Fixing stdout/stderr interleaving in lit test.

2013-10-14 Thread Warren Hunt
Author: whunt Date: Mon Oct 14 15:58:36 2013 New Revision: 192625 URL: http://llvm.org/viewvc/llvm-project?rev=192625view=rev Log: Fixing stdout/stderr interleaving in lit test. Modified: cfe/trunk/test/Layout/ms-x86-lazy-empty-nonvirtual-base.cpp Modified:

r192626 - PR17576: Fix assertion on polymorphic classes with small alignment

2013-10-14 Thread Reid Kleckner
Author: rnk Date: Mon Oct 14 16:14:05 2013 New Revision: 192626 URL: http://llvm.org/viewvc/llvm-project?rev=192626view=rev Log: PR17576: Fix assertion on polymorphic classes with small alignment We have to reserve at least the width of a pointer for the vfptr. For classes with small alignment,

Re: r192615 - For NetBSD/current on X86 do not use libgcc and default to libc++.

2013-10-14 Thread Joerg Sonnenberger
On Mon, Oct 14, 2013 at 01:57:46PM -0700, David Blaikie wrote: On Mon, Oct 14, 2013 at 1:13 PM, Joerg Sonnenberger jo...@bec.de wrote: Author: joerg Date: Mon Oct 14 15:13:05 2013 New Revision: 192615 URL: http://llvm.org/viewvc/llvm-project?rev=192615view=rev Log: For

Re: r192615 - For NetBSD/current on X86 do not use libgcc and default to libc++.

2013-10-14 Thread David Blaikie
On Mon, Oct 14, 2013 at 2:22 PM, Joerg Sonnenberger jo...@britannica.bec.de wrote: On Mon, Oct 14, 2013 at 01:57:46PM -0700, David Blaikie wrote: On Mon, Oct 14, 2013 at 1:13 PM, Joerg Sonnenberger jo...@bec.de wrote: Author: joerg Date: Mon Oct 14 15:13:05 2013 New Revision:

Re: [PATCH] ms-compat: Fix taking the address of a member of a dependent base

2013-10-14 Thread Reid Kleckner
- Explicitly assume that unresolved unqualified id exprs are members of dependent bases. Hi rsmith, http://llvm-reviews.chandlerc.com/D1892 CHANGE SINCE LAST DIFF http://llvm-reviews.chandlerc.com/D1892?vs=4823id=4901#toc Files: lib/AST/ExprCXX.cpp lib/Sema/SemaExpr.cpp

Re: r192521 - Add missing flags -fexpensive-optimizations and -minline-all-stringops as noops.

2013-10-14 Thread Nick Lewycky
On 12 October 2013 05:28, Joerg Sonnenberger jo...@britannica.bec.dewrote: On Sat, Oct 12, 2013 at 04:24:32AM -, Nick Lewycky wrote: Author: nicholas Date: Fri Oct 11 23:24:31 2013 New Revision: 192521 URL: http://llvm.org/viewvc/llvm-project?rev=192521view=rev Log: Add missing

Re: r192521 - Add missing flags -fexpensive-optimizations and -minline-all-stringops as noops.

2013-10-14 Thread Joerg Sonnenberger
On Mon, Oct 14, 2013 at 02:45:22PM -0700, Nick Lewycky wrote: As a practical matter, I'm adding these so that I can continue to build software that used to build. They're marked clang_ignored_[fm]_Group so that we can find which flags aren't implemented. I have a certain issue with adding

Re: [patch] Emit aliases for more constructors (V2)

2013-10-14 Thread David Blaikie
On Sun, Oct 13, 2013 at 9:41 AM, Rafael Espíndola rafael.espind...@gmail.com wrote: . How do I track which expected failure switched to a unexpected successes? diffing the sum files show that the difference is expand-sals.exp which is marked as llvm.org/pr14610. Looks like producing an

r192638 - Adding a regression test for PR17578. It is marked xfail until the bug is fixed.

2013-10-14 Thread Yunzhong Gao
Author: ygao Date: Mon Oct 14 17:51:23 2013 New Revision: 192638 URL: http://llvm.org/viewvc/llvm-project?rev=192638view=rev Log: Adding a regression test for PR17578. It is marked xfail until the bug is fixed. Added: cfe/trunk/test/CodeGenCXX/offsetof.cpp Added:

r192639 - Switching some custom logic to using table-generated helper methods. This also removes an unnecessary diagnostic.

2013-10-14 Thread Aaron Ballman
Author: aaronballman Date: Mon Oct 14 18:22:37 2013 New Revision: 192639 URL: http://llvm.org/viewvc/llvm-project?rev=192639view=rev Log: Switching some custom logic to using table-generated helper methods. This also removes an unnecessary diagnostic. Modified:

Re: r192515 - Consumed analysis: replace the consumes attribute with a set_typestate

2013-10-14 Thread Aaron Ballman
No worries about fixing them; I had some spare time tonight where I could make the changes myself. :-) It's fixed up in r192639. Thanks! ~Aaron On Mon, Oct 14, 2013 at 10:57 AM, Delesley Hutchins deles...@google.com wrote: Thanks for the review, Aaron! Excellent points -- I'll fix those

r192640 - Trivial formatting changes; no functional changes intended.

2013-10-14 Thread Aaron Ballman
Author: aaronballman Date: Mon Oct 14 18:26:04 2013 New Revision: 192640 URL: http://llvm.org/viewvc/llvm-project?rev=192640view=rev Log: Trivial formatting changes; no functional changes intended. Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp

r192641 - Provide a dummy NetBSD tree and use --sysroot in the driver test.

2013-10-14 Thread Joerg Sonnenberger
Author: joerg Date: Mon Oct 14 18:26:44 2013 New Revision: 192641 URL: http://llvm.org/viewvc/llvm-project?rev=192641view=rev Log: Provide a dummy NetBSD tree and use --sysroot in the driver test. Added: cfe/trunk/test/Driver/Inputs/basic_netbsd_tree/

Re: r192612 - Lit tests for Microsoft C++ record layout.

2013-10-14 Thread Sean Silva
+struct A4 { + int a; + A4() : a(0xf0a4) {} Out of curiosity, is there a hidden meaning for these hex constants? They seem to have some sort of pattern. -- Sean Silva ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

r192643 - Add has_feature support for reflecting the presence of refined Objective-C ABI mangling for qualified id.... Fixes rdar://problem/14799110.

2013-10-14 Thread Ted Kremenek
Author: kremenek Date: Mon Oct 14 18:48:27 2013 New Revision: 192643 URL: http://llvm.org/viewvc/llvm-project?rev=192643view=rev Log: Add has_feature support for reflecting the presence of refined Objective-C ABI mangling for qualified id Fixes rdar://problem/14799110. Modified:

Re: r192521 - Add missing flags -fexpensive-optimizations and -minline-all-stringops as noops.

2013-10-14 Thread Nick Lewycky
On 14 October 2013 15:25, Joerg Sonnenberger jo...@britannica.bec.dewrote: On Mon, Oct 14, 2013 at 02:45:22PM -0700, Nick Lewycky wrote: As a practical matter, I'm adding these so that I can continue to build software that used to build. They're marked clang_ignored_[fm]_Group so that we

Re: r192612 - Lit tests for Microsoft C++ record layout.

2013-10-14 Thread Richard Smith
On Mon, Oct 14, 2013 at 4:36 PM, Sean Silva sil...@purdue.edu wrote: +struct A4 { + int a; + A4() : a(0xf0a4) {} Out of curiosity, is there a hidden meaning for these hex constants? They seem to have some sort of pattern. Note that the last couple of hex digits are the

Re: r192521 - Add missing flags -fexpensive-optimizations and -minline-all-stringops as noops.

2013-10-14 Thread Chandler Carruth
On Mon, Oct 14, 2013 at 4:53 PM, Nick Lewycky nlewy...@google.com wrote: Longer term, we should implement the ones that are sensible and warn on the ones that aren't. While I emphatically agree with you on this strategy, two notes: 1) Everyone will ignore these warnings because they have to.

Re: [patch] Emit aliases for more constructors (V2)

2013-10-14 Thread Rafael Espíndola
I haven't looked in detail at your change, but PR14610 (perhaps poorly explained by me in the bug) is more than about the duplicate debug info, but about the fact that we implement C1/C2 and D1/D2 by having one call the other so when you break on the ctor or dtor you actually break twice (once

Re: r192612 - Lit tests for Microsoft C++ record layout.

2013-10-14 Thread Warren Hunt
They're just markers. I have a little test harness that prints all of the bytes of a record and these make it very easy to read. They're not relevant to being tested in lit and can be removed. They're vestiges when turning my layout tests into lit tests and I was lazy and didn't remove them. I

r192644 - PR17567: Improve diagnostic for a mistyped constructor name. If we see something

2013-10-14 Thread Richard Smith
Author: rsmith Date: Mon Oct 14 19:00:26 2013 New Revision: 192644 URL: http://llvm.org/viewvc/llvm-project?rev=192644view=rev Log: PR17567: Improve diagnostic for a mistyped constructor name. If we see something that looks like a function declaration, except that it's missing a return type, try

r192645 - ObjectiveC migrator: Support for more possibility of

2013-10-14 Thread Fariborz Jahanian
Author: fjahanian Date: Mon Oct 14 19:00:28 2013 New Revision: 192645 URL: http://llvm.org/viewvc/llvm-project?rev=192645view=rev Log: ObjectiveC migrator: Support for more possibility of migration to NS_ENUM/NS_OPTIONS macros; when typedef'ed to NSInteger/NSUInteger preceeds well before of the

Re: [patch] Emit aliases for more constructors (V2)

2013-10-14 Thread David Blaikie
On Mon, Oct 14, 2013 at 4:59 PM, Rafael Espíndola rafael.espind...@gmail.com wrote: I haven't looked in detail at your change, but PR14610 (perhaps poorly explained by me in the bug) is more than about the duplicate debug info, but about the fact that we implement C1/C2 and D1/D2 by

[PATCH] [libcxx] Windows port of thread/mutex/chrono - initial review.

2013-10-14 Thread G M
Hi Everyone (esp Nico and pthread users) I've just applied the chrono / thread patch here: http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20131007/090709.html and am offering an initial opinion/review. I haven't yet run the code seriously and looked at in detail but I have at had a

Re: r192644 - PR17567: Improve diagnostic for a mistyped constructor name. If we see something

2013-10-14 Thread Sean Silva
Awesome! Thanks Richard! -- Sean Silva On Mon, Oct 14, 2013 at 8:00 PM, Richard Smith richard-l...@metafoo.co.ukwrote: Author: rsmith Date: Mon Oct 14 19:00:26 2013 New Revision: 192644 URL: http://llvm.org/viewvc/llvm-project?rev=192644view=rev Log: PR17567: Improve diagnostic for a

r192664 - [ms-cxxabi] Fix assert in unspecified inheritance memptr emission

2013-10-14 Thread Reid Kleckner
Author: rnk Date: Mon Oct 14 20:18:02 2013 New Revision: 192664 URL: http://llvm.org/viewvc/llvm-project?rev=192664view=rev Log: [ms-cxxabi] Fix assert in unspecified inheritance memptr emission If a class is using the unspecified inheritance model for member pointers and later we find the class

Re: [cfe-commits] [Patch] Skip attributes

2013-10-14 Thread Richard Smith
Rebased, reworked a little, and submitted as r192666. Thanks! (And sorry for the delay. Ahem.) On Mon, Dec 10, 2012 at 9:50 PM, Michael Han fragmentshad...@gmail.comwrote: Thanks Richard. Patch updated, please take a look. I am not sure of passing Disambiguate = true to

r192666 - Tidy up and improve error recovery for C++11 attributes in bad places. Based on

2013-10-14 Thread Richard Smith
Author: rsmith Date: Mon Oct 14 20:34:54 2013 New Revision: 192666 URL: http://llvm.org/viewvc/llvm-project?rev=192666view=rev Log: Tidy up and improve error recovery for C++11 attributes in bad places. Based on a patch by Michael Han. Modified: cfe/trunk/include/clang/Parse/Parser.h

Re: [PATCH] [libcxx] Windows port of thread/mutex/chrono - initial review.

2013-10-14 Thread David Majnemer
On Monday, October 14, 2013, G M wrote: Hi Everyone (esp Nico and pthread users) I've just applied the chrono / thread patch here: http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20131007/090709.html and am offering an initial opinion/review. I haven't yet run the code seriously

Re: [PATCH] [2/2] Add PRFCHW feature to a few AMD processors

2013-10-14 Thread Yunzhong Gao
ygao added you to the CC list for the revision [2/2] Add PRFCHW feature to a few AMD processors. Hi, This patch enables the 3dNow! prefetch instruction support for a few AMD processors in the clang front end. This change will allow the __PRFCHW__ macro to be set on these processors and hence

Re: [PATCH] ms-compat: Fix taking the address of a member of a dependent base

2013-10-14 Thread Richard Smith
LGTM http://llvm-reviews.chandlerc.com/D1892 BRANCH pr16014 ARCANIST PROJECT clang ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: r192643 - Add has_feature support for reflecting the presence of refined Objective-C ABI mangling for qualified id.... Fixes rdar://problem/14799110.

2013-10-14 Thread Nico Weber
Should this be documented in http://clang.llvm.org/docs/LanguageExtensions.html#objective-c-features ? On Mon, Oct 14, 2013 at 4:48 PM, Ted Kremenek kreme...@apple.com wrote: Author: kremenek Date: Mon Oct 14 18:48:27 2013 New Revision: 192643 URL:

Re: [PATCH] Implement function type checker for the undefined behavior sanitizer.

2013-10-14 Thread Richard Smith
Clever! The approach only makes me feel a //little// uneasy =) It would be polite to issue a diagnostic if someone explicitly asks for this (not via `-fsanitize=undefined`) and we don't support it for their target. Comment at: lib/CodeGen/CGExpr.cpp:3129 @@ +3128,3 @@ +

Re: r192643 - Add has_feature support for reflecting the presence of refined Objective-C ABI mangling for qualified id.... Fixes rdar://problem/14799110.

2013-10-14 Thread Ted Kremenek
Sure. This is to highlight a change introduced a few months ago: Author: efriedma Date: Tue Jun 18 22:41:37 2013 + Introduce a new mangling for protocol-qualified ObjC types in C++. This allows to provide proper overloading, and also prevents mangling conflicts with template

Re: [PATCH] Warning for Out of bound access of Array of Structures/Unions not reported

2013-10-14 Thread Richard Smith
On Tue, Oct 8, 2013 at 6:17 PM, Jordan Rose jordan_r...@apple.com wrote: Richard, I get the feeling that we should have just warned about the out-of-bounds array access before forming the MemberExpr. What do you think? http://llvm-reviews.chandlerc.com/D1580 I'm not really very happy

Re: [PATCH] [2/2] Add PRFCHW feature to a few AMD processors

2013-10-14 Thread Craig Topper
I think based on gcc behavior, def HasPrefetchW : PredicateSubtarget-has3DNow() || Subtarget-hasPRFCHW(); should only be just Subtarget-hasPRFCHW() Then in clang, towards the end of HandleTargetFeatures. Force a +prftchw into the features if 3dnow is enabled and -prftchw was not

r192670 - Document the presence of the new Objective-C++ mangling for qualified-id.

2013-10-14 Thread Ted Kremenek
Author: kremenek Date: Mon Oct 14 23:28:42 2013 New Revision: 192670 URL: http://llvm.org/viewvc/llvm-project?rev=192670view=rev Log: Document the presence of the new Objective-C++ mangling for qualified-id. Modified: cfe/trunk/docs/LanguageExtensions.rst Modified:

Re: [Patch] Unknown-bound array static data member of template shouldd be type dependent

2013-10-14 Thread Richard Smith
The addition of WasIncompleteArray pushes us up to 33 bits in VarDecl, and will cause us to use more memory on 32-bit systems. Do you really need to store this bit? This seems like something that could be reconstructed from the TypeSourceInfo. Instead of setting a flag on the variable, how about

Re: [Patch] Unknown-bound array static data member of template shouldd be type dependent

2013-10-14 Thread Richard Smith
Oh, and please do include a test. Feel free to start a test/CXX/drs/dr4xx.cpp for this. On Mon, Oct 14, 2013 at 9:34 PM, Richard Smith rich...@metafoo.co.ukwrote: The addition of WasIncompleteArray pushes us up to 33 bits in VarDecl, and will cause us to use more memory on 32-bit systems. Do

Re: [PATCH] Attribute parsing following labels

2013-10-14 Thread Richard Smith
+ SourceLocation Loc = Tok.getLocation(); Unused variable. + // If the SubStmt is invalid, we want the attributes to attach to the + // label instead. + if (!SubStmt.isUsable() || SubStmt.isInvalid()) +attrs.takeAllFrom(TempAttrs); I thought your experiments showed

Re: [PATCH] Constant expression evaluation support for __builtin_isinf

2013-10-14 Thread Richard Smith
On Wed, Oct 2, 2013 at 10:42 PM, Karthik Bhat kv.b...@samsung.com wrote: Hi Richard, Added constexpr support for builtin isnan,isfinite and isnormal. Thanks! The test case here is actually to test constexpr support in buitin so i think we cannot put it in

r192671 - Correctly skip type sugar when determining the width of an enum type. Derived

2013-10-14 Thread Richard Smith
Author: rsmith Date: Mon Oct 14 23:56:17 2013 New Revision: 192671 URL: http://llvm.org/viewvc/llvm-project?rev=192671view=rev Log: Correctly skip type sugar when determining the width of an enum type. Derived from a patch by Justin Bogner. Modified: cfe/trunk/lib/AST/ASTContext.cpp

Re: [PATCH] AST: Handle elaborated type in getIntWidth

2013-10-14 Thread Richard Smith
Special-casing ElaboratedType is not the right fix (this is a general problem with any kind of type sugar). Fixed by switching from dyn_cast to Type::getAs in r192671. On Wed, Oct 9, 2013 at 9:58 PM, Justin Bogner m...@justinbogner.com wrote: In getIntWidth we special case enums and boolean

Re: r192594 - Do not use typo correction that is unaccessible.

2013-10-14 Thread Richard Smith
On Mon, Oct 14, 2013 at 7:05 AM, Serge Pavlov sepavl...@gmail.com wrote: Author: sepavloff Date: Mon Oct 14 09:05:48 2013 New Revision: 192594 URL: http://llvm.org/viewvc/llvm-project?rev=192594view=rev Log: Do not use typo correction that is unaccessible. This patch fixes PR17019. When

Re: [PATCH] [2/2] Add PRFCHW feature to a few AMD processors

2013-10-14 Thread Craig Topper
Probably also need to check for hasPRFTCHW here if (Subtarget-hasSSE1()) setOperationAction(ISD::PREFETCH , MVT::Other, Legal); http://llvm-reviews.chandlerc.com/D1934 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu