r219780 - CodeGen: Fix a typo in a comment

2014-10-15 Thread David Majnemer
Author: majnemer Date: Wed Oct 15 02:57:38 2014 New Revision: 219780 URL: http://llvm.org/viewvc/llvm-project?rev=219780view=rev Log: CodeGen: Fix a typo in a comment No functionality change intended. Modified: cfe/trunk/lib/CodeGen/CGRecordLayoutBuilder.cpp Modified:

r219781 - CodeGen: Use the initing member's type for a union's storage type more often

2014-10-15 Thread David Majnemer
Author: majnemer Date: Wed Oct 15 02:57:41 2014 New Revision: 219781 URL: http://llvm.org/viewvc/llvm-project?rev=219781view=rev Log: CodeGen: Use the initing member's type for a union's storage type more often Unions are initialized with the default initialization of their first named member.

Re: [PATCH] Non-POD unions with bit-fields causes an assertion failure at clang/lib/AST/RecordLayoutBuilder.cpp:754

2014-10-15 Thread Alexey Bataev
Comment at: test/Layout/union_regular_bit_field.cpp:1-4 @@ +1,5 @@ +// RUN: %clang_cc1 -emit-llvm-only -triple aarch64 -fdump-record-layouts %s 2/dev/null \ +// RUN:| FileCheck %s +// RUN: %clang_cc1 -emit-llvm-only -triple x86_64 -fdump-record-layouts %s 2/dev/null

Re: [PATCH] Bugfix in template instantiation.

2014-10-15 Thread Alexey Bataev
Completely reworked patch after review. http://reviews.llvm.org/D5769 Files: lib/Sema/TreeTransform.h test/SemaTemplate/instantiate-non-dependent-types.cpp Index: test/SemaTemplate/instantiate-non-dependent-types.cpp === ---

[PATCH] [clang-tidy] Move some of the misc checks to readability/

2014-10-15 Thread Alexander Kornienko
Hi djasper, Some of the misc checks belong to readability/. I'm moving them there without changing check names for now. As the next step, I want to register some of these checks in the google and llvm modules with suitable settings (e.g. BracesAroundStatementsCheck). I'm not sure if we want to

Re: [PATCH] [clang-tidy] Move some of the misc checks to readability/

2014-10-15 Thread Daniel Jasper
Comment at: clang-tidy/misc/CMakeLists.txt:18 @@ -20,2 +17,3 @@ clangTidy + clangTidyReadability ) Hm. I understand that you don't want to create a separate readability at this point. But leave a comment here, otherwise the layering seems quite confusing.

Re: [PATCH] [libcxx] Fix SFINAE in cmath

2014-10-15 Thread Marshall Clow
This looks good to me; thanks. http://reviews.llvm.org/D5710 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] [clang-tidy] Move some of the misc checks to readability/

2014-10-15 Thread Alexander Kornienko
Fixed #endif comments, documented the clangTidyMisc - clangTidyReadability dependency. http://reviews.llvm.org/D5792 Files: clang-tidy/misc/BracesAroundStatementsCheck.cpp clang-tidy/misc/BracesAroundStatementsCheck.h clang-tidy/misc/CMakeLists.txt clang-tidy/misc/FunctionSize.cpp

Re: [PATCH] [clang-tidy] Move some of the misc checks to readability/

2014-10-15 Thread Alexander Kornienko
Comment at: clang-tidy/misc/CMakeLists.txt:18 @@ -20,2 +17,3 @@ clangTidy + clangTidyReadability ) djasper wrote: Hm. I understand that you don't want to create a separate readability at this point. But leave a comment here, otherwise the layering seems

[libcxx] r219785 - Fixes PR21157 'tuple: non-default constructible tuple hard failure' Thanks to Louis Dionne for the bug report and the patch.

2014-10-15 Thread Marshall Clow
Author: marshall Date: Wed Oct 15 05:33:02 2014 New Revision: 219785 URL: http://llvm.org/viewvc/llvm-project?rev=219785view=rev Log: Fixes PR21157 'tuple: non-default constructible tuple hard failure' Thanks to Louis Dionne for the bug report and the patch. Modified:

Re: [PATCH] [clang-tidy] Move some of the misc checks to readability/

2014-10-15 Thread Daniel Jasper
Looks good. http://reviews.llvm.org/D5792 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

[clang-tools-extra] r219786 - [clang-tidy] Move some of the misc checks to readability/

2014-10-15 Thread Alexander Kornienko
Author: alexfh Date: Wed Oct 15 05:51:57 2014 New Revision: 219786 URL: http://llvm.org/viewvc/llvm-project?rev=219786view=rev Log: [clang-tidy] Move some of the misc checks to readability/ Summary: Some of the misc checks belong to readability/. I'm moving them there without changing check

r219787 - Fixed a comment. No functional changes.

2014-10-15 Thread Alexander Kornienko
Author: alexfh Date: Wed Oct 15 06:03:39 2014 New Revision: 219787 URL: http://llvm.org/viewvc/llvm-project?rev=219787view=rev Log: Fixed a comment. No functional changes. Modified: cfe/trunk/include/clang/Tooling/Refactoring.h Modified: cfe/trunk/include/clang/Tooling/Refactoring.h URL:

Re: [PATCH] Speed up hasName() matcher.

2014-10-15 Thread Manuel Klimek
lg http://reviews.llvm.org/D5776 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] specify dwarf version for Solaris

2014-10-15 Thread Alexander Eremin
Hello David, this is probably same issue as here: https://gcc.gnu.org/ml/gcc-patches/2012-05/msg00445.html Without patch: # clang++ -v -o /tmp/test /tmp/test.cpp clang version 3.5.0 (tags/RELEASE_350/final) Target: i386-pc-solaris2.11 Thread model: posix /usr/local/bin/clang -cc1 -triple

[clang-tools-extra] r219788 - Reformatted code samples in the unit test. No functional changes.

2014-10-15 Thread Alexander Kornienko
Author: alexfh Date: Wed Oct 15 06:36:48 2014 New Revision: 219788 URL: http://llvm.org/viewvc/llvm-project?rev=219788view=rev Log: Reformatted code samples in the unit test. No functional changes. Modified: clang-tools-extra/trunk/unittests/clang-tidy/LLVMModuleTest.cpp Modified:

[PATCH] Fix llvm-header-guard check.

2014-10-15 Thread Alexander Kornienko
Hi djasper, This patch makes the check work better for LLVM code: * always fix existing #endif comments * use one space before the comment (+allow customization for other styles) http://reviews.llvm.org/D5795 Files: clang-tidy/utils/HeaderGuard.cpp clang-tidy/utils/HeaderGuard.h

Re: [PATCH] Fix llvm-header-guard check.

2014-10-15 Thread Daniel Jasper
Looks good. http://reviews.llvm.org/D5795 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

[clang-tools-extra] r219789 - Fix llvm-header-guard check.

2014-10-15 Thread Alexander Kornienko
Author: alexfh Date: Wed Oct 15 07:18:35 2014 New Revision: 219789 URL: http://llvm.org/viewvc/llvm-project?rev=219789view=rev Log: Fix llvm-header-guard check. Summary: This patch makes the check work better for LLVM code: * always fix existing #endif comments * use one space before the

[PATCH] [clang-tidy] Default options in modules.

2014-10-15 Thread Alexander Kornienko
Hi djasper, This patch allows modules to specify default options for the checks defined in them. This way a sufficiently configurable check can be registered in multiple modules with different default options. E.g. the SpacesBeforeComments option may be set to 1 for the llvm-namespace-comments

Re: [PATCH] Speed up hasName() matcher.

2014-10-15 Thread Samuel Benzaquen
Closed by commit rL219792 (authored by @sbenza). REPOSITORY rL LLVM http://reviews.llvm.org/D5776 Files: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h cfe/trunk/include/clang/ASTMatchers/ASTMatchersInternal.h cfe/trunk/lib/ASTMatchers/ASTMatchersInternal.cpp Index:

r219792 - Speed up hasName() matcher.

2014-10-15 Thread Samuel Benzaquen
Author: sbenza Date: Wed Oct 15 09:58:46 2014 New Revision: 219792 URL: http://llvm.org/viewvc/llvm-project?rev=219792view=rev Log: Speed up hasName() matcher. Summary: Speed up hasName() matcher by skipping the expensive generation of the fully qualified name unless we need it. In the common

[libclc] r219793 - r600: Use llvm intrinsic to read work dimension information

2014-10-15 Thread Jan Vesely
Author: jvesely Date: Wed Oct 15 10:08:06 2014 New Revision: 219793 URL: http://llvm.org/viewvc/llvm-project?rev=219793view=rev Log: r600: Use llvm intrinsic to read work dimension information v2: Fix function declaration Add range metadata to r600 implementation v3: change prefix to AMDGPU

[PATCH] Fix for PR 21254 - Assertion in the comment parser

2014-10-15 Thread Dario Domizioli
Hello cfe-dev, I have a patch to fix PR 21254 ( http://llvm.org/bugs/show_bug.cgi?id=21254 ). The details of the problem are quite complex and explained in the bugzilla entry, but it all boils down to a bitfield being too narrow. At the moment it is possible that a client of the Clang library

r219794 - [analyzer] Handle 'mingw32-make' in the same way as 'make' and 'gmake'.

2014-10-15 Thread Anton Yartsev
Author: ayartsev Date: Wed Oct 15 10:11:45 2014 New Revision: 219794 URL: http://llvm.org/viewvc/llvm-project?rev=219794view=rev Log: [analyzer] Handle 'mingw32-make' in the same way as 'make' and 'gmake'. Modified: cfe/trunk/tools/scan-build/scan-build Modified:

Re: [PATCH] specify dwarf version for Solaris

2014-10-15 Thread David Blaikie
Sorry, I'm not sure I follow - what I meant is the patch needs (or should have, unless there's a reason this isn't testable, etc) a test case in Clang's regression suite. Probably in clang/test/CodeGen/debug-info-* (you could try removing other targets from that conditional and see which tests

[PATCH] Fix bug in Sema::ActOnGCCAsmStmt (PR21270)

2014-10-15 Thread Akira Hatanaka
The attached patch fixes a bug in Sema::ActOnGCCAsmStmt where it wasn't computing the corresponding ConstraintIdx from an operand number correctly when there were constraints with the '+' modifier. For example, when the following inline-asm statement is compiled, void g2(int one, int two, int

r219795 - Turned Sema::HandleDelayedAvailabilityCheck into a static function; NFC.

2014-10-15 Thread Aaron Ballman
Author: aaronballman Date: Wed Oct 15 10:37:51 2014 New Revision: 219795 URL: http://llvm.org/viewvc/llvm-project?rev=219795view=rev Log: Turned Sema::HandleDelayedAvailabilityCheck into a static function; NFC. Did a bit of drive-by reformatting as well since it required rearranging some other

r219797 - Update for llvm api change.

2014-10-15 Thread Rafael Espindola
Author: rafael Date: Wed Oct 15 10:44:25 2014 New Revision: 219797 URL: http://llvm.org/viewvc/llvm-project?rev=219797view=rev Log: Update for llvm api change. Modified: cfe/trunk/test/Headers/altivec-header.c Modified: cfe/trunk/test/Headers/altivec-header.c URL:

Re: [PATCH] [Proposal] [Analyzer] Individual options for checkers

2014-10-15 Thread Aleksei Sidorin
This is how MallocChecker looks with options used. http://reviews.llvm.org/D3967 Files: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h lib/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/MallocChecker.cpp lib/StaticAnalyzer/Core/AnalyzerOptions.cpp

Re: [PATCH] Fix for PR 21254 - Assertion in the comment parser

2014-10-15 Thread Dmitri Gribenko
On Wed, Oct 15, 2014 at 4:19 PM, Dario Domizioli dario.domizi...@gmail.com wrote: Hello cfe-dev, I have a patch to fix PR 21254 ( http://llvm.org/bugs/show_bug.cgi?id=21254 ). + // We only have a limited number of bits to encode command IDs in the + // CommandInfo structure, so the ID

r219800 - Update for llvm api change.

2014-10-15 Thread Rafael Espindola
Author: rafael Date: Wed Oct 15 11:12:57 2014 New Revision: 219800 URL: http://llvm.org/viewvc/llvm-project?rev=219800view=rev Log: Update for llvm api change. Modified: cfe/trunk/tools/driver/cc1as_main.cpp Modified: cfe/trunk/tools/driver/cc1as_main.cpp URL:

Re: [PATCH] Fix -fdelayed-template-parsing leaks with enableIncrementalProcessing

2014-10-15 Thread Vassil Vassilev
On 14/10/14 20:10, Brad King wrote: On 09/24/2014 03:05 PM, Brad King wrote: On 09/15/2014 02:48 PM, Brad King wrote: On 09/15/2014 02:42 PM, Reid Kleckner wrote: lgtm Thanks. I do not have commit access. Would someone apply, please? Ping. I've confirmed that the patches still work on

Re: [PATCH] Fix bug in Sema::ActOnGCCAsmStmt (PR21270)

2014-10-15 Thread Akira Hatanaka
There were mistakes in my previous email. The correct mapping should be like this: %0 = +r (one) = ConstraintIdx = 0 %1 = +r (two) = ConstraintIdx = 1 %2 = r (three) = ConstraintIdx = 2 %3 = +r (one) = ConstraintIdx = 0 %4 = +r (two) = ConstraintIdx = 1 On Wed, Oct 15, 2014 at 8:36 AM, Akira

r219802 - Fix for PR21254 - Assertion in comment parser

2014-10-15 Thread Dario Domizioli
Author: ddomizioli Date: Wed Oct 15 11:18:20 2014 New Revision: 219802 URL: http://llvm.org/viewvc/llvm-project?rev=219802view=rev Log: Fix for PR21254 - Assertion in comment parser The size of the ID field in CommandInfo was narrow, leading to potential wrap-around of command IDs, causing

r219805 - CodeGen: Cleanup CGRecordLowering::lowerUnion a little

2014-10-15 Thread David Majnemer
Author: majnemer Date: Wed Oct 15 11:36:11 2014 New Revision: 219805 URL: http://llvm.org/viewvc/llvm-project?rev=219805view=rev Log: CodeGen: Cleanup CGRecordLowering::lowerUnion a little Remove some duplicated state, no functionality change intended. Modified:

r219806 - Don't use a global_ctors comdat for globals that aren't externally visible

2014-10-15 Thread Reid Kleckner
Author: rnk Date: Wed Oct 15 11:38:00 2014 New Revision: 219806 URL: http://llvm.org/viewvc/llvm-project?rev=219806view=rev Log: Don't use a global_ctors comdat for globals that aren't externally visible In particular, if you have two identical templates in different TUs in anonymous namespaces,

[PATCH][analyzer] Pass original command line arguments to compilers.

2014-10-15 Thread Anton Yartsev
The goal of the patch is to pass unmodified arguments to compilers as they were written in the makefile. Arguments taken from @ARGV may be modified by the system and Perl, at least quotes and backslash sequences are processed. Using this arguments may cause compiler errors. Sometimes

r219807 - Adding attributes to the IndirectFieldDecl that we generate for anonymous struct/union fields. This fixes PR20930.

2014-10-15 Thread Aaron Ballman
Author: aaronballman Date: Wed Oct 15 11:58:18 2014 New Revision: 219807 URL: http://llvm.org/viewvc/llvm-project?rev=219807view=rev Log: Adding attributes to the IndirectFieldDecl that we generate for anonymous struct/union fields. This fixes PR20930. Modified:

Re: [PATCH] specify dwarf version for Solaris

2014-10-15 Thread Alexander Eremin
Thanks for pointing, this is updated patch. Alex 2014-10-15 19:24 GMT+04:00 David Blaikie dblai...@gmail.com: Sorry, I'm not sure I follow - what I meant is the patch needs (or should have, unless there's a reason this isn't testable, etc) a test case in Clang's regression suite. Probably in

r219809 - [libclang] Add function to retrieve storage class in libclang.

2014-10-15 Thread Argyrios Kyrtzidis
Author: akirtzidis Date: Wed Oct 15 12:05:31 2014 New Revision: 219809 URL: http://llvm.org/viewvc/llvm-project?rev=219809view=rev Log: [libclang] Add function to retrieve storage class in libclang. Patch by guibufolo! Modified: cfe/trunk/bindings/python/clang/cindex.py

Re: [PATCH] Added function to retrieve storage class in libclang.

2014-10-15 Thread Argyrios Kyrtzidis
Committed in r219809, thanks! On Oct 13, 2014, at 5:22 AM, guibufolo+l...@gmail.com wrote: Fixed raised style concerns. http://reviews.llvm.org/D5538 Files: bindings/python/clang/cindex.py include/clang-c/Index.h tools/libclang/CIndex.cpp tools/libclang/libclang.exports

Re: [PATCH] Added function to retrieve storage class in libclang.

2014-10-15 Thread Argyrios Kyrtzidis
Committed in r219809, thanks! http://reviews.llvm.org/D5538 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

r219810 - Fix late template parsing leak with incremental processing

2014-10-15 Thread Reid Kleckner
Author: rnk Date: Wed Oct 15 12:08:33 2014 New Revision: 219810 URL: http://llvm.org/viewvc/llvm-project?rev=219810view=rev Log: Fix late template parsing leak with incremental processing Add a second late template parser callback meant to cleanup any resources allocated by late template

Re: [PATCH/RFC] Fix -fdelayed-template-parsing leaks with enableIncrementalProcessing

2014-10-15 Thread Reid Kleckner
Landed this in r219810, thanks! On Mon, Sep 15, 2014 at 11:48 AM, Brad King brad.k...@kitware.com wrote: On 09/15/2014 02:42 PM, Reid Kleckner wrote: lgtm Thanks. I do not have commit access. Would someone apply, please? +if(LateTemplateParserCleanup) +

Re: [PATCH] specify dwarf version for Solaris

2014-10-15 Thread David Blaikie
LGTM, please commit. (I wouldn't mind it if there were some sense that this was a decision made by the Solaris platform - perhaps you are such a spokesperson for Solaris, but I don't know) On Wed, Oct 15, 2014 at 10:10 AM, Alexander Eremin alexander.r.ere...@gmail.com wrote: Thanks for

r219812 - [analyzer] Perl scripts are run differently from makefiles. Sometimes additional utilities are involved, e.g. 'env' utility that present in MSYS but is missing in MinGW. The patch unifies la

2014-10-15 Thread Anton Yartsev
Author: ayartsev Date: Wed Oct 15 12:13:02 2014 New Revision: 219812 URL: http://llvm.org/viewvc/llvm-project?rev=219812view=rev Log: [analyzer] Perl scripts are run differently from makefiles. Sometimes additional utilities are involved, e.g. 'env' utility that present in MSYS but is missing

r219813 - Revert Fix late template parsing leak with incremental processing

2014-10-15 Thread Reid Kleckner
Author: rnk Date: Wed Oct 15 12:22:56 2014 New Revision: 219813 URL: http://llvm.org/viewvc/llvm-project?rev=219813view=rev Log: Revert Fix late template parsing leak with incremental processing This reverts commit r219810. The test suite appears broken. Modified:

Re: [PATCH/RFC] Fix -fdelayed-template-parsing leaks with enableIncrementalProcessing

2014-10-15 Thread Reid Kleckner
Hrm, this broke some tests, so I rolled it back: http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/17971 On Wed, Oct 15, 2014 at 10:20 AM, Reid Kleckner r...@google.com wrote: Landed this in r219810, thanks! On Mon, Sep 15, 2014 at 11:48 AM, Brad King brad.k...@kitware.com wrote:

Re: [PATCH] Bugfix in template instantiation.

2014-10-15 Thread Richard Smith
Please add tests for the case where the type before the ::~ instantiates as an enum type, in both C++98 and C++11. Otherwise, this looks fine. Thanks! http://reviews.llvm.org/D5769 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

r219818 - Drop unneccessary default case from switch introduced in r219809

2014-10-15 Thread Kaelyn Takata
Author: rikka Date: Wed Oct 15 12:46:18 2014 New Revision: 219818 URL: http://llvm.org/viewvc/llvm-project?rev=219818view=rev Log: Drop unneccessary default case from switch introduced in r219809 This silences: ../tools/clang/tools/libclang/CIndex.cpp:6451:3: warning: default label in switch

Re: r219818 - Drop unneccessary default case from switch introduced in r219809

2014-10-15 Thread David Blaikie
This'll probably end up with a GCC warning about missing return after the switch will probably require an llvm_unreachable be placed after the switch to silence GCC. On Wed, Oct 15, 2014 at 10:46 AM, Kaelyn Takata ri...@google.com wrote: Author: rikka Date: Wed Oct 15 12:46:18 2014 New

r219820 - Add llvm_unreachable after switch to avoid warnings about a missing

2014-10-15 Thread Kaelyn Takata
Author: rikka Date: Wed Oct 15 13:03:26 2014 New Revision: 219820 URL: http://llvm.org/viewvc/llvm-project?rev=219820view=rev Log: Add llvm_unreachable after switch to avoid warnings about a missing return. Forgot to add this in r219818. Modified: cfe/trunk/tools/libclang/CIndex.cpp

Re: r219818 - Drop unneccessary default case from switch introduced in r219809

2014-10-15 Thread Kaelyn Takata
Forgot about that! Added in r219820 On Wed, Oct 15, 2014 at 11:05 AM, David Blaikie dblai...@gmail.com wrote: This'll probably end up with a GCC warning about missing return after the switch will probably require an llvm_unreachable be placed after the switch to silence GCC. On Wed, Oct

Re: [PATCH] Handle use of default member initializers before end of outermost class

2014-10-15 Thread Reid Kleckner
- Adjust wording http://reviews.llvm.org/D5690 Files: include/clang/AST/DeclBase.h include/clang/AST/ExprCXX.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/AST/DeclBase.cpp lib/AST/Expr.cpp lib/Sema/SemaDeclCXX.cpp lib/Sema/SemaInit.cpp

Re: [PATCH] Handle use of default member initializers before end of outermost class

2014-10-15 Thread Reid Kleckner
Comment at: lib/Sema/SemaTemplateInstantiate.cpp:452 @@ +451,3 @@ + } else if (FieldDecl *FD = dyn_castFieldDecl(D)) { +Diags.Report(Active-PointOfInstantiation, + diag::note_template_nsdmi_here) This has created some extra

[PATCH] Do not depend on libclang in unittests if building with --disable-clang-arcmt

2014-10-15 Thread Vassil Vassilev
Hi folks, If ENABLE_CLANG_ARCMT=0 it seems we don't build libclang, so the unittests for libclang should be disabled too. Please review. Cheers, Vassil ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

Re: [PATCH] Do not depend on libclang in unittests if building with --disable-clang-arcmt

2014-10-15 Thread Vassil Vassilev
Forgot to attach the patch I came up with. Vassil On 15/10/14 21:41, Vassil Vassilev wrote: Hi folks, If ENABLE_CLANG_ARCMT=0 it seems we don't build libclang, so the unittests for libclang should be disabled too. Please review. Cheers, Vassil --- tools/clang/unittests/Makefile +++

r219838 - Set ABI and DescriptionString first to reduce OS specific logic.

2014-10-15 Thread Joerg Sonnenberger
Author: joerg Date: Wed Oct 15 14:47:15 2014 New Revision: 219838 URL: http://llvm.org/viewvc/llvm-project?rev=219838view=rev Log: Set ABI and DescriptionString first to reduce OS specific logic. Use switch for FreeBSD check to allow easier extension. Modified:

r219839 - As requested by Matt Thomas, use long long for intmax_t and int64_t on

2014-10-15 Thread Joerg Sonnenberger
Author: joerg Date: Wed Oct 15 14:52:03 2014 New Revision: 219839 URL: http://llvm.org/viewvc/llvm-project?rev=219839view=rev Log: As requested by Matt Thomas, use long long for intmax_t and int64_t on PPC64/NetBSD. Modified: cfe/trunk/lib/Basic/Targets.cpp

[PATCH] Warning on unused results in an unevaluated context

2014-10-15 Thread Aaron Ballman
We currently emit diagnostics warning about unused results while in an unevaluated context. This seems a bit strange to me, since an unevaluated context implies we aren't using *any* results. This patch addresses that by not emitting such diagnostics from an unevaluated context. It also fixes

r219840 - Move SanitizerBlacklist to clangBasic. NFC.

2014-10-15 Thread Alexey Samsonov
Author: samsonov Date: Wed Oct 15 14:57:45 2014 New Revision: 219840 URL: http://llvm.org/viewvc/llvm-project?rev=219840view=rev Log: Move SanitizerBlacklist to clangBasic. NFC. This change moves SanitizerBlacklist.h from lib/CodeGen to public Clang headers in include/clang/Basic.

r219842 - Move -fsanitize-blacklist to LangOpts from CodeGenOpts. NFC.

2014-10-15 Thread Alexey Samsonov
Author: samsonov Date: Wed Oct 15 15:22:54 2014 New Revision: 219842 URL: http://llvm.org/viewvc/llvm-project?rev=219842view=rev Log: Move -fsanitize-blacklist to LangOpts from CodeGenOpts. NFC. After http://reviews.llvm.org/D5687 is submitted, we will need SanitizerBlacklist before the CodeGen

Re: [PATCH] Insert poisoned paddings between fields in C++ classes.

2014-10-15 Thread Alexey Samsonov
Comment at: lib/AST/RecordLayoutBuilder.cpp:1369-1379 @@ +1368,13 @@ + + // FIXME (before commit): where should this SpecialCaseList reside? + // In RecordLayoutBuilder? In global scope? + // Also, can we reuse the existing -fsanitize-blacklist flag to pass + // the file path

Re: [PATCH] autoconf: Build libClang-Version.so with --enable-shared

2014-10-15 Thread Eric Christopher
No real objections, appears to be a bit of cut and paste from somewhere? -eric On Thu, Sep 18, 2014 at 6:07 PM, Tom Stellard thomas.stell...@amd.com wrote: This patch just adds support for building and installing the shared library. All the tools still link against the static libraries. ---

r219849 - Change hasName() to take const std::string, as it was taking before rL219792.

2014-10-15 Thread Samuel Benzaquen
Author: sbenza Date: Wed Oct 15 16:23:31 2014 New Revision: 219849 URL: http://llvm.org/viewvc/llvm-project?rev=219849view=rev Log: Change hasName() to take const std::string, as it was taking before rL219792. Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h Modified:

r219850 - test: simplify test further

2014-10-15 Thread Saleem Abdulrasool
Author: compnerd Date: Wed Oct 15 16:37:52 2014 New Revision: 219850 URL: http://llvm.org/viewvc/llvm-project?rev=219850view=rev Log: test: simplify test further Remove the use of an unnecessary function. NFC. Modified: cfe/trunk/test/CodeGen/mangle-blocks.c Modified:

r219851 - Sema: handle AttributedTypeLocs in C++14 auto deduction

2014-10-15 Thread Saleem Abdulrasool
Author: compnerd Date: Wed Oct 15 16:37:55 2014 New Revision: 219851 URL: http://llvm.org/viewvc/llvm-project?rev=219851view=rev Log: Sema: handle AttributedTypeLocs in C++14 auto deduction When performing a type deduction from the return type, the FunctionDecl may be attributed with a calling

Re: r219851 - Sema: handle AttributedTypeLocs in C++14 auto deduction

2014-10-15 Thread Richard Smith
On Wed, Oct 15, 2014 at 2:37 PM, Saleem Abdulrasool compn...@compnerd.org wrote: Author: compnerd Date: Wed Oct 15 16:37:55 2014 New Revision: 219851 URL: http://llvm.org/viewvc/llvm-project?rev=219851view=rev Log: Sema: handle AttributedTypeLocs in C++14 auto deduction When performing a

r219855 - Avoid having using namespace for both clang and llvm namespaces.

2014-10-15 Thread Alexey Samsonov
Author: samsonov Date: Wed Oct 15 17:00:40 2014 New Revision: 219855 URL: http://llvm.org/viewvc/llvm-project?rev=219855view=rev Log: Avoid having using namespace for both clang and llvm namespaces. This is fragile, as there are classes with the same name in both namespaces (e.g. llvm::Module and

[clang-tools-extra] r219855 - Avoid having using namespace for both clang and llvm namespaces.

2014-10-15 Thread Alexey Samsonov
Author: samsonov Date: Wed Oct 15 17:00:40 2014 New Revision: 219855 URL: http://llvm.org/viewvc/llvm-project?rev=219855view=rev Log: Avoid having using namespace for both clang and llvm namespaces. This is fragile, as there are classes with the same name in both namespaces (e.g. llvm::Module and

[PATCH] libclang.dll compat with Borland compilers

2014-10-15 Thread Stephen Fewer
Hi, This patch adds compatibility for using libclang.dll built with MSVC in Borland compiled code (C++ Builder). The 32bit Borland compiler returns structures 4 bytes and 9 bytes using a different ABI than MSVC emits, so to workaround this you must use a Borland specific keyword __msreturn as

r219857 - Move SanitizerBlacklist object from CodeGenModule to ASTContext.

2014-10-15 Thread Alexey Samsonov
Author: samsonov Date: Wed Oct 15 17:17:27 2014 New Revision: 219857 URL: http://llvm.org/viewvc/llvm-project?rev=219857view=rev Log: Move SanitizerBlacklist object from CodeGenModule to ASTContext. Soon we'll need to have access to blacklist before the CodeGen phase (see

[PATCH] Add frontend support for __vectorcall

2014-10-15 Thread Reid Kleckner
Hi rsmith, majnemer, Wire it through everywhere we have support for fastcall, essentially. This allows us to parse the MSVC 14 CTP headers, but we will miscompile them because LLVM doesn't support __vectorcall yet. http://reviews.llvm.org/D5808 Files: include/clang-c/Index.h

r219859 - CodeGen: Don't drop thread_local when emitting __thread aliases

2014-10-15 Thread David Majnemer
Author: majnemer Date: Wed Oct 15 17:38:23 2014 New Revision: 219859 URL: http://llvm.org/viewvc/llvm-project?rev=219859view=rev Log: CodeGen: Don't drop thread_local when emitting __thread aliases CodeGen wouldn't mark the aliasee as thread_local if the aliasee was a tentative definition. Even

Re: [PATCH] libclang.dll compat with Borland compilers

2014-10-15 Thread Reid Kleckner
IIRC GCC and MSVC also disagree about how to pass and return structures by value. Maybe libclang should not be returning structures by value instead? On Wed, Oct 15, 2014 at 3:23 PM, Stephen Fewer stephen_fe...@harmonysecurity.com wrote: Hi, This patch adds compatibility for using

Re: [PATCH] Add frontend support for __vectorcall

2014-10-15 Thread Richard Smith
Comment at: lib/CodeGen/CGCall.cpp:50-51 @@ -49,2 +49,4 @@ case CC_IntelOclBicc: return llvm::CallingConv::Intel_OCL_BI; // TODO: add support for CC_X86Pascal to llvm + // TODO: Add support for __vectorcall to LLVM. + case CC_X86VectorCall: return llvm::CallingConv::C;

r219877 - Moving CGF::EmitAlignmentAssumption to IRBuilder

2014-10-15 Thread Hal Finkel
Author: hfinkel Date: Wed Oct 15 18:45:08 2014 New Revision: 219877 URL: http://llvm.org/viewvc/llvm-project?rev=219877view=rev Log: Moving CGF::EmitAlignmentAssumption to IRBuilder The functionality contained in CodeGenFunction::EmitAlignmentAssumption has been moved to IRBuilder (so that it

Re: [PATCH] Insert poisoned paddings between fields in C++ classes.

2014-10-15 Thread Kostya Serebryany
Use proper blacklist machinery. PTAL http://reviews.llvm.org/D5687 Files: include/clang/AST/Decl.h include/clang/Basic/DiagnosticFrontendKinds.td include/clang/Basic/DiagnosticGroups.td include/clang/Basic/SanitizerBlacklist.h lib/AST/Decl.cpp lib/AST/RecordLayoutBuilder.cpp

r219880 - [CMake] clangBasic: Add Core to LINK_COMPONENTS introduced by r219840.

2014-10-15 Thread NAKAMURA Takumi
Author: chapuni Date: Wed Oct 15 19:12:02 2014 New Revision: 219880 URL: http://llvm.org/viewvc/llvm-project?rev=219880view=rev Log: [CMake] clangBasic: Add Core to LINK_COMPONENTS introduced by r219840. Modified: cfe/trunk/lib/Basic/CMakeLists.txt Modified:

Re: [PATCH] libclang.dll compat with Borland compilers

2014-10-15 Thread Argyrios Kyrtzidis
On Oct 15, 2014, at 3:23 PM, Stephen Fewer stephen_fe...@harmonysecurity.com wrote: Hi, This patch adds compatibility for using libclang.dll built with MSVC in Borland compiled code (C++ Builder). The 32bit Borland compiler returns structures 4 bytes and 9 bytes using a different ABI

r219883 - DebugInfo: Cleanup testing of non-type template parameters.

2014-10-15 Thread David Blaikie
Author: dblaikie Date: Wed Oct 15 19:41:40 2014 New Revision: 219883 URL: http://llvm.org/viewvc/llvm-project?rev=219883view=rev Log: DebugInfo: Cleanup testing of non-type template parameters. Separate out the non-nullable parameters from the nullable ones (currently only the template template

[PATCH] Adding ID and Warning Option to Diagnostic Log

2014-10-15 Thread Steven Wu
Hi This patch adds two more fields to diagnostic log (not serialize-diagnostic). The two new fields are DiagnosticID and Warning Option. I find them very handy in detecting and categorizing diagnostics. The added fields are in a dict type in a plist so it is unlikely to break any existing

Re: [PATCH] Insert poisoned paddings between fields in C++ classes.

2014-10-15 Thread Alexey Samsonov
Comment at: lib/AST/Decl.cpp:3642 @@ +3641,3 @@ +ReasonToReject = standard layout; + else if (II Blacklist.isBlacklistedType(II-getName(), field-padding)) +ReasonToReject = blacklisted by type; This looks weird: II-getName() is neither mangled nor

Re: [PATCH] Handle use of default member initializers before end of outermost class

2014-10-15 Thread Reid Kleckner
- wording tweak http://reviews.llvm.org/D5690 Files: include/clang/AST/DeclBase.h include/clang/AST/ExprCXX.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/AST/DeclBase.cpp lib/AST/Expr.cpp lib/Sema/SemaDeclCXX.cpp lib/Sema/SemaInit.cpp

Re: r219883 - DebugInfo: Cleanup testing of non-type template parameters.

2014-10-15 Thread Frédéric Riss
On 15 Oct 2014, at 17:41, David Blaikie dblai...@gmail.com wrote: Author: dblaikie Date: Wed Oct 15 19:41:40 2014 New Revision: 219883 URL: http://llvm.org/viewvc/llvm-project?rev=219883view=rev http://llvm.org/viewvc/llvm-project?rev=219883view=rev Log: DebugInfo: Cleanup testing of

[PATCH] MS Compat: mark globals emitted in read-only sections const

2014-10-15 Thread Hans Wennborg
Hi majnemer, rnk, They cannot be written to, so marking them const makes sense and may improve optimisation. The actual motivation for doing this is to fix this kind of link error when compiling ATL: warning LNK4254: section 'ATL' (C040) merged into '.rdata' (4040) with different

Re: [PATCH] Insert poisoned paddings between fields in C++ classes.

2014-10-15 Thread Richard Smith
Comment at: include/clang/AST/Decl.h:3266 @@ -3265,1 +3265,3 @@ + /// MayInsertExtraPadding -- Whether we are allowed to insert extra padding + /// between fields. These padding are added to help AddressSanitizer detect In new code, please use `\brief` instead

Re: [PATCH] Warning on unused results in an unevaluated context

2014-10-15 Thread Richard Smith
Does this still warn on cases like: typeid(f(), g()); where we don't know we've got an evaluated operand until after we've finished parsing it? ... Hmm, we don't seem to get any warning on that case right now. =( Might be worth someone looking into that, maybe there are other cases we're

[libcxx] r219894 - Add my buildbot to list of libc++ buildbots in documentation

2014-10-15 Thread Eric Fiselier
Author: ericwf Date: Wed Oct 15 21:48:59 2014 New Revision: 219894 URL: http://llvm.org/viewvc/llvm-project?rev=219894view=rev Log: Add my buildbot to list of libc++ buildbots in documentation Modified: libcxx/trunk/www/index.html Modified: libcxx/trunk/www/index.html URL:

Re: [libcxx] r219894 - Add my buildbot to list of libc++ buildbots in documentation

2014-10-15 Thread Richard Smith
On Wed, Oct 15, 2014 at 7:48 PM, Eric Fiselier e...@efcs.ca wrote: Author: ericwf Date: Wed Oct 15 21:48:59 2014 New Revision: 219894 URL: http://llvm.org/viewvc/llvm-project?rev=219894view=rev Log: Add my buildbot to list of libc++ buildbots in documentation Modified:

r219897 - Bugfix in template instantiation in CXXPseudoDestructorExpr.

2014-10-15 Thread Alexey Bataev
Author: abataev Date: Wed Oct 15 22:04:35 2014 New Revision: 219897 URL: http://llvm.org/viewvc/llvm-project?rev=219897view=rev Log: Bugfix in template instantiation in CXXPseudoDestructorExpr. Fix for clang crash when instantiating a template with qualified lookup for members in non-class

Re: [PATCH] Bugfix in template instantiation.

2014-10-15 Thread Alexey Bataev
Closed by commit rL219897 (authored by @ABataev). REPOSITORY rL LLVM http://reviews.llvm.org/D5769 Files: cfe/trunk/lib/Sema/TreeTransform.h cfe/trunk/test/SemaTemplate/instantiate-non-dependent-types.cpp Index: cfe/trunk/test/SemaTemplate/instantiate-non-dependent-types.cpp

[libcxx] r219898 - Fix bad link in documentation. Thanks to rsmith

2014-10-15 Thread Eric Fiselier
Author: ericwf Date: Wed Oct 15 22:15:31 2014 New Revision: 219898 URL: http://llvm.org/viewvc/llvm-project?rev=219898view=rev Log: Fix bad link in documentation. Thanks to rsmith Modified: libcxx/trunk/www/index.html Modified: libcxx/trunk/www/index.html URL:

Re: [PATCH] Adding 4 ASTMatchers: typedefDecl, isInMainFile, isInSystemFile, isInFileMatchingName

2014-10-15 Thread Hendrik von Prince
! In D4283#15, @klimek wrote: Is this still ongoing? Yes! I'm sorry i didn't react on this for so long, i am currently updating the patch according to the reviews (thanks by the way!) http://reviews.llvm.org/D4283 ___ cfe-commits mailing list

r219900 - PR21246: DebugInfo: Emit the appropriate type (cv qualifiers, reference-ness, etc) for non-type template parameters

2014-10-15 Thread David Blaikie
Author: dblaikie Date: Wed Oct 15 23:21:25 2014 New Revision: 219900 URL: http://llvm.org/viewvc/llvm-project?rev=219900view=rev Log: PR21246: DebugInfo: Emit the appropriate type (cv qualifiers, reference-ness, etc) for non-type template parameters Plumb through the full QualType of the

Re: [PATCH] [libcxx] Add support for building and testing with an ABI library not along linker paths

2014-10-15 Thread Eric Fiselier
Update and merge the patch with changes already upstream. http://reviews.llvm.org/D5038 Files: CMakeLists.txt cmake/Modules/HandleLibCXXABI.cmake test/lit.cfg test/lit.site.cfg.in www/index.html Index: CMakeLists.txt ===