jvoung accepted this revision.
jvoung added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D11271
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
LGTM
http://reviews.llvm.org/D10701
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Comment at: lib/CodeGen/TargetInfo.cpp:2501
@@ -2500,3 +2500,3 @@
if (HiStart != 8) {
// There are only two sorts of types the ABI generation code can produce
for
// the low part of a pair that aren't 8 bytes in size: float or i8/i16/i32.
For the old
otherwise LGTM
a little sad that a bunch of tools have to duplicate the // Silence warning
for clang -g foo.o -o foo stuff... =/
Comment at: lib/Driver/ToolChains.cpp:2447
@@ +2446,3 @@
+ TheTriple.getEnvironment() == llvm::Triple::UnknownEnvironment)
+
Comment at: lib/Basic/Targets.cpp:3897
@@ -3896,1 +3896,3 @@
+ assert(!BigEndian NaCl on ARM does not support big endian);
+ DescriptionString = e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S128;
} else {
BTW, for the description string there was
LGTM thanks
http://reviews.llvm.org/D7416
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
LGTM
http://reviews.llvm.org/D7234
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Comment at: lib/CodeGen/TargetInfo.cpp:5061
@@ -5075,3 +5060,3 @@
public:
NaClARMTargetCodeGenInfo(CodeGen::CodeGenTypes CGT, ARMABIInfo::ABIKind
Kind)
: TargetCodeGenInfo(new ARMABIInfo(CGT, Kind)) {}
Can the ARM one be removed too?
Closed by commit rL218889 (authored by @jvoung).
REPOSITORY
rL LLVM
http://reviews.llvm.org/D
Files:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
cfe/trunk/test/CodeGenCXX/x86_64-arguments-nacl-x32.cpp
cfe/trunk/test/CodeGenCXX/x86_64-arguments.cpp
Index:
Give test struct a better name.
http://reviews.llvm.org/D
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGenCXX/x86_64-arguments-nacl-x32.cpp
test/CodeGenCXX/x86_64-arguments.cpp
Index: lib/CodeGen/TargetInfo.cpp
===
---
Hi dschuff,
Set NaCl OSTargetInfo to have LongLongAlign = 64. Otherwise, it will pick up
the setting of 32 from X86_32TargetInfo.
http://llvm-reviews.chandlerc.com/D2544
Files:
lib/Basic/Targets.cpp
test/CodeGen/malign-double-x86-nacl.c
Index: lib/Basic/Targets.cpp
at 1:15 PM, Chris Lattner clatt...@apple.com wrote:
On Mar 1, 2013, at 3:35 PM, Jan Voung jvo...@chromium.org wrote:
Statistics are still available in Release+Asserts (or any +Asserts builds),
and they can also be turned on with LLVM_ENABLE_STATS.
Also change some of the FastISel stats
Ah, I didn't know there was a REQUIRES: asserts. I can revert the test
moves and do that instead.
On Fri, Mar 8, 2013 at 3:33 PM, Chandler Carruth chandl...@google.comwrote:
On Fri, Mar 8, 2013 at 2:42 PM, Jan Wen Voung jvo...@google.com wrote:
Author: jvoung
Date: Fri Mar 8 16:42:02 2013
Here is the patch for moving back the clang tests, and using REQUIRES:
asserts.
On Fri, Mar 8, 2013 at 3:46 PM, Jan Voung jvo...@google.com wrote:
Ah, I didn't know there was a REQUIRES: asserts. I can revert the test
moves and do that instead.
On Fri, Mar 8, 2013 at 3:33 PM, Chandler
Attached is a creduce'd test case which compiles without any clang errors,
but would have broken the assertion that lock_hack == 0 that was
in Robert's patch. Well, I changed it to a print and grepped for the print
so that it wouldn't crash clang before clang had a chance to print other
errors.
On Thu, Oct 18, 2012 at 1:20 PM, David Blaikie dblai...@gmail.com wrote:
On Thu, Oct 18, 2012 at 1:15 PM, Jan Voung jvo...@chromium.org wrote:
Attached is a creduce'd test case which compiles without any clang
errors,
but would have broken the assertion that lock_hack == 0
On Thu, Oct 18, 2012 at 2:24 PM, David Blaikie dblai...@gmail.com wrote:
On Thu, Oct 18, 2012 at 2:07 PM, Jan Voung jvo...@chromium.org wrote:
On Thu, Oct 18, 2012 at 1:20 PM, David Blaikie dblai...@gmail.com
wrote:
On Thu, Oct 18, 2012 at 1:15 PM, Jan Voung jvo...@chromium.org wrote
17 matches
Mail list logo
