Re: [PATCH] Qt Creator help/documentation file for Clang

2014-03-11 Thread Michael Gottesman
Alright sounds good to me. http://llvm-reviews.chandlerc.com/D2965 BRANCH master ARCANIST PROJECT clang ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] Qt Creator help/documentation file for Clang

2014-03-10 Thread Michael Gottesman
One question, otherwise this looks fine to me. I defer of course to other gribozavr if he has any opinions. Comment at: docs/CMakeLists.txt:29 @@ +28,3 @@ + Filename of the Qt Compressed help file) +set(CLANG_DOXYGEN_QHP_NAMESPACE org.llvm.clang CACHE STRING +

Re: [PATCH] Only allow builtin/runtime builtins to be forgotten upon seeing a declaration with the same name.

2013-11-01 Thread Michael Gottesman
another patch. Michael On Oct 31, 2013, at 5:08 PM, Richard Smith rich...@metafoo.co.uk wrote: On Thu, Oct 31, 2013 at 4:27 PM, Michael Gottesman mgottes...@apple.com wrote: Hey dgregor! The attached patch ensures that clang only allows the user to respecify declarations for library

[PATCH] Only allow builtin/runtime builtins to be forgotten upon seeing a declaration with the same name.

2013-10-31 Thread Michael Gottesman
Hey dgregor! The attached patch ensures that clang only allows the user to respecify declarations for library/runtime builtins instead of generic builtins. Background: In r122351, clang began to allow users to override the prototype of builtins if the user declared a function with the same

Re: [llvm] r193350 - Reverting my r193344 checkin due to build breakage.

2013-10-31 Thread Michael Gottesman
We do use it internally and can not remove the dependency. Michael On Oct 24, 2013, at 12:27 PM, Michael Gottesman mgottes...@apple.com wrote: The reason why we are building it in phase 1 is we build it so internally. Let me chat with Bob. Michael On Oct 24, 2013, at 11:29 AM, Argyrios

Re: [llvm] r193350 - Reverting my r193344 checkin due to build breakage.

2013-10-24 Thread Michael Gottesman
The reason why we are building it in phase 1 is we build it so internally. Let me chat with Bob. Michael On Oct 24, 2013, at 11:29 AM, Argyrios Kyrtzidis kyrtzi...@apple.com wrote: On Oct 24, 2013, at 11:28 AM, Chandler Carruth chandl...@google.com wrote: On Thu, Oct 24, 2013 at 11:25

Re: [PATCH] [ARMv8] Add NEON intrinsics

2013-09-11 Thread Michael Gottesman
LGTM. Comment at: utils/TableGen/NeonEmitter.cpp:2825 @@ -2824,3 +2845,1 @@ - - genTargetTest(OS, EmittedMap, true); } Joey Gouly wrote: I didn't remove this, since I just disabled AArch64 for now, didn't remove it entirely. I'm hoping Ana/Hao/Kevin/Chad

Re: [PATCH] [ARMv8] Add NEON intrinsics

2013-09-10 Thread Michael Gottesman
Some nits + substantive questions. Comment at: utils/TableGen/NeonEmitter.cpp:2662 @@ -2656,3 +2661,3 @@ bool isShift, bool isHiddenLOp, - ClassKind ck, const std::string InstName, + ClassKind ck,

[libcxx] r189739 - [cmake] Provide an option to not install the support headers so that the cmake build can match the make build if requested.

2013-09-02 Thread Michael Gottesman
Author: mgottesman Date: Mon Sep 2 02:28:05 2013 New Revision: 189739 URL: http://llvm.org/viewvc/llvm-project?rev=189739view=rev Log: [cmake] Provide an option to not install the support headers so that the cmake build can match the make build if requested. Modified:

[libcxx] r189738 - [cmake] Make libcxx standalone compile on Mac OS X.

2013-09-02 Thread Michael Gottesman
Author: mgottesman Date: Mon Sep 2 02:28:03 2013 New Revision: 189738 URL: http://llvm.org/viewvc/llvm-project?rev=189738view=rev Log: [cmake] Make libcxx standalone compile on Mac OS X. Modified: libcxx/trunk/lib/CMakeLists.txt Modified: libcxx/trunk/lib/CMakeLists.txt URL:

Re: [clang-tools-extra] r189691 - cpp11-migrate: Fixing autoconf build after adding libclangReplace dependency

2013-08-30 Thread Michael Gottesman
Reverted this and the commit this was a follow up to (r189689) in revision r189700. This was because since the original commit broke the OS X phase 1 build for ~2 hours. See my response to commit r189689 for details. Michael On Aug 30, 2013, at 12:45 PM, Edwin Vane edwin.v...@intel.com wrote:

r189508 - [doxygen] Added code for generating doxygen documentation for clang for cmake.

2013-08-28 Thread Michael Gottesman
Author: mgottesman Date: Wed Aug 28 15:29:40 2013 New Revision: 189508 URL: http://llvm.org/viewvc/llvm-project?rev=189508view=rev Log: [doxygen] Added code for generating doxygen documentation for clang for cmake. Added: cfe/trunk/docs/CMakeLists.txt Modified: cfe/trunk/CMakeLists.txt

r189509 - [doxygen] Added support for doxygen external search.

2013-08-28 Thread Michael Gottesman
Author: mgottesman Date: Wed Aug 28 15:29:44 2013 New Revision: 189509 URL: http://llvm.org/viewvc/llvm-project?rev=189509view=rev Log: [doxygen] Added support for doxygen external search. Modified: cfe/trunk/docs/CMakeLists.txt cfe/trunk/docs/Makefile cfe/trunk/docs/doxygen.cfg.in

r189523 - [doxygen] Add a few missing variables to the doxygen.cfg.in for external search and cleaned up external_search_map.

2013-08-28 Thread Michael Gottesman
Author: mgottesman Date: Wed Aug 28 16:55:41 2013 New Revision: 189523 URL: http://llvm.org/viewvc/llvm-project?rev=189523view=rev Log: [doxygen] Add a few missing variables to the doxygen.cfg.in for external search and cleaned up external_search_map. Modified: cfe/trunk/docs/CMakeLists.txt

r189311 - Use set to create CLANG_ORDER_FILE instead of option which implies a bool value.

2013-08-26 Thread Michael Gottesman
Author: mgottesman Date: Mon Aug 26 23:40:12 2013 New Revision: 189311 URL: http://llvm.org/viewvc/llvm-project?rev=189311view=rev Log: Use set to create CLANG_ORDER_FILE instead of option which implies a bool value. Patch by Edoardo P. ed0.88.p...@gmail.com. Modified:

Re: [PATCH] Fix r188763 - CLANG_ORDER_FILE defined as a BOOL instead as a STRING

2013-08-26 Thread Michael Gottesman
Committed in r189311. Thanks! On Aug 26, 2013, at 6:41 PM, Edoardo P. ed0.88.p...@gmail.com wrote: Yes, please. 2013/8/27 Jordan Rose jordan_r...@apple.com Looks good to me. Do you need someone to commit for you? Jordan On Aug 26, 2013, at 12:29 , Edoardo P. ed0.88.p...@gmail.com

r188760 - [autotools-cmake] Move add_subdirectory(test) inside CLANG_INCLUDE_TESTS to match the behavior of the LLVM where LLVM_INCLUDE_TESTS controls whether tests is included.

2013-08-20 Thread Michael Gottesman
Author: mgottesman Date: Tue Aug 20 02:09:54 2013 New Revision: 188760 URL: http://llvm.org/viewvc/llvm-project?rev=188760view=rev Log: [autotools-cmake] Move add_subdirectory(test) inside CLANG_INCLUDE_TESTS to match the behavior of the LLVM where LLVM_INCLUDE_TESTS controls whether tests is

r188759 - [autotools-cmake] Added support for creating the clang driver plist for OS X.

2013-08-20 Thread Michael Gottesman
Author: mgottesman Date: Tue Aug 20 02:09:51 2013 New Revision: 188759 URL: http://llvm.org/viewvc/llvm-project?rev=188759view=rev Log: [autotools-cmake] Added support for creating the clang driver plist for OS X. Modified: cfe/trunk/tools/driver/CMakeLists.txt Modified:

r188763 - [autotools-cmake] Added support for building clang with an order file.

2013-08-20 Thread Michael Gottesman
Author: mgottesman Date: Tue Aug 20 02:41:18 2013 New Revision: 188763 URL: http://llvm.org/viewvc/llvm-project?rev=188763view=rev Log: [autotools-cmake] Added support for building clang with an order file. Modified: cfe/trunk/CMakeLists.txt cfe/trunk/tools/driver/CMakeLists.txt

r188687 - Revert Revert Revert DebugInfo: Omit debug info for dynamic classes in TUs that do not have the vtable for that class

2013-08-19 Thread Michael Gottesman
Author: mgottesman Date: Mon Aug 19 13:46:16 2013 New Revision: 188687 URL: http://llvm.org/viewvc/llvm-project?rev=188687view=rev Log: Revert Revert Revert DebugInfo: Omit debug info for dynamic classes in TUs that do not have the vtable for that class This reverts commit r188642. This change

Re: r188642 - Revert Revert DebugInfo: Omit debug info for dynamic classes in TUs that do not have the vtable for that class

2013-08-19 Thread Michael Gottesman
Hey Dave! This causes our LTO builders to blow up due to use of too much memory (i.e. out of swap). This has been messing with our builders all weekend so I am going to revert now. Can you work with me on IRC to resolve the issue? Michael On Aug 18, 2013, at 10:59 AM, David Blaikie

Re: r188722 - Simplify code by using CreateMemTemp. No functional change intended.

2013-08-19 Thread Michael Gottesman
I believe this broke the public llvm builder: http://lab.llvm.org:8013/builders/phase1%20-%20sanity/builds/10418 Can you fix/revert. Michael On Aug 19, 2013, at 3:20 PM, Juergen Ributzka juer...@apple.com wrote: Author: ributzka Date: Mon Aug 19 17:20:37 2013 New Revision: 188722 URL:

Re: r188739 - Revert Revert Revert Revert DebugInfo: Omit debug info for dynamic classes in TUs that do not have the vtable for that class

2013-08-19 Thread Michael Gottesman
coverage fix for -gline-tables-only. Thanks Michael Gottesman for reverting this patch when it demonstrated problems providing a reproduction/details to help me track this down. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/lib/CodeGen/CGDebugInfo.h cfe/trunk/lib

r188479 - [autotools-cmake] Added variable CLANG_VENDOR_UTI.

2013-08-15 Thread Michael Gottesman
Author: mgottesman Date: Thu Aug 15 14:22:36 2013 New Revision: 188479 URL: http://llvm.org/viewvc/llvm-project?rev=188479view=rev Log: [autotools-cmake] Added variable CLANG_VENDOR_UTI. Modified: cfe/trunk/CMakeLists.txt Modified: cfe/trunk/CMakeLists.txt URL:

r188478 - [autotools-cmake] Added CMake support for the preprocessor variable CLANG_REPOSITORY_STRING.

2013-08-15 Thread Michael Gottesman
Author: mgottesman Date: Thu Aug 15 14:22:33 2013 New Revision: 188478 URL: http://llvm.org/viewvc/llvm-project?rev=188478view=rev Log: [autotools-cmake] Added CMake support for the preprocessor variable CLANG_REPOSITORY_STRING. This is a patch in a longer series of patches to add

Re: [libc++][patch] Fix a lit.cfg bug: the CMake build compiler is ignored

2013-07-29 Thread Michael Gottesman
Hey Sebastian. Your patch looks fine to me except that you should indent in the inferring section so it looks more like this: if cxx_under_test is None: cxx_under_test = getattr(config, 'cxx_under_test', None) -- Indent more in starting here +if cxx_under_test is None: # If no

Re: [libc++][patch] Fix a lit.cfg bug: the CMake build compiler is ignored

2013-07-29 Thread Michael Gottesman
Ok. I think you should make the change given that the checks around it follow that convention (see libcxx_src_root, libcxx_obj_root, etc). Once that is fixed, LGTM. Michael On Jul 29, 2013, at 4:05 PM, Sebastian Redl sebastian.r...@getdesigned.at wrote: On 29.07.2013, at 21:58, Michael

[clang-tools-extra] r186873 - Revert cp11-migrate: Integration with LibFormat

2013-07-22 Thread Michael Gottesman
Author: mgottesman Date: Mon Jul 22 16:03:56 2013 New Revision: 186873 URL: http://llvm.org/viewvc/llvm-project?rev=186873view=rev Log: Revert cp11-migrate: Integration with LibFormat This reverts commit r186866. This breaks the build and the original author Guillaume Papin

Re: [clang-tools-extra] r186866 - cp11-migrate: Integration with LibFormat

2013-07-22 Thread Michael Gottesman
This breaks the build so Guillaume asked me to revert until you guys could look at it again tomorrow. Reverted in r186873. On Jul 22, 2013, at 1:26 PM, Edwin Vane edwin.v...@intel.com wrote: Guillaume Papin guillaume.pa...@epitech.eu ___

Re: r185229 - PR7927, PR16247: Reimplement handling of matching extern C declarations

2013-06-29 Thread Michael Gottesman
I am seeing a similar issue on Darwin with a bunch of programs in the test-suite (for example Shootout-C++/heapsort.cpp). Michael On Jun 29, 2013, at 1:36 AM, Timur Iskhodzhanov timur...@google.com wrote: Hi Richard, This has broken compilation of windows.h: C:\Program Files

Re: r184787 - Added arm_neon intrinsic tests.

2013-06-27 Thread Michael Gottesman
I just checked and it passed for me on x86-64 mac os x and linux. I think maybe the failure you were seeing was due to the bug Bob fixed in r184870 (which were caught by these tests as you saw = p). Like you suggested I am going to revert your revert and see if the issue is fixed. Thanks

Re: r184787 - Added arm_neon intrinsic tests.

2013-06-27 Thread Michael Gottesman
Recommitted in r185110. On Jun 27, 2013, at 2:50 PM, Michael Gottesman mgottes...@apple.com wrote: I just checked and it passed for me on x86-64 mac os x and linux. I think maybe the failure you were seeing was due to the bug Bob fixed in r184870 (which were caught by these tests as you

r184785 - [NeonIntrinsicTestEmitter] Fix incorrect FileCheck pattern where we were expecting a ', ' prefix to alignment hints.

2013-06-24 Thread Michael Gottesman
Author: mgottesman Date: Mon Jun 24 16:25:37 2013 New Revision: 184785 URL: http://llvm.org/viewvc/llvm-project?rev=184785view=rev Log: [NeonIntrinsicTestEmitter] Fix incorrect FileCheck pattern where we were expecting a ',' prefix to alignment hints. Modified:

r184784 - [NeonIntrinsicTestEmitter] Add requirement to arm neon intrinsic tests for the feature long_tests.

2013-06-24 Thread Michael Gottesman
Author: mgottesman Date: Mon Jun 24 16:25:34 2013 New Revision: 184784 URL: http://llvm.org/viewvc/llvm-project?rev=184784view=rev Log: [NeonIntrinsicTestEmitter] Add requirement to arm neon intrinsic tests for the feature long_tests. This will prevent the tests from running on normal make

r184786 - [NeonIntrinsicTestEmitter] vld1/vst1 do not require the :64 hint.

2013-06-24 Thread Michael Gottesman
Author: mgottesman Date: Mon Jun 24 16:25:39 2013 New Revision: 184786 URL: http://llvm.org/viewvc/llvm-project?rev=184786view=rev Log: [NeonIntrinsicTestEmitter] vld1/vst1 do not require the :64 hint. Modified: cfe/trunk/utils/TableGen/NeonEmitter.cpp Modified:

Re: r184596 - Aggregate rename limit debug info tests.

2013-06-21 Thread Michael Gottesman
It looks like this broke buildbots: http://lab.llvm.org:8013/builders/clang-x86_64-darwin11-nobootstrap-RAincremental/builds/3315 http://lab.llvm.org:8013/builders/phase1%20-%20sanity/builds/7768 On Jun 21, 2013, at 2:23 PM, David Blaikie dblai...@gmail.com wrote: Author: dblaikie Date: Fri

Re: r184596 - Aggregate rename limit debug info tests.

2013-06-21 Thread Michael Gottesman
Yes. Thank you! On Jun 21, 2013, at 3:26 PM, David Blaikie dblai...@gmail.com wrote: On Fri, Jun 21, 2013 at 3:18 PM, Michael Gottesman mgottes...@apple.com wrote: It looks like this broke buildbots: http://lab.llvm.org:8013/builders/clang-x86_64-darwin11-nobootstrap-RAincremental/builds

Re: r184596 - Aggregate rename limit debug info tests.

2013-06-21 Thread Michael Gottesman
(i.e. your commit fixed it). On Jun 21, 2013, at 3:53 PM, Michael Gottesman mgottes...@apple.com wrote: Yes. Thank you! On Jun 21, 2013, at 3:26 PM, David Blaikie dblai...@gmail.com wrote: On Fri, Jun 21, 2013 at 3:18 PM, Michael Gottesman mgottes...@apple.com wrote: It looks like

Re: [PATCH] Checked arithmetic builtins

2013-06-20 Thread Michael Gottesman
On Jun 20, 2013, at 2:16 PM, Eli Friedman eli.fried...@gmail.com wrote:On Tue, Jun 18, 2013 at 3:11 PM, Michael Gottesmanmgottes...@apple.comwrote:Hello cfe commits!The attached patch adds checked-arithmetic builtins to ameliorate such code in security critical applications (for instance webkit).

Re: [PATCH] Checked arithmetic builtins

2013-06-20 Thread Michael Gottesman
Of course = ). Michael On Jun 20, 2013, at 3:06 PM, Eli Friedman eli.fried...@gmail.com wrote: On Thu, Jun 20, 2013 at 3:05 PM, Eli Friedman eli.fried...@gmail.com wrote: On Thu, Jun 20, 2013 at 2:39 PM, Michael Gottesman mgottes...@apple.com wrote: On Jun 20, 2013, at 2:16 PM, Eli

r184497 - [checked-arithmetic builtins] Added builtins to enable users to perform checked-arithmetic in c.

2013-06-20 Thread Michael Gottesman
Author: mgottesman Date: Thu Jun 20 18:28:10 2013 New Revision: 184497 URL: http://llvm.org/viewvc/llvm-project?rev=184497view=rev Log: [checked-arithmetic builtins] Added builtins to enable users to perform checked-arithmetic in c. This will enable users in security critical applications to

Re: [PATCH] Checked arithmetic builtins

2013-06-20 Thread Michael Gottesman
Done. r184497. On Jun 20, 2013, at 3:59 PM, Michael Gottesman mgottes...@apple.com wrote: Of course = ). Michael On Jun 20, 2013, at 3:06 PM, Eli Friedman eli.fried...@gmail.com wrote: On Thu, Jun 20, 2013 at 3:05 PM, Eli Friedman eli.fried...@gmail.com wrote: On Thu, Jun 20, 2013 at 2

r184385 - [clang-lit] Added the run_long_tests param option/long_tests feature to toggle execution of long running FileCheck tests.

2013-06-19 Thread Michael Gottesman
Author: mgottesman Date: Wed Jun 19 18:23:49 2013 New Revision: 184385 URL: http://llvm.org/viewvc/llvm-project?rev=184385view=rev Log: [clang-lit] Added the run_long_tests param option/long_tests feature to toggle execution of long running FileCheck tests. This will allow for longer running

r184227 - [multiprecision-builtins] Added missing builtin __builtin_{add, sub}cb for {add, sub} with carry for bytes.

2013-06-18 Thread Michael Gottesman
Author: mgottesman Date: Tue Jun 18 15:40:40 2013 New Revision: 184227 URL: http://llvm.org/viewvc/llvm-project?rev=184227view=rev Log: [multiprecision-builtins] Added missing builtin __builtin_{add,sub}cb for {add,sub} with carry for bytes. I have had several people ask me about why this

[PATCH] Checked arithmetic builtins

2013-06-18 Thread Michael Gottesman
Hello cfe commits! The attached patch adds checked-arithmetic builtins to ameliorate such code in security critical applications (for instance webkit). It simply exposes {u,s}{add,sub,mul}. *NOTE* The u{add,sub} overlaps with the multi precision built-ins. I decided to add in the additional

r183598 - Fixed comment typo.

2013-06-07 Thread Michael Gottesman
Author: mgottesman Date: Fri Jun 7 19:27:19 2013 New Revision: 183598 URL: http://llvm.org/viewvc/llvm-project?rev=183598view=rev Log: Fixed comment typo. Modified: cfe/trunk/lib/CodeGen/CodeGenTBAA.h Modified: cfe/trunk/lib/CodeGen/CodeGenTBAA.h URL:

Re: [PATCH] Attach objc-arc function attribute to function definitions compiled in a module with ARC enabled.

2013-05-16 Thread Michael Gottesman
Sent. On May 16, 2013, at 11:22 AM, Bill Wendling wendl...@apple.com wrote: On May 15, 2013, at 9:29 PM, Bob Wilson bob.wil...@apple.com wrote: On May 15, 2013, at 3:39 PM, jahanian fjahan...@apple.com wrote: On May 15, 2013, at 2:27 PM, Michael Gottesman mgottes...@apple.com wrote

Re: [PATCH] Attach objc-arc function attribute to function definitions compiled in a module with ARC enabled.

2013-05-16 Thread Michael Gottesman
...@apple.com wrote: On May 15, 2013, at 3:39 PM, jahanian fjahan...@apple.com wrote: On May 15, 2013, at 2:27 PM, Michael Gottesman mgottes...@apple.com wrote: Hey Fariborz! I think that predicating this on LTO may be the wrong thing to do [but please correct me if I am wrong as always

Re: [PATCH] Attach objc-arc function attribute to function definitions compiled in a module with ARC enabled.

2013-05-16 Thread Michael Gottesman
Ok. I will prepare a new patch and post it here. Michael On May 16, 2013, at 1:34 PM, Michael Gottesman mgottes...@apple.com wrote: I was going for simplicity. If you want we could do that (i.e. I have no preference). Michael On May 16, 2013, at 1:32 PM, Bill Wendling wendl

[PATCH] Attach objc-arc function attribute to function definitions compiled in a module with ARC enabled.

2013-05-15 Thread Michael Gottesman
The following patch attaches to all function definitions in a module compiled with ARC the function attribute objc-arc. This enables us to know which functions to run ObjCARCContract on when we compile ARC applications with LTO. Please Review, Michael

Re: [PATCH] Attach objc-arc function attribute to function definitions compiled in a module with ARC enabled.

2013-05-15 Thread Michael Gottesman
Good point (updating patch). Michael On May 15, 2013, at 11:09 AM, jahanian fjahan...@apple.com wrote: If this attribute is consumed by LTO, why can’t we set when in LTO optimization mode only? - fariborz On May 15, 2013, at 10:59 AM, Michael Gottesman mgottes...@apple.com wrote

Re: [PATCH] Attach objc-arc function attribute to function definitions compiled in a module with ARC enabled.

2013-05-15 Thread Michael Gottesman
that plumbing and additionally if allowing the passes to do that would open up all sorts of cans of worms. Tell me what you think, Michael On May 15, 2013, at 11:15 AM, Michael Gottesman mgottes...@apple.com wrote: Good point (updating patch). Michael On May 15, 2013, at 11:09 AM

Re: r180233 - [neonemitter tests] Change triple of emitted tests to thumbv7s to match the target cpu being swift. Also specify the target-abi to apcs-gnu.

2013-04-24 Thread Michael Gottesman
This is for rdar://8762292 Michael. On Apr 24, 2013, at 5:10 PM, Michael Gottesman mgottes...@apple.com wrote: Author: mgottesman Date: Wed Apr 24 19:10:14 2013 New Revision: 180233 URL: http://llvm.org/viewvc/llvm-project?rev=180233view=rev Log: [neonemitter tests] Change triple

r180233 - [neonemitter tests] Change triple of emitted tests to thumbv7s to match the target cpu being swift. Also specify the target-abi to apcs-gnu.

2013-04-24 Thread Michael Gottesman
Author: mgottesman Date: Wed Apr 24 19:10:14 2013 New Revision: 180233 URL: http://llvm.org/viewvc/llvm-project?rev=180233view=rev Log: [neonemitter tests] Change triple of emitted tests to thumbv7s to match the target cpu being swift. Also specify the target-abi to apcs-gnu. Modified:

r179624 - [1/6] ARM Neon Intrinsic Tablegen Test Generator.

2013-04-16 Thread Michael Gottesman
Author: mgottesman Date: Tue Apr 16 16:08:04 2013 New Revision: 179624 URL: http://llvm.org/viewvc/llvm-project?rev=179624view=rev Log: [1/6] ARM Neon Intrinsic Tablegen Test Generator. Changes necessary to arm_neon.td for the generation of Neon tests. This is the first of six patches to add to

r179628 - [2/6] ARM Neon Intrinsic Tablegen Test Generator.

2013-04-16 Thread Michael Gottesman
Author: mgottesman Date: Tue Apr 16 16:18:42 2013 New Revision: 179628 URL: http://llvm.org/viewvc/llvm-project?rev=179628view=rev Log: [2/6] ARM Neon Intrinsic Tablegen Test Generator. This patch causes OpInst records to be silently identified with their Non-Op inst counterparts so that the

r179636 - [3/6] ARM Neon Intrinsic Tablegen Test Generator.

2013-04-16 Thread Michael Gottesman
Author: mgottesman Date: Tue Apr 16 17:07:30 2013 New Revision: 179636 URL: http://llvm.org/viewvc/llvm-project?rev=179636view=rev Log: [3/6] ARM Neon Intrinsic Tablegen Test Generator. Refactored out the method InstructionTypeCode from MangleName for use in further patches which perform neon

r179640 - [4/6] ARM Neon Intrinsic Tablegen Test Generator.

2013-04-16 Thread Michael Gottesman
Author: mgottesman Date: Tue Apr 16 17:48:52 2013 New Revision: 179640 URL: http://llvm.org/viewvc/llvm-project?rev=179640view=rev Log: [4/6] ARM Neon Intrinsic Tablegen Test Generator. Added code to NeonEmitter::runTests so that GenTest gets all of the needed arguments to invoke the neon test

r179642 - [5/6] ARM Neon Intrinsic Tablegen Test Generator.

2013-04-16 Thread Michael Gottesman
Author: mgottesman Date: Tue Apr 16 17:55:01 2013 New Revision: 179642 URL: http://llvm.org/viewvc/llvm-project?rev=179642view=rev Log: [5/6] ARM Neon Intrinsic Tablegen Test Generator. Changed the test generation target cpu type from cortex-a9 to swift. Reviewed by Bob Wilson. Modified:

r179644 - [6/6] ARM Neon Intrinsic Tablegen Test Generator.

2013-04-16 Thread Michael Gottesman
Author: mgottesman Date: Tue Apr 16 18:00:26 2013 New Revision: 179644 URL: http://llvm.org/viewvc/llvm-project?rev=179644view=rev Log: [6/6] ARM Neon Intrinsic Tablegen Test Generator. Added GenerateChecksForIntrinsic method to generate FileCheck patterns for generated arm neon tests. Reviewed

Re: r179229 - Mips specific inline asm memory operand modifier test case

2013-04-10 Thread Michael Gottesman
This broke buildbots: http://lab.llvm.org:8013/builders/clang-x86_64-darwin11-nobootstrap-RAincremental/builds/259 On Apr 10, 2013, at 3:10 PM, Jack Carter jack.car...@imgtec.com wrote: Author: jacksprat Date: Wed Apr 10 17:10:45 2013 New Revision: 179229 URL:

[clang-tools-extra] r178223 - Revert modularize - Fixed poor array usage.

2013-03-28 Thread Michael Gottesman
Author: mgottesman Date: Thu Mar 28 01:07:15 2013 New Revision: 178223 URL: http://llvm.org/viewvc/llvm-project?rev=178223view=rev Log: Revert modularize - Fixed poor array usage. This has broken buildbots for a few hours. Modified: clang-tools-extra/trunk/modularize/Modularize.cpp

Re: [clang-tools-extra] r178214 - modularize - Fixed poor array usage.

2013-03-28 Thread Michael Gottesman
This commit is causing buildbot failures: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/3194 For some reason your commit did not show up in the buildbot view at all = /. I think that is because perhaps the master scheduler is not tracking clang-tools-extra. Reverted in

Re: [clang-tools-extra] r178214 - modularize - Fixed poor array usage.

2013-03-28 Thread Michael Gottesman
in. -Original Message- From: cfe-commits-boun...@cs.uiuc.edu [mailto:cfe-commits-boun...@cs.uiuc.edu] On Behalf Of Michael Gottesman Sent: Wednesday, March 27, 2013 11:08 PM To: John Thompson Cc: cfe-commits@cs.uiuc.edu Subject: Re: [clang-tools-extra] r178214 - modularize - Fixed poor

r175838 - Added a footnote to the documentation for objc_storeStrong that makes it clear

2013-02-21 Thread Michael Gottesman
Author: mgottesman Date: Thu Feb 21 18:16:48 2013 New Revision: 175838 URL: http://llvm.org/viewvc/llvm-project?rev=175838view=rev Log: Added a footnote to the documentation for objc_storeStrong that makes it clear that a __strong object of block type is a valid argument to objc_storeStrong but

r174461 - Changed CGObjCMac.cpp to add the marker externally_initialized to SELECTOR_REFERENCES in both the fragile and non-fragile API.

2013-02-05 Thread Michael Gottesman
Author: mgottesman Date: Tue Feb 5 17:08:45 2013 New Revision: 174461 URL: http://llvm.org/viewvc/llvm-project?rev=174461view=rev Log: Changed CGObjCMac.cpp to add the marker externally_initialized to SELECTOR_REFERENCES in both the fragile and non-fragile API. This is to ensure that GlobalOpt

r174471 - Added test for r174461 that checks that the desired behavior also occurs in ObjC++ alongside ObjC.

2013-02-05 Thread Michael Gottesman
Author: mgottesman Date: Tue Feb 5 18:14:48 2013 New Revision: 174471 URL: http://llvm.org/viewvc/llvm-project?rev=174471view=rev Log: Added test for r174461 that checks that the desired behavior also occurs in ObjC++ alongside ObjC. \end paranoia. Added:

r174253 - On platforms which do not support ARC natively, do not mark objc_retain/objc_release as nonlazybind.

2013-02-01 Thread Michael Gottesman
Author: mgottesman Date: Fri Feb 1 18:57:44 2013 New Revision: 174253 URL: http://llvm.org/viewvc/llvm-project?rev=174253view=rev Log: On platforms which do not support ARC natively, do not mark objc_retain/objc_release as nonlazybind. rdar://13108298. rdar://13129783. Modified:

r174254 - Fixed whitespace.

2013-02-01 Thread Michael Gottesman
Author: mgottesman Date: Fri Feb 1 19:03:01 2013 New Revision: 174254 URL: http://llvm.org/viewvc/llvm-project?rev=174254view=rev Log: Fixed whitespace. Modified: cfe/trunk/lib/CodeGen/CGObjC.cpp Modified: cfe/trunk/lib/CodeGen/CGObjC.cpp URL:

r174255 - Fixed another whitespace issue... *sigh*.

2013-02-01 Thread Michael Gottesman
Author: mgottesman Date: Fri Feb 1 19:05:06 2013 New Revision: 174255 URL: http://llvm.org/viewvc/llvm-project?rev=174255view=rev Log: Fixed another whitespace issue... *sigh*. Modified: cfe/trunk/lib/CodeGen/CGObjC.cpp Modified: cfe/trunk/lib/CodeGen/CGObjC.cpp URL:

[cfe-commits] r173648 - Since ObjCARC has been refactored into its own library with its own declaration header, we need to include the declaration header alongside Scalar.h in BackendUtil.

2013-01-27 Thread Michael Gottesman
Author: mgottesman Date: Sun Jan 27 19:36:00 2013 New Revision: 173648 URL: http://llvm.org/viewvc/llvm-project?rev=173648view=rev Log: Since ObjCARC has been refactored into its own library with its own declaration header, we need to include the declaration header alongside Scalar.h in

[cfe-commits] r172939 - /cfe/trunk/lib/Sema/Sema.cpp

2013-01-19 Thread Michael Gottesman
Author: mgottesman Date: Sat Jan 19 19:04:14 2013 New Revision: 172939 URL: http://llvm.org/viewvc/llvm-project?rev=172939view=rev Log: Fixed trailing whitespace. Modified: cfe/trunk/lib/Sema/Sema.cpp Modified: cfe/trunk/lib/Sema/Sema.cpp URL:

Re: [cfe-commits] [Patch 2/2] Multiprecision Arithmetic Builtins

2013-01-14 Thread Michael Gottesman
Ping. On Jan 12, 2013, at 8:36 PM, Michael Gottesman mgottes...@apple.com wrote: Updated patch: 0001-Multiprecision-subtraction-builtins.patch On Jan 12, 2013, at 6:33 PM, Michael Gottesman mgottes...@apple.com wrote: This is the last part of a pair of patches which adds support

[cfe-commits] r172476 - in /cfe/trunk: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins-multiprecision.c

2013-01-14 Thread Michael Gottesman
Author: mgottesman Date: Mon Jan 14 15:44:30 2013 New Revision: 172476 URL: http://llvm.org/viewvc/llvm-project?rev=172476view=rev Log: Multiprecision subtraction builtins. We lower these into 2x chained usub.with.overflow intrinsics. Modified: cfe/trunk/include/clang/Basic/Builtins.def

Re: [cfe-commits] [Patch 2/2] Multiprecision Arithmetic Builtins

2013-01-14 Thread Michael Gottesman
Committed in r172476. On Jan 14, 2013, at 1:17 PM, Nick Lewycky nlewy...@google.com wrote: On 14 January 2013 10:58, Michael Gottesman mgottes...@apple.com wrote: Ping. Looks fine to me! Nick On Jan 12, 2013, at 8:36 PM, Michael Gottesman mgottes...@apple.com wrote: Updated patch

Re: [cfe-commits] r172341 - in /cfe/trunk: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins-multipercision.c

2013-01-13 Thread Michael Gottesman
Thanks Nakamura! Michael On Jan 13, 2013, at 3:30 AM, NAKAMURA Takumi geek4ci...@gmail.com wrote: 2013/1/13 Michael Gottesman mgottes...@apple.com: Author: mgottesman Date: Sat Jan 12 20:22:39 2013 New Revision: 172341 URL: http://llvm.org/viewvc/llvm-project?rev=172341view=rev Log

[cfe-commits] [PATCH 1/2] Multiprecision Arithmetic Builtins

2013-01-12 Thread Michael Gottesman
This patch is the first of two patches which adds support for Multiprecision arithmetic to clang via builtins. This specific patch contains the addition builtins. I will send the other once I get this one in. *NOTE* In case you are wondering I am also preparing patches for LLVM to perform the

[cfe-commits] r172341 - in /cfe/trunk: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins-multipercision.c

2013-01-12 Thread Michael Gottesman
Author: mgottesman Date: Sat Jan 12 20:22:39 2013 New Revision: 172341 URL: http://llvm.org/viewvc/llvm-project?rev=172341view=rev Log: Added builtins for multiprecision adds. We lower all of these intrinsics into a 2x chained usage of uadd.with.overflow. Added:

Re: [cfe-commits] [PATCH 1/2] Multiprecision Arithmetic Builtins

2013-01-12 Thread Michael Gottesman
k. I will update the documentation and repost in this thread. Committed actual patch with fixes in r172341. On Jan 12, 2013, at 5:18 PM, Dmitri Gribenko griboz...@gmail.com wrote: On Sun, Jan 13, 2013 at 2:44 AM, Michael Gottesman mgottes...@apple.com wrote: This patch is the first of two

[cfe-commits] [Patch 2/2] Multiprecision Arithmetic Builtins

2013-01-12 Thread Michael Gottesman
This is the last part of a pair of patches which adds support for multi precision arithmetic to clang via bulletins. This specific patch contains the subtraction builtins. Please Review, Michael 0001-Multiprecision-subtraction-builtins.patch Description: Binary data

[cfe-commits] r172342 - /cfe/trunk/test/CodeGen/builtins-multipercision.c

2013-01-12 Thread Michael Gottesman
Author: mgottesman Date: Sat Jan 12 21:40:23 2013 New Revision: 172342 URL: http://llvm.org/viewvc/llvm-project?rev=172342view=rev Log: Added a triple to the test builtins-multiprecision.c. Modified: cfe/trunk/test/CodeGen/builtins-multipercision.c Modified:

[cfe-commits] r172343 - in /cfe/trunk/test/CodeGen: builtins-multipercision.c builtins-multiprecision.c

2013-01-12 Thread Michael Gottesman
Author: mgottesman Date: Sat Jan 12 21:44:31 2013 New Revision: 172343 URL: http://llvm.org/viewvc/llvm-project?rev=172343view=rev Log: Fixed spelling of test name: builtins-multipercision.c = builtins-multiprecision.c. Added: cfe/trunk/test/CodeGen/builtins-multiprecision.c - copied,

Re: [cfe-commits] r172342 - /cfe/trunk/test/CodeGen/builtins-multipercision.c

2013-01-12 Thread Michael Gottesman
Fixed it in the next commit. On Jan 12, 2013, at 7:44 PM, Charles Davis cdavi...@gmail.com wrote: On Jan 12, 2013, at 8:40 PM, Michael Gottesman wrote: Author: mgottesman Date: Sat Jan 12 21:40:23 2013 New Revision: 172342 URL: http://llvm.org/viewvc/llvm-project?rev=172342view=rev

Re: [cfe-commits] [Patch 2/2] Multiprecision Arithmetic Builtins

2013-01-12 Thread Michael Gottesman
Updated patch: 0001-Multiprecision-subtraction-builtins.patch Description: Binary data On Jan 12, 2013, at 6:33 PM, Michael Gottesman mgottes...@apple.com wrote: This is the last part of a pair of patches which adds support for multi precision arithmetic to clang via bulletins

[cfe-commits] r172345 - /cfe/trunk/docs/LanguageExtensions.rst

2013-01-12 Thread Michael Gottesman
Author: mgottesman Date: Sat Jan 12 22:35:31 2013 New Revision: 172345 URL: http://llvm.org/viewvc/llvm-project?rev=172345view=rev Log: Updated documentation to reflect new multiprecision builtin functions. Modified: cfe/trunk/docs/LanguageExtensions.rst Modified:

Re: [cfe-commits] [PATCH 1/2] Multiprecision Arithmetic Builtins

2013-01-12 Thread Michael Gottesman
Committed documentation in r172345. On Jan 12, 2013, at 6:23 PM, Michael Gottesman mgottes...@apple.com wrote: k. I will update the documentation and repost in this thread. Committed actual patch with fixes in r172341. On Jan 12, 2013, at 5:18 PM, Dmitri Gribenko griboz...@gmail.com wrote

[cfe-commits] r171920 - /cfe/trunk/docs/AutomaticReferenceCounting.rst

2013-01-08 Thread Michael Gottesman
Author: mgottesman Date: Tue Jan 8 17:55:10 2013 New Revision: 171920 URL: http://llvm.org/viewvc/llvm-project?rev=171920view=rev Log: Removed extra ` from ARC documentation. Modified: cfe/trunk/docs/AutomaticReferenceCounting.rst Modified: cfe/trunk/docs/AutomaticReferenceCounting.rst

Re: [cfe-commits] [PATCH] Convert Block-ABI-Apple.txt = Block-ABI-Apple.rst

2013-01-07 Thread Michael Gottesman
On Jan 6, 2013, at 20:39 , Sean Silva sil...@purdue.edu wrote: LGTM -- Sean Silva On Sun, Jan 6, 2013 at 11:22 PM, Michael Gottesman mgottes...@apple.com wrote: Subject says it all. Please review: Michael ___ cfe-commits mailing

Re: [cfe-commits] [PATCH] Convert Block-ABI-Apple.txt = Block-ABI-Apple.rst

2013-01-07 Thread Michael Gottesman
would be better but I don't know how to do that. Jordan On Jan 7, 2013, at 9:41 , Michael Gottesman mgottes...@apple.com wrote: What do you mean by this specifically (i.e. what would it entail in terms of this patch). Michael On Jan 7, 2013, at 9:20 AM, Jordan Rose jordan_r

Re: [cfe-commits] [PATCH] Convert Block-ABI-Apple.txt = Block-ABI-Apple.rst

2013-01-07 Thread Michael Gottesman
How does this sound: ``*NOTE* This document has moved to http://clang.llvm.org/docs/Block-ABI-Apple.html.'' On another note, it seems that http://clang.llvm.org/docs/Block-ABI-Apple.txt does not exist. On Jan 7, 2013, at 10:05 AM, Michael Gottesman mgottes...@apple.com wrote: Ok. On Jan

Re: [cfe-commits] [PATCH] Convert Block-ABI-Apple.txt = Block-ABI-Apple.rst

2013-01-07 Thread Michael Gottesman
this already came up once; am I wrong about that?) Jordan On Jan 7, 2013, at 10:12 , Michael Gottesman mgottes...@apple.com wrote: How does this sound: ``*NOTE* This document has moved to http://clang.llvm.org/docs/Block-ABI-Apple.html.'' On another note, it seems that http

Re: [cfe-commits] [PATCH] Convert Block-ABI-Apple.txt = Block-ABI-Apple.rst

2013-01-07 Thread Michael Gottesman
not be if it does not. OTOH I guess it's already been broken since we first switched to Sphinx, so maybe it shouldn't block you, but I still think this is important. I was hoping Sean would have a better appropriate solution. On Jan 7, 2013, at 11:10 , Michael Gottesman mgottes...@apple.com

Re: [cfe-commits] [PATCH] Convert Block-ABI-Apple.txt = Block-ABI-Apple.rst

2013-01-07 Thread Michael Gottesman
to do something useful -- either a manual redirect or an automatic redirect. If you can make that happen, we're good. :-) Jordan On Jan 7, 2013, at 11:21 , Michael Gottesman mgottes...@apple.com wrote: How about I create a separate rst file that just consists of said text file i.e

Re: [cfe-commits] [PATCH] Convert Block-ABI-Apple.txt = Block-ABI-Apple.rst

2013-01-07 Thread Michael Gottesman
On IRC Sean said go. Committed in r171799. On Jan 7, 2013, at 2:23 PM, Michael Gottesman mgottes...@apple.com wrote: Ok done. So I assuming this means go? On Jan 7, 2013, at 2:05 PM, Sean Silva sil...@purdue.edu wrote: I filed http://llvm.org/bugs/show_bug.cgi?id=14714 a while back due

Re: [cfe-commits] [PATCH] Conversion of BlockLanguageSpec.txt = BlockLanguageSpec.rst

2012-12-19 Thread Michael Gottesman
On Dec 19, 2012, at 5:27 AM, Dmitri Gribenko griboz...@gmail.com wrote: On Wed, Dec 19, 2012 at 5:29 AM, Michael Gottesman mgottes...@apple.com wrote: I got bored and converted BlockLanguageSpec.txt = BlockLanguageSpec.rst (so I could read it in a pdf format). The attached patch

[cfe-commits] r170571 - in /cfe/trunk/docs: BlockLanguageSpec.rst BlockLanguageSpec.txt

2012-12-19 Thread Michael Gottesman
Author: mgottesman Date: Wed Dec 19 12:41:09 2012 New Revision: 170571 URL: http://llvm.org/viewvc/llvm-project?rev=170571view=rev Log: Converted BlockLanguageSpec.txt = BlockLanguageSpec.rst. Added: cfe/trunk/docs/BlockLanguageSpec.rst Removed: cfe/trunk/docs/BlockLanguageSpec.txt

[cfe-commits] r170572 - /cfe/trunk/docs/BlockLanguageSpec.rst

2012-12-19 Thread Michael Gottesman
Author: mgottesman Date: Wed Dec 19 12:42:42 2012 New Revision: 170572 URL: http://llvm.org/viewvc/llvm-project?rev=170572view=rev Log: Forgot to remove trailing whitespace when I converted the BlockLanguageSpec.txt = BlockLanguageSpec.rst. It has been eliminated. Modified:

Re: [cfe-commits] [PATCH] Conversion of BlockLanguageSpec.txt = BlockLanguageSpec.rst

2012-12-19 Thread Michael Gottesman
*NOTE* I forgot to remove the trailing whitespace before I committed. I performed the strip and then committed again in r170572. On Dec 19, 2012, at 10:42 AM, Michael Gottesman mgottes...@apple.com wrote: On Dec 19, 2012, at 5:27 AM, Dmitri Gribenko griboz...@gmail.com wrote: On Wed, Dec

[cfe-commits] r170644 - /cfe/trunk/docs/LanguageExtensions.rst

2012-12-19 Thread Michael Gottesman
Author: mgottesman Date: Wed Dec 19 21:23:52 2012 New Revision: 170644 URL: http://llvm.org/viewvc/llvm-project?rev=170644view=rev Log: Updated link in LanguageExtensions.rst to point to BlockLanguageSpec.rst instead of BlockLanguageSpec.txt. Thanks to Jean-Daniel Dupas for comments! Modified:

Re: [cfe-commits] r170571 - in /cfe/trunk/docs: BlockLanguageSpec.rst BlockLanguageSpec.txt

2012-12-19 Thread Michael Gottesman
Done in r170643. On Dec 19, 2012, at 10:50 AM, Dmitri Gribenko griboz...@gmail.com wrote: +- 2008/7/28 — revised, __block syntax ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

  1   2   >