revane added you to the CC list for the revision C++11 nullptr-convert
standalone tool.
Hi chandlerc, klimek,
This is the initial commit for a standalone tool that converts the usage of
null pointer constants (e.g. NULL, 0, etc.) in legacy C++ code to the new C+11
nullptr keyword. This
We'll look into searching for all nulls as Richard and Dmitri suggested.
http://llvm-reviews.chandlerc.com/D136
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Hi klimek,
getASTContext provides access to ASTContex for user-written AST matchers.
Author: Edwin Vane edwin.v...@intel.com
http://llvm-reviews.chandlerc.com/D144
Files:
include/clang/ASTMatchers/ASTMatchersInternal.h
lib/ASTMatchers/ASTMatchFinder.cpp
Index: include/clang
I don't have commit access yet. Would you commit it for me? I forgot to ask
originally.
http://llvm-reviews.chandlerc.com/D144
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
So I tried looking for ImplicitCastExpr where the CastKind was
CK_NullToPointer or CK_NullToMemberPointer. This does handle most of the cases
with a single simple matcher. However, there are two test of my test cases
failing:
int *p;
p = static_castT*(reinterpret_castint*((void*)NULL));
Instantiating the template doesn't help. In fact my test case is already
instantiating the template with Barint which I presume is why I see two
entries in the AST for Bar, one with T=int and one general definition.
http://llvm-reviews.chandlerc.com/D136
Author: revane
Date: Mon Dec 3 08:32:13 2012
New Revision: 169126
URL: http://llvm.org/viewvc/llvm-project?rev=169126view=rev
Log:
Test commit: reformat comment.
Modified:
clang-tools-extra/trunk/remove-cstr-calls/RemoveCStrCalls.cpp
Modified:
Hi klimek,
In the spirit of incremental development, here's a really basic first commit
for the new cpp11-migrate tool.
- Added directory structures and build system files for the new tool.
- Extremely basic implementation of tool performs only an initial syntax
check.
- Basic tests
Abandoning as requested. Functionality will be folded into cpp11-migrate
instead.
http://llvm-reviews.chandlerc.com/D136
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Use CommonOptionsParser.
Hi klimek,
http://llvm-reviews.chandlerc.com/D199
CHANGE SINCE LAST DIFF
http://llvm-reviews.chandlerc.com/D199?vs=484id=498#toc
Files:
CMakeLists.txt
cpp11-migrate/CMakeLists.txt
cpp11-migrate/Cpp11Migrate.cpp
cpp11-migrate/Makefile
test/CMakeLists.txt
Updated comments as requested.
Hi klimek,
http://llvm-reviews.chandlerc.com/D199
CHANGE SINCE LAST DIFF
http://llvm-reviews.chandlerc.com/D199?vs=498id=508#toc
Files:
clang-format/clang-format.py
Index: clang-format/clang-format.py
Previous diff was generated in error. Here's the real one.
Hi klimek,
http://llvm-reviews.chandlerc.com/D199
CHANGE SINCE LAST DIFF
http://llvm-reviews.chandlerc.com/D199?vs=508id=509#toc
Files:
CMakeLists.txt
cpp11-migrate/CMakeLists.txt
cpp11-migrate/Cpp11Migrate.cpp
Committed as r169983.
http://llvm-reviews.chandlerc.com/D199
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Author: revane
Date: Wed Dec 12 08:30:57 2012
New Revision: 169983
URL: http://llvm.org/viewvc/llvm-project?rev=169983view=rev
Log:
Initial commit for cpp11-migrate tool
- Added directory structures and build system files for the new tool.
- Extremely basic implementation of tool performs only
http://llvm-reviews.chandlerc.com/D210
Files:
Makefile
Index: Makefile
===
--- Makefile
+++ Makefile
@@ -11,7 +11,7 @@
include $(CLANG_LEVEL)/../../Makefile.config
-PARALLEL_DIRS := remove-cstr-calls tool-template
Reviewed by j'ey via IRC. Committed as 169986.
http://llvm-reviews.chandlerc.com/D210
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Hi klimek,
- Renaming GetCompilations() and GetSourcePathList() to follow LLVM
style.
- Updating docs to reflect name change.
- Also updating help text to not mention clang-check since this class
can be used by any tool.
http://llvm-reviews.chandlerc.com/D211
Files:
GetCompilations() and GetSourcePathLists() were renamed to match LLVM
style.
http://llvm-reviews.chandlerc.com/D212
Files:
cpp11-migrate/Cpp11Migrate.cpp
Index: cpp11-migrate/Cpp11Migrate.cpp
===
---
Author: revane
Date: Fri Dec 14 12:58:25 2012
New Revision: 170229
URL: http://llvm.org/viewvc/llvm-project?rev=170229view=rev
Log:
Style and Doc fix for CommonOptionsParser
- Renaming GetCompilations() and GetSourcePathList() to follow LLVM
style.
- Updating docs to reflect name change.
-
Author: revane
Date: Fri Dec 14 12:59:24 2012
New Revision: 170230
URL: http://llvm.org/viewvc/llvm-project?rev=170230view=rev
Log:
Use renamed CommonOptionsParser member functions
GetCompilations() and GetSourcePathLists() were renamed to match LLVM style.
Reviewed By: Alexander Kornienko
Committed as r170230.
http://llvm-reviews.chandlerc.com/D212
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Committed as r170229.
http://llvm-reviews.chandlerc.com/D211
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Hi chapuni,
The release build was complaining about unused results from chdir(). Now
fixed.
Reviewed-By: Kevin P Schoedel kevin.p.schoe...@intel.com
http://llvm-reviews.chandlerc.com/D220
Files:
tools/c-index-test/c-index-test.c
Index: tools/c-index-test/c-index-test.c
Hi klimek,
For consistency, following the pattern set by llvm::Pass as much as
possible. Not all features of Pass registration are obviously applicable
to Transform registration at this point.
http://llvm-reviews.chandlerc.com/D221
Files:
cpp11-migrate/CMakeLists.txt
Addressing reviewer comments from Dmitri Gribenko.
- Fixed a pointer-space issue. I'm going to have to auto-lint locally until I
can get myself used to this style.
- Fixed header guards with leading underscores. Following a bad example.
- registerTransform() now takes a const
Committed by akirtzidis in r170366.
http://llvm-reviews.chandlerc.com/D220
BRANCH
revane
ARCANIST PROJECT
clang
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Added the creation of TransformRegistryImpl.
Hi klimek,
http://llvm-reviews.chandlerc.com/D221
CHANGE SINCE LAST DIFF
http://llvm-reviews.chandlerc.com/D221?vs=536id=542#toc
Files:
cpp11-migrate/CMakeLists.txt
cpp11-migrate/Transform.cpp
cpp11-migrate/Transform.h
Addressed Simplification concerns:
* TransformListener completely gone.
* pimpl idiom in TransformRegistry no longer used.
* Some misc style issues.
Also added transform-enabling argument handling as it's part of foundation as
well.
Hi klimek,
http://llvm-reviews.chandlerc.com/D221
Removed unneeded include.
Hi klimek,
http://llvm-reviews.chandlerc.com/D221
CHANGE SINCE LAST DIFF
http://llvm-reviews.chandlerc.com/D221?vs=548id=549#toc
Files:
cpp11-migrate/CMakeLists.txt
cpp11-migrate/Cpp11Migrate.cpp
cpp11-migrate/Transform.cpp
cpp11-migrate/Transform.h
Taking a different approach as requested. Abandoning this patch.
http://llvm-reviews.chandlerc.com/D221
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
An interface as is presented with git add -p is just an idea for future work
at this point. Right now, cpp11-migrate is going to apply transforms wholesale
to files with no user input other than what is given on the command line. As
mentioned in the design doc, there are plans to introduce
CL was meant to mean Command Line. Given the use of the class and the use of
'CL' in existing LLVM code (e.g. the namespace) I thought it was an ok use of
the acronym. I guess it's not as widely known as I thought. Will come up with
something different.
The use of cl::list is being used
Committed as r171481.
http://llvm-reviews.chandlerc.com/D251
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Hi klimek,
- Turned off -count-only tests as they aren't supported in cpp11-migrate
yet.
- Updated tests to use new binary name and options to access
loop-convert transform.
http://llvm-reviews.chandlerc.com/D263
Files:
test/cpp11-migrate/LoopConvert/Inputs/negative-header.h
Fixed header guards. No longer using reserved names.
Hi klimek,
http://llvm-reviews.chandlerc.com/D263
CHANGE SINCE LAST DIFF
http://llvm-reviews.chandlerc.com/D263?vs=628id=632#toc
Files:
test/cpp11-migrate/LoopConvert/Inputs/negative-header.h
Author: revane
Date: Tue Jan 8 08:36:29 2013
New Revision: 171852
URL: http://llvm.org/viewvc/llvm-project?rev=171852view=rev
Log:
Transferred loop-convert tests to cpp11-migrate
- Turned off -count-only tests as they aren't supported in cpp11-migrate
yet.
- Updated tests to use new binary
Committed as r171852.
http://llvm-reviews.chandlerc.com/D263
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Hi klimek,
RefactoringTool::run() always writes the result of rewrites to disk.
Instead, make this optional and provide a method for getting the
refactoring results in a memory buffer instead.
Also made ClangTool polymorphic so RefactoringTool could inherit from it
to properly express the IS-A
This patch will break any users of RefactoringTool as changes won't
automatically be written to disk anymore. The only users I could find are in
clang-tools-extra and I have another patch that fixes them.
http://llvm-reviews.chandlerc.com/D273
___
Hi klimek,
RefactoringTool::run() no longer writes changes to disk automatically. Updating
users of RefactoringTool to explicitly perform the write.
http://llvm-reviews.chandlerc.com/D279
Files:
cpp11-migrate/LoopConvert/LoopConvert.cpp
remove-cstr-calls/RemoveCStrCalls.cpp
Index:
I like the three method approach. New patch coming soon.
Comment at: include/clang/Tooling/Refactoring.h:125
@@ -120,3 +124,3 @@
/// processed.
-class RefactoringTool {
+class RefactoringTool : public ClangTool {
public:
Manuel Klimek wrote:
I'm opposed to
Committed as r172074.
http://llvm-reviews.chandlerc.com/D271
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Comment at: lib/Tooling/Refactoring.cpp:142
@@ +141,3 @@
+// saveRewrittenFiles() and getResults(), without cluttering Refactoring.h's
+// header with includes that are really only needed by the implementation.
+class RewriteHelper {
Edwin Vane wrote:
Manuel
Klimek wrote:
Edwin Vane wrote:
Edwin Vane wrote:
Manuel Klimek wrote:
I think not putting something into the header is not a good reason to
pull out an abstraction. I also generally don't like abstractions
called Helper (I understand that you don't intend
Hi eugenis,
- -Bsymbolic must be added for x86 as well.
- Default CPU name also set to 'atom' for x86 android.
http://llvm-reviews.chandlerc.com/D91
Files:
lib/Driver/Tools.cpp
test/Driver/linux-ld.c
Index: lib/Driver/Tools.cpp
Hi chandlerc,
Following the example from loop-convert tests, simplifying the
remove-cstr-calls lit script.
http://llvm-reviews.chandlerc.com/D92
Files:
test/remove-cstr-calls/basic.cpp
Index: test/remove-cstr-calls/basic.cpp
Hi chandlerc,
LLVM Bugzilla: http://llvm.org/bugs/show_bug.cgi?id=13221
This patch makes the behavior of clang consistent with the behavior of gcc 4.6
in cases where both -fPIC and -fPIE is used.
- Separately check if -fPIE was specified in the command line and define both
__PIC__ and
Instead of using 'atom' as default cpu name, after some internal
consultation, 'core2' is a better common denominator for x86 android. Added
tests to test/Driver/clang-translation.c.
Note that gcc doesn't appear to do anything special if you don't explicitly
specify which CPU to target
Just want to make sure the new default CPUName is ok.
http://llvm-reviews.chandlerc.com/D91
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Sorry for the spam. Uploaded the wrong patch file (i.e. the old one again)
last time.
Hi eugenis,
http://llvm-reviews.chandlerc.com/D91
CHANGE SINCE LAST DIFF
http://llvm-reviews.chandlerc.com/D91?vs=245id=246#toc
Files:
lib/Driver/Tools.cpp
test/Driver/clang-translation.c
Addressed reviewer comments.
Hi eugenis,
http://llvm-reviews.chandlerc.com/D91
CHANGE SINCE LAST DIFF
http://llvm-reviews.chandlerc.com/D91?vs=244id=245#toc
Files:
lib/Driver/Tools.cpp
test/Driver/clang-translation.c
test/Driver/linux-ld.c
Index: lib/Driver/Tools.cpp
Fixed line break nit. These drive me nuts too!
Hi eugenis,
http://llvm-reviews.chandlerc.com/D91
CHANGE SINCE LAST DIFF
http://llvm-reviews.chandlerc.com/D91?vs=246id=250#toc
Files:
lib/Driver/Tools.cpp
test/Driver/clang-translation.c
test/Driver/linux-ld.c
Index:
Committed by Rafael Espíndola.
http://llvm-reviews.chandlerc.com/D91
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Submitted by Manuel Klimek as r167390.
http://llvm-reviews.chandlerc.com/D92
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Addressing reviwer comments:
* Using RewriteBuffer::write() instead of new function
getRewriteResult().
* RefactoringTool now provides three functions run() (inherited from
ClangTool), runAndSave() which contains the behaviour of the old
RefactoringTool::run(), and
Bad revision push from arc. Can't undo so abandoning revision to reduce noise.
http://llvm-reviews.chandlerc.com/D279
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Hi klimek,
RefactoringTool::run() no longer writes changes to disk automatically. Updating
users of RefactoringTool to explicitly perform the write.
http://llvm-reviews.chandlerc.com/D287
Files:
cpp11-migrate/LoopConvert/LoopConvert.cpp
remove-cstr-calls/RemoveCStrCalls.cpp
Index:
Nits fixed.
Hi klimek, alexfh,
http://llvm-reviews.chandlerc.com/D273
CHANGE SINCE LAST DIFF
http://llvm-reviews.chandlerc.com/D273?vs=673id=678#toc
BRANCH
refactor-changes
ARCANIST PROJECT
clang
Files:
include/clang/Rewrite/Core/Rewriter.h
include/clang/Tooling/Refactoring.h
Author: revane
Date: Fri Jan 11 11:04:55 2013
New Revision: 172219
URL: http://llvm.org/viewvc/llvm-project?rev=172219view=rev
Log:
Allow RefactoringTool to write to memory instead of always to disk
RefactoringTool::run() always writes the result of rewrites to disk.
Instead, make this
Author: revane
Date: Fri Jan 11 11:04:09 2013
New Revision: 172218
URL: http://llvm.org/viewvc/llvm-project?rev=172218view=rev
Log:
Update users of RefactoringTool
RefactoringTool::run() no longer writes changes to disk automatically. Updating
users of RefactoringTool to explicitly perform
Committed as r172219.
http://llvm-reviews.chandlerc.com/D273
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Committed as r172218.
http://llvm-reviews.chandlerc.com/D287
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Hi klimek,
Instead of writing the result of each transform to disk for every
transform, write the results to buffers in memory and pass those buffers
to the next transform as input. Only write the buffers to disk if the
final syntax check passes.
http://llvm-reviews.chandlerc.com/D288
Files:
Hi klimek,
http://llvm-reviews.chandlerc.com/D289
Files:
.gitignore
Index: .gitignore
===
--- /dev/null
+++ .gitignore
@@ -0,0 +1,31 @@
+#==#
+# This
Author: revane
Date: Mon Jan 14 08:20:19 2013
New Revision: 172414
URL: http://llvm.org/viewvc/llvm-project?rev=172414view=rev
Log:
Adding a .gitignore to tools-extra
Reviewers: klimek
Added:
clang-tools-extra/trunk/.gitignore
Added: clang-tools-extra/trunk/.gitignore
URL:
Committed as r172414.
http://llvm-reviews.chandlerc.com/D289
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Addressing reviewer comments:
* Removed class RefactoringResults and replaced simply with a vector of
pairs of strings. Updated usage in a few places.
* collectResults() is now a free function provided in Transform.h so
that main users, subclasses of Transform, can easily access it.
Comment at: cpp11-migrate/RefactoringResults.h:34
@@ +33,3 @@
+public:
+ typedef std::pairchar*, std::string ResultEntry;
+ typedef std::vectorResultEntry ResultVec;
Manuel Klimek wrote:
why not pairstring, string?
I'm not sure why I chose char*. Possibly a
Comment at: cpp11-migrate/LoopConvert/LoopConvert.cpp:72
@@ -60,1 +71,3 @@
+ OwningPtrRewriterContainer
+Rewrite(new RewriterContainer(LoopTool.getFiles()));
Manuel Klimek wrote:
Any reason to not just do:
RewriterContainer Rewrite(LoopTool.getFiles());
- Addressed reviewer nits
Hi klimek,
http://llvm-reviews.chandlerc.com/D288
CHANGE SINCE LAST DIFF
http://llvm-reviews.chandlerc.com/D288?vs=691id=710#toc
Files:
cpp11-migrate/CMakeLists.txt
cpp11-migrate/Cpp11Migrate.cpp
cpp11-migrate/LoopConvert/LoopConvert.cpp
Author: revane
Date: Wed Jan 16 15:11:50 2013
New Revision: 172657
URL: http://llvm.org/viewvc/llvm-project?rev=172657view=rev
Log:
Write transform results to disk only once
Instead of writing the result of each transform to disk for every
transform, write the results to buffers in memory
Committed as r172657.
http://llvm-reviews.chandlerc.com/D288
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Author: revane
Date: Mon Jan 21 08:35:54 2013
New Revision: 173046
URL: http://llvm.org/viewvc/llvm-project?rev=173046view=rev
Log:
Removing empty loop-convert directory
Removed:
clang-tools-extra/trunk/loop-convert/
___
cfe-commits mailing list
Author: revane
Date: Tue Jan 22 12:31:49 2013
New Revision: 173178
URL: http://llvm.org/viewvc/llvm-project?rev=173178view=rev
Log:
Add use-nullptr transform to cpp11-migrate
This transform converts the usage of null pointer constants (e.g. NULL, 0,
etc.) in legacy C++ code and converts them to
Committed as r173178.
http://llvm-reviews.chandlerc.com/D295
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Hi gribozavr,
Fixed used-uninitialized and set-but-not-used warnings.
http://llvm-reviews.chandlerc.com/D342
Files:
lib/AST/ASTDiagnostic.cpp
lib/AST/CommentParser.cpp
lib/AST/Decl.cpp
lib/Basic/LangOptions.cpp
lib/CodeGen/CGObjCGNU.cpp
lib/Sema/SemaChecking.cpp
- Removing fixes for used-uninitialized warnings
Hi gribozavr,
http://llvm-reviews.chandlerc.com/D342
CHANGE SINCE LAST DIFF
http://llvm-reviews.chandlerc.com/D342?vs=802id=808#toc
Files:
lib/AST/Decl.cpp
lib/Basic/LangOptions.cpp
Index: lib/AST/Decl.cpp
Comment at: lib/Basic/LangOptions.cpp:17-21
@@ -16,3 +16,7 @@
-const SanitizerOptions SanitizerOptions::Disabled = {};
+const SanitizerOptions SanitizerOptions::Disabled = {
+#define SANITIZER(NAME, ID) 0,
+#include clang/Basic/Sanitizers.def
+};
+
Dmitri
Gribenko wrote:
Edwin Vane wrote:
Dmitri Gribenko wrote:
David Blaikie wrote:
Not sure of the motivation for this change - shouldn't the {} in the
original code produce the same effect (zero initializing all the
elements)?
I have mixed feelings about this. -Wmissing-field
Gribenko wrote:
Edwin Vane wrote:
Dmitri Gribenko wrote:
Edwin Vane wrote:
Dmitri Gribenko wrote:
David Blaikie wrote:
Not sure of the motivation for this change - shouldn't the {} in
the original code produce the same effect (zero initializing all
the elements
Using -Wno-missing-field-initializers for gcc and
-Wmissing-field-initializers for clang builds instead. Patch forthcoming.
http://llvm-reviews.chandlerc.com/D342
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
Hi gribozavr, dblaikie,
gcc produces false positives for empty braces so turning the warning
off. Instead, turning the warning on for clang so proper warnings aren't
missed.
http://llvm-reviews.chandlerc.com/D358
Files:
cmake/modules/HandleLLVMOptions.cmake
Index:
- Adding check_cxx_compiler_flag test.
Hi gribozavr, dblaikie,
http://llvm-reviews.chandlerc.com/D358
CHANGE SINCE LAST DIFF
http://llvm-reviews.chandlerc.com/D358?vs=846id=848#toc
Files:
cmake/modules/HandleLLVMOptions.cmake
Index: cmake/modules/HandleLLVMOptions.cmake
Chandler accepted this revision by email.
http://llvm-reviews.chandlerc.com/D358
BRANCH
uninit_fix
ARCANIST PROJECT
llvm
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Committed as r174073.
http://llvm-reviews.chandlerc.com/D358
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
I don't know anything about the analyzer but it sounds like it is what is
driving the design. For tools this all looks good if only a little
heavy-handed. Your suggestions for improvements that would make parent map
construction not touch the whole AST would be welcome.
Question: does
Comment at: cpp11-migrate/Transform.h:82
@@ -80,2 +81,3 @@
Sources(Diagnostics, Files),
- Rewrite(Sources, DefaultLangOptions) {}
+ Rewrite(Sources, DefaultLangOptions) {
+
I don't know why this didn't occur to me in our internal review but
Oops. I guess it's not very easy to get the SourceManager out of
RefactoringTool since it's created internally every time ToolInvocation::run()
is executed. Forget what I said.
http://llvm-reviews.chandlerc.com/D371
___
cfe-commits mailing list
Author: revane
Date: Thu Feb 7 12:49:23 2013
New Revision: 174643
URL: http://llvm.org/viewvc/llvm-project?rev=174643view=rev
Log:
Fix for combined loop and nullptr convert tests
The rewriter was previously reading the content buffer from the file itself.
Since we are now keeping the content in
Hi klimek,
Initial draft of UseAuto replaces the type specifier for declarations of
variables that inherit from std::iterator or have iterator type traits
with the C++11 'auto' keyword.
http://llvm-reviews.chandlerc.com/D392
Files:
cpp11-migrate/CMakeLists.txt
cpp11-migrate/Makefile
Hi klimek,
For variable declarations initialized with new expressions, use 'auto'
for the type specifier.
- Some slight refactoring.
- Added a new test case.
http://llvm-reviews.chandlerc.com/D393
Files:
cpp11-migrate/UseAuto/UseAuto.cpp
cpp11-migrate/UseAuto/UseAutoActions.cpp
I have one more patch for factory functions that's not quite ready for
review. It's coming soon.
http://llvm-reviews.chandlerc.com/D393
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
Comment at: cpp11-migrate/UseAuto/UseAutoActions.cpp:38
@@ +37,3 @@
+ // Drill down to the as-written initializer.
+ const Expr *E = *Construct-arg_begin();
+
Dmitri Gribenko wrote:
An assertion to check the number of arguments would be nice.
The matcher this
Comment at: cpp11-migrate/UseAuto/UseAutoMatchers.cpp:62-63
@@ +61,4 @@
+
+/// \brief Overload of allOf accepting 5 args.
+template typename M1, typename M2, typename M3, typename M4, typename M5
+internal::PolymorphicMatcherWithParam2
Edwin Vane wrote:
Dmitri
Comment at: cpp11-migrate/UseAuto/UseAuto.cpp:43-46
@@ +42,6 @@
+
+ if (int result = UseAutoTool.run(newFrontendActionFactory(Finder))) {
+llvm::errs() Error encountered during translation.\n;
+return result;
+ }
+
Sean Silva wrote:
Comment at: cpp11-migrate/UseAuto/UseAuto.h:27
@@ +26,3 @@
+/// In addition to being used as the type specifier for variable declarations
+/// auto can be used in these ways (c++11 §7.1.6.4.2):
+/// * With functions with trailing return type
Dmitri Gribenko
Hi klimek, gribozavr,
Adding overloads of allOf accepting 4 and 5 arguments.
http://llvm-reviews.chandlerc.com/D394
Files:
include/clang/ASTMatchers/ASTMatchers.h
unittests/ASTMatchers/ASTMatchersTest.cpp
Index: include/clang/ASTMatchers/ASTMatchers.h
- Ran clang-format on allOf overloads.
Hi klimek, gribozavr,
http://llvm-reviews.chandlerc.com/D394
CHANGE SINCE LAST DIFF
http://llvm-reviews.chandlerc.com/D394?vs=952id=953#toc
BRANCH
allOf
ARCANIST PROJECT
clang
Files:
include/clang/ASTMatchers/ASTMatchers.h
Not sure why I uploaded the adjustment after you had already accepted the
initial revision. I do like your suggestion more as it makes things easier to
convert to variadic templates or macro-ification
http://llvm-reviews.chandlerc.com/D394
BRANCH
allOf
ARCANIST PROJECT
clang
Author: revane
Date: Tue Feb 12 07:55:40 2013
New Revision: 174967
URL: http://llvm.org/viewvc/llvm-project?rev=174967view=rev
Log:
Adding more overloads for allOf matcher
Adding overloads of allOf accepting 4 and 5 arguments.
Reviewer: klimek
Modified:
1 - 100 of 654 matches
Mail list logo
