Re: r216282 - Objective-C. Update my previous patch to not warn if

2014-08-26 Thread Jean-Daniel Dupas
Le 25 août 2014 à 22:58, jahanian fjahan...@apple.com a écrit : On Aug 25, 2014, at 11:12 AM, jahanian fjahan...@apple.com wrote: On Aug 25, 2014, at 10:57 AM, Jean-Daniel Dupas devli...@shadowlab.org wrote: Le 25 août 2014 à 18:47, jahanian fjahan...@apple.com a écrit

Re: r216282 - Objective-C. Update my previous patch to not warn if

2014-08-25 Thread Jean-Daniel Dupas
Le 25 août 2014 à 18:47, jahanian fjahan...@apple.com a écrit : On Aug 25, 2014, at 9:35 AM, jahanian fjahan...@apple.com wrote: On Aug 24, 2014, at 12:36 AM, Jean-Daniel Dupas devli...@shadowlab.org wrote: Are you sure excluding that case is right ? AFAIK, call [super

Re: r216282 - Objective-C. Update my previous patch to not warn if

2014-08-24 Thread Jean-Daniel Dupas
Are you sure excluding that case is right ? AFAIK, call [super initialize] is suspicious, as the runtime already call it for each class in the hierarchy. Le 22 août 2014 à 21:52, Fariborz Jahanian fjahan...@apple.com a écrit : Author: fjahanian Date: Fri Aug 22 14:52:49 2014 New Revision:

Re: Should unw_word_t be 32-bits on 32-bit platforms?

2014-05-31 Thread Jean-Daniel Dupas
Le 1 juin 2014 à 06:42, Saleem Abdulrasool compn...@compnerd.org a écrit : On Sat, May 31, 2014 at 6:21 PM, Albert Wong (王重傑) ajw...@google.com wrote: Hello cfe-commits, As part of our work to implement EHABI, we experimentally tried to typedef unw_word_t so it was 32-bits on arm

Re: C++11 attributes for C11 (was Re: [PATCH] Generalized attribute support)

2014-04-23 Thread Jean-Daniel Dupas
Le 22 avr. 2014 à 22:45, Nico Weber tha...@chromium.org a écrit : On Sat, Apr 19, 2014 at 4:05 PM, Alp Toker a...@nuanti.com wrote: Small update for the list.. We discussed this at LLVM Europe 2014 and came to the conclusion that we might as well offer the feature behind an -f flag.

Re: [PATCH] Let __attribute__((format(…))) accept OFStrings

2013-11-26 Thread Jean-Daniel Dupas
Le 26 nov. 2013 à 18:35, Jonathan Schleifer j...@webkeks.org a écrit : Am 26.11.2013 um 17:46 schrieb Arthur O'Dwyer arthur.j.odw...@gmail.com: I think Jonathan's current patch is probably the most Clang-like way of doing it, but there *is* at least one more option: we could expose the set

Re: r195323 - Add new attribute 'objc_suppress_protocol' to suppress protocol conformance for a class.

2013-11-21 Thread Jean-Daniel Dupas
Le 21 nov. 2013 à 08:20, Ted Kremenek kreme...@apple.com a écrit : Author: kremenek Date: Thu Nov 21 01:20:42 2013 New Revision: 195323 URL: http://llvm.org/viewvc/llvm-project?rev=195323view=rev Log: Add new attribute 'objc_suppress_protocol' to suppress protocol conformance for a

Re: r195061 - ObjectiveC ARC. Adopt objc_bridge attribute

2013-11-18 Thread Jean-Daniel Dupas
Le 19 nov. 2013 à 01:27, Douglas Gregor dgre...@apple.com a écrit : On Nov 18, 2013, at 4:09 PM, Fariborz Jahanian fjahan...@apple.com wrote: Author: fjahanian Date: Mon Nov 18 18:09:48 2013 New Revision: 195061 URL: http://llvm.org/viewvc/llvm-project?rev=195061view=rev Log:

Re: [PATCH] Fix libc++ header install on darwin.

2013-11-15 Thread Jean-Daniel Dupas
Le 15 nov. 2013 à 01:10, Justin Bogner m...@justinbogner.com a écrit : Jean-Daniel Dupas devli...@shadowlab.org writes: On darwin, clang looks for libc++ headers in 'lib/c++/v1' and not in 'include/c++/v1' like on other OSes. This patch update the libc++ CMake build system to install

Re: [libcxx] r194825 - Justin Bogner: This makes the headers available in the build directory, making it

2013-11-15 Thread Jean-Daniel Dupas
Doesn't this commit miss the include/CMakeFile.txt file ? Le 15 nov. 2013 à 18:18, Howard Hinnant hhinn...@apple.com a écrit : Author: hhinnant Date: Fri Nov 15 11:18:57 2013 New Revision: 194825 URL: http://llvm.org/viewvc/llvm-project?rev=194825view=rev Log: Justin Bogner: This makes

Re: [libcxx] r194825 - Justin Bogner: This makes the headers available in the build directory, making it

2013-11-15 Thread Jean-Daniel Dupas
On Nov 15, 2013, at 1:08 PM, Jean-Daniel Dupas devli...@shadowlab.org wrote: Doesn't this commit miss the include/CMakeFile.txt file ? Le 15 nov. 2013 à 18:18, Howard Hinnant hhinn...@apple.com a écrit : Author: hhinnant Date: Fri Nov 15 11:18:57 2013 New Revision: 194825 URL: http

Re: [PATCH] Fix libc++ header install on darwin.

2013-11-15 Thread Jean-Daniel Dupas
Deprecated by r194833 http://llvm-reviews.chandlerc.com/D2122 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] Fix libc++ header install on darwin.

2013-11-14 Thread Jean-Daniel Dupas
Ping http://llvm-reviews.chandlerc.com/D2122 Le 8 nov. 2013 à 11:44, Jean-Daniel Dupas devli...@shadowlab.org a écrit : On darwin, clang looks for libc++ headers in 'lib/c++/v1' and not in 'include/c++/v1' like on other OSes. This patch update the libc++ CMake build system to install

[PATCH] Fix libc++ header install on darwin.

2013-11-08 Thread Jean-Daniel Dupas
Hi howard.hinnant, On darwin, clang looks for libc++ headers in 'lib/c++/v1' and not in 'include/c++/v1' like on other OSes. This patch update the libc++ CMake build system to install the libc++ headers at the right place on darwin. http://llvm-reviews.chandlerc.com/D2122 Files:

Re: [PATCH] Add an optional mapping from source paths to source contents.

2013-11-08 Thread Jean-Daniel Dupas
Isn't clang using 'mmap' to load files ? If so, loading the same file many times would probably fill the virtual memory space (which is not an issue on 64bit arch), but not the RAM, especially if header files are opened read-only. Le 8 nov. 2013 à 20:24, Dmitri Gribenko griboz...@gmail.com a

Re: r193934 - Default to use libc++ on OS X 10.9+ and iOS 7+.

2013-11-05 Thread Jean-Daniel Dupas
I'm not sure it works with the CMake build system. When I'm working with TOT (and CMake), I usually symlink the libc++/include dir at the right place in the install dir (lib/c++/v1) so clang found it automatically. That said, produced binaries will always use the system libc++ as by default

Re: r193934 - Default to use libc++ on OS X 10.9+ and iOS 7+.

2013-11-05 Thread Jean-Daniel Dupas
: The libc++ dylib is shipped with OS X, but the libc++ headers are supposed to go with clang. I don't use CMake but it sounds like someone should fix it to install the headers. On Nov 5, 2013, at 11:23 AM, Jean-Daniel Dupas devli...@shadowlab.org wrote: I'm not sure it works with the CMake

Re: [libcxxabi][PATCH] unwinder

2013-10-08 Thread Jean-Daniel Dupas
Le 8 oct. 2013 à 20:22, David Fang f...@csl.cornell.edu a écrit : Nick, On Oct 7, 2013, at 7:38 PM, David Fang wrote: Hi Nick, Thanks for the libunwind commit! Would it be possible to also include mach-o/dyld_priv.h as well? It is referenced by src/Unwind/AddressSpace.hpp. I

[libcxxabi] r189603 - Change the two last remaining _LIBCPP_CANTTHROW to _NOEXCEPT

2013-08-29 Thread Jean-Daniel Dupas
Author: jddupas Date: Thu Aug 29 14:19:27 2013 New Revision: 189603 URL: http://llvm.org/viewvc/llvm-project?rev=189603view=rev Log: Change the two last remaining _LIBCPP_CANTTHROW to _NOEXCEPT Modified: libcxxabi/trunk/src/stdexcept.cpp Modified: libcxxabi/trunk/src/stdexcept.cpp URL:

Re: [PATCH] [libcxx] Distinguish between MSVC, MSVCRT, and Windows-specific code

2013-08-13 Thread Jean-Daniel Dupas
-#include windows.h // ymath.h works correctly +// These are built-in's for clang etc. Provide them for the genuine ms compiler. +#if _MSC_VER !__clang__ +#include float.h // FLT_ etc. +#include limits.h // CHAR_BIT -#ifndef __clang__ // MSVC-based

Re: patch: link ubsan into shared libraries

2013-08-13 Thread Jean-Daniel Dupas
. On Tue, Aug 13, 2013 at 11:49 AM, Jean-Daniel Dupas devli...@shadowlab.org wrote: Le 13 août 2013 à 01:25, Nick Lewycky nlewy...@google.com a écrit : The attached patch causes ubsan to get linked in when building a .so file. This is different from other sanitizers. The other sanitizers

Re: [PATCH] Check dynamic_cast is not used with -fno-rtti

2013-07-29 Thread Jean-Daniel Dupas
Le 29 juil. 2013 à 17:52, Arnaud A. de Grandmaison arnaud.ad...@gmail.com a écrit : Clang emits an error when typeid is used with -fno-rtti, but does not perform a similar check for dynamic_cast. The attached patch implements the check. I have done it late in

Re: [PATCH] Fix another place where clang check objc selector name instead of checking the selector family

2013-07-19 Thread Jean-Daniel Dupas
Closed by commit rL186718 (authored by @jddupas). CHANGED PRIOR TO COMMIT http://llvm-reviews.chandlerc.com/D1163?vs=2860id=2918#toc http://llvm-reviews.chandlerc.com/D1163 COMMIT http://llvm-reviews.chandlerc.com/rL186718 ___ cfe-commits

r186718 - Fix another place where clang check objc selector name instead of checking the selector family

2013-07-19 Thread Jean-Daniel Dupas
Author: jddupas Date: Fri Jul 19 15:25:56 2013 New Revision: 186718 URL: http://llvm.org/viewvc/llvm-project?rev=186718view=rev Log: Fix another place where clang check objc selector name instead of checking the selector family Summary: In ARC mode, clang emits a warning if the result of an

Re: [PATCH] Improve idiomatic-parentheses test by checking selector family instead of just checking selector name.

2013-07-17 Thread Jean-Daniel Dupas
Jean-Daniel added you to the CC list for the revision Improve idiomatic-parentheses test by checking selector family instead of just checking selector name.. -Wparentheses try to be smart and filter out some common idiom like if (self = [super init]). This idiom should test that the

[PATCH] Fix another place where clang check objc selector name instead of checking the selector family

2013-07-17 Thread Jean-Daniel Dupas
In ARC mode, clang emits a warning if the result of an 'init' method is unused but miss cases where the method does not follows the Cocoa naming convention but is properly declared as an init family method. http://llvm-reviews.chandlerc.com/D1163 Files: lib/AST/Expr.cpp test/SemaObjC/arc.m

Re: [PATCH] Improve idiomatic-parentheses test by checking selector family instead of just checking selector name.

2013-07-17 Thread Jean-Daniel Dupas
Thanks, commited as r186524 Le 17 juil. 2013 à 20:07, Jordan Rose jordan_r...@apple.com a écrit : LGTM! http://llvm-reviews.chandlerc.com/D1162 -- Jean-Daniel ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

r186524 - Improve idiomatic-parentheses by checking method family instead of relying on the selector name.

2013-07-17 Thread Jean-Daniel Dupas
Author: jddupas Date: Wed Jul 17 13:17:14 2013 New Revision: 186524 URL: http://llvm.org/viewvc/llvm-project?rev=186524view=rev Log: Improve idiomatic-parentheses by checking method family instead of relying on the selector name. Modified: cfe/trunk/lib/Sema/SemaExpr.cpp

Re: r185873 - [Objective-C migrator] replace candidate user setter/getter with

2013-07-10 Thread Jean-Daniel Dupas
Le 10 juil. 2013 à 02:24, jahanian fjahan...@apple.com a écrit : On Jul 9, 2013, at 9:22 AM, Jordan Rose jordan_r...@apple.com wrote: On Jul 8, 2013, at 14:42 , Fariborz Jahanian fjahan...@apple.com wrote: +@property(weak) NSString *__weak WeakProp; + +@property(strong) NSString *

Re: [libcxx] r185451 - Windows support in thread::hardware_concurrency.

2013-07-03 Thread Jean-Daniel Dupas
Le 3 juil. 2013 à 17:05, Howard Hinnant hhinn...@apple.com a écrit : On Jul 3, 2013, at 12:35 AM, Chandler Carruth chandl...@google.com wrote: On Tue, Jul 2, 2013 at 9:10 PM, Nico Rieck nico.ri...@gmail.com wrote: On 02.07.2013 23:55, Óscar Fuentes wrote: Nico and Howard, Nico Rieck

Re: r180909 - Only evaluate __has_feature(c_thread_local) and __has_feature(cxx_thread_local) true when the target supports thread-local storage.

2013-05-02 Thread Jean-Daniel Dupas
Is it OK to use the same condition for both while they don't require the same Target support ? AFAK, C++ TLS require __cxa_thread_atexit support, and so the target should support thread_atexit, while C TLS doesn't need it. Actually, I think darwin has support for C thread local, but no C++

Re: r180909 - Only evaluate __has_feature(c_thread_local) and __has_feature(cxx_thread_local) true when the target supports thread-local storage.

2013-05-02 Thread Jean-Daniel Dupas
OK. Thank you for the answer. Last time I checked, I missed the __tlv_atexit call. I'm glad to know C++11 TLS support can work on OS X :-) Le 2 mai 2013 à 15:17, Douglas Gregor dgre...@apple.com a écrit : On May 2, 2013, at 1:00 AM, Jean-Daniel Dupas devli...@shadowlab.org wrote

Re: r177605 - Split ubsan runtime into three pieces (clang part):

2013-03-21 Thread Jean-Daniel Dupas
Le 21 mars 2013 à 00:49, Richard Smith richard-l...@metafoo.co.uk a écrit : Author: rsmith Date: Wed Mar 20 18:49:07 2013 New Revision: 177605 URL: http://llvm.org/viewvc/llvm-project?rev=177605view=rev Log: Split ubsan runtime into three pieces (clang part): * libclang_rt-san-* is

Re: r177194 - rdar://problem/13426257 Introduce SDKSettings.plist as an input file dependency for PCH/modules.

2013-03-15 Thread Jean-Daniel Dupas
Out of curiosity, what happen while compiling on Darwin without specifying an sdkroot as in such case, it uses headers from /System directly and will not be able to locate a SDKSettings.plist file. Le 15 mars 2013 à 23:15, Douglas Gregor dgre...@apple.com a écrit : Author: dgregor Date:

Re: r176924 - Tighten up the rules for precise lifetime and document

2013-03-13 Thread Jean-Daniel Dupas
Le 13 mars 2013 à 04:10, John McCall rjmcc...@apple.com a écrit : Author: rjmccall Date: Tue Mar 12 22:10:54 2013 New Revision: 176924 URL: http://llvm.org/viewvc/llvm-project?rev=176924view=rev Log: Tighten up the rules for precise lifetime and document the requirements on the ARC

Re: r176832 - Objective-C: When using super.prop, property should be

2013-03-12 Thread Jean-Daniel Dupas
Le 11 mars 2013 à 23:26, Fariborz Jahanian fjahan...@apple.com a écrit : Author: fjahanian Date: Mon Mar 11 17:26:33 2013 New Revision: 176832 URL: http://llvm.org/viewvc/llvm-project?rev=176832view=rev Log: Objective-C: When using super.prop, property should be looked up the current

Re: [cfe-commits] r172856 - in /cfe/trunk: lib/Driver/Tools.cpp test/Driver/ubsan-ld.c

2013-01-19 Thread Jean-Daniel Dupas
Should it be done for darwin too ? (see Toolchains.cpp:321) Le 18 janv. 2013 à 23:09, Richard Smith richard-l...@metafoo.co.uk a écrit : Author: rsmith Date: Fri Jan 18 16:09:26 2013 New Revision: 172856 URL: http://llvm.org/viewvc/llvm-project?rev=172856view=rev Log: Include ubsan

Re: [cfe-commits] r172761 - in /cfe/trunk: include/clang/Basic/DiagnosticParseKinds.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/TokenKinds.def include/clang/Sema/DeclSpec.h lib/H

2013-01-18 Thread Jean-Daniel Dupas
Le 17 janv. 2013 à 23:16, Richard Smith richard-l...@metafoo.co.uk a écrit : NamedDecl* @@ -6429,9 +6433,10 @@ void Sema::CheckMain(FunctionDecl* FD, const DeclSpec DS) { // C++11 [basic.start.main]p3: A program that declares main to be inline, // static or constexpr is ill-formed.

Re: [cfe-commits] r172761 - in /cfe/trunk: include/clang/Basic/DiagnosticParseKinds.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/TokenKinds.def include/clang/Sema/DeclSpec.h lib/H

2013-01-18 Thread Jean-Daniel Dupas
Le 18 janv. 2013 à 14:16, Jean-Daniel Dupas devli...@shadowlab.org a écrit : Le 17 janv. 2013 à 23:16, Richard Smith richard-l...@metafoo.co.uk a écrit : NamedDecl* @@ -6429,9 +6433,10 @@ void Sema::CheckMain(FunctionDecl* FD, const DeclSpec DS) { // C++11 [basic.start.main]p3

Re: [cfe-commits] changing svn to read/write

2013-01-16 Thread Jean-Daniel Dupas
Le 16 janv. 2013 à 17:43, reed kotler rkot...@mips.com a écrit : My svn for clang is read onlyrkotler@ubuntu-rkotler:~/llvm_trunk/tools$ cd clang rkotler@ubuntu-rkotler:~/llvm_trunk/tools/clang$ svn info Path: . URL: http://llvm.org/svn/llvm-project/cfe/trunk Repository Root:

Re: [cfe-commits] r172437 - in /cfe/trunk: include/clang/Basic/DiagnosticLexKinds.td include/clang/Basic/Module.h include/clang/Serialization/ASTBitCodes.h lib/Basic/Module.cpp lib/CodeGen/CodeGenModu

2013-01-14 Thread Jean-Daniel Dupas
Nice. Look like this change will also allow to easily implement the MS extension: #pragma comment(lib, xxx.lib) :-) Le 14 janv. 2013 à 18:21, Douglas Gregor dgre...@apple.com a écrit : Author: dgregor Date: Mon Jan 14 11:21:00 2013 New Revision: 172437 URL:

Re: [cfe-commits] r172091 - in /cfe/trunk: lib/CodeGen/CGException.cpp lib/CodeGen/CGObjCGNU.cpp lib/CodeGen/CGObjCMac.cpp lib/CodeGen/CGObjCRuntime.h test/CodeGenObjCXX/exceptions.mm

2013-01-10 Thread Jean-Daniel Dupas
Le 10 janv. 2013 à 20:02, Fariborz Jahanian fjahan...@apple.com a écrit : Author: fjahanian Date: Thu Jan 10 13:02:56 2013 New Revision: 172091 URL: http://llvm.org/viewvc/llvm-project?rev=172091view=rev Log: objectiveC++: When throwing c++ exception of an objectiveC object, use

[cfe-commits] Somewhat outdated documentation

2013-01-07 Thread Jean-Daniel Dupas
While reading the PTH internal doc, I found the following paragraph that should probably be updated… There are plans to potentially implement an complementary PCH implementation for Clang based on the lazy deserialization of ASTs. This approach would theoretically have the same constant-time

Re: [cfe-commits] r170571 - in /cfe/trunk/docs: BlockLanguageSpec.rst BlockLanguageSpec.txt

2012-12-19 Thread Jean-Daniel Dupas
Don't forget to update the link in LanguageExtensions.rst. It points to BlockLanguageSpec.txt which is now removed. Le 19 déc. 2012 à 19:41, Michael Gottesman mgottes...@apple.com a écrit : Author: mgottesman Date: Wed Dec 19 12:41:09 2012 New Revision: 170571 URL:

Re: [cfe-commits] r170260 - in /cfe/trunk/docs: AnalyzerRegions.rst analyzer/AnalyzerRegions.rst index.rst

2012-12-18 Thread Jean-Daniel Dupas
Le 18 déc. 2012 à 04:53, Sean Silva sil...@purdue.edu a écrit : Previously, I kind of considered docs/ to be more associated with lib/ than with www/. Woah, I didn't even know that there was that weird www/ directory in the clang tree. Personally, I would like to see that abolished to

Re: [cfe-commits] Updated and expanded Clang manual page (docs/tools/clang.pod)

2012-12-02 Thread Jean-Daniel Dupas
Le 28 nov. 2012 à 20:15, John McCall rjmcc...@apple.com a écrit : On Nov 28, 2012, at 4:10 AM, Jean-Daniel Dupas devli...@shadowlab.org wrote: Le 28 nov. 2012 à 01:37, John McCall rjmcc...@apple.com a écrit : On Nov 21, 2012, at 10:40 AM, Jonathan de Boyne Pollard j.deboynepollard-newsgro

Re: [cfe-commits] Updated and expanded Clang manual page (docs/tools/clang.pod)

2012-11-28 Thread Jean-Daniel Dupas
Le 28 nov. 2012 à 01:37, John McCall rjmcc...@apple.com a écrit : On Nov 21, 2012, at 10:40 AM, Jonathan de Boyne Pollard j.deboynepollard-newsgro...@ntlworld.com wrote: On 2012-11-21 16:19, Chris Lattner wrote: Definitely! Please send patches to the cfe-commits mailing list! The output

Re: [cfe-commits] r167678 - in /cfe/trunk: lib/CodeGen/CGBlocks.h test/CodeGenObjC/arc-blocks.m

2012-11-11 Thread Jean-Daniel Dupas
Isn't the 27 bit unused ? Le 10 nov. 2012 à 19:53, Jordan Rose jordan_r...@apple.com a écrit : Should we maybe put that in a comment, so that this won't happen again? We're out of bits now. :-( Jordan On Nov 10, 2012, at 10:30 , Fariborz Jahanian fjahan...@apple.com wrote: Author:

Re: [cfe-commits] [Patch] Fix for comma-removal ahead of __VA_ARGS__ in macros

2012-11-05 Thread Jean-Daniel Dupas
Le 5 nov. 2012 à 09:08, Eli Friedman eli.fried...@gmail.com a écrit : On Sun, Nov 4, 2012 at 3:10 PM, Andy Gibbs andyg1...@hotmail.co.uk wrote: Hi, Please could someone review the attached patch for me before I commit it. This patch fixes the rules surrounding the removal of a leading

Re: [cfe-commits] [Patch] Fix for comma-removal ahead of __VA_ARGS__ in macros

2012-11-05 Thread Jean-Daniel Dupas
Le 5 nov. 2012 à 12:07, Andy Gibbs andyg1...@hotmail.co.uk a écrit : On Monday, November 05, 2012 9:50 AM, Jean-Daniel Dupas wrote: Le 5 nov. 2012 à 09:08, Eli Friedman a écrit : On Sun, Nov 4, 2012 at 3:10 PM, Andy Gibbs wrote: Hi, Please could someone review the attached patch for me

Re: [cfe-commits] [patch] Remove -ccc-clang-cxx and -ccc-no-clang-cxx

2012-10-31 Thread Jean-Daniel Dupas
Le 31 oct. 2012 à 19:38, João Matos ripzonetri...@gmail.com a écrit : On Wed, Oct 31, 2012 at 6:25 PM, Daniel Dunbar dan...@zuster.org wrote: If we did that, then it would be entirely sensible to provide another (more sensibly named) option to request linking with the C++ standard library

Re: [cfe-commits] [patch] UBSAN darwin support

2012-10-30 Thread Jean-Daniel Dupas
Ping Le 22 oct. 2012 à 12:51, Jean-Daniel Dupas devli...@shadowlab.org a écrit : Thanks. Look like you forget to svn add the new Makefile and unistd.h though. Here is a rebased svn patch that include these files. Le 22 oct. 2012 à 12:31, Jonathan Sauer jonathan.sa...@gmx.de a écrit

Re: [cfe-commits] [PATCH] When using make VERBOSE=1, make sure compiler-rt is also build verbosely.

2012-10-27 Thread Jean-Daniel Dupas
Because I erroneously though that simply using make VERBOSE= was enough to enable verbose mode. http://llvm-reviews.chandlerc.com/D67 CHANGE SINCE LAST DIFF http://llvm-reviews.chandlerc.com/D67?vs=181id=220#toc Files: runtime/compiler-rt/Makefile Index: runtime/compiler-rt/Makefile

Re: [cfe-commits] [patch] UBSAN darwin support

2012-10-22 Thread Jean-Daniel Dupas
Thanks. Look like you forget to svn add the new Makefile and unistd.h though. Here is a rebased svn patch that include these files. Le 22 oct. 2012 à 12:31, Jonathan Sauer jonathan.sa...@gmx.de a écrit : Hello, I applied the patch to compiler-rt r166410 (darwin-ubsan.patch did not apply

Re: [cfe-commits] r163917 - in /cfe/trunk: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp lib/Sema/SemaExprCXX.cpp test/ARCMT/cxx-checking.mm

2012-10-19 Thread Jean-Daniel Dupas
You may workaround this issue by using a custom compiler definition (xcspec). To create a custom clang definition: Copy the builtin definition (/Applications/Xcode.app/Contents/PlugIns/Xcode3Core.ideplugin/Contents/SharedSupport/Developer/Library/Xcode/Plug-ins/Clang LLVM 1.0.xcplugin).

[cfe-commits] [PATCH] When using make VERBOSE=1, make sure compiler-rt is also build verbosely.

2012-10-18 Thread Jean-Daniel Dupas
When building clang+compiler-rt verbosely, the build commands of compiler-rt are not output in the terminal as expected. This patch fixes the issue by forwarding the VERBOSE flag to the compiler-rt make. http://llvm-reviews.chandlerc.com/D67 Files: runtime/compiler-rt/Makefile Index:

Re: [cfe-commits] [patch] Forward VERBOSE flag to compiler-rt Makefile.

2012-10-18 Thread Jean-Daniel Dupas
Le 16 oct. 2012 à 10:14, Jean-Daniel Dupas devli...@shadowlab.org a écrit : Hello, Using the autoconf build system, it is possible to build clang in verbose mode to get the full transcript of the build (using make VERBOSE=1). This is useful to track issues with the build system

Re: [cfe-commits] r165988 - in /cfe/trunk: include/clang/Basic/ObjCRuntime.h lib/CodeGen/CGObjC.cpp lib/Driver/ToolChains.cpp lib/Driver/Tools.cpp lib/Sema/SemaExpr.cpp runtime/compiler-rt/Makefile te

2012-10-17 Thread Jean-Daniel Dupas
Le 17 oct. 2012 à 08:10, Nico Weber tha...@chromium.org a écrit : On Tue, Oct 16, 2012 at 10:33 PM, Bob Wilson bob.wil...@apple.com wrote: On Oct 16, 2012, at 9:25 PM, Bob Wilson bob.wil...@apple.com wrote: On Oct 16, 2012, at 9:18 PM, Nico Weber tha...@chromium.org wrote: It's also

Re: [cfe-commits] r165988 - in /cfe/trunk: include/clang/Basic/ObjCRuntime.h lib/CodeGen/CGObjC.cpp lib/Driver/ToolChains.cpp lib/Driver/Tools.cpp lib/Sema/SemaExpr.cpp runtime/compiler-rt/Makefile te

2012-10-17 Thread Jean-Daniel Dupas
Le 17 oct. 2012 à 17:55, Nico Weber tha...@chromium.org a écrit : On Wed, Oct 17, 2012 at 1:03 AM, Jean-Daniel Dupas devli...@shadowlab.org wrote: Le 17 oct. 2012 à 08:10, Nico Weber tha...@chromium.org a écrit : On Tue, Oct 16, 2012 at 10:33 PM, Bob Wilson bob.wil...@apple.com wrote

Re: [cfe-commits] r165988 - in /cfe/trunk: include/clang/Basic/ObjCRuntime.h lib/CodeGen/CGObjC.cpp lib/Driver/ToolChains.cpp lib/Driver/Tools.cpp lib/Sema/SemaExpr.cpp runtime/compiler-rt/Makefile te

2012-10-17 Thread Jean-Daniel Dupas
Le 17 oct. 2012 à 18:18, Jean-Daniel Dupas devli...@shadowlab.org a écrit : Le 17 oct. 2012 à 17:55, Nico Weber tha...@chromium.org a écrit : On Wed, Oct 17, 2012 at 1:03 AM, Jean-Daniel Dupas devli...@shadowlab.org wrote: Le 17 oct. 2012 à 08:10, Nico Weber tha...@chromium.org a écrit

[cfe-commits] [patch] Forward VERBOSE flag to compiler-rt Makefile.

2012-10-16 Thread Jean-Daniel Dupas
Hello, Using the autoconf build system, it is possible to build clang in verbose mode to get the full transcript of the build (using make VERBOSE=1). This is useful to track issues with the build system. Unfortunately, it does not work when you want to find an issue in the compiler-rt

[cfe-commits] [patch] UBSAN darwin support

2012-10-16 Thread Jean-Daniel Dupas
Hello, As discussed in an previous thread on cfe-dev, darwin lacks ubsan support, and so compilation with -fcatch-undefined-behavior will result in a linker error. Here are two patches for compiler-rt to start to fix this issue. The first one update the stub darwin SDK in compiler-rt to make

Re: [cfe-commits] [patch] Elided __VA_ARGS__ now erase preceding comma in MS mode

2012-08-27 Thread Jean-Daniel Dupas
Le 27 août 2012 à 14:31, Aaron Ballman aa...@aaronballman.com a écrit : On Mon, Aug 27, 2012 at 5:42 AM, Martin Vejnár martin.vej...@avg.com wrote: I’ve beed asked to post this patch to cfe-commits, so there you go. The preprocessor show now consume a comma before elided __VA_ARGS__ even if

Re: [cfe-commits] [PATCH] Add -fobjc-direct-class-refs

2012-08-17 Thread Jean-Daniel Dupas
Please, when bumping a review request, re-attach the patch. Le 17 août 2012 à 16:04, Jonathan Schleifer j...@webkeks.org a écrit : Any news on this? :) I assume you just forgot it as we already talked about ARC in the ObjFW runtime on objc-list@apple? -- Jonathan

Re: [cfe-commits] r161972 - in /cfe/trunk: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/Sema/tentative-decls.c

2012-08-15 Thread Jean-Daniel Dupas
Le 15 août 2012 à 21:10, jahanian fjahan...@apple.com a écrit : On Aug 15, 2012, at 12:04 PM, Jordan Rose wrote: On Aug 15, 2012, at 11:58 , jahanian fjahan...@apple.com wrote: On Aug 15, 2012, at 11:49 AM, Jordan Rose wrote: What is the unexpected behavior? Or what will it not

Re: [cfe-commits] [libcxx] r161760 - /libcxx/trunk/Makefile

2012-08-13 Thread Jean-Daniel Dupas
Isn't this target used by the installheaders target just above ? Le 13 août 2012 à 18:17, Howard Hinnant hhinn...@apple.com a écrit : Author: hhinnant Date: Mon Aug 13 11:17:12 2012 New Revision: 161760 URL: http://llvm.org/viewvc/llvm-project?rev=161760view=rev Log: Remove obsolete

Re: [cfe-commits] r160265 - in /cfe/trunk: include/clang/Tooling/CommandLineClangTool.h lib/Tooling/CMakeLists.txt lib/Tooling/CommandLineClangTool.cpp test/CMakeLists.txt test/Tooling/clang-ast-dump.

2012-07-17 Thread Jean-Daniel Dupas
Le 17 juil. 2012 à 20:08, Manuel Klimek kli...@google.com a écrit : On Tue, Jul 17, 2012 at 7:55 PM, Douglas Gregor dgre...@apple.com wrote: On Jul 16, 2012, at 11:56 PM, Manuel Klimek kli...@google.com wrote: On Tue, Jul 17, 2012 at 7:22 AM, Douglas Gregor dgre...@apple.com wrote: On

Re: [cfe-commits] PATCH: ASTMatchers-based refactoring callbacks to make common cases of refactoring easy

2012-07-13 Thread Jean-Daniel Dupas
+// +// This will replace all integer literals with 2. +// Isn't the universal answer 42 instead of 2 ? ;-) Le 13 juil. 2012 à 16:22, Daniel Jasper djas...@google.com a écrit : With these callbacks, simple refactorings should be quite easy. It is a starting point and can be

Re: [cfe-commits] r159939 - in /cfe/trunk: docs/ReleaseNotes.html include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp test/FixIt/objc-literals.m test/SemaObjC/objc-literal-comparison.m

2012-07-09 Thread Jean-Daniel Dupas
While this is just a warning now, I found the comment in the release note very helpful to understand why we should never do it. Le 9 juil. 2012 à 18:54, Jordan Rose a écrit : Author: jrose Date: Mon Jul 9 11:54:44 2012 New Revision: 159939 URL:

Re: [cfe-commits] r159939 - in /cfe/trunk: docs/ReleaseNotes.html include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp test/FixIt/objc-literals.m test/SemaObjC/objc-literal-comparison.m

2012-07-09 Thread Jean-Daniel Dupas
appears on developer.apple.com). Jordan On Jul 9, 2012, at 10:06 , Jean-Daniel Dupas devli...@shadowlab.org wrote: While this is just a warning now, I found the comment in the release note very helpful to understand why we should never do it. Le 9 juil. 2012 à 18:54, Jordan Rose a écrit

Re: [cfe-commits] r159626 - in /cfe/trunk: include/clang/Parse/Parser.h include/clang/Sema/Sema.h lib/Parse/ParseDecl.cpp lib/Parse/ParseObjc.cpp lib/Parse/Parser.cpp lib/Sema/SemaDeclObjC.cpp test/Se

2012-07-03 Thread Jean-Daniel Dupas
This commit broke the Obj-C++11 parser: foo.mm @interface Foo @end @implementation Foo static int test() { return 0; } @end -- clang++ -fsyntax-only -std=c++11 foo.mm foo.mm:8:2: error: expected expression return 0; ^ foo.mm:9:2: error: expected ';' after top

Re: [cfe-commits] r159626 - in /cfe/trunk: include/clang/Parse/Parser.h include/clang/Sema/Sema.h lib/Parse/ParseDecl.cpp lib/Parse/ParseObjc.cpp lib/Parse/Parser.cpp lib/Sema/SemaDeclObjC.cpp test/Se

2012-07-03 Thread Jean-Daniel Dupas
Le 4 juil. 2012 à 00:31, jahanian a écrit : On Jul 3, 2012, at 3:02 PM, Jean-Daniel Dupas wrote: This commit broke the Obj-C++11 parser: I turned it off for Obj-C++11 parser until I get the chance to look at it. This is in r159690 - Fariborz OK. Thank you. -- Jean-Daniel

[cfe-commits] [libc++ patch] Using double underscore feature variant (take 2)

2012-07-02 Thread Jean-Daniel Dupas
Hello Now that we let some time pass, and that the last stable clang released support double underscore variant in __has_feature, I repost this (updated) patch to add double underscores in __has_feature tests in libc++ headers. This is require to avoid conflict with user defined macros like

Re: [cfe-commits] [patch] Trying to fix __va_list_tag serialization issue (bug 13189)

2012-06-29 Thread Jean-Daniel Dupas
Le 29 juin 2012 à 07:57, Meador Inge a écrit : Moving to cfe-commits... On Jun 28, 2012, at 6:06 PM, Jean-Daniel Dupas wrote: Hello (and please ignore previous mail to cfe-dev), I'm trying to fix a regression with va_list handling in precompiled headers. http://llvm.org/bugs

Re: [cfe-commits] [patch] Trying to fix __va_list_tag serialization issue (bug 13189)

2012-06-29 Thread Jean-Daniel Dupas
Le 29 juin 2012 à 16:58, Meador Inge a écrit : On Jun 29, 2012, at 1:49 AM, Jean-Daniel Dupas wrote: Le 29 juin 2012 à 07:57, Meador Inge a écrit : Moving to cfe-commits... On Jun 28, 2012, at 6:06 PM, Jean-Daniel Dupas wrote: Hello (and please ignore previous mail to cfe-dev

Re: [cfe-commits] [patch] Trying to fix __va_list_tag serialization issue (bug 13189)

2012-06-29 Thread Jean-Daniel Dupas
Le 29 juin 2012 à 19:31, Meador Inge a écrit : On Jun 29, 2012, at 12:20 PM, Douglas Gregor wrote: On Jun 29, 2012, at 8:07 AM, Jean-Daniel Dupas devli...@shadowlab.org wrote: Le 29 juin 2012 à 16:58, Meador Inge a écrit : On Jun 29, 2012, at 1:49 AM, Jean-Daniel Dupas wrote

[cfe-commits] [patch] Trying to fix __va_list_tag serialization issue (bug 13189)

2012-06-28 Thread Jean-Daniel Dupas
Hello (and please ignore previous mail to cfe-dev), I'm trying to fix a regression with va_list handling in precompiled headers. http://llvm.org/bugs/show_bug.cgi?id=13189 Can someone tell me if the attached patch is the right approach to solve this type serialization issue. Thanks --

[cfe-commits] r156742 - /cfe/trunk/docs/Tooling.html

2012-05-13 Thread Jean-Daniel Dupas
Author: jddupas Date: Sun May 13 09:32:11 2012 New Revision: 156742 URL: http://llvm.org/viewvc/llvm-project?rev=156742view=rev Log: Fix Xcode case (Upper X, lower c) Modified: cfe/trunk/docs/Tooling.html Modified: cfe/trunk/docs/Tooling.html URL:

[cfe-commits] r156161 - in /cfe/trunk: lib/Driver/Tools.cpp test/Driver/warning-options.cpp

2012-05-04 Thread Jean-Daniel Dupas
Author: jddupas Date: Fri May 4 03:08:37 2012 New Revision: 156161 URL: http://llvm.org/viewvc/llvm-project?rev=156161view=rev Log: Fix -Wlarge-by-value-copy option handling in the driver. CC1 supports only the joined format. Added: cfe/trunk/test/Driver/warning-options.cpp (with props)

Re: [cfe-commits] [patch] Fix -Wlarge-by-value-copy option in the driver.

2012-05-04 Thread Jean-Daniel Dupas
, so... ;) Cheers, James -Original Message- From: cfe-commits-boun...@cs.uiuc.edu [mailto:cfe-commits-boun...@cs.uiuc.edu] On Behalf Of Jean-Daniel Dupas Sent: 03 May 2012 22:22 To: cfe-commits cfe Subject: [cfe-commits] [patch] Fix -Wlarge-by-value-copy option in the driver

Re: [cfe-commits] r156092 - /cfe/trunk/lib/Sema/SemaChecking.cpp

2012-05-04 Thread Jean-Daniel Dupas
When I updated -Wformat to works with NSString methods, I had to include a similar workaround for NSLocalizedString. At that time, I wasn't aware of the existence of isInSystemMacro(). I wrote a patch to use this method instead of disabling the warning in all macros in my existing workaround,

[cfe-commits] r156205 - in /cfe/trunk: lib/Sema/SemaChecking.cpp test/SemaObjC/format-strings-objc.m test/SemaObjC/format-strings-system.h

2012-05-04 Thread Jean-Daniel Dupas
Author: jddupas Date: Fri May 4 16:08:08 2012 New Revision: 156205 URL: http://llvm.org/viewvc/llvm-project?rev=156205view=rev Log: Inhibit ObjC format warning only in system headers (NSLocalizedString). Add a test case for the related NSAssert workaround. Added:

[cfe-commits] [patch] Fix -Wlarge-by-value-copy option in the driver.

2012-05-03 Thread Jean-Daniel Dupas
Hi, Recent change in CC1Options and Options definition broke the '-Wlarge-by-value-copy' argument. When trying to using it, clang cc1 failed with the following message: error: unknown argument: '-Wlarge-by-value-copy' Is this attached patch OK ? Thanks -- Jean-Daniel large-copy.patch

Re: [cfe-commits] r155082 - in /cfe/trunk: docs/ include/clang/AST/ include/clang/Basic/ include/clang/Parse/ include/clang/Sema/ include/clang/Serialization/ lib/AST/ lib/CodeGen/ lib/Lex/ lib/Parse/

2012-04-19 Thread Jean-Daniel Dupas
I just try and @INT_MIN Just Works™ Le 19 avr. 2012 à 21:30, Jordy Rose a écrit : I can't build a fresh copy of clang right now, but doesn't this mean that @INT_MIN /will/ work now? The docs as they are now imply that you'd have to write @(INT_MIN). If only this were taken /out/ of

[cfe-commits] Fix in documentation.

2012-03-20 Thread Jean-Daniel Dupas
Hi, In the new objc literal documentation, there is: NSDictionary *masses = @{ @H : @1.0078, @He : @4.0026, @O : @15.9990, @C : @12.0096 }; is equivalent to : id keys[] = { @H, @He, @O, @C }; id values[] = { [NSNumber numberWithFloat:1.0078], [NSNumber numberWithFloat:4.0026],

Re: [cfe-commits] r152531 - in /cfe/trunk: docs/LanguageExtensions.html lib/Parse/ParseDecl.cpp

2012-03-12 Thread Jean-Daniel Dupas
Le 11 mars 2012 à 18:26, Douglas Gregor a écrit : On Mar 11, 2012, at 1:45 AM, Jean-Daniel Dupas wrote: Just a question. For a function introduced in 10.7, what append if the deployment target is 10.6 ? Does clang use weak linking for this function ? Yes, it does. I've updated

Re: [cfe-commits] [patch] Retain/release checking for ObjCStringLiterals

2012-03-12 Thread Jean-Daniel Dupas
Le 11 mars 2012 à 22:37, Jordan Rose a écrit : After I complained about it a few days ago, I figured I'd take a stab at fixing this: [@abc release]; // should warn! I'm not sure I agree it should warn. It is a well known fact that retain/release are noop on constant string literal and

Re: [cfe-commits] r152531 - in /cfe/trunk: docs/LanguageExtensions.html lib/Parse/ParseDecl.cpp

2012-03-11 Thread Jean-Daniel Dupas
Just a question. For a function introduced in 10.7, what append if the deployment target is 10.6 ? Does clang use weak linking for this function ? Le 11 mars 2012 à 05:53, Douglas Gregor a écrit : Author: dgregor Date: Sat Mar 10 22:53:21 2012 New Revision: 152531 URL:

[cfe-commits] r151809 - in /cfe/trunk: docs/LanguageExtensions.html lib/Lex/PPMacroExpansion.cpp test/Preprocessor/has_attribute.c

2012-03-01 Thread Jean-Daniel Dupas
Author: jddupas Date: Thu Mar 1 08:53:16 2012 New Revision: 151809 URL: http://llvm.org/viewvc/llvm-project?rev=151809view=rev Log: Implement double underscore names support in __has_attribute Added: cfe/trunk/test/Preprocessor/has_attribute.c (with props) Modified:

Re: [cfe-commits] [patch]fix clang to accept double underscore names in __has_attribute

2012-03-01 Thread Jean-Daniel Dupas
pushed as r151809 Le 1 mars 2012 à 14:10, Jean-Daniel Dupas a écrit : Is this simple patch OK ? -- Jean-Daniel has_attr.patch___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [cfe-commits] r151445 - in /cfe/trunk: docs/LanguageExtensions.html lib/Lex/PPMacroExpansion.cpp lib/Sema/AttributeList.cpp test/Lexer/has_extension.c test/Preprocessor/feature_tests.c

2012-03-01 Thread Jean-Daniel Dupas
Le 1 mars 2012 à 16:36, Jonathan Sauer a écrit : Hello, Ah, attribute names with double underscores are not allowed in __has_attribute! I removed the description and updated a patch. We should fix clang to accept double underscore names there too :) Attached :-) (I did not change the

Re: [cfe-commits] r151809 - in /cfe/trunk: docs/LanguageExtensions.html lib/Lex/PPMacroExpansion.cpp test/Preprocessor/has_attribute.c

2012-03-01 Thread Jean-Daniel Dupas
Le 1 mars 2012 à 18:20, Jonathan Sauer a écrit : Hello, Added: cfe/trunk/test/Preprocessor/has_attribute.c URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Preprocessor/has_attribute.c?rev=151809view=auto

[cfe-commits] [libc++] Switching to 'double underscore' notation for has_feature.

2012-03-01 Thread Jean-Daniel Dupas
Hi, clang recently gained support for double underscore variant of the features in __has_feature test (the same way attributes support a double underscore variant). This change provide a way to safely use __has_feature in system headers without conflicting with potential user defined macros.

Re: [cfe-commits] [libc++] Switching to 'double underscore' notation for has_feature.

2012-03-01 Thread Jean-Daniel Dupas
It does not solve the do not use identifier that can conflict with legitimate user macros issue. --- #define cxx_noexpect noexcept() #if __has_feature(__cxx_noexpect__) || __has_feature(cxx_noexpect) #endif --- feat.cpp:4:40: error: builtin feature check macro requires

Re: [cfe-commits] [Patch][Review] __has_feature(__feature__)

2012-02-24 Thread Jean-Daniel Dupas
Le 24 févr. 2012 à 20:47, Jonathan Sauer a écrit : Hello, following the discussion in cfe-dev[*], I decided to put my money where my mouth is and have attached a patch that makes it possible to use __has_feature(__feature__) in place of __has_feature(feature) to protect the feature

Re: [cfe-commits] [Patch][Review] __has_feature(__feature__)

2012-02-24 Thread Jean-Daniel Dupas
Le 24 févr. 2012 à 20:47, Jonathan Sauer a écrit : Hello, following the discussion in cfe-dev[*], I decided to put my money where my mouth is and have attached a patch that makes it possible to use __has_feature(__feature__) in place of __has_feature(feature) to protect the feature

Re: [cfe-commits] [patch] -Wformat fixup for vprintf (and friends)

2012-02-21 Thread Jean-Daniel Dupas
didn't notice anything in the patch. There may be some existing test cases, but it's probably worth showing that purely correct behavior doesn't trigger a warning. Ted On Feb 20, 2012, at 10:23 AM, Jean-Daniel Dupas devli...@shadowlab.org wrote: ping. Le 16 févr. 2012 à 23:39, Jean

Re: [cfe-commits] [patch] -Wformat fixup for vprintf (and friends)

2012-02-21 Thread Jean-Daniel Dupas
Le 21 févr. 2012 à 20:53, Ted Kremenek a écrit : On Feb 21, 2012, at 10:32 AM, Jean-Daniel Dupas devli...@shadowlab.org wrote: Thanks, What do you mean by the right thing. In the C test, the function check_string_literal2() test that the warning does not trigger when the user

[cfe-commits] r151080 - in /cfe/trunk: lib/Sema/SemaChecking.cpp test/Sema/format-strings.c test/SemaCXX/format-strings.cpp test/SemaObjC/format-strings-objc.m

2012-02-21 Thread Jean-Daniel Dupas
Author: jddupas Date: Tue Feb 21 14:00:53 2012 New Revision: 151080 URL: http://llvm.org/viewvc/llvm-project?rev=151080view=rev Log: When calling a non variadic format function(vprintf, vscanf, NSLogv, …), warn if the format string argument is a parameter that is not itself declared as a format

Re: [cfe-commits] [patch] -Wformat fixup for vprintf (and friends)

2012-02-20 Thread Jean-Daniel Dupas
ping. Le 16 févr. 2012 à 23:39, Jean-Daniel Dupas a écrit : Le 16 févr. 2012 à 19:17, Ted Kremenek a écrit : On Feb 16, 2012, at 1:57 AM, Jean-Daniel Dupas devli...@shadowlab.org wrote: Hi, This patch implements a long standing FIXME. When calling a non variadic format function

  1   2   >