Re: [cfe-commits] [PATCH] External Sema Source

2012-10-18 Thread Douglas Gregor
On Oct 11, 2012, at 8:02 AM, Vassil Vassilev vasil.georgiev.vasi...@cern.ch wrote: Hi, We need to attach multiple ExternalSources to Sema, to provide modules /and/ last resort lookup. Right now that's a pain. The attached patch makes this much easier, at (almost?) no runtime cost for the

Re: [cfe-commits] [PATCH] External Sema Source

2012-10-18 Thread Vassil Vassilev
On 10/18/12 7:04 PM, Douglas Gregor wrote: On Oct 11, 2012, at 8:02 AM, Vassil Vassilev vasil.georgiev.vasi...@cern.ch wrote: Hi, We need to attach multiple ExternalSources to Sema, to provide modules /and/ last resort lookup. Right now that's a pain. The attached patch makes this much

Re: [cfe-commits] [PATCH] External Sema Source

2012-10-16 Thread Vassil Vassilev
Ping... On 10/11/2012 05:02 PM, Vassil Vassilev wrote: Hi, We need to attach multiple ExternalSources to Sema, to provide modules /and/ last resort lookup. Right now that's a pain. The attached patch makes this much easier, at (almost?) no runtime cost for the compiler. Okay to commit?

[cfe-commits] [PATCH] External Sema Source

2012-10-11 Thread Vassil Vassilev
Hi, We need to attach multiple ExternalSources to Sema, to provide modules /and/ last resort lookup. Right now that's a pain. The attached patch makes this much easier, at (almost?) no runtime cost for the compiler. Okay to commit? Vassil Index: tools/clang/include/clang/Sema/Sema.h

Re: [cfe-commits] [PATCH] External Sema Source

2012-10-11 Thread Jordan Rose
I don't know enough about this to make good comments, but rather than have isMultiplex as the field in Sema, why not call it isOwned? That's more in line with some of our other delegate-pattern uses, and it keeps it from being a temptation to start abusing the field. We could also some day in

Re: [cfe-commits] [PATCH] External Sema Source

2012-10-11 Thread Jordan Rose
On Oct 11, 2012, at 11:11 , Vassil Vassilev vvasi...@cern.ch wrote: Hi, On 10/11/12 7:21 PM, Jordan Rose wrote: I don't know enough about this to make good comments, but rather than have isMultiplex as the field in Sema, why not call it isOwned? That's more in line with some of our other

Re: [cfe-commits] [PATCH] External Sema Source

2012-10-11 Thread Vassil Vassilev
Hi, On 10/11/12 7:21 PM, Jordan Rose wrote: I don't know enough about this to make good comments, but rather than have isMultiplex as the field in Sema, why not call it isOwned? That's more in line with some of our other delegate-pattern uses, and it keeps it from being a temptation to start