Re: [cfe-commits] r167249 - /cfe/trunk/lib/CodeGen/CGObjCMac.cpp

2012-11-05 Thread Chandler Carruth
On Thu, Nov 1, 2012 at 5:15 PM, jahanian fjahan...@apple.com wrote: On Nov 1, 2012, at 3:59 PM, Matt Beaumont-Gay matthe...@google.com wrote: On Thu, Nov 1, 2012 at 3:48 PM, NAKAMURA Takumi geek4ci...@gmail.com wrote: 2012/11/2 jahanian fjahan...@apple.com: On Nov 1, 2012, at 1:26 PM, Matt

Re: [cfe-commits] r167249 - /cfe/trunk/lib/CodeGen/CGObjCMac.cpp

2012-11-05 Thread Benjamin Kramer
On 05.11.2012, at 12:24, Chandler Carruth chandl...@google.com wrote: On Thu, Nov 1, 2012 at 5:15 PM, jahanian fjahan...@apple.com wrote: On Nov 1, 2012, at 3:59 PM, Matt Beaumont-Gay matthe...@google.com wrote: On Thu, Nov 1, 2012 at 3:48 PM, NAKAMURA Takumi geek4ci...@gmail.com wrote:

Re: [cfe-commits] r167249 - /cfe/trunk/lib/CodeGen/CGObjCMac.cpp

2012-11-05 Thread jahanian
On Nov 5, 2012, at 3:57 AM, Benjamin Kramer benny@gmail.com wrote: I personally dislike the PRI* macros, but if the community consensus is otherwise, that's fine :) I personally prefer the explicit type cast; instead of chasing down what PRIx64 is. Thirded. ;] I think we can

[cfe-commits] r167249 - /cfe/trunk/lib/CodeGen/CGObjCMac.cpp

2012-11-01 Thread Matt Beaumont-Gay
Author: matthewbg Date: Thu Nov 1 15:26:42 2012 New Revision: 167249 URL: http://llvm.org/viewvc/llvm-project?rev=167249view=rev Log: Silence -Wformat on platforms where uint64_t is unsigned long. Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp

Re: [cfe-commits] r167249 - /cfe/trunk/lib/CodeGen/CGObjCMac.cpp

2012-11-01 Thread jahanian
On Nov 1, 2012, at 1:26 PM, Matt Beaumont-Gay matthe...@google.com wrote: Author: matthewbg Date: Thu Nov 1 15:26:42 2012 New Revision: 167249 URL: http://llvm.org/viewvc/llvm-project?rev=167249view=rev Log: Silence -Wformat on platforms where uint64_t is unsigned long. Thank you. -

Re: [cfe-commits] r167249 - /cfe/trunk/lib/CodeGen/CGObjCMac.cpp

2012-11-01 Thread NAKAMURA Takumi
2012/11/2 jahanian fjahan...@apple.com: On Nov 1, 2012, at 1:26 PM, Matt Beaumont-Gay matthe...@google.com wrote: Author: matthewbg Date: Thu Nov 1 15:26:42 2012 New Revision: 167249 URL: http://llvm.org/viewvc/llvm-project?rev=167249view=rev Log: Silence -Wformat on platforms where

Re: [cfe-commits] r167249 - /cfe/trunk/lib/CodeGen/CGObjCMac.cpp

2012-11-01 Thread Matt Beaumont-Gay
On Thu, Nov 1, 2012 at 3:48 PM, NAKAMURA Takumi geek4ci...@gmail.com wrote: 2012/11/2 jahanian fjahan...@apple.com: On Nov 1, 2012, at 1:26 PM, Matt Beaumont-Gay matthe...@google.com wrote: Author: matthewbg Date: Thu Nov 1 15:26:42 2012 New Revision: 167249 URL:

Re: [cfe-commits] r167249 - /cfe/trunk/lib/CodeGen/CGObjCMac.cpp

2012-11-01 Thread jahanian
On Nov 1, 2012, at 3:59 PM, Matt Beaumont-Gay matthe...@google.com wrote: On Thu, Nov 1, 2012 at 3:48 PM, NAKAMURA Takumi geek4ci...@gmail.com wrote: 2012/11/2 jahanian fjahan...@apple.com: On Nov 1, 2012, at 1:26 PM, Matt Beaumont-Gay matthe...@google.com wrote: Author: matthewbg Date: